cleaning

manifest.toml

@@ -14,7 +14,7 @@ license = "MIT"
 code = "https://github.com/jatekos101/20euros"
 
 [integration]
-yunohost = ">= 11.2.18"
+yunohost = ">= 11.2.28"
 helpers_version = "2.1"
 architectures = "all"
 multi_instance = true

scripts/install

@@ -19,13 +19,6 @@ ynh_script_progression "Configuring NGINX web server..."
 # Create a dedicated NGINX config
 ynh_config_add_nginx
 
-#=================================================
-# SECURE FILES AND DIRECTORIES
-#=================================================
-
-# Set permissions to app files
-#REMOVEME? Assuming the install dir is setup using ynh_setup_source, the proper chmod/chowns are now already applied and it shouldn't be necessary to tweak perms | chown -R $app:www-data $install_dir
-#REMOVEME? Assuming the install dir is setup using ynh_setup_source, the proper chmod/chowns are now already applied and it shouldn't be necessary to tweak perms | chmod o-rwx $install_dir
 #=================================================
 # END OF SCRIPT
 #=================================================

scripts/remove

@@ -7,7 +7,6 @@ source /usr/share/yunohost/helpers
 #=================================================
 ynh_script_progression "Removing NGINX web server configuration..."
 
-# Remove the dedicated NGINX config
 ynh_config_remove_nginx
 
 #=================================================

scripts/restore

@@ -17,13 +17,6 @@ ynh_script_progression "Restoring $app main directory..."
 
 ynh_restore "$install_dir"
 
-#=================================================
-# RESTORE USER RIGHTS
-#=================================================
-
-# Restore permissions on app files
-#REMOVEME? Assuming the install dir is setup using ynh_setup_source, the proper chmod/chowns are now already applied and it shouldn't be necessary to tweak perms | chown -R $app:www-data $install_dir
-#REMOVEME? Assuming the install dir is setup using ynh_setup_source, the proper chmod/chowns are now already applied and it shouldn't be necessary to tweak perms | chmod o-rwx $install_dir
 #=================================================
 # RELOAD NGINX
 #=================================================

scripts/upgrade

@@ -5,17 +5,10 @@ source /usr/share/yunohost/helpers
 #=================================================
 # DOWNLOAD, CHECK AND UNPACK SOURCE
 #=================================================
+ynh_script_progression "Upgrading source files..."
 
-# FIXME: this is still supported but the recommendation is now to *always* re-setup the app sources wether or not the upstream sources changed
+mkdir -p $install_dir
-if ynh_app_upstream_version_changed
+cp -a ../sources/* $install_dir
-then
-	ynh_script_progression "Upgrading source files..."
-
-	# Download the source from ../sources
-
-	mkdir -p $install_dir
-	cp -a ../sources/* $install_dir
-fi
 
 #=================================================
 # NGINX CONFIGURATION
@@ -25,13 +18,6 @@ ynh_script_progression "Upgrading NGINX web server configuration..."
 # Create a dedicated NGINX config
 ynh_config_add_nginx
 
-#=================================================
-# SECURE FILES AND DIRECTORIES
-#=================================================
-
-# Set permissions on app files
-#REMOVEME? Assuming the install dir is setup using ynh_setup_source, the proper chmod/chowns are now already applied and it shouldn't be necessary to tweak perms | chown -R $app:www-data $install_dir
-#REMOVEME? Assuming the install dir is setup using ynh_setup_source, the proper chmod/chowns are now already applied and it shouldn't be necessary to tweak perms | chmod o-rwx $install_dir
 #=================================================
 # END OF SCRIPT
 #=================================================