From 4613c98a1a779efa7ba37c2fc9f08cbdf73c3a1d Mon Sep 17 00:00:00 2001 From: OniriCorpe Date: Thu, 4 Jul 2024 19:44:49 +0200 Subject: [PATCH] add a message to guide the user if the machine doesn't have any public IPs --- scripts/_common.sh | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/scripts/_common.sh b/scripts/_common.sh index a884fa8..950768c 100644 --- a/scripts/_common.sh +++ b/scripts/_common.sh @@ -102,7 +102,16 @@ update_agh_ip_config(){ # used to update the IP adresses in the AGHconfig file if [ -z "${ipv4_addr:-}" ] && [ -z "${ipv6_addr:-}" ]; then - ynh_die --message="At leat one IP adress is required to run AdGuard Home. Please report this error." + if [ -z "${expose_port_53:-}" ] || [[ "$expose_port_53" = "false" ]]; then + # if the variable 'expose_port_53' is unset or false, maybe the machine + # doesn't have any private IP? User guidance is relevant... + ynh_die --message="At leat one IP adress is required to run AdGuard Home. Please report this error. + (If you're using a VPS that haven't any private IPs, you need to run the command \`yunohost app setting adguardhome expose_port_53 -v true\` + to activate public IP binding and unlock your situation, then re-run the upgrade process. Sorry about that!)" + else + # else, do not show the message under parenthesis, because it's irrelevant + ynh_die --message="At leat one IP adress is required to run AdGuard Home. Please report this error." + fi fi # use python's yaml and open the AGH config file