From 2b89ff6332d9d32416f413118cda00d06f0b939a Mon Sep 17 00:00:00 2001 From: antoine Date: Wed, 18 Dec 2019 16:32:23 +0100 Subject: [PATCH 1/2] pull_request_template.md --- pull_request_template.md | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) create mode 100644 pull_request_template.md diff --git a/pull_request_template.md b/pull_request_template.md new file mode 100644 index 0000000..2cef46f --- /dev/null +++ b/pull_request_template.md @@ -0,0 +1,22 @@ +## Problem +- *Description of why you made this PR* + +## Solution +- *And how do you fix that problem* + +## PR Status +- [ ] Code finished. +- [ ] Tested with Package_check. +- [ ] Fix or enhancement tested. +- [ ] Upgrade from last version tested. +- [ ] Can be reviewed and tested. + +## Validation +--- +- [ ] **Code review** : +- [ ] **Approval (LGTM)** : +*Code review and approval have to be from a member of @YunoHost-Apps/apps-group* +- **CI succeeded** : +[![Build Status](https://ci-apps-hq.yunohost.org/jenkins/job/APP_ynh%20PR-NUM-/badge/icon)](https://ci-apps-hq.yunohost.org/jenkins/job/APP_ynh%20PR-NUM-/) +*Please replace '-NUM-' in this link by the PR number.* +When the PR is marked as ready to merge, you have to wait for 3 days before really merging it. From 2d2c701047cee43e7c1334d3b0bed9fce55d3f2d Mon Sep 17 00:00:00 2001 From: toitoinebzh <44553182+toitoinebzh@users.noreply.github.com> Date: Tue, 31 Dec 2019 21:57:30 +0100 Subject: [PATCH 2/2] correct link --- pull_request_template.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pull_request_template.md b/pull_request_template.md index 2cef46f..7aa53c5 100644 --- a/pull_request_template.md +++ b/pull_request_template.md @@ -15,8 +15,8 @@ --- - [ ] **Code review** : - [ ] **Approval (LGTM)** : -*Code review and approval have to be from a member of @YunoHost-Apps/apps-group* + - **CI succeeded** : -[![Build Status](https://ci-apps-hq.yunohost.org/jenkins/job/APP_ynh%20PR-NUM-/badge/icon)](https://ci-apps-hq.yunohost.org/jenkins/job/APP_ynh%20PR-NUM-/) -*Please replace '-NUM-' in this link by the PR number.* +[![Build Status](https://ci-apps-dev.yunohost.org/jenkins/job/blogotext_ynh%20PR-NUM-%20(-USER-)/badge/icon)](https://ci-apps-dev.yunohost.org/jenkins/job/blogotext_ynh%20PR-NUM-%20(-USER-)/) +*Please replace '-NUM-' in this link by the PR number and -USER- by your user name on [Jenkins](https://ci-apps-dev.yunohost.org/jenkins/)* When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.