From 941f84fff98414bd277bd7a936b16984351839c2 Mon Sep 17 00:00:00 2001 From: scith Date: Sun, 9 Apr 2017 10:04:40 +0200 Subject: [PATCH 1/3] Check_process improvements - Fix set -eu and set -u Suggest forcing levels 4 and 5: - **Level 4**: The app does not support LDAP and HTTP auth and is single user only. However, it is set as passwordless and protected behind the SSO. All users can share the same CouchPotato instance to manage their collective libraries. - **Level 5**: I suppose linter is fine. The failure is the result of this problem (which I can't explain): https://github.com/YunoHost/package_linter/issues/15 --- check_process | 11 +++++++++++ scripts/remove | 3 ++- scripts/restore | 2 ++ scripts/upgrade | 2 ++ 4 files changed, 17 insertions(+), 1 deletion(-) diff --git a/check_process b/check_process index f8bbf06..8737f1d 100644 --- a/check_process +++ b/check_process @@ -20,3 +20,14 @@ fail_download_source=0 port_already_use=1 (5050) final_path_already_use=0 +;;; Levels + Level 1=auto + Level 2=auto + Level 3=auto + Level 4=1 + Level 5=1 + Level 6=auto + Level 7=auto + Level 8=0 + Level 9=0 + Level 10=0 diff --git a/scripts/remove b/scripts/remove index 475ba83..88b5d46 100644 --- a/scripts/remove +++ b/scripts/remove @@ -1,5 +1,6 @@ #!/bin/bash - #set -eu + + set -u app=$YNH_APP_INSTANCE_NAME # Source app helpers diff --git a/scripts/restore b/scripts/restore index 3e2a516..d8debe6 100644 --- a/scripts/restore +++ b/scripts/restore @@ -1,4 +1,6 @@ #!/bin/bash + + set -eu app=$YNH_APP_INSTANCE_NAME # Source app helpers diff --git a/scripts/upgrade b/scripts/upgrade index b359c6b..167851e 100644 --- a/scripts/upgrade +++ b/scripts/upgrade @@ -1,4 +1,6 @@ #!/bin/bash + + set -eu app=$YNH_APP_INSTANCE_NAME source="https://github.com/CouchPotato/CouchPotatoServer" From dafff5c86acb5488aed5170eff5b1abb019c4d4d Mon Sep 17 00:00:00 2001 From: Jeff Date: Sun, 9 Apr 2017 22:49:40 +0200 Subject: [PATCH 2/3] Clarify force --- check_process | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/check_process b/check_process index 8737f1d..9f761e7 100644 --- a/check_process +++ b/check_process @@ -24,10 +24,10 @@ Level 1=auto Level 2=auto Level 3=auto - Level 4=1 - Level 5=1 + Level 4=1 # The app is single-user and does not support LDAP. It is therefore protected behind SSO. + Level 5=1 # See https://github.com/YunoHost/package_linter/issues/15 Level 6=auto Level 7=auto Level 8=0 Level 9=0 - Level 10=0 + Level 10=0 From 76e7672ac94ac62920dc7855c7ac5fc459dd3b25 Mon Sep 17 00:00:00 2001 From: Maniack Crudelis Date: Sun, 9 Apr 2017 23:19:14 +0200 Subject: [PATCH 3/3] Comments on dedicated line You can't add a comment at the end of a line in a check_process file. It's not really convenient, I know... --- check_process | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/check_process b/check_process index 9f761e7..6ea04f6 100644 --- a/check_process +++ b/check_process @@ -24,8 +24,10 @@ Level 1=auto Level 2=auto Level 3=auto - Level 4=1 # The app is single-user and does not support LDAP. It is therefore protected behind SSO. - Level 5=1 # See https://github.com/YunoHost/package_linter/issues/15 + # The app is single-user and does not support LDAP. It is therefore protected behind SSO. + Level 4=1 + # See https://github.com/YunoHost/package_linter/issues/15 + Level 5=1 Level 6=auto Level 7=auto Level 8=0