From 3bcfe37f49a859e874cd979a0c497f901c8d4564 Mon Sep 17 00:00:00 2001
From: mastereur <22839524+mastereur@users.noreply.github.com>
Date: Thu, 25 Mar 2021 00:18:52 +0100
Subject: [PATCH] Remove duplicate public access and add condition in install
 according to auto install test

---
 scripts/install | 5 ++++-
 scripts/upgrade | 4 ----
 2 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/scripts/install b/scripts/install
index e4ccef7..345d103 100644
--- a/scripts/install
+++ b/scripts/install
@@ -241,7 +241,10 @@ then
 	ynh_permission_update --permission="main" --remove="visitors"
 fi
 
-ynh_permission_create --permission "public_space" --url "/public/" --allowed "visitors"
+# Create the public space permission if needed
+if ! ynh_permission_exists --permission "public_space"; then
+	ynh_permission_create --permission "public_space" --url "/public/" --allowed "visitors"
+fi
 
 #=================================================
 # RELOAD NGINX
diff --git a/scripts/upgrade b/scripts/upgrade
index 17f95a8..402149e 100755
--- a/scripts/upgrade
+++ b/scripts/upgrade
@@ -84,10 +84,6 @@ if [ -z "$phpversion" ]; then
     phpversion="$YNH_PHP_VERSION"
 fi
 
-if ! ynh_permission_exists --permission "public_space"; then
-	ynh_permission_create --permission "public_space" --url "/public/" --allowed "visitors"
-fi
-
 #=================================================
 # BACKUP BEFORE UPGRADE THEN ACTIVE TRAP
 #=================================================