From 264ba6a48e8129ffdbc852d2327eee73f389a4fa Mon Sep 17 00:00:00 2001
From: Kayou <pierre.moltess@gmail.com>
Date: Sun, 3 Mar 2019 15:03:26 +0100
Subject: [PATCH] Adding double quote for the -z

---
 scripts/upgrade | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/scripts/upgrade b/scripts/upgrade
index fa49981..96cb8d1 100644
--- a/scripts/upgrade
+++ b/scripts/upgrade
@@ -40,7 +40,7 @@ elif [ "$is_public" = "No" ]; then
 fi
 
 # If domain doesn't exist, retrieve it
-if [ -z $domain ]; then
+if [ -z "$domain" ]; then
 	domain=$(grep "external_url" "/etc/gitlab/gitlab.rb" | cut -d'/' -f3) # retrieve $domain from conf file
 	if [ ${domain: -1} == "'" ]; then # if the last char of $domain is ' remove it
 		domain=${domain:0:-1}
@@ -49,20 +49,20 @@ if [ -z $domain ]; then
 fi
 
 # If path_url doesn't exist, retrieve it
-if [ -z $path_url ]; then
+if [ -z "$path_url" ]; then
 	path_url=$(grep "location" "/etc/nginx/conf.d/${domain}.d/gitlab.conf" | cut -d' ' -f2)
 	path_url=$(ynh_normalize_url_path $path_url)
 	ynh_app_setting_set $app path_url path_url
 fi
 
 # If port doesn't exist, retrieve it
-if [ -z $port ]; then
+if [ -z "$port" ]; then
 	port=$(grep -F "nginx['listen_port']" "/etc/gitlab/gitlab.rb" | cut -d' ' -f3)
 	ynh_app_setting_set $app web_port $port
 fi
 
 # If port doesn't exist, retrieve it
-if [ -z $portUnicorn ]; then
+if [ -z "$portUnicorn" ]; then
 	portUnicorn=$(grep -F "unicorn['port']" "/etc/gitlab/gitlab.rb" | cut -d' ' -f3)
 	ynh_app_setting_set $app unicorn_port $portUnicorn
 fi