Merge pull request #53 from YunoHost-Apps/testing

Testing

manifest.json

@@ -2,7 +2,7 @@
     "name": "Gitlab",
     "id": "gitlab",
     "packaging_format": 1,
-    "version": "11.10.4~ynh2",
+    "version": "11.10.4~ynh3",
     "description": {
         "en": "GitLab is a Git-repository manager.",
         "fr": "GitLab est un gestionnaire de dépôts Git."

scripts/_common.sh

@@ -76,8 +76,11 @@ ynh_add_swap () {
 	# If there's enough space for a swap, and no existing swap here
 	if [ $swap_size -ne 0 ] && [ ! -e /swap_$app ]
 	then
-		# Preallocate space for the swap file
+		# Preallocate space for the swap file, fallocate may sometime not be used, use dd instead in this case
-		fallocate -l ${swap_size}K /swap_$app
+		if ! fallocate -l ${swap_size}K /swap_$app
+		then
+			dd if=/dev/zero of=/swap_$app bs=1024 count=${swap_size}
+		fi
 		chmod 0600 /swap_$app
 		# Create the swap
 		mkswap /swap_$app

scripts/change_url

@@ -120,7 +120,7 @@ ynh_store_file_checksum --file="$config_path/gitlab.rb"
 gitlab-ctl reconfigure
 
 if [ $change_path -eq 1 ]; then
-	gitlab-ctl restart
+	ynh_systemd_action --action=restart --service_name="gitlab-runsvdir"
 	gitlab-ctl restart unicorn
 fi
 

scripts/install

@@ -166,7 +166,6 @@ ynh_store_file_checksum --file="$config_path/gitlab.rb"
 #=================================================
 ynh_script_progression --message="Setting up source files..." --weight=200
 
-update_src_version() {
 source ./upgrade.d/upgrade.last.sh
 cp ../conf/$architecture.src.default ../conf/$architecture.src
 ynh_replace_string --match_string="__VERSION__" --replace_string="$gitlab_version" --target_file="../conf/$architecture.src"
@@ -177,16 +176,14 @@ update_src_version() {
 elif [ $architecture = "arm" ]; then
 	ynh_replace_string --match_string="__SHA256_SUM__" --replace_string="$gitlab_arm_source_sha256" --target_file="../conf/$architecture.src"
 fi
-}
-
-update_src_version
 
 tempdir="$(mktemp -d)"
 
 ynh_setup_source --dest_dir=$tempdir --source_id=$architecture
 
-if [ ${PACKAGE_CHECK_EXEC:-0} -eq 0 ]; then
+if [ ${PACKAGE_CHECK_EXEC:-0} -eq 1 ]; then
-	if ! ynh_exec_warn_less dpkg -i $tempdir/$gitlab_filename ; then # This command will fail in lxc env
+	if ! ynh_exec_warn_less dpkg -i $tempdir/$gitlab_filename ; 
+	then # This command will fail in lxc env
 		ynh_replace_string --match_string="command \"cat \/etc\/sysctl.conf \/etc\/sysctl.d\/\*.conf  | sysctl -e -p -\"" --replace_string="command \"cat \/etc\/sysctl.conf\"" --target_file="$final_path/embedded/cookbooks/package/resources/sysctl.rb"
 		ynh_exec_warn_less dpkg --configure gitlab-ce
 	fi

scripts/remove

@@ -39,7 +39,7 @@ fi
 #=================================================
 ynh_script_progression --message="Stopping gitlab" --weight=8
 
-gitlab-ctl stop
+ynh_systemd_action --action=stop --service_name="gitlab-runsvdir"
 
 #=================================================
 # REMOVE GITLAB

scripts/restore

@@ -97,7 +97,6 @@ ynh_restore_file --origin_path="$config_path/gitlab-persistent.rb"
 #=================================================
 ynh_script_progression --message="Reinstalling gitlab..." --weight=200
 
-update_src_version() {
 source ../settings/scripts/upgrade.d/upgrade.last.sh
 mkdir -p ../conf/
 cp ../settings/conf/$architecture.src.default ../conf/$architecture.src
@@ -109,16 +108,14 @@ update_src_version() {
 elif [ $architecture = "arm" ]; then
 	ynh_replace_string --match_string="__SHA256_SUM__" --replace_string="$gitlab_arm_source_sha256" --target_file="../conf/$architecture.src"
 fi
-}
-
-update_src_version
 
 tempdir="$(mktemp -d)"
 
 ynh_setup_source --dest_dir=$tempdir --source_id=$architecture
 
-if [ ${PACKAGE_CHECK_EXEC:-0} -eq 0 ]; then
+if [ ${PACKAGE_CHECK_EXEC:-0} -eq 1 ]; then
-	if ! ynh_exec_warn_less dpkg -i $tempdir/$gitlab_filename ; then # This command will fail in lxc env
+	if ! ynh_exec_warn_less dpkg -i $tempdir/$gitlab_filename ;
+	then # This command will fail in lxc env
 		ynh_replace_string --match_string="command \"cat \/etc\/sysctl.conf \/etc\/sysctl.d\/\*.conf  | sysctl -e -p -\"" --replace_string="command \"cat \/etc\/sysctl.conf\"" --target_file="$final_path/embedded/cookbooks/package/resources/sysctl.rb"
 		ynh_exec_warn_less dpkg --configure gitlab-ce
 	fi

scripts/upgrade

@@ -231,7 +231,10 @@ chown admin: "$config_path/gitlab-persistent.rb"
 # DOWNLOAD, CHECK AND UNPACK SOURCE
 #=================================================
 
-update_src_version() {
+if [ "$upgrade_type" == "UPGRADE_APP" ]
+then
+	ynh_script_progression --message="Setting up source files..." --weight=200
+
 	source ./upgrade.d/upgrade.last.sh
 	cp ../conf/$architecture.src.default ../conf/$architecture.src
 	ynh_replace_string --match_string="__VERSION__" --replace_string="$gitlab_version" --target_file="../conf/$architecture.src"
@@ -242,20 +245,14 @@ update_src_version() {
 	elif [ $architecture = "arm" ]; then
 		ynh_replace_string --match_string="__SHA256_SUM__" --replace_string="$gitlab_arm_source_sha256" --target_file="../conf/$architecture.src"
 	fi
-}
-
-if [ "$upgrade_type" == "UPGRADE_APP" ]
-then
-	ynh_script_progression --message="Setting up source files..." --weight=200
-
-	update_src_version
 
 	tempdir="$(mktemp -d)"
 
 	ynh_setup_source --dest_dir=$tempdir --source_id=$architecture
 
-	if [ ${PACKAGE_CHECK_EXEC:-0} -eq 0 ]; then
+	if [ ${PACKAGE_CHECK_EXEC:-0} -eq 1 ]; then
-		if ! ynh_exec_warn_less dpkg -i $tempdir/$gitlab_filename ; then # This command will fail in lxc env
+		if ! ynh_exec_warn_less dpkg -i $tempdir/$gitlab_filename ;
+		then # This command will fail in lxc env
 			ynh_replace_string --match_string="command \"cat \/etc\/sysctl.conf \/etc\/sysctl.d\/\*.conf  | sysctl -e -p -\"" --replace_string="command \"cat \/etc\/sysctl.conf\"" --target_file="$final_path/embedded/cookbooks/package/resources/sysctl.rb"
 			ynh_exec_warn_less dpkg --configure gitlab-ce
 		fi