From 3a2be9d683431f0956b5b0b4c9e8939d47a8db4d Mon Sep 17 00:00:00 2001
From: ericgaspar <junk.eg@free.fr>
Date: Fri, 20 Nov 2020 08:45:49 +0100
Subject: [PATCH] Fix linter warnings

---
 check_process                  | 10 ------
 scripts/backup                 |  2 +-
 scripts/change_url             |  2 +-
 scripts/experimental_helper.sh | 61 ----------------------------------
 scripts/install                |  2 +-
 scripts/remove                 |  1 -
 scripts/restore                |  1 -
 scripts/upgrade                |  1 -
 8 files changed, 3 insertions(+), 77 deletions(-)
 delete mode 100644 scripts/experimental_helper.sh

diff --git a/check_process b/check_process
index 14429cb..a62c0f4 100644
--- a/check_process
+++ b/check_process
@@ -21,17 +21,7 @@
         port_already_use=1 (6000)
         change_url=1
 ;;; Levels
-    Level 1=auto
-    Level 2=auto
-    Level 3=auto
-    # https://github.com/YunoHost-Apps/gogs_ynh/blob/master/conf/login_source.sql
-    Level 4=1
     Level 5=auto
-    Level 6=auto
-    Level 7=auto
-    Level 8=0
-    Level 9=0
-    Level 10=0
 ;;; Upgrade options
 	; commit=aa075b2051ffad7b0b6fef3a9c767376d5bdbfab
 		name=Before multi_instance and refactoring
diff --git a/scripts/backup b/scripts/backup
index 772fae0..aef132b 100644
--- a/scripts/backup
+++ b/scripts/backup
@@ -11,7 +11,7 @@ source /usr/share/yunohost/helpers
 ynh_abort_if_errors
 
 # Load common variables and helpers
-source ../settings/scripts/experimental_helper.sh
+
 source ../settings/scripts/_common.sh
 
 # Retrieve app settings
diff --git a/scripts/change_url b/scripts/change_url
index c85fa31..883baf6 100644
--- a/scripts/change_url
+++ b/scripts/change_url
@@ -11,7 +11,7 @@ source /usr/share/yunohost/helpers
 ynh_abort_if_errors
 
 # Import common cmd
-source ./experimental_helper.sh
+
 source ./_common.sh
 
 # RETRIEVE ARGUMENTS
diff --git a/scripts/experimental_helper.sh b/scripts/experimental_helper.sh
deleted file mode 100644
index 600a653..0000000
--- a/scripts/experimental_helper.sh
+++ /dev/null
@@ -1,61 +0,0 @@
-# Delete a file checksum from the app settings
-#
-# $app should be defined when calling this helper
-#
-# usage: ynh_remove_file_checksum file
-# | arg: file - The file for which the checksum will be deleted
-ynh_delete_file_checksum () {
-	local checksum_setting_name=checksum_${1//[\/ ]/_}	# Replace all '/' and ' ' by '_'
-	ynh_app_setting_delete $app $checksum_setting_name
-} 
-
-# Start or restart a service and follow its booting
-#
-# usage: ynh_check_starting "Line to match" [Log file] [Timeout] [Service name]
-#
-# | arg: Line to match - The line to find in the log to attest the service have finished to boot.
-# | arg: Log file - The log file to watch
-# | arg: Service name
-# /var/log/$app/$app.log will be used if no other log is defined.
-# | arg: Timeout - The maximum time to wait before ending the watching. Defaut 300 seconds.
-ynh_check_starting () {
-	local line_to_match="$1"
-	local service_name="${4:-$app}"
-	local app_log="${2:-/var/log/$service_name/$service_name.log}"
-	local timeout=${3:-300}
-
-	ynh_clean_check_starting () {
-		# Stop the execution of tail.
-		kill -s 15 $pid_tail 2>&1
-		ynh_secure_remove "$templog" 2>&1
-	}
-
-	echo "Starting of $service_name" >&2
-	systemctl stop $service_name
-	local templog="$(mktemp)"
-	# Following the starting of the app in its log
-	tail -F -n0 "$app_log" > "$templog" &
-	# Get the PID of the tail command
-	local pid_tail=$!
-	systemctl start $service_name
-
-	local i=0
-	for i in `seq 1 $timeout`
-	do
-		# Read the log until the sentence is found, that means the app finished to start. Or run until the timeout
-		if grep --quiet "$line_to_match" "$templog"
-		then
-			echo "The service $service_name has correctly started." >&2
-			break
-		fi
-		echo -n "." >&2
-		sleep 1
-	done
-	if [ $i -eq $timeout ]
-	then
-		echo "The service $service_name didn't fully started before the timeout." >&2
-	fi
-
-	echo ""
-	ynh_clean_check_starting
-}
\ No newline at end of file
diff --git a/scripts/install b/scripts/install
index 76586ee..d2a8f2f 100644
--- a/scripts/install
+++ b/scripts/install
@@ -11,7 +11,7 @@ source /usr/share/yunohost/helpers
 ynh_abort_if_errors
 
 # Load common variables and helpers
-source ./experimental_helper.sh
+
 source ./_common.sh
 
 # Retrieve arguments
diff --git a/scripts/remove b/scripts/remove
index 681dd01..e5deb31 100644
--- a/scripts/remove
+++ b/scripts/remove
@@ -8,7 +8,6 @@
 source /usr/share/yunohost/helpers
 
 # Load common variables and helpers
-source ./experimental_helper.sh
 source ./_common.sh
 
 #=================================================
diff --git a/scripts/restore b/scripts/restore
index 27b6ee5..f135ead 100644
--- a/scripts/restore
+++ b/scripts/restore
@@ -11,7 +11,6 @@ source /usr/share/yunohost/helpers
 ynh_abort_if_errors
 
 # Load common variables and helpers
-source ../settings/scripts/experimental_helper.sh
 source ../settings/scripts/_common.sh
 
 # Retrieve old app settings
diff --git a/scripts/upgrade b/scripts/upgrade
index 82d0b6d..483f6b4 100644
--- a/scripts/upgrade
+++ b/scripts/upgrade
@@ -11,7 +11,6 @@ source /usr/share/yunohost/helpers
 ynh_abort_if_errors
 
 # Load common variables and helpers
-source ./experimental_helper.sh
 source ./_common.sh
 
 # Retrieve app settings