From f671a8a5361024ec0087b099b78ec118c017e82c Mon Sep 17 00:00:00 2001 From: Aeris One Date: Mon, 6 Apr 2020 15:32:58 +0200 Subject: [PATCH 1/2] Update pull_request_template.md --- pull_request_template.md | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/pull_request_template.md b/pull_request_template.md index a9a8ac5..3de1420 100644 --- a/pull_request_template.md +++ b/pull_request_template.md @@ -2,7 +2,7 @@ - *Description of why you made this PR* ## Solution -- *And how you fix that* +- *And how you fix that problem* ## PR Status - [ ] Code finished. @@ -13,12 +13,10 @@ ## Validation --- -*Minor decision* -- **Upgrade previous version** : - [ ] **Code review** : -- [ ] **Approval (LGTM)** : -- [ ] **Approval (LGTM)** : +- [ ] **Approval (LGTM)** : +*Code review and approval have to be from a member of @YunoHost-Apps/apps-group* - **CI succeeded** : -[![Build Status](https://ci-apps-hq.yunohost.org/jenkins/job/hextris_ynh%20PR-NUM-/badge/icon)](https://ci-apps-hq.yunohost.org/jenkins/job/hextris_ynh%20PR-NUM-/) +[![Build Status](https://ci-apps-hq.yunohost.org/jenkins/job/APP_ynh%20PR-NUM-/badge/icon)](https://ci-apps-hq.yunohost.org/jenkins/job/APP_ynh%20PR-NUM-/) *Please replace '-NUM-' in this link by the PR number.* -When the PR is marked as ready to merge, you have to wait for 3 days before really merging it. +When the PR is marked as ready to merge, we have to wait for 3 days before really merging it. From 9272fb87bd60e01833849f2c06ac573fe8e1ddef Mon Sep 17 00:00:00 2001 From: Maniack Crudelis Date: Mon, 6 Apr 2020 15:36:30 +0200 Subject: [PATCH 2/2] Update pull_request_template.md --- pull_request_template.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pull_request_template.md b/pull_request_template.md index 3de1420..c6480b1 100644 --- a/pull_request_template.md +++ b/pull_request_template.md @@ -17,6 +17,6 @@ - [ ] **Approval (LGTM)** : *Code review and approval have to be from a member of @YunoHost-Apps/apps-group* - **CI succeeded** : -[![Build Status](https://ci-apps-hq.yunohost.org/jenkins/job/APP_ynh%20PR-NUM-/badge/icon)](https://ci-apps-hq.yunohost.org/jenkins/job/APP_ynh%20PR-NUM-/) +[![Build Status](https://ci-apps-hq.yunohost.org/jenkins/job/hextris_ynh%20PR-NUM-/badge/icon)](https://ci-apps-hq.yunohost.org/jenkins/job/hextris_ynh%20PR-NUM-/) *Please replace '-NUM-' in this link by the PR number.* -When the PR is marked as ready to merge, we have to wait for 3 days before really merging it. +When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.