From b88b317faa8b462c3c932ed59903122a580ae825 Mon Sep 17 00:00:00 2001
From: Alexis Metaireau <alexis@notmyidea.org>
Date: Tue, 18 Oct 2011 18:13:54 +0200
Subject: [PATCH] Bills can't be negative. Fix #45

---
 budget/forms.py                               |   4 ++++
 budget/messages.pot                           |   3 +++
 budget/tests.py                               |   9 +++++++++
 .../translations/fr/LC_MESSAGES/messages.mo   | Bin 7213 -> 7305 bytes
 .../translations/fr/LC_MESSAGES/messages.po   |   3 +++
 5 files changed, 19 insertions(+)

diff --git a/budget/forms.py b/budget/forms.py
index 5abbd84..d0a60ca 100644
--- a/budget/forms.py
+++ b/budget/forms.py
@@ -120,6 +120,10 @@ class BillForm(Form):
     def set_default(self):
         self.payed_for.data = self.payed_for.default
 
+    def validate_amount(self, field):
+        if field.data < 0:
+            raise ValidationError(_("Bills can't be negative"))
+
 
 class MemberForm(Form):
 
diff --git a/budget/messages.pot b/budget/messages.pot
index b8de26f..ef1fe23 100644
--- a/budget/messages.pot
+++ b/budget/messages.pot
@@ -445,3 +445,6 @@ msgstr ""
 
 msgid "each"
 msgstr ""
+
+msgid "Bills can't be negative"
+msgstr ""
diff --git a/budget/tests.py b/budget/tests.py
index 0caf186..452f71f 100644
--- a/budget/tests.py
+++ b/budget/tests.py
@@ -283,6 +283,15 @@ class BudgetTestCase(TestCase):
         bill = models.Bill.query.one()
         self.assertEqual(bill.amount, 25)
 
+        self.app.post("/raclette/add", data={
+            'date': '2011-08-10',
+            'what': u'fromage à raclette',
+            'payer': members_ids[0],
+            'payed_for': members_ids,
+            'amount': '-25', # bill with a negative value is not possible
+        })
+        self.assertEqual(1, models.Bill.query.count())
+
         # edit the bill
         resp = self.app.post("/raclette/edit/%s" % bill.id, data={
             'date': '2011-08-10',
diff --git a/budget/translations/fr/LC_MESSAGES/messages.mo b/budget/translations/fr/LC_MESSAGES/messages.mo
index c3b07a9197c53709a8f5a089be429d5feadc046f..62efe515edae4e506d09057f32d745154cabd589 100644
GIT binary patch
delta 1819
zcmYM!TS!zv9LMp|%1dRs+N!l>r>hECpjZ}BWEY{N9xN-mvASCbx=F55p&Y0nyI>EM
zSkb+pBrTL8$fz(WBIsT(A(#(QNQi|!DAe~?1Ih7xX6BqT|C#^HY)jtZ1#WlZ$Ww;D
zGX5v=9~hz9|G%42#!R5vg0t``M&Ngh$9{}P-9|$Uj>RM#hmLiwZC{Krw6DelV_dV2
z0+$JL8-*2^f>o#i9Ytc8>o^{7p$DH}B7U%b#gWv9aSTQfg#acFHIOvacUh=7OE8A`
zW(9><8rGl!ZNw?K-L|`!O#Lv%;YFN=tvC^1qrU6Ibo_xDh>uPkbWoXDikVo58bA$t
zh;M3bLj!8WCs8T9hMHlUt#{eyZ*096wKV;xfsH1LGL(u_F$*u_T1>(L<T6pDM;Z2@
zs}3?LXeP@r1Gk~t4_PnaOzQWs7ke-tyBMW9iXr+ebWraVpq8!zHK8NOs+hAl1FxWi
z&*I3xX8M%|rDV`LjH%QkSvV$Ve7Fc_;zBGz1wMybsyoOh<~?R%FKVV9cBuN9gp)BB
z)n5^6$+pImf2~!323dxDYeJ~aQfFU0j+#LuDwXF^0org5K0tlfhYB!++9RWwzUmp+
zz_H0jhx%hW*ML5|6e1~Tp|#c{xG7LFDo`3~Alax?F1PjdsP}dv`_1e^FYdAJ4Ys`z
zb7;SS%FJ8)Jc7=Z88?;!ZDtxOK(2KqDkB?^%WUDMfmEUb?YH$N)Y3I0+rr$ocA!%H
z43&wOs7wrC8V)1zT;pTQ&Zc2D>cve+_Dn6##bc=7qz=?Ee1z)gBj#WaYAL*oN_)aV
z1<pggzXY{6ijm6%Y<(YkbpGop=)*IpHEBbA_{z3_!THpGV;#=tq1O5iYM@V0$L$?z
zW`n4HymYFR=b-xcbJO#^s0lY=zs`Rbh2?mc1<^4aLT##K&Y+If3Zzd{j#{Dvs2QEa
zOuUTg_yS3W`H9LvES+hOBp^*D6*cf|%*UnZE~aph0+;FJrt{y8TFYqPzZ54S%Vi2s
z?`=lStOm6dSFNq6!1qvrAEE~I6gA*asN??4KL6!2^ZushHw_Ay!moxl<8)NOd8pmJ
z3N^4IR0p*uPDedY$uBD}uX0NLq4cm*5_Cero&IoHO|ZQr+B+t<Fz8h53WfcluoFnH
s4h5YZ{?c&uZoTGI2CKtPrN7GQY!0iX^M=0MVTw=qd|B<+66<6C04CP7ssI20

delta 1727
zcmYM!ZD^KN7zgmPbn0fyr7LrD?kQ|jawbG+HjKoqPZFU<VPqL<BobI@h&&SXrsS7l
z^x{a8K3J?T1~M0fFe(fpNGi34Bz{<d3=A8E)bC$6^l<O|&beRCb<TCp*&BBcE~}5u
zoP4nOZS^<T--bzP{r@{OrIb0E1MKE;HgJ?Pc%D-^&Sp;VT26BFI<{7JG4~g98t-9i
zDfO~S#Z}fR8u>UgkWJKA*~>P*#_M^AGx<s7Nlw;2&FMTt9hZyD0Io3KHHw=4XEOun
zR5XcSx>XWr3A?!T-v^~U!W*@pWD9rk7QV`M9%a58VGqA%26CA-PB0mn(^Ser&SwU&
zh8fV>w8bx*RWjmjOp5j}Gu&6T2dd{ERqbJBNxotR_6w7tao)^EQ9oc0XYmv>kWs~K
zjxpaiNLM{G=}=j~yO;-0RKCPpwflL2LtM!LqfAHV+06;&y)L84(%sKY=qbv6*}?hT
z%^D9g6Fu1?|4GR=Zp72PiDzjt<udztmCL!@f+p|_%u>BckIEo>In2y-jOpihcCy7z
zO@FsBOLix-RDCn#Kb8C3@NQYntj)UW#VyPXwlk@GkqNMmi+PawZiET&9kWM%uG&e%
z0mr48HTU1qc?NWX*YL->O4j-u6X+5X=n7q>*~6rAF4OL1-n*CfS9yRp@S*Dd=IZ`-
zCL=qm`yVnH8KkRxp-8{=GgakRCKG=#14xm8ZA^gfs@=yd)f(CkWo_j~Cbip`4D4Vs
z@)qauFca`|F5<WJUcFpZk*!j*g>UB)=6}#e=J-9$bhMjy@D*kWhM2uD!UX<_dH({l
zC;nsxK24GKJZ3_RnD17wGv|N3N<MtPda$2MwU2NQ&oOKKsFyO(t;{jo#mwwoW=)5f
zl>fj4XjJ5RCo|(dj`JC=;$zmMJ?H;@m29RH%yAl{K1!>zn3VM}Gg!ujT+JRnN0TgX
zGZ`3U_Qt1lmCqCz`1f4Ni(J74&U}vj7DYYh{$-V{<;P5lkJGA@-{>lTD>Ae8j{lb8
z!ODl3z#Evro0tJT%M5rgbIuP`&)=iTmm^HP;STe)-^!P6B;Z+QS6^ZV_6O5Jt^eqh
XQ^)pCZJXY(zJF&&@3DqiuQ&Yz*-V{4

diff --git a/budget/translations/fr/LC_MESSAGES/messages.po b/budget/translations/fr/LC_MESSAGES/messages.po
index 0f021eb..e6232c0 100644
--- a/budget/translations/fr/LC_MESSAGES/messages.po
+++ b/budget/translations/fr/LC_MESSAGES/messages.po
@@ -451,3 +451,6 @@ msgstr "et les notifier vous même"
 
 msgid "each"
 msgstr "chacun"
+
+msgid "Bills can't be negative"
+msgstr "Le montant d'une facture ne peut pas être négatif"