1
0
Fork 0
mirror of https://github.com/YunoHost-Apps/ihatemoney_ynh.git synced 2024-09-03 19:26:15 +02:00
Commit graph

453 commits

Author SHA1 Message Date
Baptiste Jonglez
b507a5afa1 Prevent transfers with a zero amount in the settle page
This workarounds a rounding issue caused by the (incorrect) usage of
floats for bill amounts.

This fixes #138
2017-01-03 21:37:19 +01:00
Baptiste Jonglez
543df7c1d4 Add a test to catch zero-amount transfers in the settle page 2017-01-03 21:37:19 +01:00
Baptiste Jonglez
699db1c4c8 Sort bills by (date.desc, ID.desc) instead of just date.desc
When viewing the list of bills, bills are (correctly) sorted by date.  But
the order of all bills for a given day is not intuitive: I would expect
bills to be sorted by reverse order of insertion.  That is, the last bill
to be added for a given day should appear first, not last.  Otherwise,
when adding several bills in a row for a given day, it's confusing to see
that the new bills do not appear on top of the list.

Fix this by sorting by decreasing ID after sorting by date.
2017-01-02 13:22:28 +01:00
Baptiste Jonglez
8e5ac8ae98 Optimise SQL queries when computing balance
This avoids creating thousands of small SQL queries when computing the
balance of users.  This significantly improves the performance of
displaying the main page of a project, since the balance of users is
displayed there:

    Before this commit: 4004 SQL queries, 19793 ms elapsed time, 19753 ms CPU time, 2094 ms SQL time
    After this commit:    12 SQL queries,  3688 ms elapsed time,  3753 ms CPU time,   50 ms SQL time
    Measured request:   display the sidebar with the balance of all users for the project (without displaying the list of bills)

This commit also greatly improves the performance of the "settle bills" page:

    Before this commit: 8006 SQL queries, 39167 ms elapsed time, 39600 ms CPU time, 4141 ms SQL time
    After this commit:    22 SQL queries,  7144 ms elapsed time,  7283 ms CPU time,   96 ms SQL time
    Measured request:   display the "Settle bills" page

Test setup to measure performance improvement:

- 5 users with various weights
- 1000 bills, each paid by a random user, each involving all 5 users
- laptop with Celeron N2830@2.16 GHz, SSD Samsung 850 EVO
- sqlite database on SSD, using sqlite 3.15.2
- python 2.7.13
- Flask-DebugToolbar 0.10.0 (to count SQL queries and loading time)

Performance measurements (using Flask-DebugToolbar on the second request,
to avoid measuring cold-cache performance):

- number of SQL queries
- elapsed time (from request to response)
- total CPU time consumed by the server handling the request
- total time spent on SQL queries (as reported by SQLAlchemy)
2017-01-02 13:09:26 +01:00
Baptiste Jonglez
74df614007 Optimise SQL queries when displaying bills for a project
By defaut, SQLAlchemy uses lazy loading, which means that displaying n
bills will generate around n queries (to get the list of owers of each
bill).  Pre-load the list of owers to drastically decrease the number of
SQL queries.

Before this commit: 1004 SQL queries, 7535 ms elapsed time, 7536 ms CPU time, 530 ms SQL time

After this commit: 5 SQL queries, 3342 ms elapsed time, 3393 ms CPU time, 15 ms SQL time

Measured request: display the list of all bills for the project (without displaying the sidebar with balances)

Test setup to measure performance improvement:

- 5 users with various weights
- 1000 bills, each paid by a random user, each involving all 5 users
- laptop with Celeron N2830@2.16 GHz, SSD Samsung 850 EVO
- sqlite database on SSD, using sqlite 3.15.2
- python 2.7.13
- Flask-DebugToolbar 0.10.0 (to count SQL queries and loading time)

Performance measurements (using Flask-DebugToolbar with the second
request, to avoid measuring cold-cache performance):

- number of SQL queries
- elapsed time (from request to response)
- total CPU time consumed by the server handling the request
- total time spent on SQL queries (as reported by SQLAlchemy)
2017-01-02 13:09:26 +01:00
Alexis Metaireau
4d5c8a507b Merge pull request #154 from aavenel/enableTravisCI
Enable Travis CI
2016-10-05 11:16:07 +02:00
Alexandre Avenel
d26d547372 Add Travis CI badge in README 2016-10-01 14:15:25 +02:00
Alexandre Avenel
6515d859d5 Add a basic travis.yml file (Enable Travis CI) 2016-09-25 16:28:42 +02:00
Alexis Metaireau
fb69e8aa89 Merge pull request #151 from spiral-project/jd-fix-domain
Change ihatemoney.notmyidea.org → ihatemoney.org
2016-09-13 11:23:23 +02:00
Jocelyn Delalande
1e3cc6919a
Change ihatemoney.notmyidea.org → ihatemoney.org
As the old domain seams dead and not even redirecting.
2016-09-13 11:21:28 +02:00
Alexis Metaireau
7ba9048b06 Merge pull request #150 from fredericsureau/negative-amounts
Allow negative bill amounts
2016-09-12 17:54:58 +02:00
fredericsureau
c9b2d17f60 Update negative amounts test 2016-09-12 16:30:01 +02:00
Alexis Metaireau
30904481aa Merge pull request #145 from adamchainz/readthedocs.io
Convert readthedocs links for their .org -> .io migration for hosted projects
2016-09-12 16:21:35 +02:00
Alexis Metaireau
bd07689de8 Merge pull request #148 from JocelynDelalande/api-doc-precisions
REST API doc precisions
2016-09-12 16:19:48 +02:00
fredericsureau
a1f1655f06 Allow negative bill amounts 2016-09-12 14:21:57 +02:00
Jocelyn Delalande
338f735d46 Explain better multi-valued payed_for in API doc
… And use a multi-valued example, as it's IMHO the "standard" use-case with
IHM.
2016-08-18 18:06:37 +02:00
Jocelyn Delalande
74b087fe6a Mentions in API doc that the date is optional. 2016-08-18 18:06:12 +02:00
Jocelyn Delande
ad91b11a92 Merge remote-tracking branch 'upstream/master'
fix #5
2016-07-10 17:42:05 +02:00
Jocelyn Delande
4944d0a96f Fix upgrade script
refs #5
2016-07-10 17:41:41 +02:00
Adam Chainz
a80202e066 Convert readthedocs links for their .org -> .io migration for hosted projects
As per [their blog post of the 27th April](https://blog.readthedocs.com/securing-subdomains/) ‘Securing subdomains’:

> Starting today, Read the Docs will start hosting projects from subdomains on the domain readthedocs.io, instead of on readthedocs.org. This change addresses some security concerns around site cookies while hosting user generated data on the same domain as our dashboard.

Test Plan: Manually visited all the links I’ve modified.
2016-06-28 07:46:50 +01:00
Alexis Metaireau
6bcf5e3aa2 Merge pull request #144 from JocelynDelalande/fix-migrations-upgrade-path
Fix migrations upgrade path for MySQL
2016-06-28 01:01:15 +02:00
Jocelyn Delande
a5579220e0 Fix migrations upgrade path for MySQL
For some reason, the migration path from unmanaged db (from alembic
point-of-view) to managed db, through the initial migration works well with
sqlite… But not with mysql where the db system tries to re-create the existing
tables.

This commit is a way to detect if we are migrating from pre-alembic era and
skip the first migration (which would do nothing anyway), marking it as already
executed.

It's quite hackish but that's the best I found so far to get it working with
both MySQL and SQLite.
2016-06-18 12:13:46 +02:00
Jocelyn Delande
f039b6f710 Fix manifest to comply with ynh 2.4 style
The shift to 2.4 is not finished though ; still TODO :

- backup/restore scripts
- use of the helpers ?
- remove deprecated yunohost commands
2016-06-18 00:33:51 +02:00
Jocelyn Delande
98ea1c8873 Merge remote-tracking branch 'upstream/master'
Conflicts:
	conf/nginx.conf
	sources/budget/run.py
	sources/budget/utils.py
2016-06-17 23:40:38 +02:00
Alexis Metaireau
5084cafe6b Merge pull request #131 from JocelynDelalande/members-weights
Added Members weights handling
2016-06-17 10:06:19 +02:00
Jocelyn Delande
c49a355eb0 Update translation 2016-06-16 15:52:24 +02:00
Jocelyn Delande
d3bb04c1bf Add migration to initialize Person weights
That's for Persons that existed before the weights were added to model.
2016-06-16 15:52:24 +02:00
Jocelyn Delande
7a630b78ea Hide the member weights in members list if all weights are "1". 2016-06-16 15:52:24 +02:00
Jocelyn Delande
ec8fe2326b Added member edit form 2016-06-16 15:52:24 +02:00
Jocelyn Delande
64c2cd56df display an edit button on members list 2016-06-15 10:20:37 +02:00
Jocelyn Delande
1147f2ece8 Ask for confirmation only for deleting users 2016-06-15 10:20:37 +02:00
Jocelyn Delande
85abc0b1fc Added a template filter not to show zero decimals on user weights 2016-06-15 10:20:37 +02:00
Jocelyn Delande
b57df5cd36 UI for showing user weights in user list 2016-06-15 10:20:37 +02:00
Jocelyn Delande
06f10d0508 Added member weights support to API 2016-06-15 10:20:37 +02:00
Jocelyn Delande
2b071a1a3b Add members weight in models and budget backend refs #94 2016-06-15 10:20:37 +02:00
Alexis Metaireau
7891967215 Merge pull request #141 from JocelynDelalande/jd-alembic-migrations
Alembic DB migrations
2016-05-31 14:12:50 +02:00
Jocelyn Delande
465deabd02 Add a manage.py CLI (flask_script)
As it's the Flask-Migrate way to expose its commands (./manage.py db command).

In our case, it's specially useful for creating new migrations.
2016-05-31 12:10:53 +02:00
Jocelyn Delande
74995f9959 Handle migrations through alembic/flask-Migrations
Auto-initialization now applies migrations instead of using db. create_all()

fix #83
2016-05-31 12:10:53 +02:00
Alexis Metaireau
698efd7681 Merge pull request #129 from JocelynDelalande/no-user-settings-in-tests
Do not load user-overriden settings in unit tests.
2016-04-05 00:56:14 +02:00
Jocelyn Delande
b685fa74d6 Do not load user-overriden settings in unit tests.
Loading not versioned settings.py during tests make them less predictable.
That's inspired from django behaviour with DJANGO_SETTING_MODULE environment variable.
2016-04-03 22:31:32 +02:00
Alexis Metaireau
a8841f9d3f Merge pull request #122 from JocelynDelalande/configurable-prefix
Made an URL prefix configurable in settings
2015-11-09 09:26:11 +01:00
Mathieu Leplatre
eff0f7c2df Prevent comma to be included in URL 2015-09-25 12:32:56 +02:00
Mathieu Leplatre
c6c40f02c5 Prevent comma to be included in URL 2015-09-25 12:31:52 +02:00
Quentin Roy
d31de6c4a3 Merge pull request #130 from JocelynDelalande/trailing-whitespaces
Remove trailing whitespaces
2015-08-20 12:08:52 +02:00
Jocelyn Delande
d9313ba40e Remove trailing whitespaces 2015-08-20 12:02:04 +02:00
Jocelyn Delande
15091e28c0 Made an URL prefix configurable in settings, includes tests. 2015-08-19 22:56:45 +02:00
Jocelyn Delande
d6c514e7d1 Adds a way to (re)configure the running app, reloading settings.
Currently, there is no way to reset settings after modifying them, which is
anoying for tests.
2015-08-19 22:53:16 +02:00
Alexis Metaireau
0e21449191 Merge pull request #126 from aavenel/fix-settle-rounding
Bugfix rounding settle algorithm
2015-07-28 16:05:19 +02:00
Jocelyn Delande
309e46013f Cleans after itself in case the install fails.
Refs #1 and #4 (and hopefuly fixes them)
2015-07-26 18:23:54 +02:00
Alexandre Avenel
b9458db08e Bugfix rounding settle algorithm
In some cases, settle algorithm failed to deliver optimal solution due to a rounding bug.
2015-07-05 22:16:38 +02:00