From 55ae72b32624df190fb8bf310421bc87a94faa27 Mon Sep 17 00:00:00 2001 From: Sebastian Gumprich Date: Sun, 6 Feb 2022 21:18:22 +0000 Subject: [PATCH] Apply suggestions from code review --- README.md | 5 ++--- README_fr.md | 2 +- conf/default.env | 2 +- conf/nginx.conf | 4 ++++ doc/DISCLAIMER.md | 5 ++--- manifest.json | 3 ++- scripts/_common.sh | 1 - 7 files changed, 12 insertions(+), 10 deletions(-) diff --git a/README.md b/README.md index c17d3a4..f9e856a 100644 --- a/README.md +++ b/README.md @@ -31,18 +31,17 @@ Create and email invoices, track payments, expenses, and time tasks This is the new version of InvoiceNinja. There are several things not working at the moment: -* migration from v4 * installation into a sub-directory * sending mails -Invoice Ninja is the #1 open-source platform to create & email invoices, track payments and expenses, and time billable tasks & projects for clients. +Invoice Ninja is the the leading self-hosted invoicing platform to create & email invoices, track payments and expenses, and time billable tasks & projects for clients. ## YunoHost specific features #### Multi-user support * There is no official LDAP support -* The first user gets created after installing Invoice Ninja +* The first user gets created after installing Invoice Ninja. The email-address is the one of your administrator user of the app. The password is the administration password you provided while installing. * Other users can be created from inside the application ## Documentation and resources diff --git a/README_fr.md b/README_fr.md index f17b073..70fe37f 100644 --- a/README_fr.md +++ b/README_fr.md @@ -38,7 +38,7 @@ Invoice Ninja is the #1 open-source platform to create & email invoices, track p #### Multi-user support * There is no official LDAP support -* The first user gets created after installing Invoice Ninja +* The first user gets created after installing Invoice Ninja. The email-address is the one of your administrator user of the app. The password is the administration password you provided while installing. * Other users can be created from inside the application ## Documentations et ressources diff --git a/conf/default.env b/conf/default.env index 2b177fa..c5210f1 100644 --- a/conf/default.env +++ b/conf/default.env @@ -1,5 +1,5 @@ APP_ENV=production -APP_DEBUG=true +APP_DEBUG=false APP_NAME="Invoice Ninja" APP_URL=https://__DOMAIN__ APP_KEY=__APP_KEY__ diff --git a/conf/nginx.conf b/conf/nginx.conf index 82bf57b..1cbd20f 100644 --- a/conf/nginx.conf +++ b/conf/nginx.conf @@ -15,6 +15,10 @@ location ^~ __PATH__/ { more_set_headers "Referrer-Policy: no-referrer"; index index.php index.html index.htm; + + if (!-e $request_filename) { + rewrite ^(.+)$ /index.php?q= last; + } try_files $uri $uri/ __PATH__/__PATH__/index.php?q=; diff --git a/doc/DISCLAIMER.md b/doc/DISCLAIMER.md index 9536ce9..d2f61f2 100644 --- a/doc/DISCLAIMER.md +++ b/doc/DISCLAIMER.md @@ -2,16 +2,15 @@ This is the new version of InvoiceNinja. There are several things not working at the moment: -* migration from v4 * installation into a sub-directory * sending mails -Invoice Ninja is the #1 open-source platform to create & email invoices, track payments and expenses, and time billable tasks & projects for clients. +Invoice Ninja is the the leading self-hosted invoicing platform to create & email invoices, track payments and expenses, and time billable tasks & projects for clients. ## YunoHost specific features #### Multi-user support * There is no official LDAP support -* The first user gets created after installing Invoice Ninja +* The first user gets created after installing Invoice Ninja. The email-address is the one of your administrator user of the app. The password is the administration password you provided while installing. * Other users can be created from inside the application diff --git a/manifest.json b/manifest.json index 2e76fc6..95d42b4 100644 --- a/manifest.json +++ b/manifest.json @@ -59,7 +59,8 @@ }, { "name": "password", - "type": "password" + "type": "password", + "help": "Password must contain an upper case character and a number." } ] } diff --git a/scripts/_common.sh b/scripts/_common.sh index d68741e..7b44130 100644 --- a/scripts/_common.sh +++ b/scripts/_common.sh @@ -7,7 +7,6 @@ YNH_PHP_VERSION="7.4" # dependencies used by the app -#pkg_dependencies="phantomjs gconf-service libasound2 libatk1.0-0 libc6 libcairo2 libcups2 libdbus-1-3 libexpat1 libfontconfig1 libgcc1 libgconf-2-4 libgdk-pixbuf2.0-0 libglib2.0-0 libgtk-3-0 libnspr4 libpango-1.0-0 libpangocairo-1.0-0 libstdc++6 libx11-6 libx11-xcb1 libxcb1 libxcomposite1 libxcursor1 libxdamage1 libxext6 libxfixes3 libxi6 libxrandr2 libxrender1 libxss1 libxtst6 ca-certificates fonts-liberation libappindicator1 libnss3 lsb-release xdg-utils wget" pkg_dependencies="php${YNH_PHP_VERSION}-bcmath php${YNH_PHP_VERSION}-gmp php${YNH_PHP_VERSION}-fileinfo php${YNH_PHP_VERSION}-gd php${YNH_PHP_VERSION}-json php${YNH_PHP_VERSION}-mbstring php${YNH_PHP_VERSION}-pdo php${YNH_PHP_VERSION}-xml php${YNH_PHP_VERSION}-curl php${YNH_PHP_VERSION}-zip php${YNH_PHP_VERSION}-mysql"