From 415fa5b9d7bca2846e474b1233b583bebf744b4a Mon Sep 17 00:00:00 2001
From: Navan Chauhan <navanchauhan@gmail.com>
Date: Sun, 23 May 2021 01:29:07 +0530
Subject: [PATCH] cosmetic fixes

---
 scripts/backup     | 1 -
 scripts/change_url | 2 +-
 scripts/upgrade    | 7 +------
 3 files changed, 2 insertions(+), 8 deletions(-)

diff --git a/scripts/backup b/scripts/backup
index 401c0ef..7238ad2 100755
--- a/scripts/backup
+++ b/scripts/backup
@@ -31,7 +31,6 @@ app=$YNH_APP_INSTANCE_NAME
 final_path=$(ynh_app_setting_get --app=$app --key=final_path)
 domain=$(ynh_app_setting_get --app=$app --key=domain)
 db_name=$(ynh_app_setting_get --app=$app --key=db_name)
-phpversion=$(ynh_app_setting_get --app=$app --key=phpversion)
 
 #=================================================
 # DECLARE DATA AND CONF FILES TO BACKUP
diff --git a/scripts/change_url b/scripts/change_url
index d902869..d1831ac 100644
--- a/scripts/change_url
+++ b/scripts/change_url
@@ -28,7 +28,7 @@ ynh_script_progression --message="Loading installation settings..."
 
 # Needed for helper "ynh_add_nginx_config"
 final_path=$(ynh_app_setting_get --app=$app --key=final_path)
-app_port=$()ynh_app_setting_get --app=$app --key=port)
+app_port=$(ynh_app_setting_get --app=$app --key=port)
 
 #=================================================
 # BACKUP BEFORE CHANGE URL THEN ACTIVE TRAP
diff --git a/scripts/upgrade b/scripts/upgrade
index c3019a5..f4dc163 100644
--- a/scripts/upgrade
+++ b/scripts/upgrade
@@ -88,11 +88,6 @@ if ynh_legacy_permissions_exists; then
 	ynh_app_setting_delete --app=$app --key=is_public
 fi
 
-if ! ynh_permission_exists --permission="admin"; then
-	# Create the required permissions
-	ynh_permission_create --permission="admin" --url="/admin" --allowed=$admin
-fi
-
 # Create a permission if needed
 if ! ynh_permission_exists --permission="api"; then
 	ynh_permission_create --permission="api" --url="/api" --allowed="visitors" --show_tile="false" --protected="true"
@@ -126,7 +121,7 @@ fi
 # this will be treated as a security issue.
 chmod 750 "$final_path"
 chmod -R o-rwx "$final_path"
-chown -R $app:www-data "$final_path"
+chmod -R $app: "$final_path"
 
 #=================================================
 # NGINX CONFIGURATION