From e0f9655ec72952f80e19385a191d0b9688edfc76 Mon Sep 17 00:00:00 2001 From: yalh76 Date: Thu, 8 Apr 2021 00:50:11 +0200 Subject: [PATCH 1/3] remove no more working install --- check_process | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/check_process b/check_process index 622fe43..2646756 100644 --- a/check_process +++ b/check_process @@ -12,7 +12,7 @@ setup_public=1 upgrade=1 # 2.150.2~ynh2 - upgrade=1 from_commit=29141b702f2954e0f72925121aea82a7fa3fc118 + # upgrade=1 from_commit=29141b702f2954e0f72925121aea82a7fa3fc118 # 2.263.1~ynh1 upgrade=1 from_commit=0e1aae7be82034650e2c1f6c1ad6d68a41b80176 backup_restore=1 From 6183216ce83fcae5c9793d16b4df88194c4a172f Mon Sep 17 00:00:00 2001 From: yalh76 Date: Thu, 8 Apr 2021 00:52:14 +0200 Subject: [PATCH 2/3] cleanup permission system --- scripts/upgrade | 9 --------- 1 file changed, 9 deletions(-) diff --git a/scripts/upgrade b/scripts/upgrade index e5f8739..902553d 100644 --- a/scripts/upgrade +++ b/scripts/upgrade @@ -36,15 +36,6 @@ upgrade_type=$(ynh_check_app_version_changed) #================================================= ynh_script_progression --message="Ensuring downward compatibility..." --weight=2 -# Fix is_public as a boolean -if [ "$is_public" = "Yes" ]; then - ynh_app_setting_set --app=$app --key=is_public --value=1 - is_public=1 -elif [ "$is_public" = "No" ]; then - ynh_app_setting_set --app=$app --key=is_public --value=0 - is_public=0 -fi - # If overwrite_nginx doesn't exist, create it if [ -z "$overwrite_nginx" ]; then overwrite_nginx=1 From bf17539b2d91703b47bf303a923ae5c397b70f6a Mon Sep 17 00:00:00 2001 From: yalh76 Date: Thu, 8 Apr 2021 00:54:10 +0200 Subject: [PATCH 3/3] Ask string for argument is superflous --- manifest.json | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/manifest.json b/manifest.json index 9e55626..b528e4d 100644 --- a/manifest.json +++ b/manifest.json @@ -29,29 +29,17 @@ { "name": "domain", "type": "domain", - "ask": { - "en": "Choose a domain for Jenkins", - "fr": "Choisissez un domaine pour Jenkins" - }, "example": "example.com" }, { "name": "path", "type": "path", - "ask": { - "en": "Choose a path for Jenkins", - "fr": "Choisissez un chemin pour Jenkins" - }, "example": "/jenkins", "default": "/jenkins" }, { "name": "is_public", "type": "boolean", - "ask": { - "en": "Is it a public application?", - "fr": "Est-ce une application publique ?" - }, "default": true, "help": { "en": "A public Jenkins will be accessible by everyone unless you configure the security into jenkins admin panel.",