Fix

check_process

@@ -1,27 +0,0 @@
-;; Test complet
-	; Manifest
-		domain="domain.tld"
-		path="/jupyterlab"
-		is_public=1
-		admin="john"
-	; Checks
-		pkg_linter=1
-		setup_sub_dir=1
-		setup_root=1
-		setup_nourl=0
-		setup_private=1
-		setup_public=1
-		upgrade=1
-		# 3.3.2~ynh1
-		upgrade=1	from_commit=511bcaf0c85174581212f3caa412182def2d0451
-		backup_restore=1
-		multi_instance=1
-		port_already_use=0
-		change_url=1
-;;; Options
-Email=
-Notification=none
-;;; Upgrade options
-	; commit=511bcaf0c85174581212f3caa412182def2d0451
-		name=Merge pull request #106 from YunoHost-Apps/testing
-		manifest_arg=domain=DOMAIN&path=PATH&is_public=1&language=fr&admin=USER&password=pass&port=666&

manifest.json

@@ -1,63 +0,0 @@
-{
-    "name": "JupyterLab",
-    "id": "jupyterlab",
-    "packaging_format": 1,
-    "description": {
-        "en": "Code console environment for running Python code interactively",
-        "fr": "Console de code pour exécuter du code Python de manière interactive"
-    },
-    "version": "3.6.1~ynh2",
-    "url": "https://jupyter.org",
-    "upstream": {
-        "license": "BSD-3-Clause",
-        "website": "https://jupyter.org",
-        "demo": "https://mybinder.org/v2/gh/jupyterlab/jupyterlab-demo/master?urlpath=lab/tree/demo",
-        "admindoc": "https://jupyterlab.readthedocs.io/en/stable/",
-        "code": "https://github.com/jupyterhub/jupyterhub",
-        "cpe": "cpe:2.3:a:jupyter:nbdime-jupyterlab"
-    },
-    "license": "BSD-3-Clause",
-    "maintainer": {
-        "name": "kay0u",
-        "email": "pierre@kayou.io"
-    },
-    "requirements": {
-        "yunohost": ">= 11.0.9"
-    },
-    "multi_instance": true,
-    "services": [
-        "nginx"
-    ],
-    "arguments": {
-        "install": [
-            {
-                "name": "domain",
-                "type": "domain"
-            },
-            {
-                "name": "path",
-                "type": "path",
-                "example": "/jupyterlab",
-                "default": "/jupyterlab"
-            },
-            {
-                "name": "is_public",
-                "type": "boolean",
-                "default": true
-            },
-            {
-                "name": "admin",
-                "type": "user"
-            },
-            {
-                "name": "enable_terminal",
-                "type": "boolean",
-                "ask": {
-                    "en": "Enable terminal in the lab?",
-                    "fr": "Activer le terminal dans le lab ?"
-                },
-                "default": true
-            }
-        ]
-    }
-}

manifest.toml

@@ -18,11 +18,11 @@ code = "https://github.com/jupyterhub/jupyterhub"
 
 [integration]
 yunohost = ">= 11.1.8"
-architectures = "all" # FIXME: can be replaced by a list of supported archs using the dpkg --print-architecture nomenclature (amd64/i386/armhf/arm64), for example: ["amd64", "i386"]
+architectures = "all"
 multi_instance = true
 ldap = true
 sso = false
-disk = "50M" # FIXME: replace with an **estimate** minimum disk requirement. e.g. 20M, 400M, 1G, ...
+disk = "50M"
 ram.build = "50M"
 ram.runtime = "50M"
 

scripts/_common.sh

@@ -4,9 +4,6 @@
 # COMMON VARIABLES
 #=================================================
 
-# dependencies used by the app
-#REMOVEME? pkg_dependencies="python3-dev python3-pip"
-
 nodejs_version="16"
 
 jupyterlab_version="3.6.1"

scripts/backup

@@ -10,26 +10,6 @@
 source ../settings/scripts/_common.sh
 source /usr/share/yunohost/helpers
 
-#=================================================
-# MANAGE SCRIPT FAILURE
-#=================================================
-
-#REMOVEME? ynh_clean_setup () {
-	true
-}
-# Exit if an error occurs during the execution of the script
-#REMOVEME? ynh_abort_if_errors
-
-#=================================================
-# LOAD SETTINGS
-#=================================================
-#REMOVEME? ynh_print_info --message="Loading installation settings..."
-
-#REMOVEME? app=$YNH_APP_INSTANCE_NAME
-
-#REMOVEME? #REMOVEME? install_dir=$(ynh_app_setting_get --app=$app --key=install_dir)
-#REMOVEME? domain=$(ynh_app_setting_get --app=$app --key=domain)
-
 #=================================================
 # DECLARE DATA AND CONF FILES TO BACKUP
 #=================================================

tests.toml

@@ -2,6 +2,12 @@ test_format = 1.0
 
 [default]
 
+    # -------------------------------
+    # Default args to use for install
+    # -------------------------------
+
+    args.enable_terminal = true
+
     # -------------------------------
     # Commits to test upgrade from
     # -------------------------------