From 3b8c0efd97102362e1bcc78f9ad304038f23cd19 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89ric=20Gaspar?=
 <46165813+ericgaspar@users.noreply.github.com>
Date: Mon, 6 Mar 2023 17:51:13 +0100
Subject: [PATCH] fix

---
 manifest.toml   |  4 ++++
 scripts/upgrade | 12 +++---------
 2 files changed, 7 insertions(+), 9 deletions(-)

diff --git a/manifest.toml b/manifest.toml
index a6c67aa..706b826 100644
--- a/manifest.toml
+++ b/manifest.toml
@@ -49,6 +49,10 @@ ram.runtime = "50M"
     [resources.permissions]
     main.url = "/"
 
+    ics.url = "/?controller=ICalendarController"
+    ics.show_tile = false
+    ics.allowed = "visitors"
+
     [resources.apt]
     packages = "mariadb-server php8.0-fpm php8.0-opcache php8.0-curl php8.0-gd php8.0-zip php8.0-xml php8.0-mbstring php8.0-mysql php8.0-ldap"
 
diff --git a/scripts/upgrade b/scripts/upgrade
index ebe9b95..ffbc180 100644
--- a/scripts/upgrade
+++ b/scripts/upgrade
@@ -23,29 +23,23 @@ upgrade_type=$(ynh_check_app_version_changed)
 ynh_script_progression --message="Ensuring downward compatibility..." --weight=1
 
 # If fpm_footprint doesn't exist, create it
-if [ -z "$fpm_footprint" ]; then
+if [ -z "${fpm_footprint:-}" ]; then
     fpm_footprint=low
     ynh_app_setting_set --app=$app --key=fpm_footprint --value=$fpm_footprint
 fi
 
 # If fpm_free_footprint doesn't exist, create it
-if [ -z "$fpm_free_footprint" ]; then
+if [ -z "${fpm_free_footprint:-}" ]; then
     fpm_free_footprint=0
     ynh_app_setting_set --app=$app --key=fpm_free_footprint --value=$fpm_free_footprint
 fi
 
 # If fpm_usage doesn't exist, create it
-if [ -z "$fpm_usage" ]; then
+if [ -z "${fpm_usage:-}" ]; then
     fpm_usage=low
     ynh_app_setting_set --app=$app --key=fpm_usage --value=$fpm_usage
 fi
 
-
-# Create a permission if needed
-#REMOVEME? if ! ynh_permission_exists --permission="ics"; then
-#REMOVEME? 	ynh_permission_create --permission="ics" --url="/?controller=ICalendarController" --allowed="visitors" --label="ICS Public access"
-#fi
-
 #=================================================
 # DOWNLOAD, CHECK AND UNPACK SOURCE
 #=================================================