Merge pull request #1 from YunoHost-Apps/testing

Update manifest.toml

README.md

@@ -16,7 +16,7 @@ If you don't have YunoHost, please consult [the guide](https://yunohost.org/#/in
 
 ## Overview
 
-Alternative front-end for Google Translate, serving as a Free and Open Source translator with over a hundred languages available
+Alternative front-end for Google Translate, serving as a Free and Open Source translator with over a hundred languages available.
 
 **Shipped version:** 2023.1.13~ynh1
 
@@ -26,6 +26,10 @@ Alternative front-end for Google Translate, serving as a Free and Open Source tr
 
 ![Screenshot of Lingva Translate](./doc/screenshots/lingva-id-en.png)
 
+## :red_circle: Antifeatures
+
+- **Non-free Network Services**: Promotes or depends entirely on a non-free network service.
+
 ## Documentation and resources
 
 * Upstream app code repository: <https://github.com/thedaviddelta/lingva-translate>

README_fr.md

@@ -16,7 +16,7 @@ Si vous n’avez pas YunoHost, regardez [ici](https://yunohost.org/#/install) po
 
 ## Vue d’ensemble
 
-Alternative front-end for Google Translate, serving as a Free and Open Source translator with over a hundred languages available
+Lingva est un front-end alternatif à Google Translate, servant de traducteur gratuit et open source avec plus d'une centaine de langues disponibles.
 
 **Version incluse :** 2023.1.13~ynh1
 
@@ -26,6 +26,10 @@ Alternative front-end for Google Translate, serving as a Free and Open Source tr
 
 ![Capture d’écran de Lingva Translate](./doc/screenshots/lingva-id-en.png)
 
+## :red_circle: Fonctions indésirables
+
+- **Non-free Network Services**: Promotes or depends entirely on a non-free network service.
+
 ## Documentations et ressources
 
 * Dépôt de code officiel de l’app : <https://github.com/thedaviddelta/lingva-translate>

conf/systemd.service

@@ -1,5 +1,5 @@
 [Unit]
-Description=alternative to google translate
+Description=Lingva: alternative to Google Translate
 After=network.target
 
 [Service]

doc/DESCRIPTION.md

@@ -1 +1 @@
-Alternative front-end for Google Translate, serving as a Free and Open Source translator with over a hundred languages available
+Alternative front-end for Google Translate, serving as a Free and Open Source translator with over a hundred languages available.

doc/DESCRIPTION_fr.md

@@ -0,0 +1 @@
+Lingva est un front-end alternatif à Google Translate, servant de traducteur gratuit et open source avec plus d'une centaine de langues disponibles.

doc/DESCRIPTION_id.md

@@ -1 +1 @@
-Antarmuka alternatif untuk Google Translate, menjadi alat penerjemahan yang Gratis/Bebas dan Sumber Terbuka dengan ratusan bahasa yang tersedia
+Antarmuka alternatif untuk Google Translate, menjadi alat penerjemahan yang Gratis/Bebas dan Sumber Terbuka dengan ratusan bahasa yang tersedia.

manifest.toml

@@ -15,11 +15,11 @@ demo = "https://lingva.ml"
 code = "https://github.com/thedaviddelta/lingva-translate"
 
 [integration]
-yunohost = ">= 11.1.14"
+yunohost = ">= 11.1.19"
 architectures = "all"
 multi_instance = true
-ldap = "not_relevant"
+ldap = false
-sso = "not_relevant"
+sso = false
 disk = "300M"
 ram.build = "50M"
 ram.runtime = "50M"
@@ -30,7 +30,7 @@ ram.runtime = "50M"
 
     [install.path]
     type = "path"
-    default = "/"
+    default = "/lingva"
 
     [install.init_main_permission]
     type = "group"
@@ -48,13 +48,10 @@ ram.runtime = "50M"
 
     [resources.install_dir]
 
-    [resources.data_dir]
-
     [resources.permissions]
     main.url = "/"
 
     [resources.ports]
-    main.default = 3000
 
     [resources.apt]
     packages = ""

scripts/_common.sh

@@ -4,7 +4,7 @@
 # COMMON VARIABLES
 #=================================================
 
-nodejs_version=18.16.0
+nodejs_version=18
 
 #=================================================
 # PERSONAL HELPERS

scripts/install

@@ -19,9 +19,6 @@ ynh_script_progression --message="Setting up source files..." --weight=1
 # Download, check integrity, uncompress and patch the source from app.src
 ynh_setup_source --dest_dir="$install_dir"
 
-# $install_dir will automatically be initialized with some decent 
-# permission by default ... however, you may need to recursively reapply
-# ownership to all files such as after the ynh_setup_source step
 chown -R $app:www-data "$install_dir"
 
 #=================================================

scripts/remove

@@ -9,19 +9,6 @@
 source _common.sh
 source /usr/share/yunohost/helpers
 
-# Settings are automatically loaded as bash variables
-# in every app script context, therefore typically these will exist:
-# - $domain
-# - $path
-# - $language
-# - $install_dir
-# - $port
-# ...
-
-# For remove operations :
-# - the core will deprovision every resource defined in the manifest **after** this script is ran
-# this includes removing the install directory, and data directory (if --purge was used)
-
 #=================================================
 # REMOVE SYSTEM CONFIGURATIONS
 #=================================================
@@ -29,8 +16,6 @@ source /usr/share/yunohost/helpers
 #=================================================
 ynh_script_progression --message="Removing system configurations related to $app..." --weight=1
 
-# This should be a symetric version of what happens in the install script
-
 # Remove the service from the list of services known by YunoHost (added from `yunohost service add`)
 if ynh_exec_warn_less yunohost service status $app >/dev/null
 then

scripts/restore

@@ -22,9 +22,6 @@ ynh_script_progression --message="Restoring the app main directory..." --weight=
 
 ynh_restore_file --origin_path="$install_dir"
 
-# $install_dir will automatically be initialized with some decent 
-# permission by default ... however, you may need to recursively reapply
-# ownership to all files such as after the ynh_setup_source step
 chown -R $app:www-data "$install_dir"
 
 #=================================================

scripts/upgrade

@@ -9,52 +9,8 @@
 source _common.sh
 source /usr/share/yunohost/helpers
 
-# Settings are automatically loaded as bash variables
-# in every app script context, therefore typically these will exist:
-# - $domain
-# - $path
-# - $language
-# - $install_dir
-# - $port
-# ...
-
-# In the context of upgrade,
-# - resources are automatically provisioned / updated / deleted (depending on existing resources)
-# - a safety backup is automatically created by the core and will be restored if the upgrade fails
-
-### This helper will compare the version of the currently installed app and the version of the upstream package.
-### $upgrade_type can have 2 different values
-### - UPGRADE_APP if the upstream app version has changed
-### - UPGRADE_PACKAGE if only the YunoHost package has changed
-### ynh_check_app_version_changed will stop the upgrade if the app is up to date.
-### UPGRADE_APP should be used to upgrade the core app only if there's an upgrade to do.
 upgrade_type=$(ynh_check_app_version_changed)
 
-#=================================================
-# STANDARD UPGRADE STEPS
-#=================================================
-# ENSURE DOWNWARD COMPATIBILITY
-#=================================================
-#ynh_script_progression --message="Ensuring downward compatibility..." --weight=1
-
-#
-# N.B. : the followings setting migrations snippets are provided as *EXAMPLES*
-# of what you may want to do in some cases (e.g. a setting was not defined on
-# some legacy installs and you therefore want to initiaze stuff during upgrade)
-#
-
-# If db_name doesn't exist, create it
-#if [ -z "$db_name" ]; then
-#	db_name=$(ynh_sanitize_dbid --db_name=$app)
-#	ynh_app_setting_set --app=$app --key=db_name --value=$db_name
-#fi
-
-# If install_dir doesn't exist, create it
-#if [ -z "$install_dir" ]; then
-#	install_dir=/var/www/$app
-#	ynh_app_setting_set --app=$app --key=install_dir --value=$install_dir
-#fi
-
 #=================================================
 # STOP SYSTEMD SERVICE
 #=================================================
@@ -76,9 +32,6 @@ then
 	ynh_setup_source --dest_dir="$install_dir"
 fi
 
-# $install_dir will automatically be initialized with some decent 
-# permission by default ... however, you may need to recursively reapply
-# ownership to all files such as after the ynh_setup_source step
 chown -R $app:www-data "$install_dir"
 
 #=================================================
@@ -96,11 +49,6 @@ ynh_add_nginx_config
 #=================================================
 ynh_script_progression --message="Updating a configuration file..." --weight=1
 
-### Same as during install
-###
-### The file will automatically be backed-up if it's found to be manually modified (because
-### ynh_add_config keeps track of the file's checksum)
-
 ynh_add_config --template=".env.local" --destination="$install_dir/.env.local"
 
 chmod 400 "$install_dir/.env.local"