From ef7cb82ef16b1ada341d175183b7be20c5c5a61b Mon Sep 17 00:00:00 2001 From: Alexandre Aubin Date: Sat, 9 Jan 2021 22:39:34 +0100 Subject: [PATCH 1/4] Finding an available port --- scripts/install | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/install b/scripts/install index ec74ab8..aa00843 100755 --- a/scripts/install +++ b/scripts/install @@ -62,7 +62,7 @@ ynh_app_setting_set --app=$app --key=language --value=$language #================================================= # FIND AND OPEN A PORT #================================================= -ynh_script_progression --message="Configuring firewall..." --weight=1 +ynh_script_progression --message="Finding an available port..." --weight=1 # Find an available port port=$(ynh_find_port --port=8095) From 5c424779d979ec500553018b7a0497b7b9d01fb3 Mon Sep 17 00:00:00 2001 From: ericgaspar Date: Wed, 27 Jan 2021 09:36:37 +0100 Subject: [PATCH 2/4] Fix linter warnings --- README.md | 2 ++ README_fr.md | 2 ++ manifest.json | 4 ++-- pull_request_template.md | 4 +--- scripts/install | 4 +--- 5 files changed, 8 insertions(+), 8 deletions(-) diff --git a/README.md b/README.md index 87e00c8..4681e0e 100755 --- a/README.md +++ b/README.md @@ -12,6 +12,8 @@ If you don't have YunoHost, please see [here](https://yunohost.org/#/install) to LionWiki-t2t is a minimalist Wiki engine programmed in PHP. It is extensible, templatable, file based (it doesn't need database like MySQL) and requires just one file to function (30 kb). It is suitable for small websites, personal notebooks or journals. This version is using the lightweight markup language TXT2TAGS. +**Shipped version:** 3.2.11b + ## Screenshot ![](screenshot_lionwikit2t.png) diff --git a/README_fr.md b/README_fr.md index 2e1844f..03edee8 100755 --- a/README_fr.md +++ b/README_fr.md @@ -12,6 +12,8 @@ Si vous n'avez pas YunoHost, regardez [ici](https://yunohost.org/#/install) pour Lionwiki-t2t est un système de type wiki minimaliste, programmé en PHP. Il est extensible et n'utilise que des fichiers plats pour sa base de données. Il est adapté pour la création de petits sites web, de notes personnelles ou de journaux. Cette version utilise le langage de balisage léger TXT2TAGS. +**Version incluse :** 3.2.11b + ## Capture d'écran ![](screenshot_lionwikit2t.png) diff --git a/manifest.json b/manifest.json index 92c5802..4727dd0 100755 --- a/manifest.json +++ b/manifest.json @@ -6,7 +6,7 @@ "en": "Lightweight wiki-style CMS using the txt2tags syntax", "fr": "CMS léger, géré sous forme de wiki utilisant la syntaxe txt2tags" }, - "version": "3.2.11b~ynh6", + "version": "3.2.11~ynh6", "url": "https://lionwiki-t2t.sourceforge.io/", "license": "MIT", "maintainer": { @@ -18,7 +18,7 @@ "multi_instance": true, "services": [ "nginx", - "php7.0-fpm" + "php7.3-fpm" ], "arguments": { "install" : [ diff --git a/pull_request_template.md b/pull_request_template.md index 14134f4..6c28fc5 100755 --- a/pull_request_template.md +++ b/pull_request_template.md @@ -13,6 +13,4 @@ ## Package_check results --- -*If you have access to [App Continuous Integration for packagers](https://yunohost.org/#/packaging_apps_ci) you can provide a link to the package_check results like below, replacing '-NUM-' in this link by the PR number and USERNAME by your username on the ci-apps-dev. Or you provide a screenshot or a pastebin of the results* - -[![Build Status](https://ci-apps-dev.yunohost.org/jenkins/job/lionwiki-t2t_ynh%20PR-NUM-%20(USERNAME)/badge/icon)](https://ci-apps-dev.yunohost.org/jenkins/job/lionwiki-t2t_ynh%20PR-NUM-%20(USERNAME)/) +* An automatic package_check will be launch at https://ci-apps-dev.yunohost.org/, when you add a specific comment to your Pull Request: "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!"* diff --git a/scripts/install b/scripts/install index aa00843..738fde9 100755 --- a/scripts/install +++ b/scripts/install @@ -208,9 +208,7 @@ ynh_script_progression --message="Configuring SSOwat..." --weight=1 # Make app public if necessary or protect it if [ $is_public -eq 1 ] then - # Everyone can access the app. - # The "main" permission is automatically created before the install script. - ynh_permission_update --permission "main" --add "visitors" + ynh_permission_update --permission="main" --add="visitors" fi #================================================= From 4b8d76b7b0035f49f5a837fda00df6febe9caaeb Mon Sep 17 00:00:00 2001 From: ericgaspar Date: Fri, 19 Mar 2021 23:28:49 +0100 Subject: [PATCH 3/4] Cleaning up --- manifest.json | 22 +--------------------- scripts/install | 3 +-- scripts/upgrade | 17 +++++++---------- 3 files changed, 9 insertions(+), 33 deletions(-) diff --git a/manifest.json b/manifest.json index 4727dd0..4b7e237 100755 --- a/manifest.json +++ b/manifest.json @@ -13,7 +13,7 @@ "name": "Eric Forgeot" }, "requirements": { - "yunohost": ">= 3.8.1" + "yunohost": ">= 4.1.7" }, "multi_instance": true, "services": [ @@ -25,38 +25,22 @@ { "name": "domain", "type": "domain", - "ask": { - "en": "Choose a domain name for Lionwiki", - "fr": "Choisissez un nom de domaine pour Lionwiki" - }, "example": "domain.org" }, { "name": "path", "type": "path", - "ask": { - "en": "Choose a path for Lionwiki", - "fr": "Choisissez un chemin pour Lionwiki" - }, "example": "/lionwiki", "default": "/lionwiki" }, { "name": "admin", "type": "user", - "ask": { - "en": "Choose an admin user", - "fr": "Choisissez l'administrateur" - }, "example": "johndoe" }, { "name": "is_public", "type": "boolean", - "ask": { - "en": "Is it a public application?", - "fr": "Est-ce une application publique ?" - }, "help": { "en": "If it's not public, only SSO registered users will be able to user it.", "fr": "Si ce n'est pas public, seuls les utilisateurs enregistrés sur le SSO pourront l'utiliser." @@ -76,10 +60,6 @@ { "name": "password", "type": "password", - "ask": { - "en": "Set the password for edition", - "fr": "Définissez le mot de passe pour l'édition" - }, "help": { "en": "Define a password which will be used for wiki edition and administration.", "fr": "Veuillez définir un mot de passe qui sera valable pour l'édition des pages de ce wiki ainsi que pour l'administration." diff --git a/scripts/install b/scripts/install index 738fde9..db02e8b 100755 --- a/scripts/install +++ b/scripts/install @@ -54,7 +54,6 @@ ynh_script_progression --message="Storing installation settings..." --weight=1 ynh_app_setting_set --app=$app --key=domain --value=$domain ynh_app_setting_set --app=$app --key=path --value=$path_url ynh_app_setting_set --app=$app --key=admin --value=$admin -ynh_app_setting_set --app=$app --key=is_public --value=$is_public ynh_app_setting_set --app=$app --key=language --value=$language #================================================= @@ -203,7 +202,7 @@ find $final_path/templates/minimaxing/minimaxing.css -type f -print0 | xargs -0 #================================================= # SETUP SSOWAT #================================================= -ynh_script_progression --message="Configuring SSOwat..." --weight=1 +ynh_script_progression --message="Configuring permissions..." --weight=1 # Make app public if necessary or protect it if [ $is_public -eq 1 ] diff --git a/scripts/upgrade b/scripts/upgrade index 73b3273..3248c95 100755 --- a/scripts/upgrade +++ b/scripts/upgrade @@ -19,7 +19,6 @@ app=$YNH_APP_INSTANCE_NAME domain=$(ynh_app_setting_get --app=$app --key=domain) path_url=$(ynh_app_setting_get --app=$app --key=path) admin=$(ynh_app_setting_get --app=$app --key=admin) -is_public=$(ynh_app_setting_get --app=$app --key=is_public) final_path=$(ynh_app_setting_get --app=$app --key=final_path) language=$(ynh_app_setting_get --app=$app --key=language) phpversion=$(ynh_app_setting_get --app=$app --key=phpversion) @@ -35,21 +34,19 @@ upgrade_type=$(ynh_check_app_version_changed) #================================================= ynh_script_progression --message="Ensuring downward compatibility..." --weight=1 -# Fix is_public as a boolean value -if [ "$is_public" = "Yes" ]; then - ynh_app_setting_set --app=$app --key=is_public --value=1 - is_public=1 -elif [ "$is_public" = "No" ]; then - ynh_app_setting_set --app=$app --key=is_public --value=0 - is_public=0 -fi - # If final_path doesn't exist, create it if [ -z "$final_path" ]; then final_path=/var/www/$app ynh_app_setting_set --app=$app --key=final_path --value=$final_path fi +# Cleaning legacy permissions +if ynh_legacy_permissions_exists; then + ynh_legacy_permissions_delete_all + + ynh_app_setting_delete --app=$app --key=is_public +fi + #================================================= # BACKUP BEFORE UPGRADE THEN ACTIVE TRAP #================================================= From 8bc9d62375cecb2f6054accab8c642201e4bc510 Mon Sep 17 00:00:00 2001 From: ericgaspar Date: Fri, 19 Mar 2021 23:32:15 +0100 Subject: [PATCH 4/4] Update check_process --- check_process | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/check_process b/check_process index 8eaf278..ad1506e 100755 --- a/check_process +++ b/check_process @@ -17,7 +17,7 @@ setup_private=1 setup_public=1 upgrade=1 - upgrade=1 from_commit=fde26800233eb9d312ef2885d747555c79ee779b + upgrade=1 from_commit=69db9a386081d9241f5548e09052fd58dee45463 backup_restore=1 multi_instance=1 port_already_use=0 @@ -26,6 +26,6 @@ Email= Notification=none ;;; Upgrade options - ; commit=fde26800233eb9d312ef2885d747555c79ee779b - name=updating to latest lionwiki-t2t release + ; commit=69db9a386081d9241f5548e09052fd58dee45463 + name=Merge pull request #4 from YunoHost-Apps/testing manifest_arg=domain=DOMAIN&path=PATH&admin=USER&is_public=Yes&language=en&