From fc08bdd80cdd18f6f5e03ef2382cc95d48809ae2 Mon Sep 17 00:00:00 2001 From: magikcypress Date: Mon, 17 Apr 2017 02:04:18 +0200 Subject: [PATCH 1/3] [fix] always public + fix upgrade --- conf/nginx.conf | 4 ++-- manifest.json | 9 --------- scripts/install | 17 +---------------- scripts/upgrade | 33 +++++++++++++-------------------- sources/source_dir | 2 +- sources/source_md5 | 2 +- sources/source_url | 2 +- 7 files changed, 19 insertions(+), 50 deletions(-) diff --git a/conf/nginx.conf b/conf/nginx.conf index 5ce3d7a..d8f0904 100644 --- a/conf/nginx.conf +++ b/conf/nginx.conf @@ -6,8 +6,8 @@ location / { try_files $uri @proxy; - #--PRIVATE--# Include SSOWAT user panel. - #--PRIVATE--include conf.d/yunohost_panel.conf.inc; + # Include SSOWAT user panel. + include conf.d/yunohost_panel.conf.inc; } location @proxy { diff --git a/manifest.json b/manifest.json index 0152f9f..97ab963 100644 --- a/manifest.json +++ b/manifest.json @@ -57,15 +57,6 @@ }, "choices": ["en_EN", "fr_FR"], "default": "fr_FR" - }, - { - "name": "is_public", - "ask": { - "en": "Mastodon is it public?", - "fr": "Mastodon est-il public ?" - }, - "choices": ["Yes", "No"], - "default": "Yes" } ] } diff --git a/scripts/install b/scripts/install index b78cb47..d99ffe2 100644 --- a/scripts/install +++ b/scripts/install @@ -17,7 +17,6 @@ domain=$YNH_APP_ARG_DOMAIN admin_mastodon=$YNH_APP_ARG_ADMIN admin_pass=$YNH_APP_ARG_PASSWD language=$YNH_APP_ARG_LANGUAGE -is_public=$YNH_APP_ARG_IS_PUBLIC app=$YNH_APP_INSTANCE_NAME @@ -33,7 +32,6 @@ ynh_app_setting_set $app domain $domain ynh_app_setting_set $app admin $admin_mastodon ynh_app_setting_set $app pass $admin_pass ynh_app_setting_set $app language $language -ynh_app_setting_set $app is_public $is_public # Create user unix sudo adduser $app --home /opt/$app --gecos "First Last,RoomNumber,WorkPhone,HomePhone" --disabled-password --disabled-login @@ -94,7 +92,7 @@ CLONECOMMANDS # Be king rewind (/var/cache/yunohost/from_file/scripts) popd -# Get Mastodon last version +# # Get Mastodon last version # sudo mkdir "${final_path}/live" # SETUP_SOURCE # sudo chown -R $app: "${final_path}" @@ -191,19 +189,6 @@ sudo sed -i "s@__APP__@$app@g" /etc/cron.d/$app # Restart crontab sudo systemctl restart cron -# Private or not -if [ "$is_public" = "Yes" ]; -then - sudo sed -i "s@#--PRIVATE--@@g" /etc/nginx/conf.d/$domain.d/$app.conf -fi - -# Setup SSOwat -ynh_app_setting_set "$app" is_public "$is_public" -if [ "$is_public" = "Yes" ]; -then - ynh_app_setting_set "$app" unprotected_uris "/" -fi - # Reload SSOwat configuration sudo yunohost app ssowatconf diff --git a/scripts/upgrade b/scripts/upgrade index 771b98b..367ee94 100644 --- a/scripts/upgrade +++ b/scripts/upgrade @@ -13,12 +13,12 @@ app=$YNH_APP_INSTANCE_NAME domain=$(ynh_app_setting_get "$app" domain) path=$(ynh_app_setting_get "$app" path) admin=$(ynh_app_setting_get "$app" admin) -is_public=$(ynh_app_setting_get "$app" is_public) +language=$(ynh_app_setting_get "$app" language) CHECK_PATH # Checks and corrects the syntax of the path. # Check if admin is not null -if [[ "$admin" = "" || "$is_public" = "" || "$language" = "" ]]; then +if [[ "$admin" = "" || "$language" = "" ]]; then echo "Unable to upgrade, please contact support" ynh_die fi @@ -32,29 +32,22 @@ sudo sed -i "s@__PATH__@$app@g" ../conf/nginx.conf* sudo sed -i "s@__FINALPATH__@$final_path/@g" ../conf/nginx.conf* # Stop Mastodon Services -sudo systemctl stop /etc/systemd/system/mastodon-*.service +sudo systemctl stop mastodon-*.service # Update Mastodon sudo su - $app < Date: Mon, 17 Apr 2017 18:10:54 +0200 Subject: [PATCH 2/3] Corrections check_process --- check_process | 27 +++++++++++++-------------- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/check_process b/check_process index c929221..6952a12 100644 --- a/check_process +++ b/check_process @@ -2,27 +2,26 @@ auto_remove=1 ; Manifest domain="domain.tld" (DOMAIN) - path="/path" (PATH) - is_public="Yes" (PUBLIC|public=Yes|private=No) admin="john" (USER) - + path="/path" (PATH) + passwd="adminpassword" ; Checks pkg_linter=1 - setup_sub_dir=1 + setup_sub_dir=0 setup_root=1 setup_nourl=0 - setup_private=1 - setup_public=1 + setup_private=0 + setup_public=0 upgrade=1 backup_restore=1 - multi_instance=1 - wrong_user=1 - wrong_path=1 - incorrect_path=1 - corrupt_source=1 - fail_download_source=1 - port_already_use=1 - final_path_already_use=1 + multi_instance=0 + wrong_user=0 + wrong_path=0 + incorrect_path=0 + corrupt_source=0 + fail_download_source=0 + port_already_use=0 + final_path_already_use=0 ;;; Levels Level 1=auto Level 2=auto From cfdc9938e270ce9bd92446f628101f0b67db3e32 Mon Sep 17 00:00:00 2001 From: magikcypress Date: Mon, 17 Apr 2017 19:53:12 +0200 Subject: [PATCH 3/3] [fix] Bug backup crontab --- scripts/backup | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/backup b/scripts/backup index 2ef6b86..0ea98a6 100644 --- a/scripts/backup +++ b/scripts/backup @@ -18,7 +18,7 @@ ynh_backup "$final_path" "sources" 1 # Copy the nginx conf files ynh_backup "/etc/nginx/conf.d/${domain}.d/${app}.conf" "nginx.conf" -ynh_backup "/etc/cron.d/${app}.conf" "cron.conf" +ynh_backup "/etc/cron.d/${app}" "cron.conf" ynh_backup "/etc/systemd/system/mastodon-web.service" "systemd_web.service" ynh_backup "/etc/systemd/system/mastodon-sidekiq.service" "systemd_sidekiq.service" ynh_backup "/etc/systemd/system/mastodon-streaming.service" "systemd_streaming.service"