diff --git a/config_panel.json b/config_panel.json
index f3e926b..af55156 100644
--- a/config_panel.json
+++ b/config_panel.json
@@ -32,6 +32,17 @@
"type": "bool",
"default": true
}]
+ },
+ {
+ "name": "Global configuration",
+ "id": "global_config",
+ "options": [{
+ "name": "Send HTML email to admin ?",
+ "help": "Allow app scripts to send HTML mails instead of plain text.",
+ "id": "email_type",
+ "type": "bool",
+ "default": true
+ }]
}]
}
]
diff --git a/manifest.json b/manifest.json
index ab2477d..505e146 100644
--- a/manifest.json
+++ b/manifest.json
@@ -6,7 +6,7 @@
"en": "Light DLNA server to share media files over the LAN",
"fr": "Serveur DLNA léger pour partager les fichiers multimédia sur le réseau local"
},
- "version": "1.0~ynh4",
+ "version": "1.0~ynh5",
"url": "http://minidlna.sourceforge.net/",
"license": "GPL-2.0",
"maintainer": {
@@ -14,7 +14,7 @@
"email": "maniackc_dev@crudelis.fr"
},
"requirements": {
- "yunohost": ">= 3.3.3"
+ "yunohost": ">= 3.4"
},
"multi_instance": false,
"services": [],
diff --git a/scripts/_common.sh b/scripts/_common.sh
index caf8bc7..e74bc0f 100755
--- a/scripts/_common.sh
+++ b/scripts/_common.sh
@@ -52,210 +52,6 @@ bool_to_true_false () {
# FUTUR OFFICIAL HELPERS
#=================================================
-# Internal helper design to allow helpers to use getopts to manage their arguments
-#
-# [internal]
-#
-# example: function my_helper()
-# {
-# declare -Ar args_array=( [a]=arg1= [b]=arg2= [c]=arg3 )
-# local arg1
-# local arg2
-# local arg3
-# ynh_handle_getopts_args "$@"
-#
-# [...]
-# }
-# my_helper --arg1 "val1" -b val2 -c
-#
-# usage: ynh_handle_getopts_args "$@"
-# | arg: $@ - Simply "$@" to tranfert all the positionnal arguments to the function
-#
-# This helper need an array, named "args_array" with all the arguments used by the helper
-# that want to use ynh_handle_getopts_args
-# Be carreful, this array has to be an associative array, as the following example:
-# declare -Ar args_array=( [a]=arg1 [b]=arg2= [c]=arg3 )
-# Let's explain this array:
-# a, b and c are short options, -a, -b and -c
-# arg1, arg2 and arg3 are the long options associated to the previous short ones. --arg1, --arg2 and --arg3
-# For each option, a short and long version has to be defined.
-# Let's see something more significant
-# declare -Ar args_array=( [u]=user [f]=finalpath= [d]=database )
-#
-# NB: Because we're using 'declare' without -g, the array will be declared as a local variable.
-#
-# Please keep in mind that the long option will be used as a variable to store the values for this option.
-# For the previous example, that means that $finalpath will be fill with the value given as argument for this option.
-#
-# Also, in the previous example, finalpath has a '=' at the end. That means this option need a value.
-# So, the helper has to be call with --finalpath /final/path, --finalpath=/final/path or -f /final/path, the variable $finalpath will get the value /final/path
-# If there's many values for an option, -f /final /path, the value will be separated by a ';' $finalpath=/final;/path
-# For an option without value, like --user in the example, the helper can be called only with --user or -u. $user will then get the value 1.
-#
-# To keep a retrocompatibility, a package can still call a helper, using getopts, with positional arguments.
-# The "legacy mode" will manage the positional arguments and fill the variable in the same order than they are given in $args_array.
-# e.g. for `my_helper "val1" val2`, arg1 will be filled with val1, and arg2 with val2.
-ynh_handle_getopts_args () {
- # Manage arguments only if there's some provided
- set +x
- if [ $# -ne 0 ]
- then
- # Store arguments in an array to keep each argument separated
- local arguments=("$@")
-
- # For each option in the array, reduce to short options for getopts (e.g. for [u]=user, --user will be -u)
- # And built parameters string for getopts
- # ${!args_array[@]} is the list of all option_flags in the array (An option_flag is 'u' in [u]=user, user is a value)
- local getopts_parameters=""
- local option_flag=""
- for option_flag in "${!args_array[@]}"
- do
- # Concatenate each option_flags of the array to build the string of arguments for getopts
- # Will looks like 'abcd' for -a -b -c -d
- # If the value of an option_flag finish by =, it's an option with additionnal values. (e.g. --user bob or -u bob)
- # Check the last character of the value associate to the option_flag
- if [ "${args_array[$option_flag]: -1}" = "=" ]
- then
- # For an option with additionnal values, add a ':' after the letter for getopts.
- getopts_parameters="${getopts_parameters}${option_flag}:"
- else
- getopts_parameters="${getopts_parameters}${option_flag}"
- fi
- # Check each argument given to the function
- local arg=""
- # ${#arguments[@]} is the size of the array
- for arg in `seq 0 $(( ${#arguments[@]} - 1 ))`
- do
- # And replace long option (value of the option_flag) by the short option, the option_flag itself
- # (e.g. for [u]=user, --user will be -u)
- # Replace long option with =
- arguments[arg]="${arguments[arg]//--${args_array[$option_flag]}/-${option_flag} }"
- # And long option without =
- arguments[arg]="${arguments[arg]//--${args_array[$option_flag]%=}/-${option_flag}}"
- done
- done
-
- # Read and parse all the arguments
- # Use a function here, to use standart arguments $@ and be able to use shift.
- parse_arg () {
- # Read all arguments, until no arguments are left
- while [ $# -ne 0 ]
- do
- # Initialize the index of getopts
- OPTIND=1
- # Parse with getopts only if the argument begin by -, that means the argument is an option
- # getopts will fill $parameter with the letter of the option it has read.
- local parameter=""
- getopts ":$getopts_parameters" parameter || true
-
- if [ "$parameter" = "?" ]
- then
- ynh_die --message="Invalid argument: -${OPTARG:-}"
- elif [ "$parameter" = ":" ]
- then
- ynh_die --message="-$OPTARG parameter requires an argument."
- else
- local shift_value=1
- # Use the long option, corresponding to the short option read by getopts, as a variable
- # (e.g. for [u]=user, 'user' will be used as a variable)
- # Also, remove '=' at the end of the long option
- # The variable name will be stored in 'option_var'
- local option_var="${args_array[$parameter]%=}"
- # If this option doesn't take values
- # if there's a '=' at the end of the long option name, this option takes values
- if [ "${args_array[$parameter]: -1}" != "=" ]
- then
- # 'eval ${option_var}' will use the content of 'option_var'
- eval ${option_var}=1
- else
- # Read all other arguments to find multiple value for this option.
- # Load args in a array
- local all_args=("$@")
-
- # If the first argument is longer than 2 characters,
- # There's a value attached to the option, in the same array cell
- if [ ${#all_args[0]} -gt 2 ]; then
- # Remove the option and the space, so keep only the value itself.
- all_args[0]="${all_args[0]#-${parameter} }"
- # Reduce the value of shift, because the option has been removed manually
- shift_value=$(( shift_value - 1 ))
- fi
-
- # Declare the content of option_var as a variable.
- eval ${option_var}=""
- # Then read the array value per value
- local i
- for i in `seq 0 $(( ${#all_args[@]} - 1 ))`
- do
- # If this argument is an option, end here.
- if [ "${all_args[$i]:0:1}" == "-" ]
- then
- # Ignore the first value of the array, which is the option itself
- if [ "$i" -ne 0 ]; then
- break
- fi
- else
- # Else, add this value to this option
- # Each value will be separated by ';'
- if [ -n "${!option_var}" ]
- then
- # If there's already another value for this option, add a ; before adding the new value
- eval ${option_var}+="\;"
- fi
- eval ${option_var}+=\"${all_args[$i]}\"
- shift_value=$(( shift_value + 1 ))
- fi
- done
- fi
- fi
-
- # Shift the parameter and its argument(s)
- shift $shift_value
- done
- }
-
- # LEGACY MODE
- # Check if there's getopts arguments
- if [ "${arguments[0]:0:1}" != "-" ]
- then
- # If not, enter in legacy mode and manage the arguments as positionnal ones..
- # Dot not echo, to prevent to go through a helper output. But print only in the log.
- set -x; echo "! Helper used in legacy mode !" > /dev/null; set +x
- local i
- for i in `seq 0 $(( ${#arguments[@]} -1 ))`
- do
- # Try to use legacy_args as a list of option_flag of the array args_array
- # Otherwise, fallback to getopts_parameters to get the option_flag. But an associative arrays isn't always sorted in the correct order...
- # Remove all ':' in getopts_parameters
- getopts_parameters=${legacy_args:-${getopts_parameters//:}}
- # Get the option_flag from getopts_parameters, by using the option_flag according to the position of the argument.
- option_flag=${getopts_parameters:$i:1}
- if [ -z "$option_flag" ]; then
- ynh_print_warn --message="Too many arguments ! \"${arguments[$i]}\" will be ignored."
- continue
- fi
- # Use the long option, corresponding to the option_flag, as a variable
- # (e.g. for [u]=user, 'user' will be used as a variable)
- # Also, remove '=' at the end of the long option
- # The variable name will be stored in 'option_var'
- local option_var="${args_array[$option_flag]%=}"
-
- # Store each value given as argument in the corresponding variable
- # The values will be stored in the same order than $args_array
- eval ${option_var}+=\"${arguments[$i]}\"
- done
- unset legacy_args
- else
- # END LEGACY MODE
- # Call parse_arg and pass the modified list of args as an array of arguments.
- parse_arg "${arguments[@]}"
- fi
- fi
- set -x
-}
-
-#=================================================
-
# Install or update the main directory yunohost.multimedia
#
# usage: ynh_multimedia_build_main_dir
@@ -517,27 +313,6 @@ ynh_check_app_version_changed () {
#=================================================
-# Delete a file checksum from the app settings
-#
-# $app should be defined when calling this helper
-#
-# usage: ynh_remove_file_checksum file
-# | arg: -f, --file= - The file for which the checksum will be deleted
-ynh_delete_file_checksum () {
- # Declare an array to define the options of this helper.
- declare -Ar args_array=( [f]=file= )
- local file
- # Manage arguments with getopts
- ynh_handle_getopts_args "$@"
-
- local checksum_setting_name=checksum_${file//[\/ ]/_} # Replace all '/' and ' ' by '_'
- ynh_app_setting_delete $app $checksum_setting_name
-}
-
-#=================================================
-# EXPERIMENTAL HELPERS
-#=================================================
-
# Start (or other actions) a service, print a log in case of failure and optionnaly wait until the service is completely started
#
# usage: ynh_systemd_action [-n service_name] [-a action] [ [-l "line to match"] [-p log_path] [-t timeout] [-e length] ]
@@ -629,10 +404,92 @@ ynh_clean_check_starting () {
#=================================================
+# Print a message as INFO and show progression during an app script
+#
+# usage: ynh_script_progression --message=message [--weight=weight] [--time]
+# | arg: -m, --message= - The text to print
+# | arg: -w, --weight= - The weight for this progression. This value is 1 by default. Use a bigger value for a longer part of the script.
+# | arg: -t, --time= - Print the execution time since the last call to this helper. Especially usefull to define weights.
+# | arg: -l, --last= - Use for the last call of the helper, to fill te progression bar.
+increment_progression=0
+previous_weight=0
+# Define base_time when the file is sourced
+base_time=$(date +%s)
+ynh_script_progression () {
+ # Declare an array to define the options of this helper.
+ declare -Ar args_array=( [m]=message= [w]=weight= [t]=time [l]=last )
+ local message
+ local weight
+ local time
+ local last
+ # Manage arguments with getopts
+ ynh_handle_getopts_args "$@"
+ weight=${weight:-1}
+ time=${time:-0}
+ last=${last:-0}
+
+ # Get execution time since the last $base_time
+ local exec_time=$(( $(date +%s) - $base_time ))
+ base_time=$(date +%s)
+
+ # Get the number of occurrences of 'ynh_script_progression' in the script. Except those are commented.
+ local helper_calls="$(grep --count "^[^#]*ynh_script_progression" $0)"
+ # Get the number of call with a weight value
+ local weight_calls=$(grep --perl-regexp --count "^[^#]*ynh_script_progression.*(--weight|-w )" $0)
+
+ # Get the weight of each occurrences of 'ynh_script_progression' in the script using --weight
+ local weight_valuesA="$(grep --perl-regexp "^[^#]*ynh_script_progression.*--weight" $0 | sed 's/.*--weight[= ]\([[:digit:]].*\)/\1/g')"
+ # Get the weight of each occurrences of 'ynh_script_progression' in the script using -w
+ local weight_valuesB="$(grep --perl-regexp "^[^#]*ynh_script_progression.*-w " $0 | sed 's/.*-w[= ]\([[:digit:]].*\)/\1/g')"
+ # Each value will be on a different line.
+ # Remove each 'end of line' and replace it by a '+' to sum the values.
+ local weight_values=$(( $(echo "$weight_valuesA" | tr '\n' '+') + $(echo "$weight_valuesB" | tr '\n' '+') 0 ))
+
+ # max_progression is a total number of calls to this helper.
+ # Less the number of calls with a weight value.
+ # Plus the total of weight values
+ local max_progression=$(( $helper_calls - $weight_calls + $weight_values ))
+
+ # Increment each execution of ynh_script_progression in this script by the weight of the previous call.
+ increment_progression=$(( $increment_progression + $previous_weight ))
+ # Store the weight of the current call in $previous_weight for next call
+ previous_weight=$weight
+
+ # Set the scale of the progression bar
+ local scale=20
+ # progress_string(1,2) should have the size of the scale.
+ local progress_string1="####################"
+ local progress_string0="...................."
+
+ # Reduce $increment_progression to the size of the scale
+ if [ $last -eq 0 ]
+ then
+ local effective_progression=$(( $increment_progression * $scale / $max_progression ))
+ # If last is specified, fill immediately the progression_bar
+ else
+ local effective_progression=$scale
+ fi
+
+ # Build $progression_bar from progress_string(1,2) according to $effective_progression
+ local progression_bar="${progress_string1:0:$effective_progression}${progress_string0:0:$(( $scale - $effective_progression ))}"
+
+ local print_exec_time=""
+ if [ $time -eq 1 ]
+ then
+ print_exec_time=" [$(date +%Hh%Mm,%Ss --date="0 + $exec_time sec")]"
+ fi
+
+ ynh_print_info "[$progression_bar] > ${message}${print_exec_time}"
+}
+
+#=================================================
+# EXPERIMENTAL HELPERS
+#=================================================
+
# Send an email to inform the administrator
#
# usage: ynh_send_readme_to_admin --app_message=app_message [--recipients=recipients] [--type=type]
-# | arg: -m --app_message= - The message to send to the administrator.
+# | arg: -m --app_message= - The file with the content to send to the administrator.
# | arg: -r, --recipients= - The recipients of this email. Use spaces to separate multiples recipients. - default: root
# example: "root admin@domain"
# If you give the name of a YunoHost user, ynh_send_readme_to_admin will find its email adress for you
@@ -645,11 +502,16 @@ ynh_send_readme_to_admin() {
local recipients
local type
# Manage arguments with getopts
+
ynh_handle_getopts_args "$@"
- app_message="${app_message:-...No specific information...}"
+ app_message="${app_message:-}"
recipients="${recipients:-root}"
type="${type:-install}"
+ # Get the value of admin_mail_html
+ admin_mail_html=$(ynh_app_setting_get $app admin_mail_html)
+ admin_mail_html="${admin_mail_html:-0}"
+
# Retrieve the email of users
find_mails () {
local list_mails="$1"
@@ -696,12 +558,53 @@ ynh_send_readme_to_admin() {
Specific information for the application $app.
-$app_message
+$(if [ -n "$app_message" ]
+then
+ cat "$app_message"
+else
+ echo "...No specific information..."
+fi)
---
Automatic diagnosis data from YunoHost
-$(yunohost tools diagnosis | grep -B 100 "services:" | sed '/services:/d')"
+__PRE_TAG1__$(yunohost tools diagnosis | grep -B 100 "services:" | sed '/services:/d')__PRE_TAG2__"
+
+ # Store the message into a file for further modifications.
+ echo "$mail_message" > mail_to_send
+
+ # If a html email is required. Apply html tags to the message.
+ if [ "$admin_mail_html" -eq 1 ]
+ then
+ # Insert 'br' tags at each ending of lines.
+ ynh_replace_string "$" "
" mail_to_send
+
+ # Insert starting HTML tags
+ sed --in-place '1s@^@\n\n
" mail_to_send + ynh_replace_string "__PRE_TAG2__" "<\pre>" mail_to_send + + # Insert finishing HTML tags + echo -e "\n\n" >> mail_to_send + + # Otherwise, remove tags to keep a plain text. + else + # Remove URL tags + ynh_replace_string "__URL_TAG[1,3]__" "" mail_to_send + ynh_replace_string "__URL_TAG2__" ": " mail_to_send + + # Remove PRE tags + ynh_replace_string "__PRE_TAG[1-2]__" "" mail_to_send + fi # Define binary to use for mail command if [ -e /usr/bin/bsd-mailx ] @@ -711,8 +614,15 @@ $(yunohost tools diagnosis | grep -B 100 "services:" | sed '/services:/d')" local mail_bin=/usr/bin/mail.mailutils fi + if [ "$admin_mail_html" -eq 1 ] + then + content_type="text/html" + else + content_type="text/plain" + fi + # Send the email to the recipients - echo "$mail_message" | $mail_bin -a "Content-Type: text/plain; charset=UTF-8" -s "$mail_subject" "$recipients" + cat mail_to_send | $mail_bin -a "Content-Type: $content_type; charset=UTF-8" -s "$mail_subject" "$recipients" } #================================================= @@ -883,3 +793,65 @@ ynh_download_file () { # Move the file to its destination mv $filename $dest_dir } + +#================================================= + +# Create a changelog for an app after an upgrade. +# +# The changelog is printed into the file ./changelog for the time of the upgrade. +# +# In order to create a changelog, ynh_app_changelog will get info from /etc/yunohost/apps/$app/status.json +# In order to find the current commit use by the app. +# The remote repository, and the branch. +# The changelog will be only the commits since the current revision. +# +# Because of the need of those info, ynh_app_changelog works only +# with apps that have been installed from a list. +# +# usage: ynh_app_changelog +ynh_app_changelog () { + get_value_from_settings () + { + local value="$1" + # Extract a value from the status.json file of an installed app. + + grep "$value\": \"" /etc/yunohost/apps/$app/status.json | sed "s/.*$value\": \"\([^\"]*\).*/\1/" + } + + local current_revision="$(get_value_from_settings revision)" + local repo="$(get_value_from_settings url)" + local branch="$(get_value_from_settings branch)" + # ynh_app_changelog works only with an app installed from a list. + if [ -z "$current_revision" ] || [ -z "$repo" ] || [ -z "$branch" ] + then + ynh_print_warn "Unable to build the changelog..." + touch changelog + return 0 + fi + + # Fetch the history of the repository, without cloning it + mkdir git_history + (cd git_history + ynh_exec_warn_less git init + ynh_exec_warn_less git remote add -f origin $repo + # Get the line of the current commit of the installed app in the history. + local line_to_head=$(git log origin/$branch --pretty=oneline | grep --line-number "$current_revision" | cut -d':' -f1) + # Cut the history before the current commit, to keep only newer commits. + # Then use sed to reorganise each lines and have a nice list of commits since the last upgrade. + # This list is redirected into the file changelog + git log origin/$branch --pretty=oneline | head --lines=$(($line_to_head-1)) | sed 's/^\([[:alnum:]]*\)\(.*\)/*(\1) -> \2/g' > ../changelog) + # Remove 'Merge pull request' commits + sed -i '/Merge pull request #[[:digit:]]* from/d' changelog + # As well as conflict resolving commits + sed -i '/Merge branch .* into/d' changelog + + # Get the value of admin_mail_html + admin_mail_html=$(ynh_app_setting_get $app admin_mail_html) + admin_mail_html="${admin_mail_html:-0}" + + # If a html email is required. Apply html to the changelog. + if [ "$admin_mail_html" -eq 1 ] + then + sed -in-place "s@\*(\([[:alnum:]]*\)) -> \(.*\)@* __URL_TAG1__\2__URL_TAG2__${repo}/commit/\1__URL_TAG3__@g" changelog + fi +} diff --git a/scripts/actions/install_backports b/scripts/actions/install_backports index 4a58b51..f30c2bf 100755 --- a/scripts/actions/install_backports +++ b/scripts/actions/install_backports @@ -12,6 +12,7 @@ source /usr/share/yunohost/helpers #================================================= # RETRIEVE ARGUMENTS #================================================= +ynh_script_progression --message="Retrieve arguments from the manifest" app=${YNH_APP_INSTANCE_NAME:-$YNH_APP_ID} @@ -33,6 +34,7 @@ fi #================================================= # RE-INSTALL MINIDLNA FROM BACKPORTS #================================================= +ynh_script_progression --message="Re-install minidlna from backports" --weight=9 # Remove the current version of minidlna ynh_package_remove minidlna @@ -45,3 +47,9 @@ ynh_replace_string "__CODENAME__" "$codename" /etc/yunohost/apps/$app/conf/minid cp -a /etc/yunohost/apps/$app/conf/minidlna.list /etc/apt/sources.list.d/ ynh_apt update ynh_package_install -t $codename-backports minidlna + +#================================================= +# END OF SCRIPT +#================================================= + +ynh_script_progression --message="Execution completed" --last diff --git a/scripts/actions/install_standard b/scripts/actions/install_standard index 4fe193b..a361a31 100755 --- a/scripts/actions/install_standard +++ b/scripts/actions/install_standard @@ -31,6 +31,7 @@ fi #================================================= # RE-INSTALL MINIDLNA FROM STABLE #================================================= +ynh_script_progression --message="Re-install minidlna from stable" --weight=9 # Remove the current version of minidlna ynh_package_remove minidlna @@ -38,3 +39,9 @@ ynh_secure_remove "/etc/apt/sources.list.d/minidlna.list" ynh_apt update ynh_package_install minidlna + +#================================================= +# END OF SCRIPT +#================================================= + +ynh_script_progression --message="Execution completed" --last diff --git a/scripts/actions/reset_db b/scripts/actions/reset_db index 81e73d1..2e608aa 100755 --- a/scripts/actions/reset_db +++ b/scripts/actions/reset_db @@ -12,6 +12,7 @@ source /usr/share/yunohost/helpers #================================================= # RETRIEVE ARGUMENTS #================================================= +ynh_script_progression --message="Retrieve arguments from the manifest" app=${YNH_APP_INSTANCE_NAME:-$YNH_APP_ID} @@ -26,8 +27,9 @@ app=${YNH_APP_INSTANCE_NAME:-$YNH_APP_ID} #================================================= # SPECIFIC ACTION #================================================= -# LIST ALL PADS FROM THE DATABASE +# RESET THE DATABASE #================================================= +ynh_script_progression --message="Reset the database" --weight=9 # Get the last value for `db_dir` in the config file of minidlna db_directory=$(tac /etc/minidlna.conf | grep --max-count=1 "db_dir=" | cut -d'=' -f 2) @@ -35,3 +37,9 @@ db_directory=$(tac /etc/minidlna.conf | grep --max-count=1 "db_dir=" | cut -d'=' ynh_systemd_action --action=stop --service_name=minidlna ynh_secure_remove "$db_directory/files.db" ynh_systemd_action --action=start --service_name=minidlna + +#================================================= +# END OF SCRIPT +#================================================= + +ynh_script_progression --message="Execution completed" --last diff --git a/scripts/backup b/scripts/backup index 0b6ccb7..cd1d53f 100644 --- a/scripts/backup +++ b/scripts/backup @@ -19,6 +19,7 @@ ynh_abort_if_errors #================================================= # LOAD SETTINGS #================================================= +ynh_script_progression --message="Load settings" app=$YNH_APP_INSTANCE_NAME @@ -32,17 +33,26 @@ version=$(ynh_app_setting_get $app version) if [ $version = "B" ] then + ynh_script_progression --message="Backup of the APT source" ynh_backup "/etc/apt/sources.list.d/minidlna.list" fi #================================================= # BACKUP OF INOTIFY'S CONFIG #================================================= +ynh_script_progression --message="Backup of inotify's config" ynh_backup "/etc/sysctl.d/90-inotify_minidlna.conf" #================================================= # BACKUP OF MINIDLNA CONFIGURATION #================================================= +ynh_script_progression --message="Backup of minidlna configuration" ynh_backup "/etc/minidlna.conf" + +#================================================= +# END OF SCRIPT +#================================================= + +ynh_script_progression --message="Backup completed" --last diff --git a/scripts/config b/scripts/config index 92939cd..504dbf7 100644 --- a/scripts/config +++ b/scripts/config @@ -51,6 +51,11 @@ old_overwrite_settings="$(ynh_app_setting_get $app overwrite_settings)" old_overwrite_settings=$(bool_to_true_false $old_overwrite_settings) overwrite_settings="${YNH_CONFIG_MAIN_OVERWRITE_FILES_OVERWRITE_SETTINGS:-$old_overwrite_settings}" +# Type of admin mail configuration +old_admin_mail_html="$(ynh_app_setting_get $app admin_mail_html)" +old_admin_mail_html=$(bool_to_true_false $old_admin_mail_html) +admin_mail_html="${YNH_CONFIG_MAIN_GLOBAL_CONFIG_EMAIL_TYPE:-$old_admin_mail_html}" + #================================================= # SHOW_CONFIG FUNCTION FOR 'SHOW' COMMAND #================================================= @@ -74,6 +79,8 @@ show_config() { echo "YNH_CONFIG_MAIN_MINIDLNA_CONFIGURATION_FRIENDLY_NAME=$friendly_name" echo "YNH_CONFIG_MAIN_OVERWRITE_FILES_OVERWRITE_SETTINGS=$overwrite_settings" + + echo "YNH_CONFIG_MAIN_GLOBAL_CONFIG_EMAIL_TYPE=$admin_mail_html" } #================================================= @@ -119,6 +126,10 @@ apply_config() { # Set overwrite_settings overwrite_settings=$(bool_to_01 $overwrite_settings) ynh_app_setting_set $app overwrite_settings "$overwrite_settings" + + # Set admin_mail_html + admin_mail_html=$(bool_to_01 $admin_mail_html) + ynh_app_setting_set $app admin_mail_html "$admin_mail_html" } #================================================= diff --git a/scripts/install b/scripts/install index 326bf4d..1b8344c 100644 --- a/scripts/install +++ b/scripts/install @@ -19,6 +19,7 @@ ynh_abort_if_errors #================================================= # RETRIEVE ARGUMENTS FROM THE MANIFEST #================================================= +ynh_script_progression --message="Retrieve arguments from the manifest" version="$YNH_APP_ARG_VERSION" app=$YNH_APP_INSTANCE_NAME @@ -26,13 +27,17 @@ app=$YNH_APP_INSTANCE_NAME #================================================= # STORE SETTINGS FROM MANIFEST #================================================= +ynh_script_progression --message="Store settings from manifest" --weight=2 ynh_app_setting_set $app version ${version:0:1} + ynh_app_setting_set $app overwrite_settings "1" +ynh_app_setting_set $app admin_mail_html "1" #================================================= -# CHECK THE DEBIAN'S CODENAME +# CHECK DEBIAN'S CODENAME #================================================= +ynh_script_progression --message="Check debian's codename" codename=$(ynh_debian_release) test -z "$codename" && (ynh_die "codename empty") @@ -42,6 +47,7 @@ test -z "$codename" && (ynh_die "codename empty") #================================================= # FIND AND OPEN A PORT #================================================= +ynh_script_progression --message="Find and open a port" --weight=15 # Find a free port port=$(ynh_find_port 48200) @@ -55,6 +61,7 @@ ynh_app_setting_set $app port $port #================================================= # CREATE YUNOHOST.MULTIMEDIA DIRECTORY #================================================= +ynh_script_progression --message="Create yunohost.multimedia directory" --weight=8 ynh_multimedia_build_main_dir @@ -63,6 +70,7 @@ ynh_multimedia_build_main_dir #================================================= # INSTALL MINIDLNA #================================================= +ynh_script_progression --message="Install minidlna" --weight=45 if [ ${version:0:1} = "B" ] then @@ -81,6 +89,7 @@ ynh_app_setting_set $app version ${version:0:1} #================================================= # INCREASE INOTIFY'S LIMITS #================================================= +ynh_script_progression --message="Increase inotify's limits" # Increase the maximum number of files inotify can monitor. cp -a ../conf/90-inotify_minidlna.conf /etc/sysctl.d/ @@ -98,6 +107,7 @@ yunohost service add minidlna --log "/var/log/minidlna.log" #================================================= # CONFIGURE MINIDLNA #================================================= +ynh_script_progression --message="Configure MiniDLNA" --weight=2 ynh_replace_string "^#*media_dir=.*" "media_dir=/home/yunohost.multimedia/share" /etc/minidlna.conf ynh_replace_string "^#*port=.*" "port=$port" /etc/minidlna.conf @@ -115,6 +125,7 @@ ynh_store_file_checksum "/etc/minidlna.conf" #================================================= # RESTART MINIDLNA #================================================= +ynh_script_progression --message="Restart MiniDLNA" --weight=4 ynh_systemd_action --action=restart --service_name=minidlna @@ -125,15 +136,21 @@ ynh_systemd_action --action=restart --service_name=minidlna # Get main domain and buid the url of the admin panel of the app. admin_panel="https://$(grep portal_domain /etc/ssowat/conf.json | cut -d'"' -f4)/yunohost/admin/#/apps/$app" -message="You can find a config file at /etc/minidlna.conf +echo "You can find a config file at /etc/minidlna.conf MiniDLNA is going to serve the files present in the directory /home/yunohost.multimedia/share Please have a look to the documentation to learn more how to use MiniDLNA, https://yunohost.org/#/app_minidlna -You can configure this app easily by using the experimental config-panel feature: $admin_panel/config-panel. -You can also find some specific actions for this app by using the experimental action feature: $admin_panel/actions. +You can configure this app easily by using the experimental __URL_TAG1__config-panel feature__URL_TAG2__$admin_panel/config-panel__URL_TAG3__. +You can also find some specific actions for this app by using the experimental __URL_TAG1__action feature__URL_TAG2__$admin_panel/actions__URL_TAG3__. -If you're facing an issue or want to improve this app, please open a new issue in this project: https://github.com/YunoHost-Apps/minidlna_ynh" +If you're facing an issue or want to improve this app, please open a new issue in this __URL_TAG1__project__URL_TAG2__https://github.com/YunoHost-Apps/minidlna_ynh__URL_TAG3__." > mail_to_send -ynh_send_readme_to_admin --app_message="$message" --recipients="root" --type="install" +ynh_send_readme_to_admin --app_message="mail_to_send" --recipients="root" --type="install" + +#================================================= +# END OF SCRIPT +#================================================= + +ynh_script_progression --message="Installation completed" --last diff --git a/scripts/remove b/scripts/remove index 826a7e8..942e5ab 100755 --- a/scripts/remove +++ b/scripts/remove @@ -12,6 +12,7 @@ source /usr/share/yunohost/helpers #================================================= # LOAD SETTINGS #================================================= +ynh_script_progression --message="Load settings" --weight=2 app=$YNH_APP_INSTANCE_NAME @@ -33,6 +34,7 @@ fi #================================================= # CLOSE PORTS #================================================= +ynh_script_progression --message="Close ports" --weight=15 ynh_exec_fully_quiet yunohost firewall disallow TCP $port ynh_exec_fully_quiet yunohost firewall disallow UDP 1900 @@ -42,6 +44,7 @@ ynh_exec_fully_quiet yunohost firewall disallow UDP 1900 #================================================= # REMOVE MINIDNLA #================================================= +ynh_script_progression --message="Remove MiniDLNA" --weight=6 ynh_apt purge minidlna ynh_secure_remove "/etc/apt/sources.list.d/minidlna.list" @@ -49,6 +52,7 @@ ynh_secure_remove "/etc/apt/sources.list.d/minidlna.list" #================================================= # REMOVE INOTIFY'S CONFIG #================================================= +ynh_script_progression --message="Remove inotify's config" if [ -e "/etc/sysctl.d/90-inotify_minidlna.conf" ]; then ynh_print_info "Delete kernel config" >&2 @@ -58,3 +62,9 @@ if [ -e "/etc/sysctl.d/90-inotify_minidlna.conf" ]; then sysctl -p /etc/sysctl.d/90-inotify_minidlna.conf fi fi + +#================================================= +# END OF SCRIPT +#================================================= + +ynh_script_progression --message="Deletion completed" --last diff --git a/scripts/restore b/scripts/restore index 7a19677..fb97f4a 100644 --- a/scripts/restore +++ b/scripts/restore @@ -19,6 +19,7 @@ ynh_abort_if_errors #================================================= # LOAD SETTINGS #================================================= +ynh_script_progression --message="Load settings" app=$YNH_APP_INSTANCE_NAME @@ -30,6 +31,7 @@ port=$(ynh_app_setting_get $app port) #================================================= # OPEN PORTS #================================================= +ynh_script_progression --message="Open ports" --weight=15 ynh_exec_fully_quiet yunohost firewall allow --no-upnp TCP $port # Discovery Protocol SSDP for UPNP. @@ -38,12 +40,14 @@ ynh_exec_fully_quiet yunohost firewall allow --no-upnp UDP 1900 #================================================= # CREATE YUNOHOST.MULTIMEDIA DIRECTORY #================================================= +ynh_script_progression --message="Create yunohost.multimedia directory" --weight=6 ynh_multimedia_build_main_dir #================================================= # INSTALL MINIDLNA #================================================= +ynh_script_progression --message="Install minidlna" --weight=45 if [ ${version:0:1} = "B" ] then @@ -62,6 +66,7 @@ fi #================================================= # RESTORE INOTIFY'S CONFIG #================================================= +ynh_script_progression --message="Restore inotify's config" ynh_restore_file "/etc/sysctl.d/90-inotify_minidlna.conf" if ! IS_PACKAGE_CHECK; then @@ -71,6 +76,7 @@ fi #================================================= # RESTORE MINIDLNA CONFIGURATION #================================================= +ynh_script_progression --message="Restore MiniDLNA configuration" --weight=7 # Delete the current config of minidlna, in order to replace it by the version from the backup ynh_secure_remove "/etc/minidlna.conf" @@ -90,15 +96,21 @@ yunohost service add minidlna --log "/var/log/minidlna.log" # Get main domain and buid the url of the admin panel of the app. admin_panel="https://$(grep portal_domain /etc/ssowat/conf.json | cut -d'"' -f4)/yunohost/admin/#/apps/$app" -message="You can find a config file at /etc/minidlna.conf +echo "You can find a config file at /etc/minidlna.conf MiniDLNA is going to serve the files present in the directory /home/yunohost.multimedia/share Please have a look to the documentation to learn more how to use MiniDLNA, https://yunohost.org/#/app_minidlna -You can configure this app easily by using the experimental config-panel feature: $admin_panel/config-panel. -You can also find some specific actions for this app by using the experimental action feature: $admin_panel/actions. +You can configure this app easily by using the experimental __URL_TAG1__config-panel feature__URL_TAG2__$admin_panel/config-panel__URL_TAG3__. +You can also find some specific actions for this app by using the experimental __URL_TAG1__action feature__URL_TAG2__$admin_panel/actions__URL_TAG3__. -If you're facing an issue or want to improve this app, please open a new issue in this project: https://github.com/YunoHost-Apps/minidlna_ynh" +If you're facing an issue or want to improve this app, please open a new issue in this __URL_TAG1__project__URL_TAG2__https://github.com/YunoHost-Apps/minidlna_ynh__URL_TAG3__." > mail_to_send -ynh_send_readme_to_admin --app_message="$message" --recipients="root" --type="restore" +ynh_send_readme_to_admin --app_message="mail_to_send" --recipients="root" --type="restore" + +#================================================= +# END OF SCRIPT +#================================================= + +ynh_script_progression --message="Restoration completed" --last diff --git a/scripts/upgrade b/scripts/upgrade index a8f8c80..04f45aa 100644 --- a/scripts/upgrade +++ b/scripts/upgrade @@ -12,6 +12,7 @@ source /usr/share/yunohost/helpers #================================================= # LOAD SETTINGS #================================================= +ynh_script_progression --message="Load settings" --weight=2 app=$YNH_APP_INSTANCE_NAME @@ -30,6 +31,7 @@ upgrade_type=$(ynh_check_app_version_changed) #================================================= # ENSURE DOWNWARD COMPATIBILITY #================================================= +ynh_script_progression --message="Ensure downward compatibility" # If overwrite_settings doesn't exist, create it if [ -z "$overwrite_settings" ]; then @@ -52,6 +54,7 @@ fi #================================================= # BACKUP BEFORE UPGRADE THEN ACTIVE TRAP #================================================= +ynh_script_progression --message="Backup the app before upgrading" --weight=2 # Backup the current version of the app ynh_backup_before_upgrade @@ -65,12 +68,14 @@ ynh_abort_if_errors #================================================= # UPGRADE THE YUNOHOST.MULTIMEDIA DIRECTORY #================================================= +ynh_script_progression --message="Upgrade the yunohost.multimedia directory" --weight=3 ynh_multimedia_build_main_dir #================================================= # UPGRADE MINIDLNA #================================================= +ynh_script_progression --message="Upgrade MiniDLNA" --weight=3 if [ $version = "B" ] then @@ -89,6 +94,7 @@ fi #================================================= # INCREASE INOTIFY'S LIMITS #================================================= +ynh_script_progression --message="Increase inotify's limits" --weight=2 # Increase the maximum number of files inotify can monitor. cp -a ../conf/90-inotify_minidlna.conf /etc/sysctl.d/ @@ -106,6 +112,7 @@ yunohost service add minidlna --log "/var/log/minidlna.log" #================================================= # CONFIGURE MINIDLNA #================================================= +ynh_script_progression --message="Reconfigure MiniDLNA" --weight=2 # Overwrite the settings config file only if it's allowed if [ $overwrite_settings -eq 1 ] @@ -126,6 +133,7 @@ fi #================================================= # RESTART MINIDLNA'S SERVICE #================================================= +ynh_script_progression --message="Restart MiniDLNA" --weight=7 ynh_systemd_action --action=restart --service_name=minidlna @@ -136,15 +144,29 @@ ynh_systemd_action --action=restart --service_name=minidlna # Get main domain and buid the url of the admin panel of the app. admin_panel="https://$(grep portal_domain /etc/ssowat/conf.json | cut -d'"' -f4)/yunohost/admin/#/apps/$app" -message="You can find a config file at /etc/minidlna.conf +# Build the changelog +ynh_app_changelog || true + +echo "You can find a config file at /etc/minidlna.conf MiniDLNA is going to serve the files present in the directory /home/yunohost.multimedia/share Please have a look to the documentation to learn more how to use MiniDLNA, https://yunohost.org/#/app_minidlna -You can configure this app easily by using the experimental config-panel feature: $admin_panel/config-panel. -You can also find some specific actions for this app by using the experimental action feature: $admin_panel/actions. +You can configure this app easily by using the experimental __URL_TAG1__config-panel feature__URL_TAG2__$admin_panel/config-panel__URL_TAG3__. +You can also find some specific actions for this app by using the experimental __URL_TAG1__action feature__URL_TAG2__$admin_panel/actions__URL_TAG3__. -If you're facing an issue or want to improve this app, please open a new issue in this project: https://github.com/YunoHost-Apps/minidlna_ynh" +If you're facing an issue or want to improve this app, please open a new issue in this __URL_TAG1__project__URL_TAG2__https://github.com/YunoHost-Apps/minidlna_ynh__URL_TAG3__. -ynh_send_readme_to_admin --app_message="$message" --recipients="root" --type="upgrade" +--- + +Changelog since your last upgrade: +$(cat changelog)" > mail_to_send + +ynh_send_readme_to_admin --app_message="mail_to_send" --recipients="root" --type="upgrade" + +#================================================= +# END OF SCRIPT +#================================================= + +ynh_script_progression --message="Upgrade completed" --last