diff --git a/README.md b/README.md
index b2d9692..72516d4 100644
--- a/README.md
+++ b/README.md
@@ -1,34 +1,44 @@
-
# Monica app for YunoHost
-[![Integration level](https://dash.yunohost.org/integration/monica.svg)](https://dash.yunohost.org/appci/app/monica)
-[![Installer Monica with YunoHost](https://install-app.yunohost.org/install-with-yunohost.png)](https://install-app.yunohost.org/?app=monica)
+[![Integration level](https://dash.yunohost.org/integration/monica.svg)](https://dash.yunohost.org/appci/app/monica) ![](https://ci-apps.yunohost.org/ci/badges/monica.status.svg) ![](https://ci-apps.yunohost.org/ci/badges/monica.maintain.svg)
+[![Install Monica with YunoHost](https://install-app.yunohost.org/install-with-yunohost.png)](https://install-app.yunohost.org/?app=monica)
-Shipped version: **2.17.0.**
-
-Personal Relationship Manager
+> *This package allows you to install Monica quickly and simply on a YunoHost server.
+If you don't have YunoHost, please consult [the guide](https://yunohost.org/#/install) to learn how to install it.*
+## Overview
+Monica is an open-source web application to organize the interactions with your loved ones. I call it a PRM, or Personal Relationship Management. Think of it as a [CRM](https://en.wikipedia.org/wiki/Customer_relationship_management) (a popular tool used by sales teams in the corporate world) for your friends or family.
-- [Yunohost project](https://yunohost.org)
-- [Monica](https://monicahq.com/)
-- [Monica source code at Github](https://github.com/monicahq/monica)
+**Shipped version:** 2.17.0
+
+## Screenshots
+
+![](https://www.monicahq.com/img/contacts.png)
+
+## Configuration
+
+Change the settings of the app by changing the values in .env
+
+## YunoHost specific features
+
+#### Multi-user support
+
+**First User Registration:** Visit the app **domain** after the installation is complete to register as **first user**. After the first user is registered the registration will be **locked**. You can open the register for all by changing the value **APP_DISABLE_SIGNUP** to **false** in **.env**. There is **no admin interface** in the Monica app currently.
+
+#### Supported architectures
+
+* x86-64 - [![Build Status](https://ci-apps.yunohost.org/ci/logs/monica%20%28Apps%29.svg)](https://ci-apps.yunohost.org/ci/apps/monica/)
+* ARMv8-A - [![Build Status](https://ci-apps-arm.yunohost.org/ci/logs/monica%20%28Apps%29.svg)](https://ci-apps-arm.yunohost.org/ci/apps/monica/)
+
+## Links
+
+ * Report a bug: https://github.com/YunoHost-Apps/monica_ynh/issues
+ * App website: https://monicahq.com/
+ * Upstream app repository: https://github.com/monicahq/monica
+ * YunoHost website: https://yunohost.org/
## Introduction
-Monica is an open-source web application to organize the interactions with your loved ones. I call it a PRM, or Personal Relationship Management. Think of it as a [CRM](https://en.wikipedia.org/wiki/Customer_relationship_management) (a popular tool used by sales teams in the corporate world) for your friends or family.
-
-## Install
-##### This app will install PHP7.2
-```
- sudo yunohost app install https://github.com/YunoHost-Apps/monica_ynh
-```
-**First User Registration:** Visit the app **domain** after the installation is complete to register as **first user**. After the first user is registered the registration will be **locked**. You can open the register for all by changing the value **APP_DISABLE_SIGNUP** to **false** in **.env**. There is **no admin interface** in the Monica app currently.
-
-## Update
-```
- sudo yunohost app upgrade -u https://github.com/YunoHost-Apps/monica_ynh monica
-```
-#### Change the settings of the app by changing the values in .env
## What works?
* [X] Update and remove script
@@ -40,6 +50,16 @@ Monica is an open-source web application to organize the interactions with your
* [ ] LDAP/SSO support
* [x] Make monica installable into subdirectory (eg. https://example.com/monica/)
-## License
+---
-GPL-3.0
+Developer info
+----------------
+
+Please send your pull request to the [testing branch](https://github.com/YunoHost-Apps/monica_ynh/tree/testing).
+
+To try the testing branch, please proceed like that.
+```
+sudo yunohost app install https://github.com/YunoHost-Apps/monica_ynh/tree/testing --debug
+or
+sudo yunohost app upgrade monica -u https://github.com/YunoHost-Apps/monica_ynh/tree/testing --debug
+```
diff --git a/check_process b/check_process
index 16ebc64..65cd5f9 100644
--- a/check_process
+++ b/check_process
@@ -3,7 +3,7 @@
# Move this file from check_process.default to check_process when you have filled it.
-;; Test complete
+;; Test complet
; Manifest
domain="domain.tld" (DOMAIN)
path="/" (PATH)
diff --git a/conf/nginx.conf b/conf/nginx.conf
index 9babf5e..afc297b 100644
--- a/conf/nginx.conf
+++ b/conf/nginx.conf
@@ -8,7 +8,8 @@ location ^~ __PATH__ {
}
location ~ \.php {
fastcgi_split_path_info ^(.+?\.php)(/.*)$;
- fastcgi_pass unix:/var/run/php/php7.2-fpm-__NAME__.sock;
+ fastcgi_pass unix:/var/run/php/php__PHPVERSION__-fpm-__NAME__.sock;
+
fastcgi_index index.php;
include fastcgi_params;
fastcgi_param REMOTE_USER $remote_user;
diff --git a/conf/php-fpm.conf b/conf/php-fpm.conf
deleted file mode 100644
index 49f1a37..0000000
--- a/conf/php-fpm.conf
+++ /dev/null
@@ -1,430 +0,0 @@
-; Start a new pool named 'www'.
-; the variable $pool can be used in any directive and will be replaced by the
-; pool name ('www' here)
-[__NAMETOCHANGE__]
-
-; Per pool prefix
-; It only applies on the following directives:
-; - 'access.log'
-; - 'slowlog'
-; - 'listen' (unixsocket)
-; - 'chroot'
-; - 'chdir'
-; - 'php_values'
-; - 'php_admin_values'
-; When not set, the global prefix (or /usr) applies instead.
-; Note: This directive can also be relative to the global prefix.
-; Default Value: none
-;prefix = /path/to/pools/$pool
-
-; Unix user/group of processes
-; Note: The user is mandatory. If the group is not set, the default user's group
-; will be used.
-user = __USER__
-group = __USER__
-
-; The address on which to accept FastCGI requests.
-; Valid syntaxes are:
-; 'ip.add.re.ss:port' - to listen on a TCP socket to a specific IPv4 address on
-; a specific port;
-; '[ip:6:addr:ess]:port' - to listen on a TCP socket to a specific IPv6 address on
-; a specific port;
-; 'port' - to listen on a TCP socket to all addresses
-; (IPv6 and IPv4-mapped) on a specific port;
-; '/path/to/unix/socket' - to listen on a unix socket.
-; Note: This value is mandatory.
-listen = /var/run/php/php7.2-fpm-__NAMETOCHANGE__.sock
-
-; Set listen(2) backlog.
-; Default Value: 511 (-1 on FreeBSD and OpenBSD)
-;listen.backlog = 511
-
-; Set permissions for unix socket, if one is used. In Linux, read/write
-; permissions must be set in order to allow connections from a web server. Many
-; BSD-derived systems allow connections regardless of permissions.
-; Default Values: user and group are set as the running user
-; mode is set to 0660
-listen.owner = www-data
-listen.group = www-data
-;listen.mode = 0660
-; When POSIX Access Control Lists are supported you can set them using
-; these options, value is a comma separated list of user/group names.
-; When set, listen.owner and listen.group are ignored
-;listen.acl_users =
-;listen.acl_groups =
-
-; List of addresses (IPv4/IPv6) of FastCGI clients which are allowed to connect.
-; Equivalent to the FCGI_WEB_SERVER_ADDRS environment variable in the original
-; PHP FCGI (5.2.2+). Makes sense only with a tcp listening socket. Each address
-; must be separated by a comma. If this value is left blank, connections will be
-; accepted from any ip address.
-; Default Value: any
-;listen.allowed_clients = 127.0.0.1
-
-; Specify the nice(2) priority to apply to the pool processes (only if set)
-; The value can vary from -19 (highest priority) to 20 (lower priority)
-; Note: - It will only work if the FPM master process is launched as root
-; - The pool processes will inherit the master process priority
-; unless it specified otherwise
-; Default Value: no set
-; process.priority = -19
-
-; Set the process dumpable flag (PR_SET_DUMPABLE prctl) even if the process user
-; or group is differrent than the master process user. It allows to create process
-; core dump and ptrace the process for the pool user.
-; Default Value: no
-; process.dumpable = yes
-
-; Choose how the process manager will control the number of child processes.
-; Possible Values:
-; static - a fixed number (pm.max_children) of child processes;
-; dynamic - the number of child processes are set dynamically based on the
-; following directives. With this process management, there will be
-; always at least 1 children.
-; pm.max_children - the maximum number of children that can
-; be alive at the same time.
-; pm.start_servers - the number of children created on startup.
-; pm.min_spare_servers - the minimum number of children in 'idle'
-; state (waiting to process). If the number
-; of 'idle' processes is less than this
-; number then some children will be created.
-; pm.max_spare_servers - the maximum number of children in 'idle'
-; state (waiting to process). If the number
-; of 'idle' processes is greater than this
-; number then some children will be killed.
-; ondemand - no children are created at startup. Children will be forked when
-; new requests will connect. The following parameter are used:
-; pm.max_children - the maximum number of children that
-; can be alive at the same time.
-; pm.process_idle_timeout - The number of seconds after which
-; an idle process will be killed.
-; Note: This value is mandatory.
-pm = dynamic
-
-; The number of child processes to be created when pm is set to 'static' and the
-; maximum number of child processes when pm is set to 'dynamic' or 'ondemand'.
-; This value sets the limit on the number of simultaneous requests that will be
-; served. Equivalent to the ApacheMaxClients directive with mpm_prefork.
-; Equivalent to the PHP_FCGI_CHILDREN environment variable in the original PHP
-; CGI. The below defaults are based on a server without much resources. Don't
-; forget to tweak pm.* to fit your needs.
-; Note: Used when pm is set to 'static', 'dynamic' or 'ondemand'
-; Note: This value is mandatory.
-pm.max_children = 5
-
-; The number of child processes created on startup.
-; Note: Used only when pm is set to 'dynamic'
-; Default Value: min_spare_servers + (max_spare_servers - min_spare_servers) / 2
-pm.start_servers = 2
-
-; The desired minimum number of idle server processes.
-; Note: Used only when pm is set to 'dynamic'
-; Note: Mandatory when pm is set to 'dynamic'
-pm.min_spare_servers = 1
-
-; The desired maximum number of idle server processes.
-; Note: Used only when pm is set to 'dynamic'
-; Note: Mandatory when pm is set to 'dynamic'
-pm.max_spare_servers = 3
-
-; The number of seconds after which an idle process will be killed.
-; Note: Used only when pm is set to 'ondemand'
-; Default Value: 10s
-;pm.process_idle_timeout = 10s;
-
-; The number of requests each child process should execute before respawning.
-; This can be useful to work around memory leaks in 3rd party libraries. For
-; endless request processing specify '0'. Equivalent to PHP_FCGI_MAX_REQUESTS.
-; Default Value: 0
-;pm.max_requests = 500
-
-; The URI to view the FPM status page. If this value is not set, no URI will be
-; recognized as a status page. It shows the following informations:
-; pool - the name of the pool;
-; process manager - static, dynamic or ondemand;
-; start time - the date and time FPM has started;
-; start since - number of seconds since FPM has started;
-; accepted conn - the number of request accepted by the pool;
-; listen queue - the number of request in the queue of pending
-; connections (see backlog in listen(2));
-; max listen queue - the maximum number of requests in the queue
-; of pending connections since FPM has started;
-; listen queue len - the size of the socket queue of pending connections;
-; idle processes - the number of idle processes;
-; active processes - the number of active processes;
-; total processes - the number of idle + active processes;
-; max active processes - the maximum number of active processes since FPM
-; has started;
-; max children reached - number of times, the process limit has been reached,
-; when pm tries to start more children (works only for
-; pm 'dynamic' and 'ondemand');
-; Value are updated in real time.
-; Example output:
-; pool: www
-; process manager: static
-; start time: 01/Jul/2011:17:53:49 +0200
-; start since: 62636
-; accepted conn: 190460
-; listen queue: 0
-; max listen queue: 1
-; listen queue len: 42
-; idle processes: 4
-; active processes: 11
-; total processes: 15
-; max active processes: 12
-; max children reached: 0
-;
-; By default the status page output is formatted as text/plain. Passing either
-; 'html', 'xml' or 'json' in the query string will return the corresponding
-; output syntax. Example:
-; http://www.foo.bar/status
-; http://www.foo.bar/status?json
-; http://www.foo.bar/status?html
-; http://www.foo.bar/status?xml
-;
-; By default the status page only outputs short status. Passing 'full' in the
-; query string will also return status for each pool process.
-; Example:
-; http://www.foo.bar/status?full
-; http://www.foo.bar/status?json&full
-; http://www.foo.bar/status?html&full
-; http://www.foo.bar/status?xml&full
-; The Full status returns for each process:
-; pid - the PID of the process;
-; state - the state of the process (Idle, Running, ...);
-; start time - the date and time the process has started;
-; start since - the number of seconds since the process has started;
-; requests - the number of requests the process has served;
-; request duration - the duration in µs of the requests;
-; request method - the request method (GET, POST, ...);
-; request URI - the request URI with the query string;
-; content length - the content length of the request (only with POST);
-; user - the user (PHP_AUTH_USER) (or '-' if not set);
-; script - the main script called (or '-' if not set);
-; last request cpu - the %cpu the last request consumed
-; it's always 0 if the process is not in Idle state
-; because CPU calculation is done when the request
-; processing has terminated;
-; last request memory - the max amount of memory the last request consumed
-; it's always 0 if the process is not in Idle state
-; because memory calculation is done when the request
-; processing has terminated;
-; If the process is in Idle state, then informations are related to the
-; last request the process has served. Otherwise informations are related to
-; the current request being served.
-; Example output:
-; ************************
-; pid: 31330
-; state: Running
-; start time: 01/Jul/2011:17:53:49 +0200
-; start since: 63087
-; requests: 12808
-; request duration: 1250261
-; request method: GET
-; request URI: /test_mem.php?N=10000
-; content length: 0
-; user: -
-; script: /home/fat/web/docs/php/test_mem.php
-; last request cpu: 0.00
-; last request memory: 0
-;
-; Note: There is a real-time FPM status monitoring sample web page available
-; It's available in: /usr/share/php/7.0/fpm/status.html
-;
-; Note: The value must start with a leading slash (/). The value can be
-; anything, but it may not be a good idea to use the .php extension or it
-; may conflict with a real PHP file.
-; Default Value: not set
-;pm.status_path = /status
-
-; The ping URI to call the monitoring page of FPM. If this value is not set, no
-; URI will be recognized as a ping page. This could be used to test from outside
-; that FPM is alive and responding, or to
-; - create a graph of FPM availability (rrd or such);
-; - remove a server from a group if it is not responding (load balancing);
-; - trigger alerts for the operating team (24/7).
-; Note: The value must start with a leading slash (/). The value can be
-; anything, but it may not be a good idea to use the .php extension or it
-; may conflict with a real PHP file.
-; Default Value: not set
-;ping.path = /ping
-
-; This directive may be used to customize the response of a ping request. The
-; response is formatted as text/plain with a 200 response code.
-; Default Value: pong
-;ping.response = pong
-
-; The access log file
-; Default: not set
-;access.log = log/$pool.access.log
-
-; The access log format.
-; The following syntax is allowed
-; %%: the '%' character
-; %C: %CPU used by the request
-; it can accept the following format:
-; - %{user}C for user CPU only
-; - %{system}C for system CPU only
-; - %{total}C for user + system CPU (default)
-; %d: time taken to serve the request
-; it can accept the following format:
-; - %{seconds}d (default)
-; - %{miliseconds}d
-; - %{mili}d
-; - %{microseconds}d
-; - %{micro}d
-; %e: an environment variable (same as $_ENV or $_SERVER)
-; it must be associated with embraces to specify the name of the env
-; variable. Some exemples:
-; - server specifics like: %{REQUEST_METHOD}e or %{SERVER_PROTOCOL}e
-; - HTTP headers like: %{HTTP_HOST}e or %{HTTP_USER_AGENT}e
-; %f: script filename
-; %l: content-length of the request (for POST request only)
-; %m: request method
-; %M: peak of memory allocated by PHP
-; it can accept the following format:
-; - %{bytes}M (default)
-; - %{kilobytes}M
-; - %{kilo}M
-; - %{megabytes}M
-; - %{mega}M
-; %n: pool name
-; %o: output header
-; it must be associated with embraces to specify the name of the header:
-; - %{Content-Type}o
-; - %{X-Powered-By}o
-; - %{Transfert-Encoding}o
-; - ....
-; %p: PID of the child that serviced the request
-; %P: PID of the parent of the child that serviced the request
-; %q: the query string
-; %Q: the '?' character if query string exists
-; %r: the request URI (without the query string, see %q and %Q)
-; %R: remote IP address
-; %s: status (response code)
-; %t: server time the request was received
-; it can accept a strftime(3) format:
-; %d/%b/%Y:%H:%M:%S %z (default)
-; The strftime(3) format must be encapsuled in a %{}t tag
-; e.g. for a ISO8601 formatted timestring, use: %{%Y-%m-%dT%H:%M:%S%z}t
-; %T: time the log has been written (the request has finished)
-; it can accept a strftime(3) format:
-; %d/%b/%Y:%H:%M:%S %z (default)
-; The strftime(3) format must be encapsuled in a %{}t tag
-; e.g. for a ISO8601 formatted timestring, use: %{%Y-%m-%dT%H:%M:%S%z}t
-; %u: remote user
-;
-; Default: "%R - %u %t \"%m %r\" %s"
-;access.format = "%R - %u %t \"%m %r%Q%q\" %s %f %{mili}d %{kilo}M %C%%"
-
-; The log file for slow requests
-; Default Value: not set
-; Note: slowlog is mandatory if request_slowlog_timeout is set
-;slowlog = log/$pool.log.slow
-
-; The timeout for serving a single request after which a PHP backtrace will be
-; dumped to the 'slowlog' file. A value of '0s' means 'off'.
-; Available units: s(econds)(default), m(inutes), h(ours), or d(ays)
-; Default Value: 0
-;request_slowlog_timeout = 0
-
-; The timeout for serving a single request after which the worker process will
-; be killed. This option should be used when the 'max_execution_time' ini option
-; does not stop script execution for some reason. A value of '0' means 'off'.
-; Available units: s(econds)(default), m(inutes), h(ours), or d(ays)
-; Default Value: 0
-request_terminate_timeout = 1d
-
-; Set open file descriptor rlimit.
-; Default Value: system defined value
-;rlimit_files = 1024
-
-; Set max core size rlimit.
-; Possible Values: 'unlimited' or an integer greater or equal to 0
-; Default Value: system defined value
-;rlimit_core = 0
-
-; Chroot to this directory at the start. This value must be defined as an
-; absolute path. When this value is not set, chroot is not used.
-; Note: you can prefix with '$prefix' to chroot to the pool prefix or one
-; of its subdirectories. If the pool prefix is not set, the global prefix
-; will be used instead.
-; Note: chrooting is a great security feature and should be used whenever
-; possible. However, all PHP paths will be relative to the chroot
-; (error_log, sessions.save_path, ...).
-; Default Value: not set
-;chroot =
-
-; Chdir to this directory at the start.
-; Note: relative path can be used.
-; Default Value: current directory or / when chroot
-chdir = __FINALPATH__
-
-; Redirect worker stdout and stderr into main error log. If not set, stdout and
-; stderr will be redirected to /dev/null according to FastCGI specs.
-; Note: on highloaded environement, this can cause some delay in the page
-; process time (several ms).
-; Default Value: no
-;catch_workers_output = yes
-
-; Clear environment in FPM workers
-; Prevents arbitrary environment variables from reaching FPM worker processes
-; by clearing the environment in workers before env vars specified in this
-; pool configuration are added.
-; Setting to "no" will make all environment variables available to PHP code
-; via getenv(), $_ENV and $_SERVER.
-; Default Value: yes
-;clear_env = no
-
-; Limits the extensions of the main script FPM will allow to parse. This can
-; prevent configuration mistakes on the web server side. You should only limit
-; FPM to .php extensions to prevent malicious users to use other extensions to
-; execute php code.
-; Note: set an empty value to allow all extensions.
-; Default Value: .php
-;security.limit_extensions = .php .php3 .php4 .php5 .php7
-
-; Pass environment variables like LD_LIBRARY_PATH. All $VARIABLEs are taken from
-; the current environment.
-; Default Value: clean env
-;env[HOSTNAME] = $HOSTNAME
-;env[PATH] = /usr/local/bin:/usr/bin:/bin
-;env[TMP] = /tmp
-;env[TMPDIR] = /tmp
-;env[TEMP] = /tmp
-
-; Additional php.ini defines, specific to this pool of workers. These settings
-; overwrite the values previously defined in the php.ini. The directives are the
-; same as the PHP SAPI:
-; php_value/php_flag - you can set classic ini defines which can
-; be overwritten from PHP call 'ini_set'.
-; php_admin_value/php_admin_flag - these directives won't be overwritten by
-; PHP call 'ini_set'
-; For php_*flag, valid values are on, off, 1, 0, true, false, yes or no.
-
-; Defining 'extension' will load the corresponding shared extension from
-; extension_dir. Defining 'disable_functions' or 'disable_classes' will not
-; overwrite previously defined php.ini values, but will append the new value
-; instead.
-
-; Note: path INI options can be relative and will be expanded with the prefix
-; (pool, global or /usr)
-
-; Default Value: nothing is defined by default except the values in php.ini and
-; specified at startup with the -d argument
-;php_admin_value[sendmail_path] = /usr/sbin/sendmail -t -i -f www@my.domain.com
-;php_flag[display_errors] = off
-;php_admin_value[error_log] = /var/log/fpm-php.www.log
-;php_admin_flag[log_errors] = on
-;php_admin_value[memory_limit] = 32M
-
-; Common values to change to increase file upload limit
-; php_admin_value[upload_max_filesize] = 50M
-; php_admin_value[post_max_size] = 50M
-; php_admin_flag[mail.add_x_header] = Off
-
-; Other common parameters
-; php_admin_value[max_execution_time] = 600
-; php_admin_value[max_input_time] = 300
-; php_admin_value[memory_limit] = 256M
-; php_admin_flag[short_open_tag] = On
diff --git a/issue_template.md b/issue_template.md
new file mode 100644
index 0000000..7b47b30
--- /dev/null
+++ b/issue_template.md
@@ -0,0 +1,46 @@
+---
+name: Bug report
+about: Create a report to help us debug, it would be nice to fill the template as much as you can to help us, help you and help us all.
+
+---
+
+**How to post a meaningful bug report**
+1. *Read this whole template first.*
+2. *Determine if you are on the right place:*
+ - *If you were performing an action on the app from the webadmin or the CLI (install, update, backup, restore, change url...), you are on the right place!*
+ - *Otherwise, the issue may be due to Monica itself. Refer to its documentation or repository for help.*
+ - *If you have a doubt, post here, we will figure it out together.*
+3. *Delete the italic comments as you write over them below, and remove this guide.*
+---
+
+**Describe the bug**
+*A clear and concise description of what the bug is.*
+
+**Versions**
+- Hardware: *VPS bought online / Old laptop or computer / Raspberry Pi at home / Internet Cube with VPN / Other ARM board / ...*
+- YunoHost version: x.x.x
+- I have access to my server: *Through SSH | through the webadmin | direct access via keyboard / screen | ...*
+- Are you in a special context or did you perform some particular tweaking on your YunoHost instance ?: *no / yes*
+ - If yes, please explain:
+- Using, or trying to install package version/branch:
+- If upgrading, current package version: *can be found in the admin, or with `yunohost app info $app_id`*
+
+**To Reproduce**
+*Steps to reproduce the behavior.*
+- *If you performed a command from the CLI, the command itself is enough. For example:*
+ ```sh
+ sudo yunohost app install monica
+ ```
+- *If you used the webadmin, please perform the equivalent command from the CLI first.*
+- *If the error occurs in your browser, explain what you did:*
+ 1. *Go to '...'*
+ 2. *Click on '....'*
+ 3. *Scroll down to '....'*
+ 4. *See error*
+
+**Expected behavior**
+*A clear and concise description of what you expected to happen. You can remove this section if the command above is enough to understand your intent.*
+
+**Logs**
+*After a failed command, YunoHost makes the log available to you, but also to others, thanks to `yunohost log display [log name] --share`. The actual command, with the correct log name, is displayed at the end of the failed attempt in the CLI. Execute it and copy here the share link it outputs.*
+*If applicable and useful, add screenshots to help explain your problem.*
diff --git a/manifest.json b/manifest.json
index b966a66..fc8ebe1 100644
--- a/manifest.json
+++ b/manifest.json
@@ -5,9 +5,9 @@
"description": {
"en": " Personal Relationship Manager - a new kind of CRM to organize interactions with your friends and family."
},
+ "version": "2.17.0~ynh1",
"url": "https://monicahq.com",
"license": "GPL-3.0",
- "version": "2.17.0~ynh1",
"maintainer": {
"name": "Sebastian Gumprich",
"email": "yunohost@gumpri.ch",
@@ -19,6 +19,7 @@
"multi_instance": true,
"services": [
"nginx",
+ "php7.0-fpm",
"mysql"
],
"arguments": {
diff --git a/pull_request_template.md b/pull_request_template.md
new file mode 100644
index 0000000..cfb87c4
--- /dev/null
+++ b/pull_request_template.md
@@ -0,0 +1,18 @@
+## Problem
+- *Description of why you made this PR*
+
+## Solution
+- *And how do you fix that problem*
+
+## PR Status
+- [ ] Code finished.
+- [ ] Tested with Package_check.
+- [ ] Fix or enhancement tested.
+- [ ] Upgrade from last version tested.
+- [ ] Can be reviewed and tested.
+
+## Package_check results
+---
+*If you have access to [App Continuous Integration for packagers](https://yunohost.org/#/packaging_apps_ci) you can provide a link to the package_check results like below, replacing '-NUM-' in this link by the PR number and USERNAME by your username on the ci-apps-dev. Or you provide a screenshot or a pastebin of the results*
+
+[![Build Status](https://ci-apps-dev.yunohost.org/jenkins/job/monica_ynh%20PR-NUM-%20(USERNAME)/badge/icon)](https://ci-apps-dev.yunohost.org/jenkins/job/monica_ynh%20PR-NUM-%20(USERNAME)/)
diff --git a/scripts/_common.sh b/scripts/_common.sh
index b5da2d8..a7a0585 100644
--- a/scripts/_common.sh
+++ b/scripts/_common.sh
@@ -1,431 +1,24 @@
#!/bin/bash
-readonly YNH_DEFAULT_PHP_VERSION=7.0
-# Declare the actual php version to use.
-# A packager willing to use another version of php can override the variable into its _common.sh.
-YNH_PHP_VERSION=${YNH_PHP_VERSION:-$YNH_DEFAULT_PHP_VERSION}
+#=================================================
+# COMMON VARIABLES
+#=================================================
+# dependencies used by the app
+pkg_dependencies=""
-pkg_dependencies="php7.2-cli php7.2-json php7.2-opcache php7.2-mysql php7.2-mbstring php7.2-zip php7.2-bcmath php7.2-intl php7.2-xml php7.2-curl php7.2-gd php7.2-gmp"
+YNH_PHP_VERSION="7.3"
+extra_php_dependencies="php${YNH_PHP_VERSION}-cli php${YNH_PHP_VERSION}-json php${YNH_PHP_VERSION}-opcache php${YNH_PHP_VERSION}-mysql php${YNH_PHP_VERSION}-mbstring php${YNH_PHP_VERSION}-zip php${YNH_PHP_VERSION}-bcmath php${YNH_PHP_VERSION}-intl php${YNH_PHP_VERSION}-xml php${YNH_PHP_VERSION}-curl php${YNH_PHP_VERSION}-gd php${YNH_PHP_VERSION}-gmp"
-# Execute a command with Composer
-#
-# usage: ynh_composer_exec --phpversion=phpversion [--workdir=$final_path] --commands="commands"
-# | arg: -w, --workdir - The directory from where the command will be executed. Default $final_path.
-# | arg: -c, --commands - Commands to execute.
-ynh_composer_exec () {
- # Declare an array to define the options of this helper.
- local legacy_args=vwc
- declare -Ar args_array=( [v]=phpversion= [w]=workdir= [c]=commands= )
- local phpversion
- local workdir
- local commands
- # Manage arguments with getopts
- ynh_handle_getopts_args "$@"
- workdir="${workdir:-$final_path}"
- phpversion="${phpversion:-7.0}"
+#=================================================
+# PERSONAL HELPERS
+#=================================================
- COMPOSER_HOME="$workdir/.composer" \
- php${phpversion} "$workdir/composer.phar" $commands \
- -d "$workdir" --quiet --no-interaction
-}
-
-# Install and initialize Composer in the given directory
-#
-# usage: ynh_install_composer --phpversion=phpversion [--workdir=$final_path]
-# | arg: -w, --workdir - The directory from where the command will be executed. Default $final_path.
-ynh_install_composer () {
- # Declare an array to define the options of this helper.
- local legacy_args=vw
- declare -Ar args_array=( [v]=phpversion= [w]=workdir= )
- local phpversion
- local workdir
- # Manage arguments with getopts
- ynh_handle_getopts_args "$@"
- workdir="${workdir:-$final_path}"
- phpversion="${phpversion:-7.0}"
-
- curl -sS https://getcomposer.org/installer \
- | COMPOSER_HOME="$workdir/.composer" \
- php${phpversion} -- --quiet --install-dir="$workdir" \
- || ynh_die "Unable to install Composer."
-
- # update dependencies to create composer.lock
- ynh_composer_exec --phpversion="${phpversion}" --workdir="$workdir" --commands="install --no-dev" \
- || ynh_die "Unable to update core dependencies with Composer."
-}
-
-
-# Install another version of php.
-#
-# usage: ynh_install_php --phpversion=phpversion [--package=packages]
-# | arg: -v, --phpversion - Version of php to install. Can be one of 7.1, 7.2 or 7.3
-# | arg: -p, --package - Additionnal php packages to install
-ynh_install_php () {
- # Declare an array to define the options of this helper.
- local legacy_args=vp
- declare -Ar args_array=( [v]=phpversion= [p]=package= )
- local phpversion
- local package
- # Manage arguments with getopts
- ynh_handle_getopts_args "$@"
- package=${package:-}
-
- # Store php_version into the config of this app
- ynh_app_setting_set $app php_version $phpversion
-
- if [ "$phpversion" == "7.0" ]
- then
- ynh_die --message="Do not use ynh_install_php to install php7.0"
- fi
-
- # Store the ID of this app and the version of php requested for it
- echo "$YNH_APP_INSTANCE_NAME:$phpversion" | tee --append "/etc/php/ynh_app_version"
-
- # Add an extra repository for those packages
- ynh_install_extra_repo --repo="https://packages.sury.org/php/ $(lsb_release -sc) main" --key="https://packages.sury.org/php/apt.gpg" --priority=995 --name=extra_php_version
-
- # Install requested dependencies from this extra repository.
- # Install php-fpm first, otherwise php will install apache as a dependency.
- ynh_add_app_dependencies --package="php${phpversion}-fpm"
- ynh_add_app_dependencies --package="php$phpversion php${phpversion}-common $package"
-
- # Set php7.0 back as the default version for php-cli.
- update-alternatives --set php /usr/bin/php7.0
-
- # Pin this extra repository after packages are installed to prevent sury of doing shit
- ynh_pin_repo --package="*" --pin="origin \"packages.sury.org\"" 200 --name=extra_php_version
- ynh_pin_repo --package="php7.0*" --pin="origin \"packages.sury.org\"" 600 --name=extra_php_version --append
-
- # INTEGRATE SERVICE IN YUNOHOST
- yunohost service add php${phpversion}-fpm --log "/var/log/php${phpversion}-fpm.log"
-}
-
-ynh_remove_php () {
- # Get the version of php used by this app
- local phpversion=$(ynh_app_setting_get $app php_version)
-
- if [ "$phpversion" == "7.0" ] || [ -z "$phpversion" ]
- then
- if [ "$phpversion" == "7.0" ]
- then
- ynh_print_err "Do not use ynh_remove_php to install php7.0"
- fi
- return 0
- fi
-
- # Remove the line for this app
- sed --in-place "/$YNH_APP_INSTANCE_NAME:$phpversion/d" "/etc/php/ynh_app_version"
-
- # If no other app uses this version of php, remove it.
- if ! grep --quiet "$phpversion" "/etc/php/ynh_app_version"
- then
- # Purge php dependences for this version.
- ynh_package_autopurge "php$phpversion php${phpversion}-fpm php${phpversion}-common"
- # Remove the service from the admin panel
- yunohost service remove php${phpversion}-fpm
- fi
-
- # If no other app uses alternate php versions, remove the extra repo for php
- if [ ! -s "/etc/php/ynh_app_version" ]
- then
- ynh_secure_remove /etc/php/ynh_app_version
- fi
-}
+#=================================================
+# EXPERIMENTAL HELPERS
+#=================================================
#=================================================
# FUTURE OFFICIAL HELPERS
#=================================================
-# Pin a repository.
-#
-# usage: ynh_pin_repo --package=packages --pin=pin_filter [--priority=priority_value] [--name=name] [--append]
-# | arg: -p, --package - Packages concerned by the pin. Or all, *.
-# | arg: -i, --pin - Filter for the pin.
-# | arg: -p, --priority - Priority for the pin
-# | arg: -n, --name - Name for the files for this repo, $app as default value.
-# | arg: -a, --append - Do not overwrite existing files.
-#
-# See https://manpages.debian.org/stretch/apt/apt_preferences.5.en.html for information about pinning.
-#
-ynh_pin_repo () {
- # Declare an array to define the options of this helper.
- local legacy_args=pirna
- declare -Ar args_array=( [p]=package= [i]=pin= [r]=priority= [n]=name= [a]=append )
- local package
- local pin
- local priority
- local name
- local append
- # Manage arguments with getopts
- ynh_handle_getopts_args "$@"
- package="${package:-*}"
- priority=${priority:-50}
- name="${name:-$app}"
- append=${append:-0}
-
- if [ $append -eq 1 ]
- then
- append="tee -a"
- else
- append="tee"
- fi
-
- mkdir -p "/etc/apt/preferences.d"
- echo "Package: $package
-Pin: $pin
-Pin-Priority: $priority" \
- | $append "/etc/apt/preferences.d/$name"
-}
-
-# Add a repository.
-#
-# usage: ynh_add_repo --uri=uri --suite=suite --component=component [--name=name] [--append]
-# | arg: -u, --uri - Uri of the repository.
-# | arg: -s, --suite - Suite of the repository.
-# | arg: -c, --component - Component of the repository.
-# | arg: -n, --name - Name for the files for this repo, $app as default value.
-# | arg: -a, --append - Do not overwrite existing files.
-#
-# Example for a repo like deb http://forge.yunohost.org/debian/ stretch stable
-# uri suite component
-# ynh_add_repo --uri=http://forge.yunohost.org/debian/ --suite=stretch --component=stable
-#
-ynh_add_repo () {
- # Declare an array to define the options of this helper.
- local legacy_args=uscna
- declare -Ar args_array=( [u]=uri= [s]=suite= [c]=component= [n]=name= [a]=append )
- local uri
- local suite
- local component
- local name
- local append
- # Manage arguments with getopts
- ynh_handle_getopts_args "$@"
- name="${name:-$app}"
- append=${append:-0}
-
- if [ $append -eq 1 ]
- then
- append="tee -a"
- else
- append="tee"
- fi
-
- mkdir -p "/etc/apt/sources.list.d"
- # Add the new repo in sources.list.d
- echo "deb $uri $suite $component" \
- | $append "/etc/apt/sources.list.d/$name.list"
-}
-
-# Add an extra repository correctly, pin it and get the key.
-#
-# usage: ynh_install_extra_repo --repo="repo" [--key=key_url] [--priority=priority_value] [--name=name] [--append]
-# | arg: -r, --repo - Complete url of the extra repository.
-# | arg: -k, --key - url to get the public key.
-# | arg: -p, --priority - Priority for the pin
-# | arg: -n, --name - Name for the files for this repo, $app as default value.
-# | arg: -a, --append - Do not overwrite existing files.
-ynh_install_extra_repo () {
- # Declare an array to define the options of this helper.
- local legacy_args=rkpna
- declare -Ar args_array=( [r]=repo= [k]=key= [p]=priority= [n]=name= [a]=append )
- local repo
- local key
- local priority
- local name
- local append
- # Manage arguments with getopts
- ynh_handle_getopts_args "$@"
- name="${name:-$app}"
- append=${append:-0}
- key=${key:-0}
- priority=${priority:-}
-
- if [ $append -eq 1 ]
- then
- append="--append"
- wget_append="tee -a"
- else
- append=""
- wget_append="tee"
- fi
-
- # Split the repository into uri, suite and components.
- # Remove "deb " at the beginning of the repo.
- repo="${repo#deb }"
-
- # Get the uri
- local uri="$(echo "$repo" | awk '{ print $1 }')"
-
- # Get the suite
- local suite="$(echo "$repo" | awk '{ print $2 }')"
-
- # Get the components
- local component="${repo##$uri $suite }"
-
- # Add the repository into sources.list.d
- ynh_add_repo --uri="$uri" --suite="$suite" --component="$component" --name="$name" $append
-
- # Pin the new repo with the default priority, so it won't be used for upgrades.
- # Build $pin from the uri without http and any sub path
- local pin="${uri#*://}"
- pin="${pin%%/*}"
- # Set a priority only if asked
- if [ -n "$priority" ]
- then
- priority="--priority=$priority"
- fi
- ynh_pin_repo --package="*" --pin="origin \"$pin\"" $priority --name="$name" $append
-
- # Get the public key for the repo
- if [ -n "$key" ]
- then
- mkdir -p "/etc/apt/trusted.gpg.d"
- wget -q "$key" -O - | gpg --dearmor | $wget_append /etc/apt/trusted.gpg.d/$name.gpg > /dev/null
- fi
-
- # Update the list of package with the new repo
- ynh_package_update
-}
-
-# Remove an extra repository and the assiociated configuration.
-#
-# usage: ynh_remove_extra_repo [--name=name]
-# | arg: -n, --name - Name for the files for this repo, $app as default value.
-ynh_remove_extra_repo () {
- # Declare an array to define the options of this helper.
- local legacy_args=n
- declare -Ar args_array=( [n]=name= )
- local name
- # Manage arguments with getopts
- ynh_handle_getopts_args "$@"
- name="${name:-$app}"
-
- ynh_secure_remove "/etc/apt/sources.list.d/$name.list"
- ynh_secure_remove "/etc/apt/preferences.d/$name"
- ynh_secure_remove "/etc/apt/trusted.gpg.d/$name.gpg"
- ynh_secure_remove "/etc/apt/trusted.gpg.d/$name.asc"
-
- # Update the list of package to exclude the old repo
- ynh_package_update
-}
-
-# Install packages from an extra repository properly.
-#
-# usage: ynh_install_extra_app_dependencies --repo="repo" --package="dep1 dep2" [--key=key_url] [--name=name]
-# | arg: -r, --repo - Complete url of the extra repository.
-# | arg: -p, --package - The packages to install from this extra repository
-# | arg: -k, --key - url to get the public key.
-# | arg: -n, --name - Name for the files for this repo, $app as default value.
-ynh_install_extra_app_dependencies () {
- # Declare an array to define the options of this helper.
- local legacy_args=rpkn
- declare -Ar args_array=( [r]=repo= [p]=package= [k]=key= [n]=name= )
- local repo
- local package
- local key
- local name
- # Manage arguments with getopts
- ynh_handle_getopts_args "$@"
- name="${name:-$app}"
- key=${key:-0}
-
- # Set a key only if asked
- if [ -n "$key" ]
- then
- key="--key=$key"
- fi
- # Add an extra repository for those packages
- ynh_install_extra_repo --repo="$repo" $key --priority=995 --name=$name
-
- # Install requested dependencies from this extra repository.
- ynh_add_app_dependencies --package="$package"
-
- # Remove this extra repository after packages are installed
- ynh_remove_extra_repo --name=$app
-}
-
-#=================================================
-
-# patched version of ynh_install_app_dependencies to be used with ynh_add_app_dependencies
-
-# Define and install dependencies with a equivs control file
-# This helper can/should only be called once per app
-#
-# usage: ynh_install_app_dependencies dep [dep [...]]
-# | arg: dep - the package name to install in dependence
-# You can give a choice between some package with this syntax : "dep1|dep2"
-# Example : ynh_install_app_dependencies dep1 dep2 "dep3|dep4|dep5"
-# This mean in the dependence tree : dep1 & dep2 & (dep3 | dep4 | dep5)
-#
-# Requires YunoHost version 2.6.4 or higher.
-ynh_install_app_dependencies () {
- local dependencies=$@
- dependencies="$(echo "$dependencies" | sed 's/\([^\<=\>]\)\ \([^(]\)/\1, \2/g')"
- dependencies=${dependencies//|/ | }
- local manifest_path="../manifest.json"
- if [ ! -e "$manifest_path" ]; then
- manifest_path="../settings/manifest.json" # Into the restore script, the manifest is not at the same place
- fi
-
- local version=$(grep '\"version\": ' "$manifest_path" | cut -d '"' -f 4) # Retrieve the version number in the manifest file.
- if [ ${#version} -eq 0 ]; then
- version="1.0"
- fi
- local dep_app=${app//_/-} # Replace all '_' by '-'
-
- # Handle specific versions
- if [[ "$dependencies" =~ [\<=\>] ]]
- then
- # Replace version specifications by relationships syntax
- # https://www.debian.org/doc/debian-policy/ch-relationships.html
- # Sed clarification
- # [^(\<=\>] ignore if it begins by ( or < = >. To not apply twice.
- # [\<=\>] matches < = or >
- # \+ matches one or more occurence of the previous characters, for >= or >>.
- # [^,]\+ matches all characters except ','
- # Ex: package>=1.0 will be replaced by package (>= 1.0)
- dependencies="$(echo "$dependencies" | sed 's/\([^(\<=\>]\)\([\<=\>]\+\)\([^,]\+\)/\1 (\2 \3)/g')"
- fi
-
- cat > /tmp/${dep_app}-ynh-deps.control << EOF # Make a control file for equivs-build
-Section: misc
-Priority: optional
-Package: ${dep_app}-ynh-deps
-Version: ${version}
-Depends: ${dependencies}
-Architecture: all
-Description: Fake package for $app (YunoHost app) dependencies
- This meta-package is only responsible of installing its dependencies.
-EOF
- ynh_package_install_from_equivs /tmp/${dep_app}-ynh-deps.control \
- || ynh_die --message="Unable to install dependencies" # Install the fake package and its dependencies
- rm /tmp/${dep_app}-ynh-deps.control
- ynh_app_setting_set --app=$app --key=apt_dependencies --value="$dependencies"
-}
-
-ynh_add_app_dependencies () {
- # Declare an array to define the options of this helper.
- local legacy_args=pr
- declare -Ar args_array=( [p]=package= [r]=replace)
- local package
- local replace
- # Manage arguments with getopts
- ynh_handle_getopts_args "$@"
- replace=${replace:-0}
-
- local current_dependencies=""
- if [ $replace -eq 0 ]
- then
- local dep_app=${app//_/-} # Replace all '_' by '-'
- if ynh_package_is_installed --package="${dep_app}-ynh-deps"
- then
- current_dependencies="$(dpkg-query --show --showformat='${Depends}' ${dep_app}-ynh-deps) "
- fi
-
- current_dependencies=${current_dependencies// | /|}
- fi
-
- ynh_install_app_dependencies "${current_dependencies}${package}"
-}
diff --git a/scripts/backup b/scripts/backup
index 4331717..bff4737 100755
--- a/scripts/backup
+++ b/scripts/backup
@@ -15,7 +15,6 @@ source /usr/share/yunohost/helpers
#=================================================
ynh_clean_setup () {
- ### Remove this function if there's nothing to clean before calling the remove script.
true
}
# Exit if an error occurs during the execution of the script
@@ -24,51 +23,53 @@ ynh_abort_if_errors
#=================================================
# LOAD SETTINGS
#=================================================
-ynh_script_progression --message="Loading installation settings..."
+ynh_print_info --message="Loading installation settings..."
app=$YNH_APP_INSTANCE_NAME
final_path=$(ynh_app_setting_get --app=$app --key=final_path)
domain=$(ynh_app_setting_get --app=$app --key=domain)
db_name=$(ynh_app_setting_get --app=$app --key=db_name)
+phpversion=$(ynh_app_setting_get --app=$app --key=phpversion)
#=================================================
-# STANDARD BACKUP STEPS
+# DECLARE DATA AND CONF FILES TO BACKUP
+#=================================================
+ynh_print_info --message="Declaring files to be backed up..."
+
#=================================================
# BACKUP THE APP MAIN DIR
#=================================================
-ynh_script_progression --message="Backing up the main app directory..."
ynh_backup --src_path="$final_path"
#=================================================
# BACKUP THE NGINX CONFIGURATION
#=================================================
-ynh_script_progression --message="Backing up nginx web server configuration..."
ynh_backup --src_path="/etc/nginx/conf.d/$domain.d/$app.conf"
-#=================================================
-# BACKUP THE MYSQL DATABASE
-#=================================================
-ynh_script_progression --message="Backing up the MySQL database..."
-
-ynh_mysql_dump_db --database="$db_name" > db.sql
-
#=================================================
# BACKUP THE PHP-FPM CONFIGURATION
#=================================================
-ynh_backup --src_path="/etc/php/7.2/fpm/pool.d/$app.conf"
+ynh_backup --src_path="/etc/php/$phpversion/fpm/pool.d/$app.conf"
#=================================================
-# BACKUP THE CRON FILE
+# BACKUP A CRON FILE
#=================================================
ynh_backup --src_path="/etc/cron.d/$app"
+#=================================================
+# BACKUP THE MYSQL DATABASE
+#=================================================
+ynh_print_info --message="Backing up the MySQL database..."
+
+ynh_mysql_dump_db --database="$db_name" > db.sql
+
#=================================================
# END OF SCRIPT
#=================================================
-ynh_script_progression --message="Backup script completed for $app. (YunoHost will then actually copy those files to the archive)." --time --last
+ynh_print_info --message="Backup script completed for $app. (YunoHost will then actually copy those files to the archive)."
diff --git a/scripts/change_url b/scripts/change_url
index 2d4e435..2024b5d 100644
--- a/scripts/change_url
+++ b/scripts/change_url
@@ -20,16 +20,37 @@ new_domain=$YNH_APP_NEW_DOMAIN
new_path=$YNH_APP_NEW_PATH
app=$YNH_APP_INSTANCE_NAME
-final_path=$(ynh_app_setting_get $app final_path)
#=================================================
-# CHECK THE SYNTAX OF THE PATHS
+# LOAD SETTINGS
#=================================================
+ynh_script_progression --message="Loading installation settings..."
-test -n "$old_path" || old_path="/"
-test -n "$new_path" || new_path="/"
-new_path=$(ynh_normalize_url_path $new_path)
-old_path=$(ynh_normalize_url_path $old_path)
+# Needed for helper "ynh_add_nginx_config"
+final_path=$(ynh_app_setting_get --app=$app --key=final_path)
+
+# Add settings here as needed by your application
+#db_name=$(ynh_app_setting_get --app=$app --key=db_name)
+#db_user=$db_name
+#db_pwd=$(ynh_app_setting_get --app=$app --key=db_pwd)
+phpversion=$(ynh_app_setting_get --app=$app --key=phpversion)
+
+#=================================================
+# BACKUP BEFORE UPGRADE THEN ACTIVE TRAP
+#=================================================
+ynh_script_progression --message="Backing up the app before changing its url (may take a while)..."
+
+# Backup the current version of the app
+ynh_backup_before_upgrade
+ynh_clean_setup () {
+ # Remove the new domain config file, the remove script won't do it as it doesn't know yet its location.
+ ynh_secure_remove --file="/etc/nginx/conf.d/$new_domain.d/$app.conf"
+
+ # restore it if the upgrade fails
+ ynh_restore_upgradebackup
+}
+# Exit if an error occurs during the execution of the script
+ynh_abort_if_errors
#=================================================
# CHECK WHICH PARTS SHOULD BE CHANGED
@@ -59,7 +80,7 @@ nginx_conf_path=/etc/nginx/conf.d/$old_domain.d/$app.conf
if [ $change_path -eq 1 ]
then
# Make a backup of the original nginx config file if modified
- ynh_backup_if_checksum_is_different "$nginx_conf_path"
+ ynh_backup_if_checksum_is_different --file="$nginx_conf_path"
# Set global variables for nginx helper
domain="$old_domain"
path_url="$new_path"
@@ -71,10 +92,10 @@ fi
if [ $change_domain -eq 1 ]
then
# Delete file checksum for the old conf file location
- ynh_delete_file_checksum "$nginx_conf_path"
+ ynh_delete_file_checksum --file="$nginx_conf_path"
mv $nginx_conf_path /etc/nginx/conf.d/$new_domain.d/$app.conf
# Store file checksum for the new config file location
- ynh_store_file_checksum "/etc/nginx/conf.d/$new_domain.d/$app.conf"
+ ynh_store_file_checksum --file="/etc/nginx/conf.d/$new_domain.d/$app.conf"
fi
#=================================================
@@ -88,5 +109,12 @@ cd $final_path && sudo /usr/bin/php7.2 artisan monica:update --force
#=================================================
# RELOAD NGINX
#=================================================
+ynh_script_progression --message="Reloading nginx web server..."
-systemctl reload nginx
+ynh_systemd_action --service_name=nginx --action=reload
+
+#=================================================
+# END OF SCRIPT
+#=================================================
+
+ynh_script_progression --message="Change of URL completed for $app"
diff --git a/scripts/helpers/ynh_add_extra_apt_repos__3 b/scripts/helpers/ynh_add_extra_apt_repos__3
deleted file mode 100644
index eca8427..0000000
--- a/scripts/helpers/ynh_add_extra_apt_repos__3
+++ /dev/null
@@ -1,295 +0,0 @@
-#!/bin/bash
-# See https://github.com/YunoHost-Apps/Experimental_helpers/blob/222a89d3d32f656e41d234cf79021a8e86371b21/ynh_add_extra_apt_repos/ynh_add_extra_apt_repos__3
-
-# Pin a repository.
-#
-# usage: ynh_pin_repo --package=packages --pin=pin_filter [--priority=priority_value] [--name=name] [--append]
-# | arg: -p, --package - Packages concerned by the pin. Or all, *.
-# | arg: -i, --pin - Filter for the pin.
-# | arg: -p, --priority - Priority for the pin
-# | arg: -n, --name - Name for the files for this repo, $app as default value.
-# | arg: -a, --append - Do not overwrite existing files.
-#
-# See https://manpages.debian.org/stretch/apt/apt_preferences.5.en.html for information about pinning.
-#
-ynh_pin_repo () {
- # Declare an array to define the options of this helper.
- local legacy_args=pirna
- declare -Ar args_array=( [p]=package= [i]=pin= [r]=priority= [n]=name= [a]=append )
- local package
- local pin
- local priority
- local name
- local append
- # Manage arguments with getopts
- ynh_handle_getopts_args "$@"
- package="${package:-*}"
- priority=${priority:-50}
- name="${name:-$app}"
- append=${append:-0}
-
- if [ $append -eq 1 ]
- then
- append="tee -a"
- else
- append="tee"
- fi
-
- mkdir -p "/etc/apt/preferences.d"
- echo "Package: $package
-Pin: $pin
-Pin-Priority: $priority" \
- | $append "/etc/apt/preferences.d/$name"
-}
-
-# Add a repository.
-#
-# usage: ynh_add_repo --uri=uri --suite=suite --component=component [--name=name] [--append]
-# | arg: -u, --uri - Uri of the repository.
-# | arg: -s, --suite - Suite of the repository.
-# | arg: -c, --component - Component of the repository.
-# | arg: -n, --name - Name for the files for this repo, $app as default value.
-# | arg: -a, --append - Do not overwrite existing files.
-#
-# Example for a repo like deb http://forge.yunohost.org/debian/ stretch stable
-# uri suite component
-# ynh_add_repo --uri=http://forge.yunohost.org/debian/ --suite=stretch --component=stable
-#
-ynh_add_repo () {
- # Declare an array to define the options of this helper.
- local legacy_args=uscna
- declare -Ar args_array=( [u]=uri= [s]=suite= [c]=component= [n]=name= [a]=append )
- local uri
- local suite
- local component
- local name
- local append
- # Manage arguments with getopts
- ynh_handle_getopts_args "$@"
- name="${name:-$app}"
- append=${append:-0}
-
- if [ $append -eq 1 ]
- then
- append="tee -a"
- else
- append="tee"
- fi
-
- mkdir -p "/etc/apt/sources.list.d"
- # Add the new repo in sources.list.d
- echo "deb $uri $suite $component" \
- | $append "/etc/apt/sources.list.d/$name.list"
-}
-
-# Add an extra repository correctly, pin it and get the key.
-#
-# usage: ynh_install_extra_repo --repo="repo" [--key=key_url] [--priority=priority_value] [--name=name] [--append]
-# | arg: -r, --repo - Complete url of the extra repository.
-# | arg: -k, --key - url to get the public key.
-# | arg: -p, --priority - Priority for the pin
-# | arg: -n, --name - Name for the files for this repo, $app as default value.
-# | arg: -a, --append - Do not overwrite existing files.
-ynh_install_extra_repo () {
- # Declare an array to define the options of this helper.
- local legacy_args=rkpna
- declare -Ar args_array=( [r]=repo= [k]=key= [p]=priority= [n]=name= [a]=append )
- local repo
- local key
- local priority
- local name
- local append
- # Manage arguments with getopts
- ynh_handle_getopts_args "$@"
- name="${name:-$app}"
- append=${append:-0}
- key=${key:-0}
- priority=${priority:-}
-
- if [ $append -eq 1 ]
- then
- append="--append"
- wget_append="tee -a"
- else
- append=""
- wget_append="tee"
- fi
-
- # Split the repository into uri, suite and components.
- # Remove "deb " at the beginning of the repo.
- repo="${repo#deb }"
-
- # Get the uri
- local uri="$(echo "$repo" | awk '{ print $1 }')"
-
- # Get the suite
- local suite="$(echo "$repo" | awk '{ print $2 }')"
-
- # Get the components
- local component="${repo##$uri $suite }"
-
- # Add the repository into sources.list.d
- ynh_add_repo --uri="$uri" --suite="$suite" --component="$component" --name="$name" $append
-
- # Pin the new repo with the default priority, so it won't be used for upgrades.
- # Build $pin from the uri without http and any sub path
- local pin="${uri#*://}"
- pin="${pin%%/*}"
- # Set a priority only if asked
- if [ -n "$priority" ]
- then
- priority="--priority=$priority"
- fi
- ynh_pin_repo --package="*" --pin="origin \"$pin\"" $priority --name="$name" $append
-
- # Get the public key for the repo
- if [ -n "$key" ]
- then
- mkdir -p "/etc/apt/trusted.gpg.d"
- wget -q "$key" -O - | gpg --dearmor | $wget_append /etc/apt/trusted.gpg.d/$name.gpg > /dev/null
- fi
-
- # Update the list of package with the new repo
- ynh_package_update
-}
-
-# Remove an extra repository and the assiociated configuration.
-#
-# usage: ynh_remove_extra_repo [--name=name]
-# | arg: -n, --name - Name for the files for this repo, $app as default value.
-ynh_remove_extra_repo () {
- # Declare an array to define the options of this helper.
- local legacy_args=n
- declare -Ar args_array=( [n]=name= )
- local name
- # Manage arguments with getopts
- ynh_handle_getopts_args "$@"
- name="${name:-$app}"
-
- ynh_secure_remove "/etc/apt/sources.list.d/$name.list"
- ynh_secure_remove "/etc/apt/preferences.d/$name"
- ynh_secure_remove "/etc/apt/trusted.gpg.d/$name.gpg"
- ynh_secure_remove "/etc/apt/trusted.gpg.d/$name.asc"
-
- # Update the list of package to exclude the old repo
- ynh_package_update
-}
-
-# Install packages from an extra repository properly.
-#
-# usage: ynh_install_extra_app_dependencies --repo="repo" --package="dep1 dep2" [--key=key_url] [--name=name]
-# | arg: -r, --repo - Complete url of the extra repository.
-# | arg: -p, --package - The packages to install from this extra repository
-# | arg: -k, --key - url to get the public key.
-# | arg: -n, --name - Name for the files for this repo, $app as default value.
-ynh_install_extra_app_dependencies () {
- # Declare an array to define the options of this helper.
- local legacy_args=rpkn
- declare -Ar args_array=( [r]=repo= [p]=package= [k]=key= [n]=name= )
- local repo
- local package
- local key
- local name
- # Manage arguments with getopts
- ynh_handle_getopts_args "$@"
- name="${name:-$app}"
- key=${key:-0}
-
- # Set a key only if asked
- if [ -n "$key" ]
- then
- key="--key=$key"
- fi
- # Add an extra repository for those packages
- ynh_install_extra_repo --repo="$repo" $key --priority=995 --name=$name
-
- # Install requested dependencies from this extra repository.
- ynh_add_app_dependencies --package="$package"
-
- # Remove this extra repository after packages are installed
- ynh_remove_extra_repo --name=$app
-}
-
-#=================================================
-
-# patched version of ynh_install_app_dependencies to be used with ynh_add_app_dependencies
-
-# Define and install dependencies with a equivs control file
-# This helper can/should only be called once per app
-#
-# usage: ynh_install_app_dependencies dep [dep [...]]
-# | arg: dep - the package name to install in dependence
-# You can give a choice between some package with this syntax : "dep1|dep2"
-# Example : ynh_install_app_dependencies dep1 dep2 "dep3|dep4|dep5"
-# This mean in the dependence tree : dep1 & dep2 & (dep3 | dep4 | dep5)
-#
-# Requires YunoHost version 2.6.4 or higher.
-ynh_install_app_dependencies () {
- local dependencies=$@
- dependencies="$(echo "$dependencies" | sed 's/\([^\<=\>]\)\ \([^(]\)/\1, \2/g')"
- dependencies=${dependencies//|/ | }
- local manifest_path="../manifest.json"
- if [ ! -e "$manifest_path" ]; then
- manifest_path="../settings/manifest.json" # Into the restore script, the manifest is not at the same place
- fi
-
- local version=$(grep '\"version\": ' "$manifest_path" | cut -d '"' -f 4) # Retrieve the version number in the manifest file.
- if [ ${#version} -eq 0 ]; then
- version="1.0"
- fi
- local dep_app=${app//_/-} # Replace all '_' by '-'
-
- # Handle specific versions
- if [[ "$dependencies" =~ [\<=\>] ]]
- then
- # Replace version specifications by relationships syntax
- # https://www.debian.org/doc/debian-policy/ch-relationships.html
- # Sed clarification
- # [^(\<=\>] ignore if it begins by ( or < = >. To not apply twice.
- # [\<=\>] matches < = or >
- # \+ matches one or more occurence of the previous characters, for >= or >>.
- # [^,]\+ matches all characters except ','
- # Ex: package>=1.0 will be replaced by package (>= 1.0)
- dependencies="$(echo "$dependencies" | sed 's/\([^(\<=\>]\)\([\<=\>]\+\)\([^,]\+\)/\1 (\2 \3)/g')"
- fi
-
- cat > /tmp/${dep_app}-ynh-deps.control << EOF # Make a control file for equivs-build
-Section: misc
-Priority: optional
-Package: ${dep_app}-ynh-deps
-Version: ${version}
-Depends: ${dependencies}
-Architecture: all
-Description: Fake package for $app (YunoHost app) dependencies
- This meta-package is only responsible of installing its dependencies.
-EOF
- ynh_package_install_from_equivs /tmp/${dep_app}-ynh-deps.control \
- || ynh_die --message="Unable to install dependencies" # Install the fake package and its dependencies
- rm /tmp/${dep_app}-ynh-deps.control
- ynh_app_setting_set --app=$app --key=apt_dependencies --value="$dependencies"
-}
-
-ynh_add_app_dependencies () {
- # Declare an array to define the options of this helper.
- local legacy_args=pr
- declare -Ar args_array=( [p]=package= [r]=replace)
- local package
- local replace
- # Manage arguments with getopts
- ynh_handle_getopts_args "$@"
- replace=${replace:-0}
-
- local current_dependencies=""
- if [ $replace -eq 0 ]
- then
- local dep_app=${app//_/-} # Replace all '_' by '-'
- if ynh_package_is_installed --package="${dep_app}-ynh-deps"
- then
- current_dependencies="$(dpkg-query --show --showformat='${Depends}' ${dep_app}-ynh-deps) "
- fi
-
- current_dependencies=${current_dependencies// | /|}
- fi
-
- ynh_install_app_dependencies "${current_dependencies}${package}"
-}
diff --git a/scripts/helpers/ynh_install_php__3 b/scripts/helpers/ynh_install_php__3
deleted file mode 100644
index 471df1d..0000000
--- a/scripts/helpers/ynh_install_php__3
+++ /dev/null
@@ -1,78 +0,0 @@
-#!/bin/bash
-# See https://raw.githubusercontent.com/YunoHost-Apps/Experimental_helpers/master/ynh_install_php/ynh_install_php__3
-
-# Install another version of php.
-#
-# usage: ynh_install_php --phpversion=phpversion [--package=packages]
-# | arg: -v, --phpversion - Version of php to install. Can be one of 7.1, 7.2 or 7.3
-# | arg: -p, --package - Additionnal php packages to install
-ynh_install_php () {
- # Declare an array to define the options of this helper.
- local legacy_args=vp
- declare -Ar args_array=( [v]=phpversion= [p]=package= )
- local phpversion
- local package
- # Manage arguments with getopts
- ynh_handle_getopts_args "$@"
- package=${package:-}
-
- # Store php_version into the config of this app
- ynh_app_setting_set $app php_version $phpversion
-
- if [ "$phpversion" == "7.0" ]
- then
- ynh_die "Do not use ynh_install_php to install php7.0"
- fi
-
- # Store the ID of this app and the version of php requested for it
- echo "$YNH_APP_INSTANCE_NAME:$phpversion" | tee --append "/etc/php/ynh_app_version"
-
- # Add an extra repository for those packages
- ynh_install_extra_repo --repo="https://packages.sury.org/php/ $(lsb_release -sc) main" --key="https://packages.sury.org/php/apt.gpg" --priority=995 --name=extra_php_version
-
- # Install requested dependencies from this extra repository.
- # Install php-fpm first, otherwise php will install apache as a dependency.
- ynh_add_app_dependencies --package="php${phpversion}-fpm"
- ynh_add_app_dependencies --package="php$phpversion php${phpversion}-common $package"
-
- # Set php7.0 back as the default version for php-cli.
- update-alternatives --set php /usr/bin/php7.0
-
- # Remove this extra repository after packages are installed
- ynh_remove_extra_repo --name=extra_php_version
-
- # Advertise service in admin panel
- yunohost service add php${phpversion}-fpm --log "/var/log/php${phpversion}-fpm.log"
-}
-
-ynh_remove_php () {
- # Get the version of php used by this app
- local phpversion=$(ynh_app_setting_get $app php_version)
-
- if [ "$phpversion" == "7.0" ] || [ -z "$phpversion" ]
- then
- if [ "$phpversion" == "7.0" ]
- then
- ynh_print_err "Do not use ynh_remove_php to install php7.0"
- fi
- return 0
- fi
-
- # Remove the line for this app
- sed --in-place "/$YNH_APP_INSTANCE_NAME:$phpversion/d" "/etc/php/ynh_app_version"
-
- # If no other app uses this version of php, remove it.
- if ! grep --quiet "$phpversion" "/etc/php/ynh_app_version"
- then
- # Purge php dependences for this version.
- ynh_package_autopurge "php$phpversion php${phpversion}-fpm php${phpversion}-common"
- # Remove the service from the admin panel
- yunohost service remove php${phpversion}-fpm
- fi
-
- # If no other app uses alternate php versions, remove the extra repo for php
- if [ ! -s "/etc/php/ynh_app_version" ]
- then
- ynh_secure_remove /etc/php/ynh_app_version
- fi
-}
\ No newline at end of file
diff --git a/scripts/install b/scripts/install
index 1e4f711..14420d7 100755
--- a/scripts/install
+++ b/scripts/install
@@ -7,6 +7,7 @@
#=================================================
source _common.sh
+source ynh_composer__2
source /usr/share/yunohost/helpers
#=================================================
@@ -25,26 +26,16 @@ path_url=$YNH_APP_ARG_PATH
admin=$YNH_APP_ARG_ADMIN
is_public=$YNH_APP_ARG_IS_PUBLIC
language=$YNH_APP_ARG_LANGUAGE
-random_key=$(ynh_string_random 32)
+random_key=$(ynh_string_random --length=32)
+email=$(ynh_user_get_info $admin 'mail')
-### If it's a multi-instance app, meaning it can be installed several times independently
-### The id of the app as stated in the manifest is available as $YNH_APP_ID
-### The instance number is available as $YNH_APP_INSTANCE_NUMBER (equals "1", "2", ...)
-### The app instance name is available as $YNH_APP_INSTANCE_NAME
-### - the first time the app is installed, YNH_APP_INSTANCE_NAME = ynhexample
-### - the second time the app is installed, YNH_APP_INSTANCE_NAME = ynhexample__2
-### - ynhexample__{N} for the subsequent installations, with N=3,4, ...
-### The app instance name is probably what interests you most, since this is
-### guaranteed to be unique. This is a good unique identifier to define installation path,
-### db names, ...
app=$YNH_APP_INSTANCE_NAME
#=================================================
# CHECK IF THE APP CAN BE INSTALLED WITH THESE ARGS
#=================================================
+ynh_script_progression --message="Validating installation parameters..."
-### If the app uses nginx as web server (written in HTML/PHP in most cases), the final path should be "/var/www/$app".
-### If the app provides an internal web server (or uses another application server such as uwsgi), the final path should be "/opt/yunohost/$app"
final_path=/var/www/$app
test ! -e "$final_path" || ynh_die --message="This path already contains a folder"
@@ -54,6 +45,7 @@ ynh_webpath_register --app=$app --domain=$domain --path_url=$path_url
#=================================================
# STORE SETTINGS FROM MANIFEST
#=================================================
+ynh_script_progression --message="Storing installation settings..."
ynh_app_setting_set --app=$app --key=domain --value=$domain
ynh_app_setting_set --app=$app --key=path --value=$path_url
@@ -69,32 +61,13 @@ ynh_app_setting_set --app=$app --key=random_key --value=$random_key
#=================================================
ynh_script_progression --message="Installing dependencies..."
-
-### `ynh_install_app_dependencies` allows you to add any "apt" dependencies to the package.
-### Those deb packages will be installed as dependencies of this package.
-### If you're not using this helper:
-### - Remove the section "REMOVE DEPENDENCIES" in the remove script
-### - Remove the variable "pkg_dependencies" in _common.sh
-### - As well as the section "REINSTALL DEPENDENCIES" in the restore script
-### - And the section "UPGRADE DEPENDENCIES" in the upgrade script
-
-ynh_print_info --message="Installing php7.2..."
- ynh_install_php --phpversion="7.2" --package="$pkg_dependencies"
+ynh_install_app_dependencies $pkg_dependencies
#=================================================
# CREATE A MYSQL DATABASE
#=================================================
ynh_script_progression --message="Creating a MySQL database..."
-### Use these lines if you need a database for the application.
-### `ynh_mysql_setup_db` will create a database, an associated user and a ramdom password.
-### The password will be stored as 'mysqlpwd' into the app settings,
-### and will be available as $db_pwd
-### If you're not using these lines:
-### - Remove the section "BACKUP THE MYSQL DATABASE" in the backup script
-### - Remove also the section "REMOVE THE MYSQL DATABASE" in the remove script
-### - As well as the section "RESTORE THE MYSQL DATABASE" in the restore script
-
db_name=$(ynh_sanitize_dbid --db_name=$app)
db_user=$db_name
ynh_app_setting_set --app=$app --key=db_name --value=$db_name
@@ -105,29 +78,14 @@ ynh_mysql_setup_db --db_user=$db_user --db_name=$db_name
#=================================================
ynh_script_progression --message="Setting up source files..."
-### `ynh_setup_source` is used to install an app from a zip or tar.gz file,
-### downloaded from an upstream source, like a git repository.
-### `ynh_setup_source` use the file conf/app.src
-
ynh_app_setting_set --app=$app --key=final_path --value=$final_path
# Download, check integrity, uncompress and patch the source from app.src
ynh_setup_source --dest_dir="$final_path"
-#=================================================
-# PHP-FPM CONFIGURATION
-#=================================================
-ynh_print_info --message="Configuring php-fpm..."
-
-# Create a dedicated php-fpm config
-ynh_add_fpm_config --phpversion="7.2"
-
-ynh_install_composer --phpversion="7.2" --workdir="$final_path"
-
#=================================================
# NGINX CONFIGURATION
#=================================================
ynh_script_progression --message="Configuring nginx web server..."
-### `ynh_add_nginx_config` will use the file conf/nginx.conf
# Create a dedicated nginx config
ynh_add_nginx_config
@@ -140,41 +98,72 @@ ynh_script_progression --message="Configuring system user..."
# Create a system user
ynh_system_user_create --username=$app
+#=================================================
+# PHP-FPM CONFIGURATION
+#=================================================
+ynh_script_progression --message="Configuring php-fpm..."
+
+# Create a dedicated php-fpm config
+ynh_add_fpm_config --usage=low --footprint=low --package="$extra_php_dependencies"
+phpversion=$(ynh_app_setting_get --app=$app --key=phpversion)
+
#=================================================
# SPECIFIC SETUP
#=================================================
+# INSTALL COMPOSER DEPENDENCIES
+#=================================================
+ynh_script_progression --message="Installing composer dependencies..."
-# Get admin email
-email=$(ynh_user_get_info $admin 'mail')
+ynh_exec_warn_less ynh_install_composer --phpversion="$phpversion" --workdir="$final_path"
-# setup application config
-cp ../conf/.env $final_path/.env
+#=================================================
+# MODIFY A CONFIG FILE
+#=================================================
+ynh_script_progression --message="Modifying a config file..."
-db_name=$(ynh_sanitize_dbid $app)
-ynh_replace_string --match_string="__DOMAIN__" --replace_string="$domain" --target_file="$final_path/.env"
-ynh_replace_string --match_string="random_key" --replace_string="$random_key" --target_file="$final_path/.env"
-ynh_replace_string --match_string="yunouser" --replace_string="$db_name" --target_file="$final_path/.env"
-ynh_replace_string --match_string="yunopass" --replace_string="$db_pwd" --target_file="$final_path/.env"
-ynh_replace_string --match_string="yunobase" --replace_string="$db_name" --target_file="$final_path/.env"
-ynh_replace_string --match_string="yunomail" --replace_string="$email" --target_file="$final_path/.env"
-ynh_replace_string --match_string="yunodomain" --replace_string="$domain" --target_file="$final_path/.env"
-ynh_replace_string --match_string="language" --replace_string="$language" --target_file="$final_path/.env"
+config="$final_path/.env"
+cp ../conf/.env "$config"
+ynh_replace_string --match_string="__DOMAIN__" --replace_string="$domain" --target_file="$config"
+ynh_replace_string --match_string="random_key" --replace_string="$random_key" --target_file="$config"
+ynh_replace_string --match_string="yunouser" --replace_string="$db_name" --target_file="$config"
+ynh_replace_string --match_string="yunopass" --replace_string="$db_pwd" --target_file="$config"
+ynh_replace_string --match_string="yunobase" --replace_string="$db_name" --target_file="$config"
+ynh_replace_string --match_string="yunomail" --replace_string="$email" --target_file="$config"
+ynh_replace_string --match_string="yunodomain" --replace_string="$domain" --target_file="$config"
+ynh_replace_string --match_string="language" --replace_string="$language" --target_file="$config"
-# setup application config
-( cd $final_path && sudo /usr/bin/php7.2 artisan monica:update --force )
-( cd $final_path && sudo /usr/bin/php7.2 artisan passport:keys )
-( cd $final_path && sudo /usr/bin/php7.2 artisan passport:client --password -n > key.txt )
-mobile_id=$( cd $final_path && tail -2 key.txt | head -1 | cut -c 12- )
-mobile_key=$( cd $final_path && tail -1 key.txt | cut -c 16- )
-ynh_replace_string --match_string="__IDENTITY__" --replace_string="$mobile_id" --target_file="$final_path/.env"
-ynh_replace_string --match_string="__KEY__" --replace_string="$mobile_key" --target_file="$final_path/.env"
-ynh_app_setting_set --app=$app --key=mobile_id --value=$mobile_id
-ynh_app_setting_set --app=$app --key=mobile_key --value=$mobile_key
-(cd $final_path && rm -f key.txt)
+#=================================================
+# DEPLOY
+#=================================================
+ynh_script_progression --message="Deploying..."
+pushd "$final_path"
+ php$phpversion artisan monica:update --force
+ php$phpversion artisan passport:keys
+ php$phpversion artisan passport:client --password -n > key.txt
+ mobile_id=$( cd $final_path && tail -2 key.txt | head -1 | cut -c 12- )
+ mobile_key=$( cd $final_path && tail -1 key.txt | cut -c 16- )
+ ynh_replace_string --match_string="__IDENTITY__" --replace_string="$mobile_id" --target_file="$config"
+ ynh_replace_string --match_string="__KEY__" --replace_string="$mobile_key" --target_file="$config"
+ ynh_app_setting_set --app=$app --key=mobile_id --value=$mobile_id
+ ynh_app_setting_set --app=$app --key=mobile_key --value=$mobile_key
+ rm -f key.txt
+popd
+
+#=================================================
+# STORE THE CONFIG FILE CHECKSUM
+#=================================================
+ynh_script_progression --message="Storing the config file checksum..."
+
+# Calculate and store the config file checksum into the app settings
+ynh_store_file_checksum --file="$config"
+
+#=================================================
+# INSTALL THE CRON FILE
+#=================================================
+ynh_script_progression --message="Installing the cron file..."
-# create a cronjob to run the scheduler
echo "* * * * * -u $app /usr/bin/php7.2 $final_path/artisan schedule:run" > /tmp/cron$app
mv /tmp/cron$app /etc/cron.d/$app
@@ -183,23 +172,16 @@ mv /tmp/cron$app /etc/cron.d/$app
#=================================================
# SECURE FILES AND DIRECTORIES
#=================================================
+ynh_script_progression --message="Securing files and directories..."
# Set permissions to app files
chown -R $app: $final_path
-#=================================================
-# STORE THE CHECKSUM OF THE CONFIG FILE
-#=================================================
-
-# Calculate and store the config file checksum into the app settings
-ynh_store_file_checksum --file="$final_path/.env"
-
#=================================================
# SETUP SSOWAT
#=================================================
ynh_script_progression --message="Configuring SSOwat..."
-
# Make app public if necessary
if [ $is_public -eq 1 ]
then
@@ -210,16 +192,6 @@ fi
#=================================================
# RELOAD NGINX
#=================================================
-#service php7.2-fpm start
-#systemctl reload php7.2-fpm
-#systemctl reload nginx
-# Set default php to php5 or php7.0
-#if [ "$(lsb_release --codename --short)" == "jessie" ]; then
-# update-alternatives --set php /usr/bin/php5
-#else
-# update-alternatives --set php /usr/bin/php7.0
-#fi
-
ynh_script_progression --message="Reloading nginx web server..."
ynh_systemd_action --service_name=nginx --action=reload
@@ -228,4 +200,4 @@ ynh_systemd_action --service_name=nginx --action=reload
# END OF SCRIPT
#=================================================
-ynh_script_progression --message="Installation of $app completed" --time --last
+ynh_script_progression --message="Installation of $app completed" --last
diff --git a/scripts/remove b/scripts/remove
index 36f489b..f007d4a 100755
--- a/scripts/remove
+++ b/scripts/remove
@@ -24,13 +24,6 @@ final_path=$(ynh_app_setting_get --app=$app --key=final_path)
#=================================================
# STANDARD REMOVE
#=================================================
-# REMOVE DEPENDENCIES
-#=================================================
-ynh_script_progression --message="Removing dependencies..."
-
-# Remove metapackage and its dependencies
-ynh_remove_app_dependencies
-#=================================================
# REMOVE THE MYSQL DATABASE
#=================================================
ynh_script_progression --message="Removing the MySQL database..."
@@ -38,6 +31,14 @@ ynh_script_progression --message="Removing the MySQL database..."
# Remove a database if it exists, along with the associated user
ynh_mysql_remove_db --db_user=$db_user --db_name=$db_name
+#=================================================
+# REMOVE DEPENDENCIES
+#=================================================
+ynh_script_progression --message="Removing dependencies..."
+
+# Remove metapackage and its dependencies
+ynh_remove_app_dependencies
+
#=================================================
# REMOVE APP MAIN DIR
#=================================================
@@ -55,24 +56,19 @@ ynh_script_progression --message="Removing nginx web server configuration..."
ynh_remove_nginx_config
#=================================================
-# REMOVE PHP-FPM 7.2 CONFIGURATION
+# REMOVE PHP-FPM CONFIGURATION
#=================================================
-ynh_script_progression --message="Removing php-fpm configuration..."
+ynh_script_progression --message="Removing php-fpm configuration..."
-# Remove the dedicated php-fpm7.2 config
+# Remove the dedicated php-fpm config
ynh_remove_fpm_config
-
#=================================================
# SPECIFIC REMOVE
-#=================================================
-
-# Remove php packages
-ynh_remove_php
-
#=================================================
# REMOVE THE CRON FILE
#=================================================
+ynh_script_progression --message="Removing the cron file..."
# Remove a cron file
ynh_secure_remove --file="/etc/cron.d/$app"
@@ -85,7 +81,7 @@ ynh_secure_remove --file="/etc/cron.d/$app"
ynh_script_progression --message="Removing the dedicated system user..."
# Delete a system user
-ynh_system_user_delete $app
+ynh_system_user_delete --username=$app
#=================================================
# END OF SCRIPT
diff --git a/scripts/restore b/scripts/restore
index f73e31a..fb6f540 100755
--- a/scripts/restore
+++ b/scripts/restore
@@ -15,7 +15,6 @@ source /usr/share/yunohost/helpers
#=================================================
ynh_clean_setup () {
- #### Remove this function if there's nothing to clean before calling the remove script.
true
}
# Exit if an error occurs during the execution of the script
@@ -33,6 +32,7 @@ path_url=$(ynh_app_setting_get --app=$app --key=path)
final_path=$(ynh_app_setting_get --app=$app --key=final_path)
db_name=$(ynh_app_setting_get --app=$app --key=db_name)
db_user=$db_name
+phpversion=$(ynh_app_setting_get --app=$app --key=phpversion)
#=================================================
# CHECK IF THE APP CAN BE RESTORED
@@ -46,26 +46,56 @@ test ! -d $final_path \
#=================================================
# STANDARD RESTORATION STEPS
-#=================================================
-# REINSTALL DEPENDENCIES
-#=================================================
-
-# Create a dedicated php-fpm7.2 config
-ynh_print_info --message="Installing php7.2..."
- ynh_install_php --phpversion="7.2" --package="$pkg_dependencies"
-
#=================================================
# RESTORE THE NGINX CONFIGURATION
#=================================================
+ynh_script_progression --message="Restoring the nginx configuration..."
-ynh_restore_file "/etc/nginx/conf.d/$domain.d/$app.conf"
+ynh_restore_file --origin_path="/etc/nginx/conf.d/$domain.d/$app.conf"
#=================================================
# RESTORE THE APP MAIN DIR
#=================================================
+ynh_script_progression --message="Restoring the app main directory..."
ynh_restore_file --origin_path="$final_path"
+#=================================================
+# RECREATE THE DEDICATED USER
+#=================================================
+ynh_script_progression --message="Recreating the dedicated system user..."
+
+# Create the dedicated user (if not existing)
+ynh_system_user_create --username=$app
+
+#=================================================
+# RESTORE USER RIGHTS
+#=================================================
+ynh_script_progression --message="Restoring user rights..."
+
+# Restore permissions on app files
+chown -R $app: $final_path
+
+#=================================================
+# RESTORE THE PHP-FPM CONFIGURATION
+#=================================================
+ynh_script_progression --message="Restoring PHP-FPM configuration..."
+
+ynh_restore_file --origin_path="/etc/php/$phpversion/fpm/pool.d/$app.conf"
+
+# Recreate a dedicated php-fpm config
+ynh_add_fpm_config --usage=low --footprint=low --package="$extra_php_dependencies"
+
+#=================================================
+# SPECIFIC RESTORATION
+#=================================================
+# REINSTALL DEPENDENCIES
+#=================================================
+ynh_script_progression --message="Reinstalling dependencies..."
+
+# Define and install dependencies
+ynh_install_app_dependencies $pkg_dependencies
+
#=================================================
# RESTORE THE MYSQL DATABASE
#=================================================
@@ -75,44 +105,10 @@ db_pwd=$(ynh_app_setting_get --app=$app --key=mysqlpwd)
ynh_mysql_setup_db --db_user=$db_user --db_name=$db_name --db_pwd=$db_pwd
ynh_mysql_connect_as --user=$db_user --password=$db_pwd --database=$db_name < ./db.sql
-#=================================================
-# RECREATE THE DEDICATED USER
-#=================================================
-ynh_script_progression --message="Recreating the dedicated system user..."
-
-# Create the dedicated user (if not existing)
-ynh_system_user_create --username=$app
-
-# Create a dedicated php-fpm config
-ynh_add_fpm_config --phpversion="7.2"
-ynh_install_composer --phpversion="7.2" --workdir="$final_path"
-
-#=================================================
-# SPECIFIC RESTORATION
-#=================================================
-# REINSTALL DEPENDENCIES
-#=================================================
-
-# Run migration
-cd $final_path && sudo /usr/bin/php7.2 artisan monica:update --force
-
-
-#=================================================
-# RESTORE USER RIGHTS
-#=================================================
-
-# Restore permissions on app files
-chown -R $app: $final_path
-
-#=================================================
-# RESTORE THE PHP-FPM CONFIGURATION
-#=================================================
-
-ynh_restore_file "/etc/php/7.2/fpm/pool.d/$app.conf"
-
#=================================================
# RESTORE THE CRON FILE
#=================================================
+ynh_script_progression --message="Restoring the cron file..."
ynh_restore_file --origin_path="/etc/cron.d/$app"
@@ -121,9 +117,9 @@ ynh_restore_file --origin_path="/etc/cron.d/$app"
#=================================================
# RELOAD NGINX AND PHP-FPM
#=================================================
-ynh_script_progression --message="Reloading nginx web server and php-fpm..." --time --weight=1
+ynh_script_progression --message="Reloading nginx web server and php-fpm..."
-ynh_systemd_action --service_name=php7.2-fpm --action=reload
+ynh_systemd_action --service_name=php$phpversion-fpm --action=reload
ynh_systemd_action --service_name=nginx --action=reload
#=================================================
@@ -131,4 +127,3 @@ ynh_systemd_action --service_name=nginx --action=reload
#=================================================
ynh_script_progression --message="Restoration completed for $app"
-
diff --git a/scripts/upgrade b/scripts/upgrade
index dfcf41e..0f303b8 100755
--- a/scripts/upgrade
+++ b/scripts/upgrade
@@ -7,6 +7,7 @@
#=================================================
source _common.sh
+source ynh_composer__2
source /usr/share/yunohost/helpers
#=================================================
@@ -21,11 +22,19 @@ path_url=$(ynh_app_setting_get --app=$app --key=path)
admin=$(ynh_app_setting_get --app=$app --key=admin)
is_public=$(ynh_app_setting_get --app=$app --key=is_public)
final_path=$(ynh_app_setting_get --app=$app --key=final_path)
+language=$(ynh_app_setting_get --app=$app --key=language)
db_name=$(ynh_app_setting_get --app=$app --key=db_name)
db_pwd=$(ynh_app_setting_get --app=$app --key=mysqlpwd)
-language=$(ynh_app_setting_get --app=$app --key=language)
random_key=$(ynh_app_setting_get --app=$app --key=random_key)
version=$(ynh_read_manifest --key="version")
+email=$(ynh_user_get_info $admin 'mail')
+
+#=================================================
+# CHECK VERSION
+#=================================================
+ynh_script_progression --message="Checking version..."
+
+upgrade_type=$(ynh_check_app_version_changed)
#=================================================
# ENSURE DOWNWARD COMPATIBILITY
@@ -72,7 +81,7 @@ ynh_abort_if_errors
#=================================================
# Normalize the URL path syntax
-path_url=$(ynh_normalize_url_path $path_url)
+path_url=$(ynh_normalize_url_path --path_url=$path_url)
#=================================================
# STANDARD UPGRADE STEPS
@@ -80,22 +89,13 @@ path_url=$(ynh_normalize_url_path $path_url)
# DOWNLOAD, CHECK AND UNPACK SOURCE
#=================================================
-# Download, check integrity, uncompress and patch the source from app.src
-ynh_setup_source --dest_dir="$final_path"
+if [ "$upgrade_type" == "UPGRADE_APP" ]
+then
+ ynh_script_progression --message="Upgrading source files..."
-#=================================================
-# UPGRADE DEPENDENCIES
-#=================================================
-# Create a dedicated php-fpm7.2 config
-ynh_print_info --message="Installing php7.2..."
- ynh_install_php --phpversion="7.2" --package="$pkg_dependencies"
-
-#=================================================
-# INSTALL COMPOSER
-#=================================================
-# Create a dedicated php-fpm config
-ynh_add_fpm_config --phpversion="7.2"
-ynh_install_composer --phpversion="7.2" --workdir="$final_path"
+ # Download, check integrity, uncompress and patch the source from app.src
+ ynh_setup_source --dest_dir="$final_path"
+fi
#=================================================
# NGINX CONFIGURATION
@@ -105,6 +105,13 @@ ynh_script_progression --message="Upgrading nginx web server configuration..."
# Create a dedicated nginx config
ynh_add_nginx_config
+#=================================================
+# UPGRADE DEPENDENCIES
+#=================================================
+ynh_script_progression --message="Upgrading dependencies..."
+
+ynh_install_app_dependencies "$pkg_dependencies"
+
#=================================================
# CREATE DEDICATED USER
#=================================================
@@ -113,63 +120,94 @@ ynh_script_progression --message="Making sure dedicated system user exists..."
# Create a dedicated user (if not existing)
ynh_system_user_create --username=$app
-
-#=================================================
-# SPECIFIC UPGRADE
-#=================================================
#=================================================
# PHP-FPM CONFIGURATION
#=================================================
ynh_script_progression --message="Upgrading php-fpm configuration..."
-# setup application config
-# Get admin email
-email=$(ynh_user_get_info $admin 'mail')
-sudo cp ../conf/.env $final_path/.env
+# Create a dedicated php-fpm config
+ynh_add_fpm_config --usage=low --footprint=low --package="$extra_php_dependencies"
+phpversion=$(ynh_app_setting_get --app=$app --key=phpversion)
-db_name=$(ynh_sanitize_dbid $app)
+#=================================================
+# SPECIFIC UPGRADE
+#=================================================
+# UPDATE PHP DEPENDENCIES
+#=================================================
+ynh_script_progression --message="Updating php dependencies..."
-ynh_replace_string --match_string="random_key" --replace_string="$random_key" --target_file="$final_path/.env"
-ynh_replace_string --match_string="yunouser" --replace_string="$db_name" --target_file="$final_path/.env"
-ynh_replace_string --match_string="yunopass" --replace_string="$db_pwd" --target_file="$final_path/.env"
-ynh_replace_string --match_string="yunobase" --replace_string="$db_name" --target_file="$final_path/.env"
-ynh_replace_string --match_string="yunomail" --replace_string="$email" --target_file="$final_path/.env"
-ynh_replace_string --match_string="yunodomain" --replace_string="$domain" --target_file="$final_path/.env"
-ynh_replace_string --match_string="language" --replace_string="$language" --target_file="$final_path/.env"
-ynh_replace_string --match_string="__DOMAIN__" --replace_string="$domain" --target_file="$final_path/.env"
+chown -R "$app": "$final_path"
+ynh_exec_warn_less ynh_composer_exec --phpversion="$phpversion" --workdir="$final_path" --commands="update"
-# Run monica update
-cd $final_path && sudo /usr/bin/php7.2 artisan monica:update --force
+#=================================================
+# MODIFY A CONFIG FILE
+#=================================================
+ynh_script_progression --message="Modifying a config file..."
+
+config="$final_path/.env"
+ynh_backup_if_checksum_is_different --file="$config"
+cp ../conf/.env "$config"
+
+ynh_replace_string --match_string="random_key" --replace_string="$random_key" --target_file="$config"
+ynh_replace_string --match_string="yunouser" --replace_string="$db_name" --target_file="$config"
+ynh_replace_string --match_string="yunopass" --replace_string="$db_pwd" --target_file="$config"
+ynh_replace_string --match_string="yunobase" --replace_string="$db_name" --target_file="$config"
+ynh_replace_string --match_string="yunomail" --replace_string="$email" --target_file="$config"
+ynh_replace_string --match_string="yunodomain" --replace_string="$domain" --target_file="$config"
+ynh_replace_string --match_string="language" --replace_string="$language" --target_file="$config"
+ynh_replace_string --match_string="__DOMAIN__" --replace_string="$domain" --target_file="$config"
+
+#=================================================
+# DEPLOYMENT
+#=================================================
+ynh_script_progression --message="Deploying..."
+
+pushd "$final_path"
+ php$phpversion artisan monica:update --force
+popd
if [ -f $final_path/storage/oauth-private.key ]; then
mobile_id=$(ynh_app_setting_get --app=$app --key=mobile_id)
mobile_key=$(ynh_app_setting_get --app=$app --key=mobile_key)
- ynh_replace_string --match_string="__IDENTITY__" --replace_string="$mobile_id" --target_file="$final_path/.env"
- ynh_replace_string --match_string="__KEY__" --replace_string="$mobile_key" --target_file="$final_path/.env"
+ ynh_replace_string --match_string="__IDENTITY__" --replace_string="$mobile_id" --target_file="$config"
+ ynh_replace_string --match_string="__KEY__" --replace_string="$mobile_key" --target_file="$config"
else
- ( cd $final_path && sudo /usr/bin/php7.2 artisan passport:keys )
- ( cd $final_path && sudo /usr/bin/php7.2 artisan passport:client --password -n > key.txt )
- mobile_id=$( cd $final_path && tail -2 key.txt | head -1 | cut -c 12- )
- mobile_key=$( cd $final_path && tail -1 key.txt | cut -c 16- )
- ynh_replace_string --match_string="__IDENTITY__" --replace_string="$mobile_id" --target_file="$final_path/.env"
- ynh_replace_string --match_string="__KEY__" --replace_string="$mobile_key" --target_file="$final_path/.env"
- ynh_app_setting_set --app=$app --key=mobile_id --value=$mobile_id
- ynh_app_setting_set --app=$app --key=mobile_key --value=$mobile_key
- (cd $final_path && rm -f key.txt)
+ pushd "$final_path"
+ php$phpversion artisan passport:keys
+ php$phpversion artisan passport:client --password -n > key.txt
+ mobile_id=$( tail -2 key.txt | head -1 | cut -c 12- )
+ mobile_key=$( tail -1 key.txt | cut -c 16- )
+ ynh_replace_string --match_string="__IDENTITY__" --replace_string="$mobile_id" --target_file="$config"
+ ynh_replace_string --match_string="__KEY__" --replace_string="$mobile_key" --target_file="$config"
+ ynh_app_setting_set --app=$app --key=mobile_id --value=$mobile_id
+ ynh_app_setting_set --app=$app --key=mobile_key --value=$mobile_key
+ rm -f key.txt
+ popd
fi
if [ "$version" -lt "2.15.0" ]; then
- ( cd $final_path && sudo /usr/bin/php7.2 artisan monica:moveavatarstophotosdirectory)
+ pushd "$final_path"
+ php$phpversion artisan monica:moveavatarstophotosdirectory)
+ popd
fi
+#=================================================
+# STORE THE CONFIG FILE CHECKSUM
+#=================================================
+ynh_script_progression --message="Storing the config file checksum..."
+
+# Calculate and store the config file checksum into the app settings
+ynh_store_file_checksum --file="$config"
+
#=================================================
# GENERIC FINALIZATION
#=================================================
# SECURE FILES AND DIRECTORIES
#=================================================
+ynh_script_progression --message="Securing files and directories..."
-# Set right permissions for curl installation
+# Set permissions on app files
chown -R $app: $final_path
#=================================================
diff --git a/scripts/helpers/ynh_composer__2 b/scripts/ynh_composer__2
similarity index 91%
rename from scripts/helpers/ynh_composer__2
rename to scripts/ynh_composer__2
index 5c8775b..6f9676b 100644
--- a/scripts/helpers/ynh_composer__2
+++ b/scripts/ynh_composer__2
@@ -16,11 +16,11 @@ ynh_composer_exec () {
# Manage arguments with getopts
ynh_handle_getopts_args "$@"
workdir="${workdir:-$final_path}"
- phpversion="${phpversion:-7.0}"
+ phpversion="${phpversion:-$YNH_PHP_VERSION}"
COMPOSER_HOME="$workdir/.composer" \
php${phpversion} "$workdir/composer.phar" $commands \
- -d "$workdir" --quiet --no-interaction
+ -d "$workdir" --no-interaction
}
# Install and initialize Composer in the given directory
@@ -39,12 +39,12 @@ ynh_install_composer () {
# Manage arguments with getopts
ynh_handle_getopts_args "$@"
workdir="${workdir:-$final_path}"
- phpversion="${phpversion:-7.0}"
+ phpversion="${phpversion:-$YNH_PHP_VERSION}"
install_args="${install_args:-}"
curl -sS https://getcomposer.org/installer \
| COMPOSER_HOME="$workdir/.composer" \
- php${phpversion} -- --quiet --install-dir="$workdir" \
+ php${phpversion} -- --install-dir="$workdir" \
|| ynh_die "Unable to install Composer."
# update dependencies to create composer.lock