[enh] Redirect to the SSO dynamically on logging out

patches/sso-logout.patch

@@ -0,0 +1,13 @@
+diff --git a/app/controllers/DisconnectController.php b/app/controllers/DisconnectController.php
+index 7af0d4b..74f0c61 100644
+--- a/app/controllers/DisconnectController.php
++++ b/app/controllers/DisconnectController.php
+@@ -13,6 +13,7 @@ class DisconnectController extends Base
+ 
+         Session::dispose();
+ 
+-        $this->redirect('login');
++        $main_domain = exec('cat /etc/yunohost/current_host');
++        header('Location: https://' . $main_domain . '/yunohost/sso/?action=logout');
+     }
+ }

scripts/_common.sh

@@ -11,6 +11,9 @@ HEAD_COMMIT="512523576b03c2c8952305e70681ed31172b9fd2"
 # Source code destination directory
 DESTDIR="/var/www/movim"
 
+# App package root directory should be the parent folder
+PKGDIR=$(cd ../; pwd)
+
 #
 # Common helpers
 #
@@ -21,3 +24,12 @@ exec_cmd() {
   (cd "$DESTDIR" \
    && sudo sudo -u movim "$@")
 }
+
+# Apply the SSO patch to Movim source code
+# usage: apply_sso_patch
+apply_sso_patch() {
+  local patch_path="/tmp/sso-logout.patch"
+  cp -f "${PKGDIR}/patches/sso-logout.patch" "$patch_path"
+  exec_cmd git apply "$patch_path"
+  rm -f "$patch_path"
+}

scripts/install

@@ -134,8 +134,7 @@ if [[ "$ssoenabled" = "0" ]]; then
     exec_cmd php mud.php config --xmppwhitelist="$domain"
 else
     ynh_app_setting_set "$app" unprotected_uris "/"
-    # Next line is to avoid SSO to auto-connect just after disconnect
-    sudo sed -i "s@redirect('login')@redirect('')@g" $DESTDIR/app/controllers/DisconnectController.php
+    apply_sso_patch
 fi
 
 # Start Movim

scripts/upgrade

@@ -66,8 +66,7 @@ if [[ "$ssoenabled" =~ ^0|No$ ]]; then
     exec_cmd php mud.php config --xmppwhitelist=$domain
 else
     ynh_app_setting_set "$app" unprotected_uris "/"
-    # Next line is to avoid SSO to auto-connect just after disconnect
-    sudo sed -i "s@redirect('login')@redirect('')@g" $DESTDIR/app/controllers/DisconnectController.php
+    apply_sso_patch
 fi
 
 # Update init scripts