From 2231f5bb4ff8a67f5890c632a9fc30f8b2da9ce3 Mon Sep 17 00:00:00 2001
From: Tagadda <36127788+Tagadda@users.noreply.github.com>
Date: Tue, 1 Feb 2022 18:36:10 +0000
Subject: [PATCH] config: password should be defined even if empty

---
 scripts/install | 2 +-
 scripts/upgrade | 3 +++
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/scripts/install b/scripts/install
index 1cddee6..6644e77 100644
--- a/scripts/install
+++ b/scripts/install
@@ -52,6 +52,7 @@ ynh_app_setting_set --app=$app --key=domain --value=$domain
 ynh_app_setting_set --app=$app --key=path --value=$path_url
 ynh_app_setting_set --app=$app --key=with_mysql --value=$with_mysql
 ynh_app_setting_set --app=$app --key=with_sftp --value=$with_sftp
+ynh_app_setting_set --app=$app --key=password --value="$password"
 ynh_app_setting_set --app=$app --key=final_path --value=$final_path
 ynh_app_setting_set --app=$app --key=phpversion --value=$phpversion
 
@@ -117,7 +118,6 @@ if [ $with_sftp -eq 1 ]
 then
     # Add the password to this user
     chpasswd <<< "${app}:${password}"
-    ynh_app_setting_set --app=$app --key=password --value="$password"
 fi
 
 #=================================================
diff --git a/scripts/upgrade b/scripts/upgrade
index 5f98d6d..fc9a33e 100644
--- a/scripts/upgrade
+++ b/scripts/upgrade
@@ -112,6 +112,9 @@ if ynh_legacy_permissions_exists; then
 	ynh_app_setting_delete --app=$app --key=is_public
 fi
 
+# Ensure password is a setting even if empty, for the config panel
+ynh_app_setting_set --app=$app --key=password --value="$password"
+
 #=================================================
 # ACTIVATE MAINTENANCE MODE
 #=================================================