From 97ea71720be90f69c880cdbfbd91844bbd1f70ca Mon Sep 17 00:00:00 2001
From: Jimmy Monin <jimmy@monin.net>
Date: Tue, 22 Dec 2020 09:26:19 +0100
Subject: [PATCH] Misc linter fixes

---
 scripts/backup  |  2 +-
 scripts/install |  2 +-
 scripts/restore |  4 ++--
 scripts/upgrade | 13 ++++++-------
 4 files changed, 10 insertions(+), 11 deletions(-)

diff --git a/scripts/backup b/scripts/backup
index 9440f6f..72071b5 100644
--- a/scripts/backup
+++ b/scripts/backup
@@ -24,7 +24,7 @@ ynh_abort_if_errors
 #=================================================
 # LOAD SETTINGS
 #=================================================
-ynh_script_progression --message="Loading installation settings..." --weight=1
+ynh_print_info --message="Loading installation settings..."
 
 app=$YNH_APP_INSTANCE_NAME
 
diff --git a/scripts/install b/scripts/install
index 0f7d350..05b7b39 100644
--- a/scripts/install
+++ b/scripts/install
@@ -92,7 +92,7 @@ ynh_add_nginx_config
 # SPECIFIC SETUP
 #=================================================
 
-ynh_script_progression --message="Executing Netdata installer..." --weight=180
+ynh_script_progression --message="Executing Netdata installer..." --weight=30
 
 # create a temporary file for the log
 tmp=$(mktemp /tmp/netdata-updater-log-XXXXXX.log)
diff --git a/scripts/restore b/scripts/restore
index 3e55786..a53d16f 100644
--- a/scripts/restore
+++ b/scripts/restore
@@ -71,7 +71,7 @@ ynh_install_app_dependencies $pkg_dependencies
 # INSTALL AND RESTORE THE APP CONFIGURATION
 #=================================================
 
-ynh_script_progression --message="Reinstalling Netdata..." --weight=180
+ynh_script_progression --message="Reinstalling Netdata..." --weight=30
 
 # Download, check integrity, uncompress and patch the source from app.src
 NETDATA_TMPDIR=$(mktemp -d)
@@ -87,7 +87,7 @@ configure_netdata
 # INTEGRATE SERVICE IN YUNOHOST
 #=================================================
 
-yunohost service add $app --description "A short description of the app" --log "$final_path/var/log/netdata/error.log" "$final_path/var/log/netdata/access.log" "$final_path/var/log/netdata/debug.log"
+yunohost service add $app --description "Real-time performance and health monitoring for systems and applications" --log "$final_path/var/log/netdata/error.log" "$final_path/var/log/netdata/access.log" "$final_path/var/log/netdata/debug.log"
 
 #=================================================
 # START SYSTEMD SERVICE
diff --git a/scripts/upgrade b/scripts/upgrade
index b6ad8ee..ae68f11 100644
--- a/scripts/upgrade
+++ b/scripts/upgrade
@@ -69,13 +69,6 @@ ynh_clean_setup () {
 # Exit if an error occurs during the execution of the script
 ynh_abort_if_errors
 
-#=================================================
-# CHECK THE PATH
-#=================================================
-
-# Normalize the URL path syntax
-path_url=$(ynh_normalize_url_path --path_url=$path_url)
-
 #=================================================
 # STANDARD UPGRADE STEPS
 #=================================================
@@ -141,6 +134,12 @@ ynh_install_app_dependencies $pkg_dependencies
 # GENERIC FINALIZATION
 #=================================================
 
+#=================================================
+# INTEGRATE SERVICE IN YUNOHOST
+#=================================================
+
+yunohost service add $app --description "Real-time performance and health monitoring for systems and applications" --log "$final_path/var/log/netdata/error.log" "$final_path/var/log/netdata/access.log" "$final_path/var/log/netdata/debug.log"
+
 #=================================================
 # SETUP SSOWAT
 #=================================================