From 8cd01bdc8da0de38906e5a3380d12ee8bfa3ca27 Mon Sep 17 00:00:00 2001
From: Jimmy Monin <jimmy@monin.net>
Date: Mon, 28 May 2018 19:30:51 +0200
Subject: [PATCH] Fix failed access after first installation Don't create the
 user data folder (automatically created by Nextcloud), thus avoiding giving
 wrong ownership...

---
 hooks/post_user_create |  1 -
 scripts/install        | 11 ++++-------
 scripts/upgrade        | 11 ++++-------
 3 files changed, 8 insertions(+), 15 deletions(-)

diff --git a/hooks/post_user_create b/hooks/post_user_create
index 24ebf8c..f215f00 100644
--- a/hooks/post_user_create
+++ b/hooks/post_user_create
@@ -2,5 +2,4 @@
 
 user=$1
 
-sudo mkdir -p /home/$user
 sudo setfacl -m g:#GROUP#:rwx /home/$user
diff --git a/scripts/install b/scripts/install
index 6900ed2..0b2aac1 100755
--- a/scripts/install
+++ b/scripts/install
@@ -183,6 +183,10 @@ exec_occ ldap:test-config \'\' \
 if [ $user_home -eq 1 ]; then
     exec_occ app:enable files_external
     create_external_storage "/home/\$user" "Home"
+    # Iterate over users to extend their home folder permissions
+    for u in $(ynh_user_list); do
+        setfacl -m g:$app:rwx "/home/$u" || true
+    done
 fi
 
 #=================================================
@@ -265,13 +269,6 @@ find ${datadir}/ -type d -print0 | xargs -0 chmod 0750
 chmod 640 "${final_path}/config/config.php"
 chmod 755 /home/yunohost.app
 
-# Iterate over users to extend their home folder permissions - for the external
-# storage plugin usage - and create relevant Nextcloud directories
-for u in $(ynh_user_list); do
-    mkdir -p "${datadir}/${u}"
-    setfacl -m g:$app:rwx "/home/$u" || true
-done
-
 #=================================================
 # SETUP LOGROTATE
 #=================================================
diff --git a/scripts/upgrade b/scripts/upgrade
index faeaf86..e1901b8 100755
--- a/scripts/upgrade
+++ b/scripts/upgrade
@@ -271,6 +271,10 @@ if [ $user_home -eq 1 ]; then
     exec_occ files_external:list --output=json \
 	| grep -q '"storage":"\\\\OC\\\\Files\\\\Storage\\\\Local"' \
 	|| create_external_storage "/home/\$user" "Home"
+    # Iterate over users to extend their home folder permissions
+    for u in $(ynh_user_list); do
+      setfacl -m g:$app:rwx "/home/$u" || true
+    done
 fi
 
 #=================================================
@@ -329,13 +333,6 @@ find ${datadir}/ -type d -print0 | xargs -0 chmod 0750
 chmod 640 "${final_path}/config/config.php"
 chmod 755 /home/yunohost.app
 
-# Iterate over users to extend their home folder permissions - for the external
-# storage plugin usage - and create relevant Nextcloud directories
-for u in $(ynh_user_list); do
-    mkdir -p "${datadir}/${u}"
-    setfacl -m g:$app:rwx "/home/$u" || true
-done
-
 #=================================================
 # WARNING ABOUT THIRD-PARTY APPS
 #=================================================