From b5699abe6429837f20806ba90490df52e14808a7 Mon Sep 17 00:00:00 2001 From: SiM Date: Sun, 29 Apr 2018 14:59:22 +0200 Subject: [PATCH 1/2] Fix stdout.log owner --- scripts/install | 1 + scripts/restore | 1 + scripts/upgrade | 1 + 3 files changed, 3 insertions(+) diff --git a/scripts/install b/scripts/install index dc82a57..0dee5b2 100644 --- a/scripts/install +++ b/scripts/install @@ -171,6 +171,7 @@ sudo -u "$app" php "$final_path/admin/migration.php" chown -R root: "$final_path" chown -R "$app": "$final_path/tpl_c" +chown -R "$app": "$final_path/admin/stdout.log" #================================================= # SETUP SSOWAT diff --git a/scripts/restore b/scripts/restore index 0797c91..ff956a9 100644 --- a/scripts/restore +++ b/scripts/restore @@ -73,6 +73,7 @@ ynh_system_user_create "$app" # Set permissions chown -R "$app": "$final_path/tpl_c" +chown -R "$app": "$final_path/admin/stdout.log" #================================================= # RESTORE THE PHP-FPM CONFIGURATION diff --git a/scripts/upgrade b/scripts/upgrade index bc52aa7..ea6424c 100644 --- a/scripts/upgrade +++ b/scripts/upgrade @@ -199,6 +199,7 @@ sudo -u "$app" php "$final_path/admin/migration.php" chown -R root: "$final_path" chown -R "$app": "$final_path/tpl_c" +chown -R "$app": "$final_path/admin/stdout.log" #================================================= # SETUP SSOWAT From e26a6431c6be7c0c0961084aa8e1bed6dbb2c4e9 Mon Sep 17 00:00:00 2001 From: Maniack Crudelis Date: Mon, 28 May 2018 10:54:40 +0200 Subject: [PATCH 2/2] Create pull_request_template.md Duplicated from https://github.com/YunoHost-Apps/searx_ynh/pull/35, merged as a micro decision --- pull_request_template.md | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) create mode 100644 pull_request_template.md diff --git a/pull_request_template.md b/pull_request_template.md new file mode 100644 index 0000000..cac1ac7 --- /dev/null +++ b/pull_request_template.md @@ -0,0 +1,25 @@ +## Problem +- *Description of why you made this PR* + +## Solution +- *And how you fix that* + +## PR Status +- [ ] Code finished. +- [ ] Tested with Package_check. +- [ ] Fix or enhancement tested. +- [ ] Upgrade from last version tested. +- [ ] Can be reviewed and tested. + +## Validation +--- +*Minor decision* +- **Upgrade previous version** : +- [ ] **Code review** : +- [ ] **Approval (LGTM)** : +- [ ] **Approval (LGTM)** : +- **CI succeeded** : +[![Build Status](https://ci-apps-dev.yunohost.org/jenkins/job/opensondage_ynh%20-BRANCH-%20(Official)/badge/icon)](https://ci-apps-dev.yunohost.org/jenkins/job/opensondage_ynh%20-BRANCH-%20(Official)/) *Please replace '-BRANCH-' in this link for a PR from a local branch.* +or +[![Build Status](https://ci-apps-dev.yunohost.org/jenkins/job/opensondage_ynh%20PR-NUM-%20(Official_fork)/badge/icon)](https://ci-apps-dev.yunohost.org/jenkins/job/opensondage_ynh%20PR-NUM-%20(Official_fork)/) *Replace '-NUM-' by the PR number in this link for a PR from a forked repository.* +When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.