From 5a4846801923e7e1d7b6acae67eb54f89775056e Mon Sep 17 00:00:00 2001 From: Yunohost-Bot <> Date: Sat, 31 Aug 2024 01:13:39 +0200 Subject: [PATCH] [autopatch] Automatic patch attempt for helpers 2.1 --- conf/config.example.js | 2 +- doc/.DS_Store | Bin 10244 -> 0 bytes manifest.toml | 4 ++- scripts/_common.sh | 14 +--------- scripts/backup | 21 ++++---------- scripts/change_url | 14 ++-------- scripts/install | 57 +++++++++++++++++-------------------- scripts/remove | 16 ++++------- scripts/restore | 31 ++++++++------------- scripts/upgrade | 62 +++++++++++++++++------------------------ 10 files changed, 81 insertions(+), 140 deletions(-) delete mode 100644 doc/.DS_Store diff --git a/conf/config.example.js b/conf/config.example.js index f4b2adf..7caba80 100644 --- a/conf/config.example.js +++ b/conf/config.example.js @@ -7,5 +7,5 @@ window.owntracks.config = { router: { basePath: "/__PATH__", }, - selectedUser: "__USER__", + selectedUser: "__APP__", }; diff --git a/doc/.DS_Store b/doc/.DS_Store deleted file mode 100644 index 6130ccbc22a1497e4a94fadf18eb7aa96384448c..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 10244 zcmeHMTWl0n7(V~D&>1?&v=q8rcVXosG*G0F76L5W3RFr8-7Vc-pw8}0%h=hOGBdjc z38ut&3HV@CVRnZ^?ev+D0-k0HO2BwRG-48m93U2PCwTh` z9|0c$9|0c$9|0eM$$$XEGF#9s3%9cWT99mKRtjK3f>U|csSa_)E#BilcQYnZ~{D>fY&m3Clp|+8RVKw0^esTG(i zEB3_?SR-*)akEZLv3u!T!m^B1zO1D7>e@)ZT+?isuA-Zo%>r~)LzliT-BhiSn3XkE zhsDOZLB!NA2ag_(sS{FXj^k6-f*EbwJDhjhAt2cJ^4;dNLI?e|K-ljmN z7Y*=4>Cx%woHsi7IzPIfWZ4^^AWo~4rr$S1uBx6{Gi!EjZEbK)ZS}nQ3;N}mDJ4BL zXw!Z-TZU!FjI7o#&v0<`t!c~LZEHCkb<))ixpDn5G*uS`bZF}SF;(L5F#6PtDOjc3 zZA~+K2W?$#9~f{nH%VJa+m>PMwjABnEwg)^wY!hC?rNDIF{|=JY!}3 zvYd6a4h`$lb6N}5h*jNT{vy#RAEo%#eYNu!Em^U;p=opT6-rR4Mw;D~(;Yo!Xq_Xv z>K^D;oU~@DIBz|;rc75K&^24Ef?Iq}SX6LMaGoGXgk(0QAI$3RVP4n5U|5vT3wYMp`S#s@TaG z$5rd4MnT>wcI7xdxpJelNvMK4F`2e98SJ;i)zM%~kiQc4)3)0b$88_h%&}f=6NGMR z*{Z6VDij!4;3=b_DANy&1!O5{#1D!D8Ne&bW8_(Knw%pS$cN+`@*TNOekQ+@o8%vI zi~I`&M3@E=<6{WI$jJ!QLlbO(jj$bd!yaU10=gjuY0zK*hQNg^jKCpy9G-?};5eLs z7vN=h1zv^M;7xcJ&cS=|K70w^!X>y2*Wm{I3V*<#@E4!h0;_lN_k0dFu~eGX-X<0} zd1qFK7^{~~dRG51w%3N2tXQ?SaZ{|of})APjho{M$vDVK#>kf^7h}Mc;GDU*e@mfG zq@{MKc%kGMkX%6tC@}9ui$fuqGLOG5T^5pLz{Mdl>&j(l4S2TI^=K=@b--;6>!gr8 z1u4%Xn>I+2T#jpkTQ_e(>r`Yvw>Gz+mC)5GmZb0hlJ_#XMt&nVApjLf*J_vxAy^Kp zpaD0~ZLkA&LL2PD4KxWoxQX^5T?avjM;T>vjIzhz33w8oLgGFL&%=vw5?+GSNZT{; zI=lgI!&!KT5%>ap1fRlZ@Hu<|7vU=0D57p#p0r%TkEN-bi`%AQnS)P9Fgufk}b@l()oNV%V8dAL0SDh4Fa= zADXD&D3>e*GwMS1>^dG_=yg21C_-I5wb6v-s3%9cL=C2U|7U=I{x95APL5kG|NMWC H&;S1ccZ3tQ diff --git a/manifest.toml b/manifest.toml index 1b090c5..78837e1 100644 --- a/manifest.toml +++ b/manifest.toml @@ -17,7 +17,8 @@ website = "https://owntracks.org/" code = "https://github.com/owntracks/frontend" [integration] -yunohost = ">= 11.2" +yunohost = ">= 11.2.18" +helpers_version = "2.1" architectures = "all" multi_instance = true ldap = false @@ -68,6 +69,7 @@ ram.runtime = "50M" [resources.system_user] [resources.install_dir] + group = "www-data:r-x" [resources.data_dir] diff --git a/scripts/_common.sh b/scripts/_common.sh index 9195d57..e3290b0 100644 --- a/scripts/_common.sh +++ b/scripts/_common.sh @@ -1,19 +1,7 @@ #!/bin/bash #================================================= -# COMMON VARIABLES +# COMMON VARIABLES AND CUSTOM HELPERS #================================================= nodejs_version=18 - -#================================================= -# PERSONAL HELPERS -#================================================= - -#================================================= -# EXPERIMENTAL HELPERS -#================================================= - -#================================================= -# FUTURE OFFICIAL HELPERS -#================================================= diff --git a/scripts/backup b/scripts/backup index f72b257..b408e6b 100644 --- a/scripts/backup +++ b/scripts/backup @@ -1,42 +1,33 @@ #!/bin/bash -#================================================= -# GENERIC START -#================================================= -# IMPORT GENERIC HELPERS -#================================================= - #Keep this path for calling _common.sh inside the execution's context of backup and restore scripts source ../settings/scripts/_common.sh source /usr/share/yunohost/helpers -#================================================= -# DECLARE DATA AND CONF FILES TO BACKUP -#================================================= -ynh_print_info --message="Declaring files to be backed up..." +ynh_print_info "Declaring files to be backed up..." #================================================= # BACKUP THE APP MAIN DIR #================================================= -ynh_backup --src_path="$install_dir" +ynh_backup "$install_dir" #================================================= # BACKUP THE DATA DIR #================================================= -ynh_backup --src_path="$data_dir" --is_big +ynh_backup "$data_dir" #================================================= # SYSTEM CONFIGURATION #================================================= -ynh_backup --src_path="/etc/nginx/conf.d/$domain.d/$app.conf" +ynh_backup "/etc/nginx/conf.d/$domain.d/$app.conf" -ynh_backup --src_path="/etc/systemd/system/$app.service" +ynh_backup "/etc/systemd/system/$app.service" #================================================= # END OF SCRIPT #================================================= -ynh_print_info --message="Backup script completed for $app. (YunoHost will then actually copy those files to the archive)." +ynh_print_info "Backup script completed for $app. (YunoHost will then actually copy those files to the archive)." diff --git a/scripts/change_url b/scripts/change_url index 6a52cf0..39d37fc 100644 --- a/scripts/change_url +++ b/scripts/change_url @@ -1,25 +1,17 @@ #!/bin/bash -#================================================= -# GENERIC STARTING -#================================================= -# IMPORT GENERIC HELPERS -#================================================= - source _common.sh source /usr/share/yunohost/helpers -#================================================= -# STANDARD MODIFICATIONS #================================================= # MODIFY URL IN NGINX CONF #================================================= -ynh_script_progression --message="Updating NGINX web server configuration..." +ynh_script_progression "Updating NGINX web server configuration..." -ynh_change_url_nginx_config +ynh_config_change_url_nginx #================================================= # END OF SCRIPT #================================================= -ynh_script_progression --message="Change of URL completed for $app" --last +ynh_script_progression "Change of URL completed for $app" diff --git a/scripts/install b/scripts/install index 241f773..dd83b6f 100644 --- a/scripts/install +++ b/scripts/install @@ -1,89 +1,82 @@ #!/bin/bash -#================================================= -# GENERIC START -#================================================= -# IMPORT GENERIC HELPERS -#================================================= - source _common.sh source /usr/share/yunohost/helpers #================================================= # INSTALL DEPENDENCIES #================================================= -ynh_script_progression --message="Installing NodeJS..." --weight=7 +ynh_script_progression "Installing NodeJS..." # Install Nodejs -ynh_exec_warn_less ynh_install_nodejs --nodejs_version=$nodejs_version +ynh_nodejs_install #================================================= # DOWNLOAD, CHECK AND UNPACK SOURCE #================================================= -ynh_script_progression --message="Setting up source files..." +ynh_script_progression "Setting up source files..." # Download, check integrity, uncompress and patch the source from app.src ynh_setup_source --dest_dir="$install_dir/source" -chmod -R o-rwx "$install_dir" -chown -R "$app:www-data" "$install_dir" - +#REMOVEME? Assuming the install dir is setup using ynh_setup_source, the proper chmod/chowns are now already applied and it shouldn't be necessary to tweak perms | chmod -R o-rwx "$install_dir" +#REMOVEME? Assuming the install dir is setup using ynh_setup_source, the proper chmod/chowns are now already applied and it shouldn't be necessary to tweak perms | chown -R "$app:www-data" "$install_dir" #================================================= # INSTALL THE LOUNGE #================================================= -ynh_script_progression --message="Installing $app..." --weight=10 +ynh_script_progression "Installing $app..." pushd "$install_dir/source" - ynh_use_nodejs - ynh_exec_warn_less ynh_exec_as "$app" env "$ynh_node_load_PATH" yarn install - ynh_exec_warn_less ynh_exec_as "$app" env "$ynh_node_load_PATH" NODE_ENV=production yarn build + + ynh_hide_warnings ynh_exec_as_app node_load_PATH" yarn install + ynh_hide_warnings ynh_exec_as_app node_load_PATH" NODE_ENV=production yarn build popd mv "$install_dir/source/dist" "$install_dir/www" -ynh_secure_remove "$install_dir/source" +ynh_safe_rm "$install_dir/source" #================================================= # ADD A CONFIGURATION #================================================= -ynh_script_progression --message="Adding configuration files..." --weight=1 +ynh_script_progression "Adding configuration files..." -ynh_add_config --template="config.example.js" --destination="$install_dir/www/config/config.js" +ynh_config_add --template="config.example.js" --destination="$install_dir/www/config/config.js" -chmod 640 "$install_dir/www/config/config.js" -chown "$app:www-data" "$install_dir/www/config/config.js" +#REMOVEME? Assuming the file is setup using ynh_config_add, the proper chmod/chowns are now already applied and it shouldn't be necessary to tweak perms | chmod 640 "$install_dir/www/config/config.js" +#REMOVEME? Assuming the file is setup using ynh_config_add, the proper chmod/chowns are now already applied and it shouldn't be necessary to tweak perms | chown "$app:www-data" "$install_dir/www/config/config.js" -ynh_add_config --template="env" --destination="$install_dir/.env" +ynh_config_add --template="env" --destination="$install_dir/.env" -chmod 600 "$install_dir/.env" -chown "$app:$app" "$install_dir/.env" +#REMOVEME? Assuming the file is setup using ynh_config_add, the proper chmod/chowns are now already applied and it shouldn't be necessary to tweak perms | chmod 600 "$install_dir/.env" +#REMOVEME? Assuming the file is setup using ynh_config_add, the proper chmod/chowns are now already applied and it shouldn't be necessary to tweak perms | chown "$app:$app" "$install_dir/.env" #================================================= # SYSTEM CONFIGURATION #================================================= -ynh_script_progression --message="Adding system configurations related to $app..." --weight=1 +ynh_script_progression "Adding system configurations related to $app..." # Create a dedicated systemd config -ynh_add_systemd_config +ynh_config_add_systemd # Add log files mkdir -p "/var/log/$app/" -chmod 660 "/var/log/$app/" -chown "$app:$app" "/var/log/$app/" +#REMOVEME? Assuming ynh_config_add_logrotate is called, the proper chmod/chowns are now already applied and it shouldn't be necessary to tweak perms | chmod 660 "/var/log/$app/" +#REMOVEME? Assuming ynh_config_add_logrotate is called, the proper chmod/chowns are now already applied and it shouldn't be necessary to tweak perms | chown "$app:$app" "/var/log/$app/" yunohost service add "$app" --description="Owntracks recorder" --log="/var/log/$app/$app.log" # Create a dedicated nginx config -ynh_add_nginx_config +ynh_config_add_nginx #================================================= # START SYSTEMD SERVICE #================================================= -ynh_script_progression --message="Starting $app's systemd service..." --weight=1 +ynh_script_progression "Starting $app's systemd service..." -ynh_systemd_action --service_name="$app" --action="start" --log_path="/var/log/$app/$app.log" +ynh_systemctl --service="$app" --action="start" #================================================= # END OF SCRIPT #================================================= -ynh_script_progression --message="Installation of $app completed" --last +ynh_script_progression "Installation of $app completed" diff --git a/scripts/remove b/scripts/remove index d902037..6765324 100644 --- a/scripts/remove +++ b/scripts/remove @@ -1,31 +1,25 @@ #!/bin/bash -#================================================= -# GENERIC START -#================================================= -# IMPORT GENERIC HELPERS -#================================================= - source _common.sh source /usr/share/yunohost/helpers #================================================= # REMOVE SYSTEM CONFIGURATIONS #================================================= -ynh_script_progression --message="Removing system configurations related to $app..." --weight=1 +ynh_script_progression "Removing system configurations related to $app..." # Remove the dedicated nginx config -ynh_remove_nginx_config +ynh_config_remove_nginx # Remove NodeJS -ynh_remove_nodejs +ynh_nodejs_remove # Remove service -ynh_systemd_action --service_name="$app" --action="stop" +ynh_systemctl --service="$app" --action="stop" yunohost service remove "$app" #================================================= # END OF SCRIPT #================================================= -ynh_script_progression --message="Removal of $app completed" --last +ynh_script_progression "Removal of $app completed" diff --git a/scripts/restore b/scripts/restore index 725730c..fa105a3 100644 --- a/scripts/restore +++ b/scripts/restore @@ -1,11 +1,5 @@ #!/bin/bash -#================================================= -# GENERIC START -#================================================= -# IMPORT GENERIC HELPERS -#================================================= - #Keep this path for calling _common.sh inside the execution's context of backup and restore scripts source ../settings/scripts/_common.sh source /usr/share/yunohost/helpers @@ -13,39 +7,36 @@ source /usr/share/yunohost/helpers #================================================= # RESTORE THE APP MAIN DIR #================================================= -ynh_script_progression --message="Restoring the app main directory..." +ynh_script_progression "Restoring the app main directory..." -ynh_restore_file --origin_path="$install_dir" - -chmod -R o-rwx "$install_dir" -chown -R $app:www-data "$install_dir" +ynh_restore "$install_dir" +#REMOVEME? Assuming the install dir is setup using ynh_setup_source, the proper chmod/chowns are now already applied and it shouldn't be necessary to tweak perms | chmod -R o-rwx "$install_dir" +#REMOVEME? Assuming the install dir is setup using ynh_setup_source, the proper chmod/chowns are now already applied and it shouldn't be necessary to tweak perms | chown -R $app:www-data "$install_dir" #================================================= # RESTORE SYSTEM CONFIGURATIONS #================================================= -ynh_script_progression --message="Restoring system configurations related to $app..." --weight=1 +ynh_script_progression "Restoring system configurations related to $app..." -ynh_restore_file --origin_path="/etc/nginx/conf.d/$domain.d/$app.conf" +ynh_restore "/etc/nginx/conf.d/$domain.d/$app.conf" -ynh_restore_file --origin_path="/etc/systemd/system/$app.service" +ynh_restore "/etc/systemd/system/$app.service" systemctl unmask "$app.service" --quiet systemctl enable "$app.service" --quiet yunohost service add "$app" --description="Owntracks recorder" --log="/var/log/$app/$app.log" -#================================================= -# GENERIC FINALIZATION #================================================= # RELOAD NGINX AND PHP-FPM #================================================= -ynh_script_progression --message="Reloading NGINX web server..." +ynh_script_progression "Reloading NGINX web server..." -ynh_systemd_action --service_name="$app" --action="start" --log_path="/var/log/$app/$app.log" +ynh_systemctl --service="$app" --action="start" -ynh_systemd_action --service_name=nginx --action=reload +ynh_systemctl --service=nginx --action=reload #================================================= # END OF SCRIPT #================================================= -ynh_script_progression --message="Restoration completed for $app" --last +ynh_script_progression "Restoration completed for $app" diff --git a/scripts/upgrade b/scripts/upgrade index e6c3a80..90cf54d 100644 --- a/scripts/upgrade +++ b/scripts/upgrade @@ -1,89 +1,79 @@ #!/bin/bash -#================================================= -# GENERIC START -#================================================= -# IMPORT GENERIC HELPERS -#================================================= - source _common.sh source /usr/share/yunohost/helpers #================================================= # INSTALL DEPENDENCIES #================================================= -ynh_script_progression --message="Updating NodeJS..." --weight=7 +ynh_script_progression "Updating NodeJS..." # Install Nodejs -ynh_exec_warn_less ynh_install_nodejs --nodejs_version=$nodejs_version +ynh_nodejs_install -#================================================= -# STANDARD UPGRADE STEPS #================================================= # DOWNLOAD, CHECK AND UNPACK SOURCE #================================================= -ynh_script_progression --message="Upgrading source files..." +ynh_script_progression "Upgrading source files..." # Download, check integrity, uncompress and patch the source from app.src -ynh_setup_source --dest_dir="$install_dir/source" --full_replace=1 - -chmod -R o-rwx "$install_dir" -chown -R $app:www-data "$install_dir" +ynh_setup_source --dest_dir="$install_dir/source" --full_replace +#REMOVEME? Assuming the install dir is setup using ynh_setup_source, the proper chmod/chowns are now already applied and it shouldn't be necessary to tweak perms | chmod -R o-rwx "$install_dir" +#REMOVEME? Assuming the install dir is setup using ynh_setup_source, the proper chmod/chowns are now already applied and it shouldn't be necessary to tweak perms | chown -R $app:www-data "$install_dir" #================================================= # INSTALL THE LOUNGE #================================================= -ynh_script_progression --message="Installing $app..." --weight=10 +ynh_script_progression "Installing $app..." # Delete current build -ynh_secure_remove "$install_dir/www" +ynh_safe_rm "$install_dir/www" pushd "$install_dir/source" - ynh_use_nodejs - ynh_exec_warn_less ynh_exec_as "$app" env "$ynh_node_load_PATH" yarn install - ynh_exec_warn_less ynh_exec_as "$app" env "$ynh_node_load_PATH" NODE_ENV=production yarn build + + ynh_hide_warnings ynh_exec_as_app node_load_PATH" yarn install + ynh_hide_warnings ynh_exec_as_app node_load_PATH" NODE_ENV=production yarn build popd mv "$install_dir/source/dist" "$install_dir/www" -ynh_secure_remove "$install_dir/source" +ynh_safe_rm "$install_dir/source" #================================================= # ADD A CONFIGURATION #================================================= -ynh_script_progression --message="Adding configuration files..." --weight=1 +ynh_script_progression "Adding configuration files..." -ynh_add_config --template="config.example.js" --destination="$install_dir/www/config/config.js" +ynh_config_add --template="config.example.js" --destination="$install_dir/www/config/config.js" -chmod -R o-rwx "$install_dir" -chown -R "$app:www-data" "$install_dir" +#REMOVEME? Assuming the install dir is setup using ynh_setup_source, the proper chmod/chowns are now already applied and it shouldn't be necessary to tweak perms | chmod -R o-rwx "$install_dir" +#REMOVEME? Assuming the install dir is setup using ynh_setup_source, the proper chmod/chowns are now already applied and it shouldn't be necessary to tweak perms | chown -R "$app:www-data" "$install_dir" +#REMOVEME? Assuming the file is setup using ynh_config_add, the proper chmod/chowns are now already applied and it shouldn't be necessary to tweak perms | chmod 640 "$install_dir/www/config/config.js" -chmod 640 "$install_dir/www/config/config.js" +ynh_config_add --template="env" --destination="$install_dir/.env" -ynh_add_config --template="env" --destination="$install_dir/.env" - -chmod 600 "$install_dir/.env" -chown "$app:$app" "$install_dir/.env" +#REMOVEME? Assuming the file is setup using ynh_config_add, the proper chmod/chowns are now already applied and it shouldn't be necessary to tweak perms | chmod 600 "$install_dir/.env" +#REMOVEME? Assuming the file is setup using ynh_config_add, the proper chmod/chowns are now already applied and it shouldn't be necessary to tweak perms | chown "$app:$app" "$install_dir/.env" #================================================= # NGINX CONFIGURATION #================================================= -ynh_script_progression --message="Upgrading NGINX web server configuration..." +ynh_script_progression "Upgrading NGINX web server configuration..." # Create a dedicated systemd config -ynh_add_systemd_config +ynh_config_add_systemd # Add log files mkdir -p "/var/log/$app/" -chmod 660 "/var/log/$app/" -chown "$app:$app" "/var/log/$app/" +#REMOVEME? Assuming ynh_config_add_logrotate is called, the proper chmod/chowns are now already applied and it shouldn't be necessary to tweak perms | chmod 660 "/var/log/$app/" +#REMOVEME? Assuming ynh_config_add_logrotate is called, the proper chmod/chowns are now already applied and it shouldn't be necessary to tweak perms | chown "$app:$app" "/var/log/$app/" yunohost service add "$app" --description="Owntracks recorder" --log="/var/log/$app/$app.log" # Create a dedicated nginx config -ynh_add_nginx_config +ynh_config_add_nginx #================================================= # END OF SCRIPT #================================================= -ynh_script_progression --message="Upgrade of $app completed" --last +ynh_script_progression "Upgrade of $app completed"