From d3090c034028272e413a65d1c567444ea7f0e294 Mon Sep 17 00:00:00 2001 From: ericgaspar Date: Sun, 6 Dec 2020 12:00:56 +0100 Subject: [PATCH] Fix linter warnings --- check_process | 4 ---- pull_request_template.md | 9 +++------ scripts/backup | 5 ++++- scripts/upgrade | 6 ------ 4 files changed, 7 insertions(+), 17 deletions(-) diff --git a/check_process b/check_process index f5d6ff9..09c1138 100644 --- a/check_process +++ b/check_process @@ -17,11 +17,7 @@ upgrade=1 from_commit=785706fb2607e95fbc4876e1367a715a6b8543d2 backup_restore=1 multi_instance=1 - incorrect_path=1 change_url=0 -;;; Levels - # If the level 5 (Package linter) is forced to 1. Please add justifications here. - Level 5=auto ;;; Options Email=aymhce@gmail.com Notification=none diff --git a/pull_request_template.md b/pull_request_template.md index 89898f3..7f7b361 100644 --- a/pull_request_template.md +++ b/pull_request_template.md @@ -11,11 +11,8 @@ - [ ] Upgrade from last version tested. - [ ] Can be reviewed and tested. -## Validation +## Package_check results --- -- [ ] **Code review** -- [ ] **Approval (LGTM)** +*If you have access to [App Continuous Integration for packagers](https://yunohost.org/#/packaging_apps_ci) you can provide a link to the package_check results like below, replacing '-NUM-' in this link by the PR number and USERNAME by your username on the ci-apps-dev. Or you provide a screenshot or a pastebin of the results* -- **CI succeeded** : - -When the PR is marked as ready to merge, you have to wait for 3 days before really merging it. +[![Build Status](https://ci-apps-dev.yunohost.org/jenkins/job/REPLACEBYYOURAPP_ynh%20PR-NUM-%20(ericgaspar)/badge/icon)](https://ci-apps-dev.yunohost.org/jenkins/job/REPLACEBYYOURAPP_ynh%20PR-NUM-%20(ericgaspar)/) diff --git a/scripts/backup b/scripts/backup index a93bf68..ea50559 100755 --- a/scripts/backup +++ b/scripts/backup @@ -27,7 +27,10 @@ domain=$(ynh_app_setting_get --app=$app --key=domain) phpversion=$(ynh_app_setting_get --app=$app --key=phpversion) #================================================= -# STANDARD BACKUP STEPS +# DECLARE DATA AND CONF FILES TO BACKUP +#================================================= +ynh_print_info --message="Declaring files to be backed up..." + #================================================= # BACKUP THE APP MAIN DIR #================================================= diff --git a/scripts/upgrade b/scripts/upgrade index b5955b5..78fe0b0 100644 --- a/scripts/upgrade +++ b/scripts/upgrade @@ -52,12 +52,6 @@ ynh_clean_setup () { # Exit if an error occurs during the execution of the script ynh_abort_if_errors -#================================================= -# CHECK THE PATH -#================================================= - -path_url=$(ynh_normalize_url_path --path_url=$path_url) - #================================================= # STANDARD UPGRADE STEPS #=================================================