From 15dd1036c79fe2a479e2bffed9defc1131ebe965 Mon Sep 17 00:00:00 2001
From: OniriCorpe <oniricorpe@disroot.org>
Date: Tue, 13 Feb 2024 02:19:55 +0100
Subject: [PATCH] fix log folder permissions

---
 scripts/install | 9 +++++----
 scripts/restore | 5 +++--
 scripts/upgrade | 2 ++
 3 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/scripts/install b/scripts/install
index f1de79c..c861501 100644
--- a/scripts/install
+++ b/scripts/install
@@ -94,10 +94,11 @@ ynh_add_nginx_config
 
 ### systemd
 
-mkdir -p /var/log/$app
-touch /var/log/$app/$app-api.log
-touch /var/log/$app/$app-proxy.log
-chown -R $app: /var/log/$app
+mkdir -p "/var/log/$app"
+touch "/var/log/$app/$app-api.log"
+touch "/var/log/$app/$app-proxy.log"
+chown -R "$app:" "/var/log/$app"
+chmod 640 "/var/log/$app"
 
 ynh_use_logrotate --logfile="/var/log/$app/$app-api.log"
 ynh_use_logrotate --logfile="/var/log/$app/$app-proxy.log"
diff --git a/scripts/restore b/scripts/restore
index b67a40d..166c7ca 100644
--- a/scripts/restore
+++ b/scripts/restore
@@ -46,8 +46,9 @@ systemctl enable $app-proxy.service --quiet
 #=================================================
 ynh_script_progression --message="Restoring the logrotate configuration..." --weight=1
 
-mkdir -p /var/log/$app
-chown -R $app:root /var/log/$app
+mkdir -p "/var/log/$app"
+chown -R "$app:root" "/var/log/$app"
+chmod 640 "/var/log/$app"
 ynh_restore_file --origin_path="/etc/logrotate.d/$app"
 
 #=================================================
diff --git a/scripts/upgrade b/scripts/upgrade
index 6752d48..ce05276 100644
--- a/scripts/upgrade
+++ b/scripts/upgrade
@@ -17,6 +17,8 @@ upgrade_type=$(ynh_check_app_version_changed)
 # ENSURE DOWNWARD COMPATIBILITY
 #=================================================
 
+chmod 640 "/var/log/$app"
+
 #=================================================
 # STOP SYSTEMD SERVICE
 #=================================================