YunoHost-Apps/pixelfed_ynh
1
0
Fork 0
mirror of https://github.com/YunoHost-Apps/pixelfed_ynh.git synced 2024-09-03 20:06:04 +02:00
Code Issues Activity Actions

Update ApiV1Controller and BookmarkController, fix api differences and allow unbookmarking regardless of relationship

Browse source
This commit is contained in:
Daniel Supernault 2023-02-10 04:06:18 -07:00
parent fe9c604804
commit e343061a13
No known key found for this signature in database
GPG key ID: 0DEF1C662C9033F7
2 changed files with 81 additions and 49 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

50
app/Http/Controllers/Api/ApiV1Controller.php
View file

@ -3018,8 +3018,15 @@ class ApiV1Controller extends Controller
->orderByDesc('id') ->orderByDesc('id')
->cursorPaginate($limit); ->cursorPaginate($limit);
$bookmarks = $bookmarkQuery->map(function($bookmark) { $bookmarks = $bookmarkQuery->map(function($bookmark) use($pid) {
return \App\Services\StatusService::getMastodon($bookmark->status_id); $status = StatusService::getMastodon($bookmark->status_id, false);
if($status) {
$status['bookmarked'] = true;
$status['favourited'] = LikeService::liked($pid, $status['id']);
$status['reblogged'] = ReblogService::get($pid, $status['id']);
}
return $status;
}) })
->filter() ->filter()
->values() ->values()
@ -3057,17 +3064,29 @@ class ApiV1Controller extends Controller
{ {
abort_if(!$request->user(), 403); abort_if(!$request->user(), 403);
$status = Status::whereNull('uri') $status = Status::findOrFail($id);
->whereScope('public') $pid = $request->user()->profile_id;
->findOrFail($id);
abort_if($status->in_reply_to_id || $status->reblog_of_id, 404);
abort_if(!in_array($status->scope, ['public', 'unlisted', 'private']), 404);
abort_if(!in_array($status->type, ['photo','photo:album', 'video', 'video:album', 'photo:video:album']), 404);
if($status->scope == 'private') {
abort_if(
$pid !== $status->profile_id && !FollowerService::follows($pid, $status->profile_id),
404,
'Error: You cannot bookmark private posts from accounts you do not follow.'
);
}
Bookmark::firstOrCreate([ Bookmark::firstOrCreate([
'status_id' => $status->id, 'status_id' => $status->id,
'profile_id' => $request->user()->profile_id 'profile_id' => $pid
]); ]);
BookmarkService::add($request->user()->profile_id, $status->id); BookmarkService::add($pid, $status->id);
$res = StatusService::getMastodon($status->id);
$res = StatusService::getMastodon($status->id, false);
$res['bookmarked'] = true; $res['bookmarked'] = true;
return $this->json($res); return $this->json($res);
@ -3084,19 +3103,22 @@ class ApiV1Controller extends Controller
{ {
abort_if(!$request->user(), 403); abort_if(!$request->user(), 403);
$status = Status::whereNull('uri') $status = Status::findOrFail($id);
->whereScope('public') $pid = $request->user()->profile_id;
->findOrFail($id);
abort_if($status->in_reply_to_id || $status->reblog_of_id, 404);
abort_if(!in_array($status->scope, ['public', 'unlisted', 'private']), 404);
abort_if(!in_array($status->type, ['photo','photo:album', 'video', 'video:album', 'photo:video:album']), 404);
$bookmark = Bookmark::whereStatusId($status->id) $bookmark = Bookmark::whereStatusId($status->id)
->whereProfileId($request->user()->profile_id) ->whereProfileId($pid)
->first(); ->first();
if($bookmark) { if($bookmark) {
BookmarkService::del($request->user()->profile_id, $status->id); BookmarkService::del($pid, $status->id);
$bookmark->delete(); $bookmark->delete();
} }
$res = StatusService::getMastodon($status->id); $res = StatusService::getMastodon($status->id, false);
$res['bookmarked'] = false; $res['bookmarked'] = false;
return $this->json($res); return $this->json($res);

20
app/Http/Controllers/BookmarkController.php
View file

@ -25,14 +25,24 @@ class BookmarkController extends Controller
$profile = Auth::user()->profile; $profile = Auth::user()->profile;
$status = Status::findOrFail($request->input('item')); $status = Status::findOrFail($request->input('item'));
abort_if($status->in_reply_to_id || $status->reblog_of_id, 404);
abort_if(!in_array($status->scope, ['public', 'unlisted', 'private']), 404); abort_if(!in_array($status->scope, ['public', 'unlisted', 'private']), 404);
abort_if(!in_array($status->type, ['photo','photo:album', 'video', 'video:album', 'photo:video:album']), 404);
if($status->scope == 'private') { if($status->scope == 'private') {
abort_if( if($profile->id !== $status->profile_id && !FollowerService::follows($profile->id, $status->profile_id)) {
$profile->id !== $status->profile_id && !FollowerService::follows($profile->id, $status->profile_id), if($exists = Bookmark::whereStatusId($status->id)->whereProfileId($profile->id)->first()) {
404, BookmarkService::del($profile->id, $status->id);
'Error: You cannot bookmark private posts from accounts you do not follow.' $exists->delete();
);
if ($request->ajax()) {
return ['code' => 200, 'msg' => 'Bookmark removed!'];
} else {
return redirect()->back();
}
}
abort(404, 'Error: You cannot bookmark private posts from accounts you do not follow.');
}
} }
$bookmark = Bookmark::firstOrCreate( $bookmark = Bookmark::firstOrCreate(