From d3eb361e055bfde092b28c23c43cba5f0fa06f5e Mon Sep 17 00:00:00 2001 From: yalh76 Date: Thu, 13 Jun 2019 23:53:01 +0200 Subject: [PATCH 1/3] Update pull_request_template.md --- pull_request_template.md | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/pull_request_template.md b/pull_request_template.md index 8b359a8..a24f41a 100644 --- a/pull_request_template.md +++ b/pull_request_template.md @@ -11,13 +11,8 @@ - [ ] Upgrade from last version tested. - [ ] Can be reviewed and tested. -## Validation +## Package_check results --- -- [ ] **Code review** -- [ ] **Approval (LGTM)** -*Code review and approval have to be from a member of @YunoHost/apps group* -- **CI succeeded** : -[![Build Status](https://ci-apps-dev.yunohost.org/jenkins/job/pleroma_ynh%20-BRANCH-/badge/icon)](https://ci-apps-dev.yunohost.org/jenkins/job/pleroma_ynh%20-BRANCH-/) -*Please replace '-BRANCH-' in this link by the name of the branch used.* -*If the PR is from a forked repository. Please provide public results from package_check.* -When the PR is marked as ready to merge, you have to wait for 3 days before really merging it. +*If you have access to [App Continuous Integration for packagers](https://yunohost.org/#/packaging_apps_ci) you can provide a link to the package_check results like below, replacing '-NUM-' in this link by the PR number and USERNAME by your username on the ci-apps-dev. Or you provide a screenshot or a pastebin of the results* + +[![Build Status](https://ci-apps-dev.yunohost.org/jenkins/job/pleroma_ynh%20PR-NUM-%20(USERNAME)/badge/icon)](https://ci-apps-dev.yunohost.org/jenkins/job/pleroma_ynh%20PR-NUM-%20(USERNAME)/) From c7cd7faaeac8f325f0906b128339ef95ba250f04 Mon Sep 17 00:00:00 2001 From: yalh76 Date: Sun, 16 Jun 2019 16:06:57 +0200 Subject: [PATCH 2/3] Update check_process --- check_process | 16 +++------------- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/check_process b/check_process index 176f79e..b898676 100755 --- a/check_process +++ b/check_process @@ -24,23 +24,13 @@ upgrade=1 from_commit=14d3be2f782048e64696cef85f4fb7dff1ab6181 backup_restore=1 multi_instance=1 - incorrect_path=1 + # This test is no longer necessary since the version 2.7 (PR: https://github.com/YunoHost/yunohost/pull/304), you can still do it if your app could be installed with this version. + # incorrect_path=1 port_already_use=0 change_url=0 ;;; Levels - Level 1=auto - Level 2=auto - Level 3=auto -# Level 4: If the app supports LDAP and SSOwat, turn level 4 to '1' and add a link to an issue or a part of your code to show it. -# If the app does not use LDAP nor SSOwat, and can't use them, turn level 4 to 'na' and explain as well. - #https://github.com/YunoHost-Apps/pleroma_ynh/issues/28 - Level 4=na + # If the level 5 (Package linter) is forced to 1. Please add justifications here. Level 5=auto - Level 6=auto - Level 7=auto - Level 8=0 - Level 9=0 - Level 10=0 ;;; Options Email=anmol@datamol.org;yalh@yahoo.com Notification=yes From 9173034edb163c29914847d552b188b307f4927f Mon Sep 17 00:00:00 2001 From: Alexandre Aubin Date: Tue, 25 Jun 2019 21:36:39 +0200 Subject: [PATCH 3/3] Dummy help field to be removed or replaced by an actual help text --- manifest.json | 4 ---- 1 file changed, 4 deletions(-) diff --git a/manifest.json b/manifest.json index 46be036..6b27de1 100755 --- a/manifest.json +++ b/manifest.json @@ -60,10 +60,6 @@ "en": "Set the administrator password", "fr": "Définissez le mot de passe administrateur" }, - "help": { - "en": "Use the help field to add an information for the admin about this question.", - "fr": "Utilisez le champ aide pour ajouter une information à l'intention de l'administrateur à propos de cette question." - }, "example": "Choose a password" }, {