From 5e074f2378a51b84dc6d9a0668bed82eca38719e Mon Sep 17 00:00:00 2001
From: Hemi03 <55916049+Hemi03@users.noreply.github.com>
Date: Tue, 26 Mar 2024 19:15:31 +0100
Subject: [PATCH 01/16] fix: replace broken old settings

---
 scripts/config | 32 ++++++++++++++++----------------
 1 file changed, 16 insertions(+), 16 deletions(-)

diff --git a/scripts/config b/scripts/config
index 8232a73..c28864e 100644
--- a/scripts/config
+++ b/scripts/config
@@ -18,8 +18,8 @@ source /usr/share/yunohost/helpers
 
 ynh_abort_if_errors
 
-datadir=$(ynh_app_setting_get --app=$app --key=datadir)
-final_path=$(ynh_app_setting_get --app=$app --key=final_path)
+data_dir=$(ynh_app_setting_get --app=$app --key=data_dir)
+install_dir=$(ynh_app_setting_get --app=$app --key=install_dir)
 
 #=================================================
 # SPECIFIC GETTERS FOR TOML SHORT KEY
@@ -51,7 +51,7 @@ get__unbrowseable() {
 #=================================================
 set__directories() {
 
-    mkdir -p $final_path/smb.conf.d
+    mkdir -p $install_dir/smb.conf.d
 
     #---------------------------------------------
     # IMPORTANT: setter are trigger only if a change is detected
@@ -64,20 +64,20 @@ set__directories() {
         fi
         
         # Create the directory
-        mkdir -p $datadir/$directory
+        mkdir -p $data_dir/$directory
 
-        chmod 750 "$datadir/$directory"
-        chmod -R o-rwx "$datadir/$directory"
-        chown -R root:root "$datadir/$directory"
-        setfacl -R -m g:samba.$directory:rwx,d:g:samba.$directory:rwx $datadir/$directory
+        chmod 750 "$data_dir/$directory"
+        chmod -R o-rwx "$data_dir/$directory"
+        chown -R root:root "$data_dir/$directory"
+        setfacl -R -m g:samba.$directory:rwx,d:g:samba.$directory:rwx $data_dir/$directory
 
 
         # Add the configuration in /etc/samba/smb.conf if needed
-        cat > $final_path/smb.conf.d/$directory.conf <<END
+        cat > $install_dir/smb.conf.d/$directory.conf <<END
 [$directory]
    comment = $directory
    read only = no
-   path = $datadir/$directory
+   path = $data_dir/$directory
    guest ok = no
    browsable = yes
    valid users = @samba.$directory
@@ -92,23 +92,23 @@ END
     done
 
     # Remove configuration for unlisted directories
-    pushd $final_path/smb.conf.d
+    pushd $install_dir/smb.conf.d
     for $directory in $(ls !(0-global).conf)
     do
         if ! [[ "${directory%.conf}" =~ $(echo "^($(echo $directories | sed s/ /|/g))$") ]]; then
-            ynh_secure_remove "$final_path/smb.conf.d/"
+            ynh_secure_remove "$install_dir/smb.conf.d/"
         fi
     done
     popd
 
-    cat > $final_path/smb.conf <<EOF
+    cat > $install_dir/smb.conf <<EOF
 # ================================================= 
 # DO NOT EDIT THIS FILE
 # EDIT SUBPARTS IN /etc/samba/smb.conf.d
 # =================================================
 
 EOF
-    cat $final_path/smb.conf.d/*.conf >> $final_path/smb.conf
+    cat $install_dir/smb.conf.d/*.conf >> $install_dir/smb.conf
     
 #---------------------------------------------
 # IMPORTANT: to be able to upgrade properly, you have to saved the value in settings too
@@ -123,7 +123,7 @@ set__readonly_dir() {
         if [[ $directory =~ $(echo "^($(echo $readonly_dir | sed s/ /|/g))$") ]]; then
             value="yes"
         fi
-        ynh_write_var_in_file --file=$final_path/smb.conf.d/$directory.conf --key="read only" --value="$value"
+        ynh_write_var_in_file --file=$install_dir/smb.conf.d/$directory.conf --key="read only" --value="$value"
     done
     ynh_app_setting_set $app readonly_dir $readonly_dir
 }
@@ -135,7 +135,7 @@ set__unbrowseable() {
         if [[ $directory =~ $(echo "^($(echo $unbrowseable | sed s/ /|/g))$") ]]; then
             value="no"
         fi
-        ynh_write_var_in_file --file=$final_path/smb.conf.d/$directory.conf --key="browsable" --value="$value"
+        ynh_write_var_in_file --file=$install_dir/smb.conf.d/$directory.conf --key="browsable" --value="$value"
     done
     ynh_app_setting_set $app unbrowseable $unbrowseable
 

From 7d0c433bad5376c79cba5f2416f389c830ddea89 Mon Sep 17 00:00:00 2001
From: Hemi03 <55916049+Hemi03@users.noreply.github.com>
Date: Tue, 26 Mar 2024 19:16:20 +0100
Subject: [PATCH 02/16] fix: old directory name

---
 scripts/install | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/install b/scripts/install
index 3c2b913..4edf583 100755
--- a/scripts/install
+++ b/scripts/install
@@ -14,7 +14,7 @@ source /usr/share/yunohost/helpers
 #=================================================
 ynh_script_progression --message="Storing installation settings..." --weight=1
 
-ynh_app_setting_set --app=$app --key=directories --value=shared
+ynh_app_setting_set --app=$app --key=directories --value=share
 ynh_app_setting_set --app=$app --key=advanced --value=0
 ynh_app_setting_set --app=$app --key=readonly_dir --value=''
 ynh_app_setting_set --app=$app --key=unbrowseable --value=''

From 972b7330670c81d3e199755740bf3ac0114a171b Mon Sep 17 00:00:00 2001
From: Hemi03 <55916049+Hemi03@users.noreply.github.com>
Date: Tue, 26 Mar 2024 22:21:24 +0100
Subject: [PATCH 03/16] fix: old service name

---
 config_panel.toml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/config_panel.toml b/config_panel.toml
index 868ea8b..b1201cc 100644
--- a/config_panel.toml
+++ b/config_panel.toml
@@ -2,7 +2,7 @@ version = "1.0"
 
 [main]
 name = "shared directory"
-services = ["samba"]
+services = ["smbd"]
 
 [main.main]
 	name = ""

From a424b1ff1f90dde6e4cc7636aa8da3964f19a811 Mon Sep 17 00:00:00 2001
From: Hemi03 <55916049+Hemi03@users.noreply.github.com>
Date: Tue, 26 Mar 2024 23:08:45 +0100
Subject: [PATCH 04/16] fix: could not iterate list

---
 scripts/config | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/scripts/config b/scripts/config
index c28864e..b1cd441 100644
--- a/scripts/config
+++ b/scripts/config
@@ -93,8 +93,7 @@ END
 
     # Remove configuration for unlisted directories
     pushd $install_dir/smb.conf.d
-    for $directory in $(ls !(0-global).conf)
-    do
+    for $directory in $(ls !(0-global).conf); do
         if ! [[ "${directory%.conf}" =~ $(echo "^($(echo $directories | sed s/ /|/g))$") ]]; then
             ynh_secure_remove "$install_dir/smb.conf.d/"
         fi
@@ -118,7 +117,7 @@ EOF
 
 set__readonly_dir() {
     local value
-    for directory in $directories; do
+    for directory in $(echo $directories | sed "s/,/ /g"); do
         value="no"
         if [[ $directory =~ $(echo "^($(echo $readonly_dir | sed s/ /|/g))$") ]]; then
             value="yes"
@@ -130,7 +129,7 @@ set__readonly_dir() {
 
 set__unbrowseable() {
     local value
-    for directory in $directories; do
+    for directory in $(echo $directories | sed "s/,/ /g"); do
         value="yes"
         if [[ $directory =~ $(echo "^($(echo $unbrowseable | sed s/ /|/g))$") ]]; then
             value="no"

From a587dfcd4a223218173cbe37cd6319aac1d41499 Mon Sep 17 00:00:00 2001
From: Hemi03 <55916049+Hemi03@users.noreply.github.com>
Date: Wed, 27 Mar 2024 02:07:22 +0100
Subject: [PATCH 05/16] fix: bad sed regex

---
 scripts/config | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/scripts/config b/scripts/config
index b1cd441..769c05d 100644
--- a/scripts/config
+++ b/scripts/config
@@ -94,7 +94,7 @@ END
     # Remove configuration for unlisted directories
     pushd $install_dir/smb.conf.d
     for $directory in $(ls !(0-global).conf); do
-        if ! [[ "${directory%.conf}" =~ $(echo "^($(echo $directories | sed s/ /|/g))$") ]]; then
+        if ! [[ "${directory%.conf}" =~ $(echo "^($(echo $directories | sed 's/,\| /|/g'))$") ]]; then
             ynh_secure_remove "$install_dir/smb.conf.d/"
         fi
     done
@@ -119,7 +119,7 @@ set__readonly_dir() {
     local value
     for directory in $(echo $directories | sed "s/,/ /g"); do
         value="no"
-        if [[ $directory =~ $(echo "^($(echo $readonly_dir | sed s/ /|/g))$") ]]; then
+        if [[ $directory =~ $(echo "^($(echo $readonly_dir | sed 's/,\| /|/g'))$") ]]; then
             value="yes"
         fi
         ynh_write_var_in_file --file=$install_dir/smb.conf.d/$directory.conf --key="read only" --value="$value"
@@ -131,7 +131,7 @@ set__unbrowseable() {
     local value
     for directory in $(echo $directories | sed "s/,/ /g"); do
         value="yes"
-        if [[ $directory =~ $(echo "^($(echo $unbrowseable | sed s/ /|/g))$") ]]; then
+        if [[ $directory =~ $(echo "^($(echo $unbrowseable | sed 's/,\| /|/g'))$") ]]; then
             value="no"
         fi
         ynh_write_var_in_file --file=$install_dir/smb.conf.d/$directory.conf --key="browsable" --value="$value"

From d2a18c0f187fa7940fa960f0906ef069c82085b4 Mon Sep 17 00:00:00 2001
From: Hemi03 <55916049+Hemi03@users.noreply.github.com>
Date: Wed, 27 Mar 2024 03:27:22 +0100
Subject: [PATCH 06/16] fix: syntax issue

---
 scripts/config | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/config b/scripts/config
index 769c05d..499ff35 100644
--- a/scripts/config
+++ b/scripts/config
@@ -93,7 +93,7 @@ END
 
     # Remove configuration for unlisted directories
     pushd $install_dir/smb.conf.d
-    for $directory in $(ls !(0-global).conf); do
+    for directory in $(ls !(0-global).conf); do
         if ! [[ "${directory%.conf}" =~ $(echo "^($(echo $directories | sed 's/,\| /|/g'))$") ]]; then
             ynh_secure_remove "$install_dir/smb.conf.d/"
         fi

From 81a0e8b5ad617a34cd7bb09b5292bd7fdc3bae18 Mon Sep 17 00:00:00 2001
From: Hemi03 <55916049+Hemi03@users.noreply.github.com>
Date: Thu, 28 Mar 2024 23:25:40 +0100
Subject: [PATCH 07/16] fix: broken removal of old configs

---
 scripts/config | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/scripts/config b/scripts/config
index 499ff35..0f6d1dc 100644
--- a/scripts/config
+++ b/scripts/config
@@ -92,13 +92,11 @@ END
     done
 
     # Remove configuration for unlisted directories
-    pushd $install_dir/smb.conf.d
-    for directory in $(ls !(0-global).conf); do
+    for directory in $(find $install_dir/smb.conf.d/ -maxdepth 1 -type f -not -name '0-global.conf' -exec basename {} \;); do
         if ! [[ "${directory%.conf}" =~ $(echo "^($(echo $directories | sed 's/,\| /|/g'))$") ]]; then
-            ynh_secure_remove "$install_dir/smb.conf.d/"
+            ynh_secure_remove "$install_dir/smb.conf.d/$directory"
         fi
     done
-    popd
 
     cat > $install_dir/smb.conf <<EOF
 # ================================================= 

From 3ae24b6dc9f3b2c55f55fde2be5ad8ffa7fc448f Mon Sep 17 00:00:00 2001
From: Hemi03 <55916049+Hemi03@users.noreply.github.com>
Date: Fri, 29 Mar 2024 05:42:41 +0100
Subject: [PATCH 08/16] remove: broken and unesseary

---
 scripts/config | 29 +++--------------------------
 1 file changed, 3 insertions(+), 26 deletions(-)

diff --git a/scripts/config b/scripts/config
index 0f6d1dc..c389875 100644
--- a/scripts/config
+++ b/scripts/config
@@ -1,10 +1,10 @@
 #!/bin/bash
-# In simple cases, you don't need a config script. 
+# In simple cases, you don't need a config script.
 
-# With a simple config_panel.toml, you can write in the app settings, in the 
+# With a simple config_panel.toml, you can write in the app settings, in the
 # upstream config file or replace complete files (logo ...) and restart services.
 
-# The config scripts allows you to go further, to handle specific cases 
+# The config scripts allows you to go further, to handle specific cases
 # (validation of several interdependent fields, specific getter/setter for a value,
 # display dynamic informations or choices, pre-loading of config type .cube... ).
 
@@ -21,30 +21,7 @@ ynh_abort_if_errors
 data_dir=$(ynh_app_setting_get --app=$app --key=data_dir)
 install_dir=$(ynh_app_setting_get --app=$app --key=install_dir)
 
-#=================================================
-# SPECIFIC GETTERS FOR TOML SHORT KEY
-#=================================================
-get__readonly_dir() {
-    local directories=$(ynh_app_setting_get $app directories)
-    if [[ "$directories" == "" ]]
-    then
-        echo "choices: []"
-    else
-        echo "choices:"
-        for directory in $(echo $directories | sed "s/,/ /g")
-        do
-            echo "  $directory: $directory"
-        done
-    fi
-}
 
-get__unbrowseable() {
-    get__readonly_dir
-}
-
-#=================================================
-# SPECIFIC VALIDATORS FOR TOML SHORT KEYS
-#=================================================
 
 #=================================================
 # SPECIFIC SETTERS FOR TOML SHORT KEYS

From 01521816b58acc50c17669ccff14df7ae2389f3a Mon Sep 17 00:00:00 2001
From: Hemi03 <55916049+Hemi03@users.noreply.github.com>
Date: Fri, 29 Mar 2024 05:44:08 +0100
Subject: [PATCH 09/16] fix: write changes in smb.conf.d actualy to config file

---
 scripts/config | 28 ++++++++++++++++++----------
 1 file changed, 18 insertions(+), 10 deletions(-)

diff --git a/scripts/config b/scripts/config
index c389875..ed670c9 100644
--- a/scripts/config
+++ b/scripts/config
@@ -21,6 +21,19 @@ ynh_abort_if_errors
 data_dir=$(ynh_app_setting_get --app=$app --key=data_dir)
 install_dir=$(ynh_app_setting_get --app=$app --key=install_dir)
 
+#=================================================
+# recreate the smb.conf from smb.conf.d
+#=================================================
+write_smb_conf() {
+    cat > $install_dir/smb.conf <<EOF
+# =================================================
+# DO NOT EDIT THIS FILE
+# EDIT SUBPARTS IN /etc/samba/smb.conf.d
+# =================================================
+
+EOF
+    cat $install_dir/smb.conf.d/*.conf >> $install_dir/smb.conf
+}
 
 
 #=================================================
@@ -36,10 +49,10 @@ set__directories() {
     for directory in $(echo $directories | sed "s/,/ /g"); do
 
         # Create yunohost permission
-        if ! ynh_permission_exists --permission=$directory ; then 
+        if ! ynh_permission_exists --permission=$directory ; then
             ynh_permission_create --permission="$directory" --allowed=all_users --show_tile=false
         fi
-        
+
         # Create the directory
         mkdir -p $data_dir/$directory
 
@@ -75,15 +88,8 @@ END
         fi
     done
 
-    cat > $install_dir/smb.conf <<EOF
-# ================================================= 
-# DO NOT EDIT THIS FILE
-# EDIT SUBPARTS IN /etc/samba/smb.conf.d
-# =================================================
+    write_smb_conf
 
-EOF
-    cat $install_dir/smb.conf.d/*.conf >> $install_dir/smb.conf
-    
 #---------------------------------------------
 # IMPORTANT: to be able to upgrade properly, you have to saved the value in settings too
 #---------------------------------------------
@@ -100,6 +106,7 @@ set__readonly_dir() {
         ynh_write_var_in_file --file=$install_dir/smb.conf.d/$directory.conf --key="read only" --value="$value"
     done
     ynh_app_setting_set $app readonly_dir $readonly_dir
+    write_smb_conf
 }
 
 set__unbrowseable() {
@@ -113,6 +120,7 @@ set__unbrowseable() {
     done
     ynh_app_setting_set $app unbrowseable $unbrowseable
 
+    write_smb_conf
 }
 #=================================================
 # GENERIC FINALIZATION

From 36b943fdb80a3c6e123215fc7f1283fc6042f806 Mon Sep 17 00:00:00 2001
From: Hemi03 <55916049+Hemi03@users.noreply.github.com>
Date: Fri, 29 Mar 2024 05:45:14 +0100
Subject: [PATCH 10/16] fix: errors on empty tags line

---
 scripts/config | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/scripts/config b/scripts/config
index ed670c9..55c0d9b 100644
--- a/scripts/config
+++ b/scripts/config
@@ -93,19 +93,19 @@ END
 #---------------------------------------------
 # IMPORTANT: to be able to upgrade properly, you have to saved the value in settings too
 #---------------------------------------------
-    ynh_app_setting_set $app directories $directories
+    ynh_app_setting_set $app directories "$directories"
 }
 
 set__readonly_dir() {
     local value
     for directory in $(echo $directories | sed "s/,/ /g"); do
         value="no"
-        if [[ $directory =~ $(echo "^($(echo $readonly_dir | sed 's/,\| /|/g'))$") ]]; then
+        if [[ -n "$readonly_dir" && $directory =~ $(echo "^($(echo $readonly_dir | sed 's/,\| /|/g'))$") ]]; then
             value="yes"
         fi
         ynh_write_var_in_file --file=$install_dir/smb.conf.d/$directory.conf --key="read only" --value="$value"
     done
-    ynh_app_setting_set $app readonly_dir $readonly_dir
+    ynh_app_setting_set $app readonly_dir "$readonly_dir"
     write_smb_conf
 }
 
@@ -113,15 +113,15 @@ set__unbrowseable() {
     local value
     for directory in $(echo $directories | sed "s/,/ /g"); do
         value="yes"
-        if [[ $directory =~ $(echo "^($(echo $unbrowseable | sed 's/,\| /|/g'))$") ]]; then
+        if [[ -n "$unbrowseable" &&  $directory =~ $(echo "^($(echo $unbrowseable | sed 's/,\| /|/g'))$") ]]; then
             value="no"
         fi
         ynh_write_var_in_file --file=$install_dir/smb.conf.d/$directory.conf --key="browsable" --value="$value"
     done
-    ynh_app_setting_set $app unbrowseable $unbrowseable
-
+    ynh_app_setting_set $app unbrowseable "$unbrowseable"
     write_smb_conf
 }
+
 #=================================================
 # GENERIC FINALIZATION
 #=================================================

From 0ab30e3ac0604910f95abcc94249f91bf535b70b Mon Sep 17 00:00:00 2001
From: Hemi03 <55916049+Hemi03@users.noreply.github.com>
Date: Fri, 29 Mar 2024 05:45:36 +0100
Subject: [PATCH 11/16] fix: error with space in search key

---
 scripts/config | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/config b/scripts/config
index 55c0d9b..16cf9e2 100644
--- a/scripts/config
+++ b/scripts/config
@@ -103,7 +103,7 @@ set__readonly_dir() {
         if [[ -n "$readonly_dir" && $directory =~ $(echo "^($(echo $readonly_dir | sed 's/,\| /|/g'))$") ]]; then
             value="yes"
         fi
-        ynh_write_var_in_file --file=$install_dir/smb.conf.d/$directory.conf --key="read only" --value="$value"
+        ynh_write_var_in_file --file=$install_dir/smb.conf.d/$directory.conf --key=read[[:space:]]only --value="$value"
     done
     ynh_app_setting_set $app readonly_dir "$readonly_dir"
     write_smb_conf

From 9553a6b7cd2a91eba3cf6ee1195a6d6695f4291b Mon Sep 17 00:00:00 2001
From: Hemi03 <55916049+Hemi03@users.noreply.github.com>
Date: Fri, 29 Mar 2024 20:00:29 +0100
Subject: [PATCH 12/16] fix: the config from being overwritten if a new
 directory gets added

---
 scripts/config | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/scripts/config b/scripts/config
index 16cf9e2..55f35ed 100644
--- a/scripts/config
+++ b/scripts/config
@@ -61,9 +61,9 @@ set__directories() {
         chown -R root:root "$data_dir/$directory"
         setfacl -R -m g:samba.$directory:rwx,d:g:samba.$directory:rwx $data_dir/$directory
 
-
-        # Add the configuration in /etc/samba/smb.conf if needed
-        cat > $install_dir/smb.conf.d/$directory.conf <<END
+        # Add the configuration in /etc/samba/smb.conf.d/ if its missing
+        if [ ! -f "$install_dir/smb.conf.d/$directory.conf" ]; then
+            cat > $install_dir/smb.conf.d/$directory.conf <<END
 [$directory]
    comment = $directory
    read only = no
@@ -78,6 +78,7 @@ set__directories() {
    recycle:keeptree = yes
    recycle:versions = yes
 END
+        fi
 
     done
 

From 5ecc23cd0eb1bceaa4de0679115c3a580e988978 Mon Sep 17 00:00:00 2001
From: Hemi03 <55916049+Hemi03@users.noreply.github.com>
Date: Tue, 2 Apr 2024 02:08:03 +0200
Subject: [PATCH 13/16] remove unessary sudo

---
 hooks/post_user_create | 3 +--
 hooks/post_user_update | 2 +-
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/hooks/post_user_create b/hooks/post_user_create
index 51f04ad..29f9c6b 100644
--- a/hooks/post_user_create
+++ b/hooks/post_user_create
@@ -1,6 +1,5 @@
 #!/bin/bash
 
-
 echo "${YNH_USER_PASSWORD}
 ${YNH_USER_PASSWORD}
-" | sudo smbpasswd -a $YNH_USER_USERNAME
+" | smbpasswd -a $YNH_USER_USERNAME
diff --git a/hooks/post_user_update b/hooks/post_user_update
index 0cad18f..be4363b 100644
--- a/hooks/post_user_update
+++ b/hooks/post_user_update
@@ -2,5 +2,5 @@
 
 echo "${YNH_USER_PASSWORD}
 ${YNH_USER_PASSWORD}
-" | sudo smbpasswd -a $YNH_USER_USERNAME
+" | smbpasswd -a $YNH_USER_USERNAME
 

From 1dc311dc17cc6f4ff2303663514152a7f7ce2744 Mon Sep 17 00:00:00 2001
From: Hemi03 <55916049+Hemi03@users.noreply.github.com>
Date: Tue, 2 Apr 2024 02:12:27 +0200
Subject: [PATCH 14/16] add removal of user with pdbedit

---
 hooks/post_user_delete | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hooks/post_user_delete b/hooks/post_user_delete
index 659412d..56dd2c5 100644
--- a/hooks/post_user_delete
+++ b/hooks/post_user_delete
@@ -1,3 +1,3 @@
 #!/bin/bash
 
-user=$1
+pdbedit -x -u $1

From 6fc9430c56b882ca2c662f952457b13793f5bee1 Mon Sep 17 00:00:00 2001
From: yunohost-bot <yunohost@yunohost.org>
Date: Sun, 19 May 2024 19:43:25 +0000
Subject: [PATCH 15/16] Auto-update READMEs

---
 ALL_README.md     |  8 ++++++++
 README.md         | 24 +++++++++++------------
 README_es.md      | 49 +++++++++++++++++++++++++++++++++++++++++++++++
 README_eu.md      | 49 +++++++++++++++++++++++++++++++++++++++++++++++
 README_fr.md      | 30 ++++++++++++++---------------
 README_gl.md      | 49 +++++++++++++++++++++++++++++++++++++++++++++++
 README_zh_Hans.md | 49 +++++++++++++++++++++++++++++++++++++++++++++++
 7 files changed, 231 insertions(+), 27 deletions(-)
 create mode 100644 ALL_README.md
 create mode 100644 README_es.md
 create mode 100644 README_eu.md
 create mode 100644 README_gl.md
 create mode 100644 README_zh_Hans.md

diff --git a/ALL_README.md b/ALL_README.md
new file mode 100644
index 0000000..8938aae
--- /dev/null
+++ b/ALL_README.md
@@ -0,0 +1,8 @@
+# All available README files by language
+
+- [Read the README in English](README.md)
+- [Lee el README en español](README_es.md)
+- [Irakurri README euskaraz](README_eu.md)
+- [Lire le README en français](README_fr.md)
+- [Le o README en galego](README_gl.md)
+- [阅读中文（简体）的 README](README_zh_Hans.md)
diff --git a/README.md b/README.md
index dfa0d4d..2c7f017 100644
--- a/README.md
+++ b/README.md
@@ -1,5 +1,5 @@
 <!--
-N.B.: This README was automatically generated by https://github.com/YunoHost/apps/tree/master/tools/README-generator
+N.B.: This README was automatically generated by <https://github.com/YunoHost/apps/tree/master/tools/readme_generator>
 It shall NOT be edited by hand.
 -->
 
@@ -9,10 +9,10 @@ It shall NOT be edited by hand.
 
 [![Install Samba with YunoHost](https://install-app.yunohost.org/install-with-yunohost.svg)](https://install-app.yunohost.org/?app=samba)
 
-*[Lire ce readme en français.](./README_fr.md)*
+*[Read this README in other languages.](./ALL_README.md)*
 
-> *This package allows you to install Samba quickly and simply on a YunoHost server.
-If you don't have YunoHost, please consult [the guide](https://yunohost.org/#/install) to learn how to install it.*
+> *This package allows you to install Samba quickly and simply on a YunoHost server.*  
+> *If you don't have YunoHost, please consult [the guide](https://yunohost.org/install) to learn how to install it.*
 
 ## Overview
 
@@ -28,19 +28,19 @@ This package allows you to create directories reachable on a private network.
 **Shipped version:** 4.13.13~ynh2
 ## Documentation and resources
 
-* Official app website: <https://www.samba.org/>
-* Official admin documentation: <https://www.samba.org/samba/docs/>
-* Upstream app code repository: <https://git.samba.org/?p=samba.git;a=summary>
-* YunoHost Store: <https://apps.yunohost.org/app/samba>
-* Report a bug: <https://github.com/YunoHost-Apps/samba_ynh/issues>
+- Official app website: <https://www.samba.org/>
+- Official admin documentation: <https://www.samba.org/samba/docs/>
+- Upstream app code repository: <https://git.samba.org/?p=samba.git;a=summary>
+- YunoHost Store: <https://apps.yunohost.org/app/samba>
+- Report a bug: <https://github.com/YunoHost-Apps/samba_ynh/issues>
 
 ## Developer info
 
-Please send your pull request to the [testing branch](https://github.com/YunoHost-Apps/samba_ynh/tree/testing).
+Please send your pull request to the [`testing` branch](https://github.com/YunoHost-Apps/samba_ynh/tree/testing).
 
-To try the testing branch, please proceed like that.
+To try the `testing` branch, please proceed like that:
 
-``` bash
+```bash
 sudo yunohost app install https://github.com/YunoHost-Apps/samba_ynh/tree/testing --debug
 or
 sudo yunohost app upgrade samba -u https://github.com/YunoHost-Apps/samba_ynh/tree/testing --debug
diff --git a/README_es.md b/README_es.md
new file mode 100644
index 0000000..9772bee
--- /dev/null
+++ b/README_es.md
@@ -0,0 +1,49 @@
+<!--
+Este archivo README esta generado automaticamente<https://github.com/YunoHost/apps/tree/master/tools/readme_generator>
+No se debe editar a mano.
+-->
+
+# Samba para Yunohost
+
+[![Nivel de integración](https://dash.yunohost.org/integration/samba.svg)](https://dash.yunohost.org/appci/app/samba) ![Estado funcional](https://ci-apps.yunohost.org/ci/badges/samba.status.svg) ![Estado En Mantención](https://ci-apps.yunohost.org/ci/badges/samba.maintain.svg)
+
+[![Instalar Samba con Yunhost](https://install-app.yunohost.org/install-with-yunohost.svg)](https://install-app.yunohost.org/?app=samba)
+
+*[Leer este README en otros idiomas.](./ALL_README.md)*
+
+> *Este paquete le permite instalarSamba rapidamente y simplement en un servidor YunoHost.*  
+> *Si no tiene YunoHost, visita [the guide](https://yunohost.org/install) para aprender como instalarla.*
+
+## Descripción general
+
+This package allows you to create directories reachable on a private network.
+
+### Features
+
+- Create and name your directories;
+- Configure permissions for your directories thanks to the yunohost permission view;
+- Define readonly directories
+
+
+**Versión actual:** 4.13.13~ynh2
+## Documentaciones y recursos
+
+- Sitio web oficial: <https://www.samba.org/>
+- Documentación administrador oficial: <https://www.samba.org/samba/docs/>
+- Repositorio del código fuente oficial de la aplicación : <https://git.samba.org/?p=samba.git;a=summary>
+- Catálogo YunoHost: <https://apps.yunohost.org/app/samba>
+- Reportar un error: <https://github.com/YunoHost-Apps/samba_ynh/issues>
+
+## Información para desarrolladores
+
+Por favor enviar sus correcciones a la [`branch testing`](https://github.com/YunoHost-Apps/samba_ynh/tree/testing
+
+Para probar la rama `testing`, sigue asÍ:
+
+```bash
+sudo yunohost app install https://github.com/YunoHost-Apps/samba_ynh/tree/testing --debug
+o
+sudo yunohost app upgrade samba -u https://github.com/YunoHost-Apps/samba_ynh/tree/testing --debug
+```
+
+**Mas informaciones sobre el empaquetado de aplicaciones:** <https://yunohost.org/packaging_apps>
diff --git a/README_eu.md b/README_eu.md
new file mode 100644
index 0000000..e729211
--- /dev/null
+++ b/README_eu.md
@@ -0,0 +1,49 @@
+<!--
+Ohart ongi: README hau automatikoki sortu da <https://github.com/YunoHost/apps/tree/master/tools/readme_generator>ri esker
+EZ editatu eskuz.
+-->
+
+# Samba YunoHost-erako
+
+[![Integrazio maila](https://dash.yunohost.org/integration/samba.svg)](https://dash.yunohost.org/appci/app/samba) ![Funtzionamendu egoera](https://ci-apps.yunohost.org/ci/badges/samba.status.svg) ![Mantentze egoera](https://ci-apps.yunohost.org/ci/badges/samba.maintain.svg)
+
+[![Instalatu Samba YunoHost-ekin](https://install-app.yunohost.org/install-with-yunohost.svg)](https://install-app.yunohost.org/?app=samba)
+
+*[Irakurri README hau beste hizkuntzatan.](./ALL_README.md)*
+
+> *Pakete honek Samba YunoHost zerbitzari batean azkar eta zailtasunik gabe instalatzea ahalbidetzen dizu.*  
+> *YunoHost ez baduzu, kontsultatu [gida](https://yunohost.org/install) nola instalatu ikasteko.*
+
+## Aurreikuspena
+
+This package allows you to create directories reachable on a private network.
+
+### Features
+
+- Create and name your directories;
+- Configure permissions for your directories thanks to the yunohost permission view;
+- Define readonly directories
+
+
+**Paketatutako bertsioa:** 4.13.13~ynh2
+## Dokumentazioa eta baliabideak
+
+- Aplikazioaren webgune ofiziala: <https://www.samba.org/>
+- Administratzaileen dokumentazio ofiziala: <https://www.samba.org/samba/docs/>
+- Jatorrizko aplikazioaren kode-gordailua: <https://git.samba.org/?p=samba.git;a=summary>
+- YunoHost Denda: <https://apps.yunohost.org/app/samba>
+- Eman errore baten berri: <https://github.com/YunoHost-Apps/samba_ynh/issues>
+
+## Garatzaileentzako informazioa
+
+Bidali `pull request`a [`testing` abarrera](https://github.com/YunoHost-Apps/samba_ynh/tree/testing).
+
+`testing` abarra probatzeko, ondorengoa egin:
+
+```bash
+sudo yunohost app install https://github.com/YunoHost-Apps/samba_ynh/tree/testing --debug
+edo
+sudo yunohost app upgrade samba -u https://github.com/YunoHost-Apps/samba_ynh/tree/testing --debug
+```
+
+**Informazio gehiago aplikazioaren paketatzeari buruz:** <https://yunohost.org/packaging_apps>
diff --git a/README_fr.md b/README_fr.md
index abf8dc9..087f8ef 100644
--- a/README_fr.md
+++ b/README_fr.md
@@ -1,6 +1,6 @@
 <!--
-N.B.: This README was automatically generated by https://github.com/YunoHost/apps/tree/master/tools/README-generator
-It shall NOT be edited by hand.
+Nota bene : ce README est automatiquement généré par <https://github.com/YunoHost/apps/tree/master/tools/readme_generator>
+Il NE doit PAS être modifié à la main.
 -->
 
 # Samba pour YunoHost
@@ -9,10 +9,10 @@ It shall NOT be edited by hand.
 
 [![Installer Samba avec YunoHost](https://install-app.yunohost.org/install-with-yunohost.svg)](https://install-app.yunohost.org/?app=samba)
 
-*[Read this readme in english.](./README.md)*
+*[Lire le README dans d'autres langues.](./ALL_README.md)*
 
-> *Ce package vous permet d’installer Samba rapidement et simplement sur un serveur YunoHost.
-Si vous n’avez pas YunoHost, regardez [ici](https://yunohost.org/#/install) pour savoir comment l’installer et en profiter.*
+> *Ce package vous permet d’installer Samba rapidement et simplement sur un serveur YunoHost.*  
+> *Si vous n’avez pas YunoHost, consultez [ce guide](https://yunohost.org/install) pour savoir comment l’installer et en profiter.*
 
 ## Vue d’ensemble
 
@@ -25,25 +25,25 @@ This package allows you to create directories reachable on a private network.
 - Define readonly directories
 
 
-**Version incluse :** 4.13.13~ynh2
+**Version incluse :** 4.13.13~ynh2
 ## Documentations et ressources
 
-* Site officiel de l’app : <https://www.samba.org/>
-* Documentation officielle de l’admin : <https://www.samba.org/samba/docs/>
-* Dépôt de code officiel de l’app : <https://git.samba.org/?p=samba.git;a=summary>
-* YunoHost Store: <https://apps.yunohost.org/app/samba>
-* Signaler un bug : <https://github.com/YunoHost-Apps/samba_ynh/issues>
+- Site officiel de l’app : <https://www.samba.org/>
+- Documentation officielle de l’admin : <https://www.samba.org/samba/docs/>
+- Dépôt de code officiel de l’app : <https://git.samba.org/?p=samba.git;a=summary>
+- YunoHost Store : <https://apps.yunohost.org/app/samba>
+- Signaler un bug : <https://github.com/YunoHost-Apps/samba_ynh/issues>
 
 ## Informations pour les développeurs
 
-Merci de faire vos pull request sur la [branche testing](https://github.com/YunoHost-Apps/samba_ynh/tree/testing).
+Merci de faire vos pull request sur la [branche `testing`](https://github.com/YunoHost-Apps/samba_ynh/tree/testing).
 
-Pour essayer la branche testing, procédez comme suit.
+Pour essayer la branche `testing`, procédez comme suit :
 
-``` bash
+```bash
 sudo yunohost app install https://github.com/YunoHost-Apps/samba_ynh/tree/testing --debug
 ou
 sudo yunohost app upgrade samba -u https://github.com/YunoHost-Apps/samba_ynh/tree/testing --debug
 ```
 
-**Plus d’infos sur le packaging d’applications :** <https://yunohost.org/packaging_apps>
\ No newline at end of file
+**Plus d’infos sur le packaging d’applications :** <https://yunohost.org/packaging_apps>
diff --git a/README_gl.md b/README_gl.md
new file mode 100644
index 0000000..8666a5c
--- /dev/null
+++ b/README_gl.md
@@ -0,0 +1,49 @@
+<!--
+NOTA: Este README foi creado automáticamente por <https://github.com/YunoHost/apps/tree/master/tools/readme_generator>
+NON debe editarse manualmente.
+-->
+
+# Samba para YunoHost
+
+[![Nivel de integración](https://dash.yunohost.org/integration/samba.svg)](https://dash.yunohost.org/appci/app/samba) ![Estado de funcionamento](https://ci-apps.yunohost.org/ci/badges/samba.status.svg) ![Estado de mantemento](https://ci-apps.yunohost.org/ci/badges/samba.maintain.svg)
+
+[![Instalar Samba con YunoHost](https://install-app.yunohost.org/install-with-yunohost.svg)](https://install-app.yunohost.org/?app=samba)
+
+*[Le este README en outros idiomas.](./ALL_README.md)*
+
+> *Este paquete permíteche instalar Samba de xeito rápido e doado nun servidor YunoHost.*  
+> *Se non usas YunoHost, le a [documentación](https://yunohost.org/install) para saber como instalalo.*
+
+## Vista xeral
+
+This package allows you to create directories reachable on a private network.
+
+### Features
+
+- Create and name your directories;
+- Configure permissions for your directories thanks to the yunohost permission view;
+- Define readonly directories
+
+
+**Versión proporcionada:** 4.13.13~ynh2
+## Documentación e recursos
+
+- Web oficial da app: <https://www.samba.org/>
+- Documentación oficial para admin: <https://www.samba.org/samba/docs/>
+- Repositorio de orixe do código: <https://git.samba.org/?p=samba.git;a=summary>
+- Tenda YunoHost: <https://apps.yunohost.org/app/samba>
+- Informar dun problema: <https://github.com/YunoHost-Apps/samba_ynh/issues>
+
+## Info de desenvolvemento
+
+Envía a túa colaboración á [rama `testing`](https://github.com/YunoHost-Apps/samba_ynh/tree/testing).
+
+Para probar a rama `testing`, procede deste xeito:
+
+```bash
+sudo yunohost app install https://github.com/YunoHost-Apps/samba_ynh/tree/testing --debug
+ou
+sudo yunohost app upgrade samba -u https://github.com/YunoHost-Apps/samba_ynh/tree/testing --debug
+```
+
+**Máis info sobre o empaquetado da app:** <https://yunohost.org/packaging_apps>
diff --git a/README_zh_Hans.md b/README_zh_Hans.md
new file mode 100644
index 0000000..b047e55
--- /dev/null
+++ b/README_zh_Hans.md
@@ -0,0 +1,49 @@
+<!--
+注意：此 README 由 <https://github.com/YunoHost/apps/tree/master/tools/readme_generator> 自动生成
+请勿手动编辑。
+-->
+
+# YunoHost 上的 Samba
+
+[![集成程度](https://dash.yunohost.org/integration/samba.svg)](https://dash.yunohost.org/appci/app/samba) ![工作状态](https://ci-apps.yunohost.org/ci/badges/samba.status.svg) ![维护状态](https://ci-apps.yunohost.org/ci/badges/samba.maintain.svg)
+
+[![使用 YunoHost 安装 Samba](https://install-app.yunohost.org/install-with-yunohost.svg)](https://install-app.yunohost.org/?app=samba)
+
+*[阅读此 README 的其它语言版本。](./ALL_README.md)*
+
+> *通过此软件包，您可以在 YunoHost 服务器上快速、简单地安装 Samba。*  
+> *如果您还没有 YunoHost，请参阅[指南](https://yunohost.org/install)了解如何安装它。*
+
+## 概况
+
+This package allows you to create directories reachable on a private network.
+
+### Features
+
+- Create and name your directories;
+- Configure permissions for your directories thanks to the yunohost permission view;
+- Define readonly directories
+
+
+**分发版本：** 4.13.13~ynh2
+## 文档与资源
+
+- 官方应用网站： <https://www.samba.org/>
+- 官方管理文档： <https://www.samba.org/samba/docs/>
+- 上游应用代码库： <https://git.samba.org/?p=samba.git;a=summary>
+- YunoHost 商店： <https://apps.yunohost.org/app/samba>
+- 报告 bug： <https://github.com/YunoHost-Apps/samba_ynh/issues>
+
+## 开发者信息
+
+请向 [`testing` 分支](https://github.com/YunoHost-Apps/samba_ynh/tree/testing) 发送拉取请求。
+
+如要尝试 `testing` 分支，请这样操作：
+
+```bash
+sudo yunohost app install https://github.com/YunoHost-Apps/samba_ynh/tree/testing --debug
+或
+sudo yunohost app upgrade samba -u https://github.com/YunoHost-Apps/samba_ynh/tree/testing --debug
+```
+
+**有关应用打包的更多信息：** <https://yunohost.org/packaging_apps>

From cfba5f7ad3fcda89836e149e00da2d7fcbd18fdb Mon Sep 17 00:00:00 2001
From: yunohost-bot <yunohost@yunohost.org>
Date: Sun, 19 May 2024 19:44:30 +0000
Subject: [PATCH 16/16] Auto-update READMEs

---
 ALL_README.md | 4 +++-
 README.md     | 2 +-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/ALL_README.md b/ALL_README.md
index 3d6c579..8938aae 100644
--- a/ALL_README.md
+++ b/ALL_README.md
@@ -1,6 +1,8 @@
 # All available README files by language
 
 - [Read the README in English](README.md)
+- [Lee el README en español](README_es.md)
+- [Irakurri README euskaraz](README_eu.md)
 - [Lire le README en français](README_fr.md)
 - [Le o README en galego](README_gl.md)
-- [Leggi il “README” in italiano](README_it.md)
+- [阅读中文（简体）的 README](README_zh_Hans.md)
diff --git a/README.md b/README.md
index 7958b48..2c7f017 100644
--- a/README.md
+++ b/README.md
@@ -9,7 +9,7 @@ It shall NOT be edited by hand.
 
 [![Install Samba with YunoHost](https://install-app.yunohost.org/install-with-yunohost.svg)](https://install-app.yunohost.org/?app=samba)
 
-*[Read this README is other languages.](./ALL_README.md)*
+*[Read this README in other languages.](./ALL_README.md)*
 
 > *This package allows you to install Samba quickly and simply on a YunoHost server.*  
 > *If you don't have YunoHost, please consult [the guide](https://yunohost.org/install) to learn how to install it.*