From 5449171f6a5ad82ff9c2130e3ee5218ab3e41543 Mon Sep 17 00:00:00 2001
From: Alexandre Aubin <alexandre.aubin@cern.ch>
Date: Tue, 31 Mar 2020 06:21:55 +0200
Subject: [PATCH] Make the package linter happy : you dun' need sudo because
 you're already root bruh

---
 scripts/_common.sh | 8 ++++----
 scripts/install    | 4 ++--
 scripts/upgrade    | 6 +++---
 3 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/scripts/_common.sh b/scripts/_common.sh
index b6e361d..ac58575 100644
--- a/scripts/_common.sh
+++ b/scripts/_common.sh
@@ -46,7 +46,7 @@ ynh_add_fail2ban_config_temp () {
   ynh_backup_if_checksum_is_different "$finalfail2banjailconf" 1
   ynh_backup_if_checksum_is_different "$finalfail2banfilterconf" 1
   
-  sudo tee $finalfail2banjailconf <<EOF
+  tee $finalfail2banjailconf <<EOF
 [$app]
 enabled = true
 port = $ports
@@ -55,7 +55,7 @@ logpath = $logpath
 maxretry = $max_retry
 EOF
 
-  sudo tee $finalfail2banfilterconf <<EOF
+  tee $finalfail2banfilterconf <<EOF
 [INCLUDES]
 before = common.conf
 [Definition]
@@ -81,7 +81,7 @@ EOF
 ynh_remove_fail2ban_config () {
   ynh_secure_remove "/etc/fail2ban/jail.d/$app.conf"
   ynh_secure_remove "/etc/fail2ban/filter.d/$app.conf"
-  sudo systemctl restart fail2ban
+  systemctl restart fail2ban
 }
 
 ynh_smart_mktemp () {
@@ -107,5 +107,5 @@ ynh_smart_mktemp () {
 		ynh_die "Insufficient free space to continue..."
         fi
 
-        echo "$(sudo mktemp --directory --tmpdir="$tmpdir")"
+        echo "$(mktemp --directory --tmpdir="$tmpdir")"
 }
diff --git a/scripts/install b/scripts/install
index aa7de30..c72e186 100644
--- a/scripts/install
+++ b/scripts/install
@@ -131,8 +131,8 @@ ynh_add_fpm_config
 
 # set proper permissions
 ynh_print_info "Set permissions..."
-find $final_path -type f | xargs sudo chmod 644
-find $final_path -type d | xargs sudo chmod 755
+find $final_path -type f | xargs chmod 644
+find $final_path -type d | xargs chmod 755
 
 # Set right permissions for curl install
 ynh_print_info "Set rights..."
diff --git a/scripts/upgrade b/scripts/upgrade
index 3205547..7a2397e 100644
--- a/scripts/upgrade
+++ b/scripts/upgrade
@@ -88,9 +88,9 @@ ynh_secure_remove "$final_path"
 ynh_print_info "Upgrading source files..."
 # Download, check integrity, uncompress and patch the source from app.src
 ynh_setup_source "$final_path"
-sudo cp -a "$tmpdir/data" "${final_path}/"
-sudo cp -a "$tmpdir/tpl" "${final_path}/"
-sudo rm -Rf "$tmpdir"
+cp -a "$tmpdir/data" "${final_path}/"
+cp -a "$tmpdir/tpl" "${final_path}/"
+rm -Rf "$tmpdir"
 
 #=================================================
 # NGINX CONFIGURATION