Remove custom swap helpers ; use new upstream helpers

manifest.toml

@@ -20,7 +20,8 @@ userdoc = "https://standardnotes.com/help"
 code = "https://github.com/standardnotes/server"
 
 [integration]
-yunohost = ">= 11.2.12"
+yunohost = ">=11.2.30"
+helpers_version = "2.1"
 architectures = "all"
 multi_instance = true
 

scripts/install

@@ -7,7 +7,6 @@
 #=================================================
 
 source _common.sh
-source ynh_add_swap
 source /usr/share/yunohost/helpers
 
 #=================================================
@@ -125,9 +124,7 @@ ynh_add_config --template="cron" --destination="/etc/cron.d/$app"
 chmod 640 "/etc/cron.d/$app"
 chown root: "/etc/cron.d/$app"
 
-if [ "${PACKAGE_CHECK_EXEC:-0}" -eq 0 ]; then
+ynh_add_swap --size="$swap_needed"
-    ynh_add_swap --size="$swap_needed"
-fi
 
 #=================================================
 # START SYSTEMD SERVICE

scripts/remove

@@ -7,7 +7,6 @@
 #=================================================
 
 source _common.sh
-source ynh_add_swap
 source /usr/share/yunohost/helpers
 
 #=================================================
@@ -92,9 +91,7 @@ ynh_secure_remove --file="/var/log/$app"
 #=================================================
 ynh_script_progression --message="Removing swap..."
 
-if [ ${PACKAGE_CHECK_EXEC:-0} -eq 0 ]; then
+ynh_del_swap
-    ynh_del_swap
-fi
 
 #=================================================
 # END OF SCRIPT

scripts/restore

@@ -8,7 +8,6 @@
 
 # Keep this path for calling _common.sh inside the execution's context of backup and restore scripts
 source ../settings/scripts/_common.sh
-source ../settings/scripts/ynh_add_swap
 source /usr/share/yunohost/helpers
 
 redis_db=$(ynh_redis_get_free_db)
@@ -80,9 +79,7 @@ ynh_restore_file --origin_path="/etc/cron.d/$app"
 
 ynh_restore_file --origin_path="/var/log/$app/"
 
-if [ "${PACKAGE_CHECK_EXEC:-0}" -eq 0 ]; then
+ynh_add_swap --size="$swap_needed"
-    ynh_add_swap --size="$swap_needed"
-fi
 
 #=================================================
 # REINSTALL NODEJS

scripts/upgrade

@@ -7,7 +7,6 @@
 #=================================================
 
 source _common.sh
-source ynh_add_swap
 source /usr/share/yunohost/helpers
 
 #=================================================
@@ -202,9 +201,7 @@ ynh_add_config --template="cron" --destination="/etc/cron.d/$app"
 chown root: "/etc/cron.d/$app"
 chmod 640 "/etc/cron.d/$app"
 
-if [ "${PACKAGE_CHECK_EXEC:-0}" -eq 0 ]; then
+ynh_add_swap --size="$swap_needed"
-    ynh_add_swap --size="$swap_needed"
-fi
 
 #=================================================
 # START SYSTEMD SERVICE

scripts/ynh_add_swap

@@ -1,93 +0,0 @@
-#!/bin/bash
-
-# Add swap
-#
-# usage: ynh_add_swap --size=SWAP in Mb
-# | arg: -s, --size= - Amount of SWAP to add in Mb.
-ynh_add_swap () {
-	# Declare an array to define the options of this helper.
-	declare -Ar args_array=( [s]=size= )
-	local size
-	# Manage arguments with getopts
-	ynh_handle_getopts_args "$@"
-
-	local swap_max_size=$(( $size * 1024 ))
-
-	local free_space=$(df --output=avail / | sed 1d)
-	# Because we don't want to fill the disk with a swap file, divide by 2 the available space.
-	local usable_space=$(( $free_space / 2 ))
-
- 	SD_CARD_CAN_SWAP=${SD_CARD_CAN_SWAP:-0}
-
-	# Swap on SD card only if it's is specified
-	if ynh_is_main_device_a_sd_card && [ "$SD_CARD_CAN_SWAP" == "0" ]
-	then
-		ynh_print_warn --message="The main mountpoint of your system '/' is on an SD card, swap will not be added to prevent some damage of this one, but that can cause troubles for the app $app. If you still want activate the swap, you can relaunch the command preceded by 'SD_CARD_CAN_SWAP=1'"
-		return
-	fi
-
-	# Compare the available space with the size of the swap.
-	# And set a acceptable size from the request
-	if [ $usable_space -ge $swap_max_size ]
-	then
-		local swap_size=$swap_max_size
-	elif [ $usable_space -ge $(( $swap_max_size / 2 )) ]
-	then
-		local swap_size=$(( $swap_max_size / 2 ))
-	elif [ $usable_space -ge $(( $swap_max_size / 3 )) ]
-	then
-		local swap_size=$(( $swap_max_size / 3 ))
-	elif [ $usable_space -ge $(( $swap_max_size / 4 )) ]
-	then
-		local swap_size=$(( $swap_max_size / 4 ))
-	else
-		echo "Not enough space left for a swap file" >&2
-		local swap_size=0
-	fi
-
-	# If there's enough space for a swap, and no existing swap here
-	if [ $swap_size -ne 0 ] && [ ! -e /swap_$app ]
-	then
-		# Preallocate space for the swap file, fallocate may sometime not be used, use dd instead in this case
-		if ! fallocate -l ${swap_size}K /swap_$app
-		then
-			dd if=/dev/zero of=/swap_$app bs=1024 count=${swap_size}
-		fi
-		chmod 0600 /swap_$app
-		# Create the swap
-		mkswap /swap_$app
-		# And activate it
-		swapon /swap_$app
-		# Then add an entry in fstab to load this swap at each boot.
-		echo -e "/swap_$app swap swap defaults 0 0 #Swap added by $app" >> /etc/fstab
-	fi
-}
-
-ynh_del_swap () {
-	# If there a swap at this place
-	if [ -e /swap_$app ]
-	then
-		# Clean the fstab
-		sed -i "/#Swap added by $app/d" /etc/fstab
-		# Desactive the swap file
-		swapoff /swap_$app
-		# And remove it
-		rm /swap_$app
-	fi
-}
-
-# Check if the device of the main mountpoint "/" is an SD card
-#
-# [internal]
-#
-# return 0 if it's an SD card, else 1
-ynh_is_main_device_a_sd_card () {
-	local main_device=$(lsblk --output PKNAME --noheadings $(findmnt / --nofsroot --uniq --output source --noheadings --first-only))
-
-	if echo $main_device | grep --quiet "mmc" && [ $(tail -n1 /sys/block/$main_device/queue/rotational) == "0" ]
-	then
-		return 0
-	else
-		return 1
-	fi
-}