From ca6619eb71a8b8591605e602b6a39dcdce77078f Mon Sep 17 00:00:00 2001 From: Nouts Date: Sat, 11 May 2019 14:45:00 +0200 Subject: [PATCH] several improvements from feedback --- README.md | 4 ++-- manifest.json | 6 +++--- scripts/config | 2 ++ scripts/install | 3 ++- scripts/upgrade | 3 ++- 5 files changed, 11 insertions(+), 7 deletions(-) diff --git a/README.md b/README.md index b54d1ba..c5068f9 100644 --- a/README.md +++ b/README.md @@ -41,11 +41,11 @@ If your server name is identical to the domain on which synapse is installed, an If not, you may need to put the following line in the dns configuration: ``` -_matrix._tcp. IN SRV 10 0 +_matrix._tcp. IN SRV 10 0 ``` for example ``` -_matrix._tcp.example.com. 3600 IN SRV 10 0 SYNAPSE_PORT example.com. +_matrix._tcp.example.com. 3600 IN SRV 10 0 SYNAPSE_PORT synapse.example.com. ``` You need to replace SYNAPSE_PORT by the real port. This port can be obtained by the command: `yunohost app setting SYNAPSE_INSTANCE_NAME synapse_tls_port` diff --git a/manifest.json b/manifest.json index 1530096..7e032f5 100644 --- a/manifest.json +++ b/manifest.json @@ -29,14 +29,14 @@ "en": "Choose a domain for Synapse", "fr": "Choisissez un domaine pour Synapse" }, - "example": "matrix.domain.org" + "example": "synapse.domain.org" }, { "name": "server_name", "type": "string", "ask": { - "en": "Choose a name for Matrix accounts", - "fr": "Choisissez un nom pour les comptes Matrix" + "en": "If your synapse domain is a subdomain, you can choose a name for your Synapse server to have your matrix user-ids looking like @user:domain.org instead of @user:synapse.domain.org", + "fr": "Si votre domaine pour synapse est un sous-domaine, vous pouvez choisir un nom pour votre serveur Synapse afin que vos identifiants matrix soient @utilisateur:domain.org plutôt que @utilisateur:synapse.domain.org" }, "example": "domain.org" }, diff --git a/scripts/config b/scripts/config index ea60910..820793b 100644 --- a/scripts/config +++ b/scripts/config @@ -69,6 +69,7 @@ apply_config() { fi domain=$(ynh_app_setting_get $app special_domain) + server_name=$(ynh_app_setting_get $app server_name) synapse_db_pwd=$(ynh_app_setting_get $app synapse_db_pwd) is_public=$(ynh_app_setting_get $app is_public) port=$(ynh_app_setting_get $app synapse_port) @@ -96,6 +97,7 @@ apply_config() { ynh_replace_string __APP__ $app "$homeserver_config_path" ynh_replace_string __DOMAIN__ $domain "$homeserver_config_path" + ynh_replace_string __SERVER_NAME__ $server_name "$homeserver_config_path" ynh_replace_string __SYNAPSE_DB_USER__ $synapse_db_user "$homeserver_config_path" ynh_replace_string __SYNAPSE_DB_PWD__ $synapse_db_pwd "$homeserver_config_path" ynh_replace_string __PORT__ $port "$homeserver_config_path" diff --git a/scripts/install b/scripts/install index 8d20035..f96a4fa 100644 --- a/scripts/install +++ b/scripts/install @@ -57,6 +57,7 @@ test ! -e "$final_path" || ynh_die "This path already contains a folder" # This hack solve the issue : https://github.com/YunoHost-Apps/synapse_ynh/issues/14 ynh_app_setting_set $app special_domain $domain ynh_app_setting_set $app special_path $path_url +ynh_app_setting_set $app server_name $server_name ynh_app_setting_set $app final_path $final_path ynh_app_setting_set $app synapse_version $upstream_version ynh_app_setting_set $app is_public $is_public @@ -179,7 +180,7 @@ PS1=${PS1:-} source $final_path/bin/activate # Generate config -python -m synapse.app.homeserver --keys-directory /etc/matrix-$app/ --generate-config --generate-keys --server-name $domain --report-stats=no -c homeserver.yml +python -m synapse.app.homeserver --keys-directory /etc/matrix-$app/ --generate-config --generate-keys --server-name $server_name --report-stats=no -c homeserver.yml # This function was defined when we called "source $final_path/bin/activate". With this function we undo what "$final_path/bin/activate" does deactivate diff --git a/scripts/upgrade b/scripts/upgrade index fd9e4f4..6ac210b 100644 --- a/scripts/upgrade +++ b/scripts/upgrade @@ -31,6 +31,7 @@ upstream_version=$(ynh_app_upstream_version) #================================================= domain=$(ynh_app_setting_get $app special_domain) +server_name=$(ynh_app_setting_get $app server_name) path_url=$(ynh_app_setting_get $app special_path) final_path=$(ynh_app_setting_get $app final_path) synapse_old_version=$(ynh_app_setting_get $app synapse_version) @@ -126,7 +127,7 @@ then source $final_path/bin/activate # Generate config and keys - python -m synapse.app.homeserver --keys-directory /etc/matrix-$app/ --generate-config --generate-keys --server-name $domain --report-stats=no -c homeserver.yml + python -m synapse.app.homeserver --keys-directory /etc/matrix-$app/ --generate-config --generate-keys --server-name $server_name --report-stats=no -c homeserver.yml # This function was defined when we called "source $final_path/bin/activate". With this function we undo what "$final_path/bin/activate" does deactivate