YunoHost-Apps/transmission_ynh
1
0
Fork 0
mirror of https://github.com/YunoHost-Apps/transmission_ynh.git synced 2024-09-04 01:46:12 +02:00
Code Issues Activity Actions

Also store the password hash on upgrade

Browse source
This commit is contained in:
Félix Piédallu 2023-12-06 11:25:05 +01:00 committed by Salamandar
parent 806bfaf4b4
commit 14bbf2cf49
2 changed files with 23 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
scripts/_common.sh
View file

@ -30,6 +30,27 @@ _wait_and_save_rcp_password_hash() {
return 1
}
_save_and_revert_rpc_password_hash_to_password() {
# This one is tricky :
# * transmission did password -> hash (we want to store hash)
# * user might have overrided other settings, we want to save them
# * we don't want false positives about user editing, so we revert the password change
# * in upgrade script, we will then re-write the saved password hash.
password_hash=$(jq -r '.["rpc-password"]' "$SETTINGS_FILE")
if [[ "$rpcpassword" == "$password_hash" ]]; then
# Upgrade already did this, exiting
return
fi
ynh_app_setting_set --app="$app" --key="rpcpassword" --value="$password_hash"
# Revert the change to maybe prevent ynh_backup_if_checksum_is_different to trigger
sed -i "s|\"${password_hash}\"|\"${rpcpassword}\"|" "$SETTINGS_FILE"
}
#=================================================
# EXPERIMENTAL HELPERS
#=================================================

2
scripts/upgrade
View file

@ -44,6 +44,8 @@ else
path_less="$path"
fi
_save_and_revert_rpc_password_hash_to_password
ynh_add_config --template="../conf/settings.json" --destination="$SETTINGS_FILE"
chmod 400 "$SETTINGS_FILE"