Remove dependency on rsync, use mv instead

manifest.toml

@@ -55,7 +55,7 @@ ram.runtime = "50M"
     [resources.ports]
     websocket.default = 3012
     rocket.default = 8095
-    
+
     [resources.permissions]
     main.url = "/"
     api.url = "/api"
@@ -69,4 +69,4 @@ ram.runtime = "50M"
     admin.show_tile = false
 
     [resources.apt]
-    packages = "libpq5, rsync"
+    packages = "libpq5"

scripts/_common.sh

@@ -15,15 +15,15 @@ _download_vaultwarden_from_docker() {
     # Download, check integrity, uncompress the source of vaultwarden from app.src to his build directory
     docker_arg=""
     # Fixup for armhf
-    if [ $YNH_ARCH == "armhf" ]; then
+    if [ "$YNH_ARCH" == "armhf" ]; then
         docker_arg="--os_arch_variant=linux/arm/v7"
     fi
     ynh_docker_image_extract --dest_dir="$install_dir/build/" --image_spec="$pkg_image:$(ynh_app_upstream_version)" $docker_arg
 
+    # Move files from the extract to the live directory
+    ynh_secure_remove --file="$install_dir/live/"
     mkdir -p "$install_dir/live/"
-
-    mv -f "$install_dir/build/vaultwarden" "$install_dir/live/vaultwarden"
-    rsync -a "$install_dir/build/web-vault/" "$install_dir/live/web-vault/"
+    mv -f "$install_dir/build/"{vaultwarden,web-vault} "$install_dir/live/"
     ynh_secure_remove --file="$install_dir/build"
 
     chmod 750 "$install_dir"