From 4e4baaba22c10c92a761f66de9c841b3fbc1ad36 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=89ric=20Gaspar?= <46165813+ericgaspar@users.noreply.github.com> Date: Thu, 2 Mar 2023 19:15:23 +0100 Subject: [PATCH 01/12] v2 --- conf/nginx.conf | 2 +- manifest.toml | 52 +++++++++++++++++++++++++++++++ scripts/_common.sh | 2 +- scripts/backup | 16 +++++----- scripts/install | 74 ++++++++++++++++++++++---------------------- scripts/remove | 30 +++++++++--------- scripts/restore | 44 +++++++++++++-------------- scripts/upgrade | 76 +++++++++++++++++++++++----------------------- 8 files changed, 174 insertions(+), 122 deletions(-) create mode 100644 manifest.toml diff --git a/conf/nginx.conf b/conf/nginx.conf index a11bfb8..d49334a 100644 --- a/conf/nginx.conf +++ b/conf/nginx.conf @@ -1,7 +1,7 @@ location / { # Path to source - alias __FINALPATH__/; + alias __INSTALL_DIR__/; try_files $uri $uri/ /; diff --git a/manifest.toml b/manifest.toml new file mode 100644 index 0000000..a2dc4db --- /dev/null +++ b/manifest.toml @@ -0,0 +1,52 @@ +packaging_format = 2 + +id = "vikunja" +name = "Vikunja" +description.en = "Self-hosted To-Do list application" +description.fr = "Application de liste de tâches auto-hébergée" + +version = "0.20.2~ynh1" + +maintainers = ["eric_G"] + +[upstream] +license = "GPL-3.0" +website = "https://vikunja.io/" +demo = "https://try.vikunja.io/login" +admindoc = "https://vikunja.io/docs/" +code = "https://kolaente.dev/vikunja/" +cpe = "???" # FIXME: optional but recommended if relevant, this is meant to contain the Common Platform Enumeration, which is sort of a standard id for applications defined by the NIST. In particular, Yunohost may use this is in the future to easily track CVE (=security reports) related to apps. The CPE may be obtained by searching here: https://nvd.nist.gov/products/cpe/search. For example, for Nextcloud, the CPE is 'cpe:2.3:a:nextcloud:nextcloud' (no need to include the version number) +fund = "???" # FIXME: optional but recommended (or remove if irrelevant / not applicable). This is meant to be an URL where people can financially support this app, especially when its development is based on volunteers and/or financed by its community. YunoHost may later advertise it in the webadmin. + +[integration] +yunohost = ">= 11.0.9" +architectures = "all" # FIXME: can be replaced by a list of supported archs using the dpkg --print-architecture nomenclature (amd64/i386/armhf/arm64), for example: ["amd64", "i386"] +multi_instance = true +ldap = "?" # FIXME: replace with true, false, or "not_relevant". Not to confuse with the "sso" key : the "ldap" key corresponds to wether or not a user *can* login on the app using its YunoHost credentials. +sso = "?" # FIXME: replace with true, false, or "not_relevant". Not to confuse with the "ldap" key : the "sso" key corresponds to wether or not a user is *automatically logged-in* on the app when logged-in on the YunoHost portal. +disk = "50M" # FIXME: replace with an **estimate** minimum disk requirement. e.g. 20M, 400M, 1G, ... +ram.build = "50M" # FIXME: replace with an **estimate** minimum ram requirement. e.g. 50M, 400M, 1G, ... +ram.runtime = "50M" # FIXME: replace with an **estimate** minimum ram requirement. e.g. 50M, 400M, 1G, ... + +[install] + [install.domain] + # this is a generic question - ask strings are automatically handled by Yunohost's core + type = "domain" + full_domain = true + + [install.init_main_permission] + help.en = "If enabled, Vikunja will be accessible by people who do not have an account. This can be changed later via the webadmin." + help.fr = "Si cette case est cochée, Vikunja sera accessible aux personnes n’ayant pas de compte. Vous pourrez changer ceci plus tard via la webadmin." + type = "group" + default = "visitors" + +[resources] + [resources.system_user] + + [resources.install_dir] + + [resources.permissions] + main.url = "/" + + [resources.database] + type = "postgresql" diff --git a/scripts/_common.sh b/scripts/_common.sh index b99d9d1..b4e6641 100644 --- a/scripts/_common.sh +++ b/scripts/_common.sh @@ -5,7 +5,7 @@ #================================================= # dependencies used by the app -pkg_dependencies="postgresql" +#REMOVEME? pkg_dependencies="postgresql" #================================================= # PERSONAL HELPERS diff --git a/scripts/backup b/scripts/backup index f8b20e9..8d24919 100644 --- a/scripts/backup +++ b/scripts/backup @@ -14,19 +14,19 @@ source /usr/share/yunohost/helpers #================================================= # Exit if an error occurs during the execution of the script -ynh_abort_if_errors +#REMOVEME? ynh_abort_if_errors #================================================= # LOAD SETTINGS #================================================= -ynh_print_info --message="Loading installation settings..." +#REMOVEME? ynh_print_info --message="Loading installation settings..." -app=$YNH_APP_INSTANCE_NAME +#REMOVEME? app=$YNH_APP_INSTANCE_NAME -final_path=$(ynh_app_setting_get --app=$app --key=final_path) -backend_path=$(ynh_app_setting_get --app=$app --key=backend_path) -domain=$(ynh_app_setting_get --app=$app --key=domain) -db_name=$(ynh_app_setting_get --app=$app --key=db_name) +#REMOVEME? #REMOVEME? install_dir=$(ynh_app_setting_get --app=$app --key=install_dir) +#REMOVEME? backend_path=$(ynh_app_setting_get --app=$app --key=backend_path) +#REMOVEME? domain=$(ynh_app_setting_get --app=$app --key=domain) +#REMOVEME? db_name=$(ynh_app_setting_get --app=$app --key=db_name) #================================================= # DECLARE DATA AND CONF FILES TO BACKUP @@ -38,7 +38,7 @@ ynh_print_info --message="Declaring files to be backed up..." #================================================= # Frontend -ynh_backup --src_path="$final_path" +ynh_backup --src_path="$install_dir" # Backend ynh_backup --src_path="$backend_path" diff --git a/scripts/install b/scripts/install index bc6f118..674b530 100644 --- a/scripts/install +++ b/scripts/install @@ -14,19 +14,19 @@ source /usr/share/yunohost/helpers #================================================= # Exit if an error occurs during the execution of the script -ynh_abort_if_errors +#REMOVEME? ynh_abort_if_errors #================================================= # RETRIEVE ARGUMENTS FROM THE MANIFEST #================================================= -domain=$YNH_APP_ARG_DOMAIN -path_url="/" -is_public=$YNH_APP_ARG_IS_PUBLIC +#REMOVEME? domain=$YNH_APP_ARG_DOMAIN +path="/" +#REMOVEME? is_public=$YNH_APP_ARG_IS_PUBLIC timezone="$(cat /etc/timezone)" secret=$(ynh_string_random --length=32) -app=$YNH_APP_INSTANCE_NAME +#REMOVEME? app=$YNH_APP_INSTANCE_NAME set_motd="" enable_registration="true" @@ -41,22 +41,22 @@ maxitemsperpage=50 #================================================= # CHECK IF THE APP CAN BE INSTALLED WITH THESE ARGS #================================================= -ynh_script_progression --message="Validating installation parameters..." --weight=1 +#REMOVEME? ynh_script_progression --message="Validating installation parameters..." --weight=1 -final_path=/var/www/$app +#REMOVEME? install_dir=/var/www/$app backend_path=/opt/$app -test ! -e "$final_path" || ynh_die --message="This path already contains a folder" +#REMOVEME? test ! -e "$install_dir" || ynh_die --message="This path already contains a folder" # Register (book) web path -ynh_webpath_register --app=$app --domain=$domain --path_url=$path_url +#REMOVEME? ynh_webpath_register --app=$app --domain=$domain --path=$path #================================================= # STORE SETTINGS FROM MANIFEST #================================================= -ynh_script_progression --message="Storing installation settings..." --weight=2 +#REMOVEME? ynh_script_progression --message="Storing installation settings..." --weight=2 -ynh_app_setting_set --app=$app --key=domain --value=$domain -ynh_app_setting_set --app=$app --key=path --value=$path_url +#REMOVEME? ynh_app_setting_set --app=$app --key=domain --value=$domain +#REMOVEME? ynh_app_setting_set --app=$app --key=path --value=$path ynh_app_setting_set --app=$app --key=set_motd --value=$set_motd ynh_app_setting_set --app=$app --key=enable_registration --value=$enable_registration ynh_app_setting_set --app=$app --key=enable_linksharing --value=$enable_linksharing @@ -72,57 +72,57 @@ ynh_app_setting_set --app=$app --key=maxitemsperpage --value=$maxitemsperpage #================================================= # FIND AND OPEN A PORT #================================================= -ynh_script_progression --message="Finding an available port..." --weight=0 +#REMOVEME? ynh_script_progression --message="Finding an available port..." --weight=0 # Find an available port -port=$(ynh_find_port --port=3456) -ynh_app_setting_set --app=$app --key=port --value=$port +#REMOVEME? port=$(ynh_find_port --port=3456) +#REMOVEME? ynh_app_setting_set --app=$app --key=port --value=$port #================================================= # INSTALL DEPENDENCIES #================================================= -ynh_script_progression --message="Installing dependencies..." --weight=20 +#REMOVEME? ynh_script_progression --message="Installing dependencies..." --weight=20 -ynh_exec_warn_less ynh_install_app_dependencies $pkg_dependencies +#REMOVEME? ynh_exec_warn_less ynh_install_app_dependencies $pkg_dependencies #================================================= # CREATE DEDICATED USER #================================================= -ynh_script_progression --message="Configuring system user..." --weight=1 +#REMOVEME? ynh_script_progression --message="Configuring system user..." --weight=1 # Create a system user -ynh_system_user_create --username=$app --home_dir=$final_path +#REMOVEME? ynh_system_user_create --username=$app --home_dir=$install_dir #================================================= # CREATE A POSTGRESQL DATABASE #================================================= -ynh_script_progression --message="Creating a PostgreSQL database..." --weight=2 +#REMOVEME? ynh_script_progression --message="Creating a PostgreSQL database..." --weight=2 -db_name=$(ynh_sanitize_dbid --db_name=$app) -db_user=$db_name -ynh_app_setting_set --app=$app --key=db_name --value=$db_name -ynh_psql_test_if_first_run -ynh_psql_setup_db --db_user=$db_user --db_name=$db_name +#REMOVEME? db_name=$(ynh_sanitize_dbid --db_name=$app) +#REMOVEME? db_user=$db_name +#REMOVEME? ynh_app_setting_set --app=$app --key=db_name --value=$db_name +#REMOVEME? ynh_psql_test_if_first_run +#REMOVEME? ynh_psql_setup_db --db_user=$db_user --db_name=$db_name #================================================= # INSTALL FRONTEND #================================================= ynh_script_progression --message="Setting up frontend..." --weight=1 -ynh_app_setting_set --app=$app --key=final_path --value=$final_path +#REMOVEME? ynh_app_setting_set --app=$app --key=install_dir --value=$install_dir # Download, check integrity, uncompress and patch the source from app.src -ynh_setup_source --dest_dir="$final_path" --source_id="front" +ynh_setup_source --dest_dir="$install_dir" --source_id="front" -chmod 750 "$final_path" -chmod -R o-rwx "$final_path" -chown -R $app:www-data "$final_path" +chmod 750 "$install_dir" +chmod -R o-rwx "$install_dir" +chown -R $app:www-data "$install_dir" #================================================= # INSTALL BACKEND #================================================= ynh_script_progression --message="Setting up backend..." --weight=1 -ynh_app_setting_set --app=$app --key=backend_path --value=$backend_path +#REMOVEME? ynh_app_setting_set --app=$app --key=backend_path --value=$backend_path # Download, check integrity, uncompress and patch the source from app.src mkdir -p "$backend_path" @@ -179,22 +179,22 @@ ynh_systemd_action --service_name=$app --action=start --log_path=systemd #--line #================================================= # SETUP SSOWAT #================================================= -ynh_script_progression --message="Configuring permissions..." --weight=1 +#REMOVEME? ynh_script_progression --message="Configuring permissions..." --weight=1 # Make app public if necessary or protect it -if [ $is_public -eq 1 ] +#REMOVEME? if [ $is_public -eq 1 ] then - ynh_permission_update --permission="main" --add="visitors" +#REMOVEME? ynh_permission_update --permission="main" --add="visitors" fi -ynh_permission_create --permission="api" --url="/api" --allowed="visitors" --auth_header="false" --show_tile="false" --protected="true" +#REMOVEME? ynh_permission_create --permission="api" --url="/api" --allowed="visitors" --auth_header="false" --show_tile="false" --protected="true" #================================================= # RELOAD NGINX #================================================= -ynh_script_progression --message="Reloading NGINX web server..." --weight=2 +#REMOVEME? ynh_script_progression --message="Reloading NGINX web server..." --weight=2 -ynh_systemd_action --service_name=nginx --action=reload +#REMOVEME? ynh_systemd_action --service_name=nginx --action=reload #================================================= # END OF SCRIPT diff --git a/scripts/remove b/scripts/remove index 4c7d338..d8af5b1 100644 --- a/scripts/remove +++ b/scripts/remove @@ -12,16 +12,16 @@ source /usr/share/yunohost/helpers #================================================= # LOAD SETTINGS #================================================= -ynh_script_progression --message="Loading installation settings..." --weight=1 +#REMOVEME? ynh_script_progression --message="Loading installation settings..." --weight=1 -app=$YNH_APP_INSTANCE_NAME +#REMOVEME? app=$YNH_APP_INSTANCE_NAME -domain=$(ynh_app_setting_get --app=$app --key=domain) -port=$(ynh_app_setting_get --app=$app --key=port) -final_path=$(ynh_app_setting_get --app=$app --key=final_path) -backend_path=$(ynh_app_setting_get --app=$app --key=backend_path) -db_name=$(ynh_app_setting_get --app=$app --key=db_name) -db_user=$db_name +#REMOVEME? domain=$(ynh_app_setting_get --app=$app --key=domain) +#REMOVEME? port=$(ynh_app_setting_get --app=$app --key=port) +#REMOVEME? #REMOVEME? install_dir=$(ynh_app_setting_get --app=$app --key=install_dir) +#REMOVEME? backend_path=$(ynh_app_setting_get --app=$app --key=backend_path) +#REMOVEME? db_name=$(ynh_app_setting_get --app=$app --key=db_name) +#REMOVEME? db_user=$db_name #================================================= # STANDARD REMOVE @@ -47,18 +47,18 @@ ynh_remove_systemd_config #================================================= # REMOVE THE POSTGRESQL DATABASE #================================================= -ynh_script_progression --message="Removing the PostgreSQL database..." --weight=2 +#REMOVEME? ynh_script_progression --message="Removing the PostgreSQL database..." --weight=2 # Remove a database if it exists, along with the associated user -ynh_psql_remove_db --db_user=$db_user --db_name=$db_name +#REMOVEME? ynh_psql_remove_db --db_user=$db_user --db_name=$db_name #================================================= # REMOVE DEPENDENCIES #================================================= -ynh_script_progression --message="Removing dependencies..." --weight=1 +#REMOVEME? ynh_script_progression --message="Removing dependencies..." --weight=1 # Remove metapackage and its dependencies -ynh_remove_app_dependencies +#REMOVEME? ynh_remove_app_dependencies #================================================= # REMOVE THE REDIS DATABASE @@ -73,7 +73,7 @@ ynh_redis_remove_db "$redis_db" ynh_script_progression --message="Removing $app main directory..." --weight=6 # Remove the app directory securely -ynh_secure_remove --file="$final_path" +#REMOVEME? ynh_secure_remove --file="$install_dir" # Remove backend ynh_secure_remove --file="$backend_path" @@ -91,10 +91,10 @@ ynh_remove_nginx_config #================================================= # REMOVE DEDICATED USER #================================================= -ynh_script_progression --message="Removing the dedicated system user..." --weight=1 +#REMOVEME? ynh_script_progression --message="Removing the dedicated system user..." --weight=1 # Delete a system user -ynh_system_user_delete --username=$app +#REMOVEME? ynh_system_user_delete --username=$app #================================================= # END OF SCRIPT diff --git a/scripts/restore b/scripts/restore index f1ba73f..c55ceb8 100644 --- a/scripts/restore +++ b/scripts/restore @@ -14,29 +14,29 @@ source /usr/share/yunohost/helpers #================================================= # Exit if an error occurs during the execution of the script -ynh_abort_if_errors +#REMOVEME? ynh_abort_if_errors #================================================= # LOAD SETTINGS #================================================= ynh_script_progression --message="Loading settings..." --weight=1 -app=$YNH_APP_INSTANCE_NAME +#REMOVEME? app=$YNH_APP_INSTANCE_NAME -domain=$(ynh_app_setting_get --app=$app --key=domain) -path_url=$(ynh_app_setting_get --app=$app --key=path) -final_path=$(ynh_app_setting_get --app=$app --key=final_path) -backend_path=$(ynh_app_setting_get --app=$app --key=backend_path) -db_name=$(ynh_app_setting_get --app=$app --key=db_name) -db_user=$db_name -db_pwd=$(ynh_app_setting_get --app=$app --key=psqlpwd) +#REMOVEME? domain=$(ynh_app_setting_get --app=$app --key=domain) +#REMOVEME? path=$(ynh_app_setting_get --app=$app --key=path) +#REMOVEME? #REMOVEME? install_dir=$(ynh_app_setting_get --app=$app --key=install_dir) +#REMOVEME? backend_path=$(ynh_app_setting_get --app=$app --key=backend_path) +#REMOVEME? db_name=$(ynh_app_setting_get --app=$app --key=db_name) +#REMOVEME? db_user=$db_name +#REMOVEME? db_pwd=$(ynh_app_setting_get --app=$app --key=psqlpwd) #================================================= # CHECK IF THE APP CAN BE RESTORED #================================================= -ynh_script_progression --message="Validating restoration parameters..." --weight=2 +#REMOVEME? ynh_script_progression --message="Validating restoration parameters..." --weight=2 -test ! -d $final_path || ynh_die --message="There is already a directory: $final_path " +#REMOVEME? test ! -d $install_dir || ynh_die --message="There is already a directory: $install_dir " #================================================= # STANDARD RESTORATION STEPS @@ -50,10 +50,10 @@ ynh_restore_file --origin_path="/etc/nginx/conf.d/$domain.d/$app.conf" #================================================= # RECREATE THE DEDICATED USER #================================================= -ynh_script_progression --message="Recreating the dedicated system user..." --weight=1 +#REMOVEME? ynh_script_progression --message="Recreating the dedicated system user..." --weight=1 # Create the dedicated user (if not existing) -ynh_system_user_create --username=$app --home_dir="$final_path" +#REMOVEME? ynh_system_user_create --username=$app --home_dir="$install_dir" #================================================= # RESTORE THE APP MAIN DIR @@ -61,10 +61,10 @@ ynh_system_user_create --username=$app --home_dir="$final_path" ynh_script_progression --message="Restoring $app main directory..." --weight=4 # Frontend -ynh_restore_file --origin_path="$final_path" -chmod 750 "$final_path" -chmod -R o-rwx "$final_path" -chown -R $app:www-data "$final_path" +ynh_restore_file --origin_path="$install_dir" +chmod 750 "$install_dir" +chmod -R o-rwx "$install_dir" +chown -R $app:www-data "$install_dir" # Backend ynh_restore_file --origin_path="$backend_path" @@ -74,18 +74,18 @@ chown -R $app:www-data "$backend_path/files" #================================================= # REINSTALL DEPENDENCIES #================================================= -ynh_script_progression --message="Reinstalling dependencies..." --weight=6 +#REMOVEME? ynh_script_progression --message="Reinstalling dependencies..." --weight=6 # Define and install dependencies -ynh_exec_warn_less ynh_install_app_dependencies $pkg_dependencies +#REMOVEME? ynh_exec_warn_less ynh_install_app_dependencies $pkg_dependencies #================================================= # RESTORE THE POSTGRESQL DATABASE #================================================= -ynh_script_progression --message="Restoring the PostgreSQL database..." --weight=6 +#REMOVEME? ynh_script_progression --message="Restoring the PostgreSQL database..." --weight=6 -ynh_psql_test_if_first_run -ynh_psql_setup_db --db_user=$db_user --db_name=$db_name --db_pwd=$db_pwd +#REMOVEME? ynh_psql_test_if_first_run +#REMOVEME? ynh_psql_setup_db --db_user=$db_user --db_name=$db_name --db_pwd=$db_pwd ynh_psql_execute_file_as_root --file="./db.sql" --database=$db_name #================================================= diff --git a/scripts/upgrade b/scripts/upgrade index e5a3e64..64b700f 100644 --- a/scripts/upgrade +++ b/scripts/upgrade @@ -12,30 +12,30 @@ source /usr/share/yunohost/helpers #================================================= # LOAD SETTINGS #================================================= -ynh_script_progression --message="Loading installation settings..." --weight=2 +#REMOVEME? ynh_script_progression --message="Loading installation settings..." --weight=2 -app=$YNH_APP_INSTANCE_NAME +#REMOVEME? app=$YNH_APP_INSTANCE_NAME -domain=$(ynh_app_setting_get --app=$app --key=domain) -path_url=$(ynh_app_setting_get --app=$app --key=path) -final_path=$(ynh_app_setting_get --app=$app --key=final_path) -backend_path=$(ynh_app_setting_get --app=$app --key=backend_path) -port=$(ynh_app_setting_get --app=$app --key=port) -db_name=$(ynh_app_setting_get --app=$app --key=db_name) -db_user=$db_name -db_pwd=$(ynh_app_setting_get --app=$app --key=psqlpwd) +#REMOVEME? domain=$(ynh_app_setting_get --app=$app --key=domain) +#REMOVEME? path=$(ynh_app_setting_get --app=$app --key=path) +#REMOVEME? #REMOVEME? install_dir=$(ynh_app_setting_get --app=$app --key=install_dir) +#REMOVEME? backend_path=$(ynh_app_setting_get --app=$app --key=backend_path) +#REMOVEME? port=$(ynh_app_setting_get --app=$app --key=port) +#REMOVEME? db_name=$(ynh_app_setting_get --app=$app --key=db_name) +#REMOVEME? db_user=$db_name +#REMOVEME? db_pwd=$(ynh_app_setting_get --app=$app --key=psqlpwd) timezone="$(cat /etc/timezone)" secret=$(ynh_string_random --length=32) -set_motd=$(ynh_app_setting_get --app=$app --key=set_motd) -enable_registration=$(ynh_app_setting_get --app=$app --key=enable_registration) -enable_linksharing=$(ynh_app_setting_get --app=$app --key=enable_linksharing) -enable_taskattachments=$(ynh_app_setting_get --app=$app --key=enable_taskattachments) -enable_taskcomments=$(ynh_app_setting_get --app=$app --key=enable_taskcomments) -enable_emailreminders=$(ynh_app_setting_get --app=$app --key=enable_emailreminders) -enable_userdeletion=$(ynh_app_setting_get --app=$app --key=enable_userdeletion) -maxavatarsize=$(ynh_app_setting_get --app=$app --key=maxavatarsize) -maxitemsperpage=$(ynh_app_setting_get --app=$app --key=maxitemsperpage) +#REMOVEME? set_motd=$(ynh_app_setting_get --app=$app --key=set_motd) +#REMOVEME? enable_registration=$(ynh_app_setting_get --app=$app --key=enable_registration) +#REMOVEME? enable_linksharing=$(ynh_app_setting_get --app=$app --key=enable_linksharing) +#REMOVEME? enable_taskattachments=$(ynh_app_setting_get --app=$app --key=enable_taskattachments) +#REMOVEME? enable_taskcomments=$(ynh_app_setting_get --app=$app --key=enable_taskcomments) +#REMOVEME? enable_emailreminders=$(ynh_app_setting_get --app=$app --key=enable_emailreminders) +#REMOVEME? enable_userdeletion=$(ynh_app_setting_get --app=$app --key=enable_userdeletion) +#REMOVEME? maxavatarsize=$(ynh_app_setting_get --app=$app --key=maxavatarsize) +#REMOVEME? maxitemsperpage=$(ynh_app_setting_get --app=$app --key=maxitemsperpage) #================================================= @@ -50,13 +50,13 @@ upgrade_type=$(ynh_check_app_version_changed) ynh_script_progression --message="Backing up $app before upgrading (may take a while)..." --weight=4 # Backup the current version of the app -ynh_backup_before_upgrade -ynh_clean_setup () { +#REMOVEME? ynh_backup_before_upgrade +#REMOVEME? ynh_clean_setup () { # restore it if the upgrade fails - ynh_restore_upgradebackup +#REMOVEME? ynh_restore_upgradebackup } # Exit if an error occurs during the execution of the script -ynh_abort_if_errors +#REMOVEME? ynh_abort_if_errors #================================================= # ENSURE DOWNWARD COMPATIBILITY @@ -66,7 +66,7 @@ ynh_script_progression --message="Ensuring downward compatibility..." --weight=1 # If backend_path doesn't exist, create it if [ -z "$backend_path" ]; then backend_path=/opt/$app - ynh_app_setting_set --app=$app --key=backend_path --value=$backend_path +#REMOVEME? ynh_app_setting_set --app=$app --key=backend_path --value=$backend_path fi if [ -z "$set_motd" ]; then @@ -115,15 +115,15 @@ if [ -z "$maxitemsperpage" ]; then fi # Cleaning legacy permissions -if ynh_legacy_permissions_exists; then - ynh_legacy_permissions_delete_all +#REMOVEME? if ynh_legacy_permissions_exists; then +#REMOVEME? ynh_legacy_permissions_delete_all ynh_app_setting_delete --app=$app --key=is_public fi # Create a permission if needed -if ! ynh_permission_exists --permission="api"; then - ynh_permission_create --permission="api" --url="/api" --allowed="visitors" --auth_header="false" --show_tile="false" --protected="true" +#REMOVEME? if ! ynh_permission_exists --permission="api"; then +#REMOVEME? ynh_permission_create --permission="api" --url="/api" --allowed="visitors" --auth_header="false" --show_tile="false" --protected="true" fi #================================================= @@ -138,10 +138,10 @@ ynh_systemd_action --service_name=$app --action=stop --log_path=systemd #================================================= # CREATE DEDICATED USER #================================================= -ynh_script_progression --message="Making sure dedicated system user exists..." --weight=1 +#REMOVEME? ynh_script_progression --message="Making sure dedicated system user exists..." --weight=1 # Create a dedicated user (if not existing) -ynh_system_user_create --username=$app --home_dir="$final_path" +#REMOVEME? ynh_system_user_create --username=$app --home_dir="$install_dir" #================================================= # DOWNLOAD, CHECK AND UNPACK SOURCE @@ -153,7 +153,7 @@ then # Download, check integrity, uncompress and patch the source from app.src # Frontend - ynh_setup_source --dest_dir="$final_path" --source_id="front" + ynh_setup_source --dest_dir="$install_dir" --source_id="front" # Backend mkdir -p "$backend_path/files" @@ -163,9 +163,9 @@ then cp "$back" "$backend_path/vikunja" fi -chmod 750 "$final_path" -chmod -R o-rwx "$final_path" -chown -R $app:www-data "$final_path" +chmod 750 "$install_dir" +chmod -R o-rwx "$install_dir" +chown -R $app:www-data "$install_dir" chmod +x "$backend_path/vikunja" chown -R $app:www-data "$backend_path/files" @@ -191,9 +191,9 @@ ynh_add_nginx_config #================================================= # UPGRADE DEPENDENCIES #================================================= -ynh_script_progression --message="Upgrading dependencies..." --weight=10 +#REMOVEME? ynh_script_progression --message="Upgrading dependencies..." --weight=10 -ynh_exec_warn_less ynh_install_app_dependencies $pkg_dependencies +#REMOVEME? ynh_exec_warn_less ynh_install_app_dependencies $pkg_dependencies #================================================= # SETUP SYSTEMD @@ -219,9 +219,9 @@ ynh_systemd_action --service_name=$app --action=start --log_path=systemd --line_ #================================================= # RELOAD NGINX #================================================= -ynh_script_progression --message="Reloading NGINX web server..." --weight=1 +#REMOVEME? ynh_script_progression --message="Reloading NGINX web server..." --weight=1 -ynh_systemd_action --service_name=nginx --action=reload +#REMOVEME? ynh_systemd_action --service_name=nginx --action=reload #================================================= # END OF SCRIPT From 2af995bb7cd7de95c015aa2ddfb363ac164c233a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=89ric=20Gaspar?= <46165813+ericgaspar@users.noreply.github.com> Date: Thu, 2 Mar 2023 19:24:51 +0100 Subject: [PATCH 02/12] fix --- doc/{POST_INSTALL.md => ADMIN.md} | 2 +- doc/{POST_INSTALL_fr.md => ADMIN_fr.md} | 2 - manifest.json | 46 -------------- manifest.toml | 25 +++++--- scripts/install | 81 +------------------------ scripts/remove | 43 ------------- scripts/restore | 41 +------------ scripts/upgrade | 70 --------------------- tests.toml | 7 +++ 9 files changed, 25 insertions(+), 292 deletions(-) rename doc/{POST_INSTALL.md => ADMIN.md} (75%) rename doc/{POST_INSTALL_fr.md => ADMIN_fr.md} (63%) delete mode 100644 manifest.json create mode 100644 tests.toml diff --git a/doc/POST_INSTALL.md b/doc/ADMIN.md similarity index 75% rename from doc/POST_INSTALL.md rename to doc/ADMIN.md index 9e5b8ca..d855bd4 100644 --- a/doc/POST_INSTALL.md +++ b/doc/ADMIN.md @@ -3,4 +3,4 @@ You can configure Vikunja with the config panels in the webadmin or by editing this file `/opt/vikunja/config.yml` using the [documentation](https://vikunja.io/docs/config-options/). -The API is accesible with this path: https://domain.ltd/api/v1/docs \ No newline at end of file +The API is accesible with this path: https://__DOMAIN__/api/v1/docs \ No newline at end of file diff --git a/doc/POST_INSTALL_fr.md b/doc/ADMIN_fr.md similarity index 63% rename from doc/POST_INSTALL_fr.md rename to doc/ADMIN_fr.md index 2211d10..b14672d 100644 --- a/doc/POST_INSTALL_fr.md +++ b/doc/ADMIN_fr.md @@ -1,3 +1 @@ -## Configuration - Vous pouvez configurer Vikunja avec les config panels ou en modifiant le fichier `/opt/vikunja/config.yml` en vous aidant de la [documentation](https://vikunja.io/docs/config-options/). \ No newline at end of file diff --git a/manifest.json b/manifest.json deleted file mode 100644 index 515665a..0000000 --- a/manifest.json +++ /dev/null @@ -1,46 +0,0 @@ -{ - "name": "Vikunja", - "id": "vikunja", - "packaging_format": 1, - "description": { - "en": "Self-hosted To-Do list application", - "fr": "Application de liste de tâches auto-hébergée" - }, - "version": "0.20.2~ynh1", - "url": "https://vikunja.io/", - "upstream": { - "license": "GPL-3.0", - "website": "https://vikunja.io/", - "demo": "https://try.vikunja.io/login", - "admindoc": "https://vikunja.io/docs/", - "code": "https://kolaente.dev/vikunja/" - }, - "license": "GPL-3.0", - "maintainer": { - "name": "eric_G" - }, - "requirements": { - "yunohost": ">= 11.0.9" - }, - "multi_instance": true, - "services": [ - "nginx" - ], - "arguments": { - "install" : [ - { - "name": "domain", - "type": "domain" - }, - { - "name": "is_public", - "type": "boolean", - "help": { - "en": "If enabled, Vikunja will be accessible by people who do not have an account. This can be changed later via the webadmin.", - "fr": "Si cette case est cochée, Vikunja sera accessible aux personnes n’ayant pas de compte. Vous pourrez changer ceci plus tard via la webadmin." - }, - "default": true - } - ] - } -} diff --git a/manifest.toml b/manifest.toml index a2dc4db..58dd5ce 100644 --- a/manifest.toml +++ b/manifest.toml @@ -15,22 +15,18 @@ website = "https://vikunja.io/" demo = "https://try.vikunja.io/login" admindoc = "https://vikunja.io/docs/" code = "https://kolaente.dev/vikunja/" -cpe = "???" # FIXME: optional but recommended if relevant, this is meant to contain the Common Platform Enumeration, which is sort of a standard id for applications defined by the NIST. In particular, Yunohost may use this is in the future to easily track CVE (=security reports) related to apps. The CPE may be obtained by searching here: https://nvd.nist.gov/products/cpe/search. For example, for Nextcloud, the CPE is 'cpe:2.3:a:nextcloud:nextcloud' (no need to include the version number) -fund = "???" # FIXME: optional but recommended (or remove if irrelevant / not applicable). This is meant to be an URL where people can financially support this app, especially when its development is based on volunteers and/or financed by its community. YunoHost may later advertise it in the webadmin. [integration] -yunohost = ">= 11.0.9" -architectures = "all" # FIXME: can be replaced by a list of supported archs using the dpkg --print-architecture nomenclature (amd64/i386/armhf/arm64), for example: ["amd64", "i386"] +yunohost = ">= 11.1.12" +architectures = "all" multi_instance = true -ldap = "?" # FIXME: replace with true, false, or "not_relevant". Not to confuse with the "sso" key : the "ldap" key corresponds to wether or not a user *can* login on the app using its YunoHost credentials. -sso = "?" # FIXME: replace with true, false, or "not_relevant". Not to confuse with the "ldap" key : the "sso" key corresponds to wether or not a user is *automatically logged-in* on the app when logged-in on the YunoHost portal. -disk = "50M" # FIXME: replace with an **estimate** minimum disk requirement. e.g. 20M, 400M, 1G, ... -ram.build = "50M" # FIXME: replace with an **estimate** minimum ram requirement. e.g. 50M, 400M, 1G, ... -ram.runtime = "50M" # FIXME: replace with an **estimate** minimum ram requirement. e.g. 50M, 400M, 1G, ... +ldap = false +sso = false +ram.build = "50M" +ram.runtime = "50M" [install] [install.domain] - # this is a generic question - ask strings are automatically handled by Yunohost's core type = "domain" full_domain = true @@ -41,6 +37,8 @@ ram.runtime = "50M" # FIXME: replace with an **estimate** minimum ram requiremen default = "visitors" [resources] + [resources.ports] + [resources.system_user] [resources.install_dir] @@ -48,5 +46,12 @@ ram.runtime = "50M" # FIXME: replace with an **estimate** minimum ram requiremen [resources.permissions] main.url = "/" + api.url = "/api" + api.show_tile = false + api.allowed = "visitors" + + [resources.apt] + packages = "postgresql" + [resources.database] type = "postgresql" diff --git a/scripts/install b/scripts/install index 674b530..0c5cff1 100644 --- a/scripts/install +++ b/scripts/install @@ -9,25 +9,13 @@ source _common.sh source /usr/share/yunohost/helpers -#================================================= -# MANAGE SCRIPT FAILURE -#================================================= - -# Exit if an error occurs during the execution of the script -#REMOVEME? ynh_abort_if_errors - #================================================= # RETRIEVE ARGUMENTS FROM THE MANIFEST #================================================= -#REMOVEME? domain=$YNH_APP_ARG_DOMAIN -path="/" -#REMOVEME? is_public=$YNH_APP_ARG_IS_PUBLIC timezone="$(cat /etc/timezone)" secret=$(ynh_string_random --length=32) -#REMOVEME? app=$YNH_APP_INSTANCE_NAME - set_motd="" enable_registration="true" enable_linksharing="true" @@ -41,22 +29,13 @@ maxitemsperpage=50 #================================================= # CHECK IF THE APP CAN BE INSTALLED WITH THESE ARGS #================================================= -#REMOVEME? ynh_script_progression --message="Validating installation parameters..." --weight=1 -#REMOVEME? install_dir=/var/www/$app backend_path=/opt/$app -#REMOVEME? test ! -e "$install_dir" || ynh_die --message="This path already contains a folder" - -# Register (book) web path -#REMOVEME? ynh_webpath_register --app=$app --domain=$domain --path=$path #================================================= # STORE SETTINGS FROM MANIFEST #================================================= -#REMOVEME? ynh_script_progression --message="Storing installation settings..." --weight=2 -#REMOVEME? ynh_app_setting_set --app=$app --key=domain --value=$domain -#REMOVEME? ynh_app_setting_set --app=$app --key=path --value=$path ynh_app_setting_set --app=$app --key=set_motd --value=$set_motd ynh_app_setting_set --app=$app --key=enable_registration --value=$enable_registration ynh_app_setting_set --app=$app --key=enable_linksharing --value=$enable_linksharing @@ -67,49 +46,11 @@ ynh_app_setting_set --app=$app --key=enable_userdeletion --value=$enable_userdel ynh_app_setting_set --app=$app --key=maxavatarsize --value=$maxavatarsize ynh_app_setting_set --app=$app --key=maxitemsperpage --value=$maxitemsperpage -#================================================= -# STANDARD MODIFICATIONS -#================================================= -# FIND AND OPEN A PORT -#================================================= -#REMOVEME? ynh_script_progression --message="Finding an available port..." --weight=0 - -# Find an available port -#REMOVEME? port=$(ynh_find_port --port=3456) -#REMOVEME? ynh_app_setting_set --app=$app --key=port --value=$port - -#================================================= -# INSTALL DEPENDENCIES -#================================================= -#REMOVEME? ynh_script_progression --message="Installing dependencies..." --weight=20 - -#REMOVEME? ynh_exec_warn_less ynh_install_app_dependencies $pkg_dependencies - -#================================================= -# CREATE DEDICATED USER -#================================================= -#REMOVEME? ynh_script_progression --message="Configuring system user..." --weight=1 - -# Create a system user -#REMOVEME? ynh_system_user_create --username=$app --home_dir=$install_dir - -#================================================= -# CREATE A POSTGRESQL DATABASE -#================================================= -#REMOVEME? ynh_script_progression --message="Creating a PostgreSQL database..." --weight=2 - -#REMOVEME? db_name=$(ynh_sanitize_dbid --db_name=$app) -#REMOVEME? db_user=$db_name -#REMOVEME? ynh_app_setting_set --app=$app --key=db_name --value=$db_name -#REMOVEME? ynh_psql_test_if_first_run -#REMOVEME? ynh_psql_setup_db --db_user=$db_user --db_name=$db_name - #================================================= # INSTALL FRONTEND #================================================= ynh_script_progression --message="Setting up frontend..." --weight=1 -#REMOVEME? ynh_app_setting_set --app=$app --key=install_dir --value=$install_dir # Download, check integrity, uncompress and patch the source from app.src ynh_setup_source --dest_dir="$install_dir" --source_id="front" @@ -122,7 +63,7 @@ chown -R $app:www-data "$install_dir" #================================================= ynh_script_progression --message="Setting up backend..." --weight=1 -#REMOVEME? ynh_app_setting_set --app=$app --key=backend_path --value=$backend_path +ynh_app_setting_set --app=$app --key=backend_path --value=$backend_path # Download, check integrity, uncompress and patch the source from app.src mkdir -p "$backend_path" @@ -176,26 +117,6 @@ ynh_script_progression --message="Starting a systemd service..." --weight=2 # Start a systemd service ynh_systemd_action --service_name=$app --action=start --log_path=systemd #--line_match="server started on" -#================================================= -# SETUP SSOWAT -#================================================= -#REMOVEME? ynh_script_progression --message="Configuring permissions..." --weight=1 - -# Make app public if necessary or protect it -#REMOVEME? if [ $is_public -eq 1 ] -then -#REMOVEME? ynh_permission_update --permission="main" --add="visitors" -fi - -#REMOVEME? ynh_permission_create --permission="api" --url="/api" --allowed="visitors" --auth_header="false" --show_tile="false" --protected="true" - -#================================================= -# RELOAD NGINX -#================================================= -#REMOVEME? ynh_script_progression --message="Reloading NGINX web server..." --weight=2 - -#REMOVEME? ynh_systemd_action --service_name=nginx --action=reload - #================================================= # END OF SCRIPT #================================================= diff --git a/scripts/remove b/scripts/remove index d8af5b1..31c3e17 100644 --- a/scripts/remove +++ b/scripts/remove @@ -9,20 +9,6 @@ source _common.sh source /usr/share/yunohost/helpers -#================================================= -# LOAD SETTINGS -#================================================= -#REMOVEME? ynh_script_progression --message="Loading installation settings..." --weight=1 - -#REMOVEME? app=$YNH_APP_INSTANCE_NAME - -#REMOVEME? domain=$(ynh_app_setting_get --app=$app --key=domain) -#REMOVEME? port=$(ynh_app_setting_get --app=$app --key=port) -#REMOVEME? #REMOVEME? install_dir=$(ynh_app_setting_get --app=$app --key=install_dir) -#REMOVEME? backend_path=$(ynh_app_setting_get --app=$app --key=backend_path) -#REMOVEME? db_name=$(ynh_app_setting_get --app=$app --key=db_name) -#REMOVEME? db_user=$db_name - #================================================= # STANDARD REMOVE #================================================= @@ -44,22 +30,6 @@ ynh_script_progression --message="Stopping and removing the systemd service..." # Remove the dedicated systemd config ynh_remove_systemd_config -#================================================= -# REMOVE THE POSTGRESQL DATABASE -#================================================= -#REMOVEME? ynh_script_progression --message="Removing the PostgreSQL database..." --weight=2 - -# Remove a database if it exists, along with the associated user -#REMOVEME? ynh_psql_remove_db --db_user=$db_user --db_name=$db_name - -#================================================= -# REMOVE DEPENDENCIES -#================================================= -#REMOVEME? ynh_script_progression --message="Removing dependencies..." --weight=1 - -# Remove metapackage and its dependencies -#REMOVEME? ynh_remove_app_dependencies - #================================================= # REMOVE THE REDIS DATABASE #================================================= @@ -72,9 +42,6 @@ ynh_redis_remove_db "$redis_db" #================================================= ynh_script_progression --message="Removing $app main directory..." --weight=6 -# Remove the app directory securely -#REMOVEME? ynh_secure_remove --file="$install_dir" - # Remove backend ynh_secure_remove --file="$backend_path" @@ -86,16 +53,6 @@ ynh_script_progression --message="Removing NGINX web server configuration..." -- # Remove the dedicated NGINX config ynh_remove_nginx_config -#================================================= -# GENERIC FINALIZATION -#================================================= -# REMOVE DEDICATED USER -#================================================= -#REMOVEME? ynh_script_progression --message="Removing the dedicated system user..." --weight=1 - -# Delete a system user -#REMOVEME? ynh_system_user_delete --username=$app - #================================================= # END OF SCRIPT #================================================= diff --git a/scripts/restore b/scripts/restore index c55ceb8..12f90e8 100644 --- a/scripts/restore +++ b/scripts/restore @@ -9,35 +9,6 @@ source ../settings/scripts/_common.sh source /usr/share/yunohost/helpers -#================================================= -# MANAGE SCRIPT FAILURE -#================================================= - -# Exit if an error occurs during the execution of the script -#REMOVEME? ynh_abort_if_errors - -#================================================= -# LOAD SETTINGS -#================================================= -ynh_script_progression --message="Loading settings..." --weight=1 - -#REMOVEME? app=$YNH_APP_INSTANCE_NAME - -#REMOVEME? domain=$(ynh_app_setting_get --app=$app --key=domain) -#REMOVEME? path=$(ynh_app_setting_get --app=$app --key=path) -#REMOVEME? #REMOVEME? install_dir=$(ynh_app_setting_get --app=$app --key=install_dir) -#REMOVEME? backend_path=$(ynh_app_setting_get --app=$app --key=backend_path) -#REMOVEME? db_name=$(ynh_app_setting_get --app=$app --key=db_name) -#REMOVEME? db_user=$db_name -#REMOVEME? db_pwd=$(ynh_app_setting_get --app=$app --key=psqlpwd) - -#================================================= -# CHECK IF THE APP CAN BE RESTORED -#================================================= -#REMOVEME? ynh_script_progression --message="Validating restoration parameters..." --weight=2 - -#REMOVEME? test ! -d $install_dir || ynh_die --message="There is already a directory: $install_dir " - #================================================= # STANDARD RESTORATION STEPS #================================================= @@ -71,21 +42,11 @@ ynh_restore_file --origin_path="$backend_path" chmod +x "$backend_path/vikunja" chown -R $app:www-data "$backend_path/files" -#================================================= -# REINSTALL DEPENDENCIES -#================================================= -#REMOVEME? ynh_script_progression --message="Reinstalling dependencies..." --weight=6 - -# Define and install dependencies -#REMOVEME? ynh_exec_warn_less ynh_install_app_dependencies $pkg_dependencies - #================================================= # RESTORE THE POSTGRESQL DATABASE #================================================= -#REMOVEME? ynh_script_progression --message="Restoring the PostgreSQL database..." --weight=6 +ynh_script_progression --message="Restoring the PostgreSQL database..." --weight=6 -#REMOVEME? ynh_psql_test_if_first_run -#REMOVEME? ynh_psql_setup_db --db_user=$db_user --db_name=$db_name --db_pwd=$db_pwd ynh_psql_execute_file_as_root --file="./db.sql" --database=$db_name #================================================= diff --git a/scripts/upgrade b/scripts/upgrade index 64b700f..fd7244b 100644 --- a/scripts/upgrade +++ b/scripts/upgrade @@ -12,52 +12,16 @@ source /usr/share/yunohost/helpers #================================================= # LOAD SETTINGS #================================================= -#REMOVEME? ynh_script_progression --message="Loading installation settings..." --weight=2 -#REMOVEME? app=$YNH_APP_INSTANCE_NAME - -#REMOVEME? domain=$(ynh_app_setting_get --app=$app --key=domain) -#REMOVEME? path=$(ynh_app_setting_get --app=$app --key=path) -#REMOVEME? #REMOVEME? install_dir=$(ynh_app_setting_get --app=$app --key=install_dir) -#REMOVEME? backend_path=$(ynh_app_setting_get --app=$app --key=backend_path) -#REMOVEME? port=$(ynh_app_setting_get --app=$app --key=port) -#REMOVEME? db_name=$(ynh_app_setting_get --app=$app --key=db_name) -#REMOVEME? db_user=$db_name -#REMOVEME? db_pwd=$(ynh_app_setting_get --app=$app --key=psqlpwd) timezone="$(cat /etc/timezone)" secret=$(ynh_string_random --length=32) -#REMOVEME? set_motd=$(ynh_app_setting_get --app=$app --key=set_motd) -#REMOVEME? enable_registration=$(ynh_app_setting_get --app=$app --key=enable_registration) -#REMOVEME? enable_linksharing=$(ynh_app_setting_get --app=$app --key=enable_linksharing) -#REMOVEME? enable_taskattachments=$(ynh_app_setting_get --app=$app --key=enable_taskattachments) -#REMOVEME? enable_taskcomments=$(ynh_app_setting_get --app=$app --key=enable_taskcomments) -#REMOVEME? enable_emailreminders=$(ynh_app_setting_get --app=$app --key=enable_emailreminders) -#REMOVEME? enable_userdeletion=$(ynh_app_setting_get --app=$app --key=enable_userdeletion) -#REMOVEME? maxavatarsize=$(ynh_app_setting_get --app=$app --key=maxavatarsize) -#REMOVEME? maxitemsperpage=$(ynh_app_setting_get --app=$app --key=maxitemsperpage) - - #================================================= # CHECK VERSION #================================================= upgrade_type=$(ynh_check_app_version_changed) -#================================================= -# BACKUP BEFORE UPGRADE THEN ACTIVE TRAP -#================================================= -ynh_script_progression --message="Backing up $app before upgrading (may take a while)..." --weight=4 - -# Backup the current version of the app -#REMOVEME? ynh_backup_before_upgrade -#REMOVEME? ynh_clean_setup () { - # restore it if the upgrade fails -#REMOVEME? ynh_restore_upgradebackup -} -# Exit if an error occurs during the execution of the script -#REMOVEME? ynh_abort_if_errors - #================================================= # ENSURE DOWNWARD COMPATIBILITY #================================================= @@ -114,18 +78,6 @@ if [ -z "$maxitemsperpage" ]; then ynh_app_setting_set --app=$app --key=maxitemsperpage --value=$maxitemsperpage fi -# Cleaning legacy permissions -#REMOVEME? if ynh_legacy_permissions_exists; then -#REMOVEME? ynh_legacy_permissions_delete_all - - ynh_app_setting_delete --app=$app --key=is_public -fi - -# Create a permission if needed -#REMOVEME? if ! ynh_permission_exists --permission="api"; then -#REMOVEME? ynh_permission_create --permission="api" --url="/api" --allowed="visitors" --auth_header="false" --show_tile="false" --protected="true" -fi - #================================================= # STANDARD UPGRADE STEPS #================================================= @@ -135,14 +87,6 @@ ynh_script_progression --message="Stopping a systemd service..." --weight=1 ynh_systemd_action --service_name=$app --action=stop --log_path=systemd -#================================================= -# CREATE DEDICATED USER -#================================================= -#REMOVEME? ynh_script_progression --message="Making sure dedicated system user exists..." --weight=1 - -# Create a dedicated user (if not existing) -#REMOVEME? ynh_system_user_create --username=$app --home_dir="$install_dir" - #================================================= # DOWNLOAD, CHECK AND UNPACK SOURCE #================================================= @@ -188,13 +132,6 @@ ynh_script_progression --message="Upgrading NGINX web server configuration..." - # Create a dedicated NGINX config ynh_add_nginx_config -#================================================= -# UPGRADE DEPENDENCIES -#================================================= -#REMOVEME? ynh_script_progression --message="Upgrading dependencies..." --weight=10 - -#REMOVEME? ynh_exec_warn_less ynh_install_app_dependencies $pkg_dependencies - #================================================= # SETUP SYSTEMD #================================================= @@ -216,13 +153,6 @@ ynh_script_progression --message="Starting a systemd service..." --weight=1 ynh_systemd_action --service_name=$app --action=start --log_path=systemd --line_match="server started on" -#================================================= -# RELOAD NGINX -#================================================= -#REMOVEME? ynh_script_progression --message="Reloading NGINX web server..." --weight=1 - -#REMOVEME? ynh_systemd_action --service_name=nginx --action=reload - #================================================= # END OF SCRIPT #================================================= diff --git a/tests.toml b/tests.toml new file mode 100644 index 0000000..91daf17 --- /dev/null +++ b/tests.toml @@ -0,0 +1,7 @@ +test_format = 1.0 + +[default] + + # ------------ + # Tests to run + # ------------ \ No newline at end of file From c4a7b6814849deb05d5228d9dca59033aded7e63 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=89ric=20Gaspar?= <46165813+ericgaspar@users.noreply.github.com> Date: Thu, 2 Mar 2023 19:25:05 +0100 Subject: [PATCH 03/12] fix --- doc/ADMIN.md | 2 -- scripts/change_url | 51 ---------------------------------------------- 2 files changed, 53 deletions(-) diff --git a/doc/ADMIN.md b/doc/ADMIN.md index d855bd4..e245837 100644 --- a/doc/ADMIN.md +++ b/doc/ADMIN.md @@ -1,5 +1,3 @@ -## Configuration - You can configure Vikunja with the config panels in the webadmin or by editing this file `/opt/vikunja/config.yml` using the [documentation](https://vikunja.io/docs/config-options/). diff --git a/scripts/change_url b/scripts/change_url index a51b808..c4e3c55 100644 --- a/scripts/change_url +++ b/scripts/change_url @@ -9,18 +9,6 @@ source _common.sh source /usr/share/yunohost/helpers -#================================================= -# RETRIEVE ARGUMENTS -#================================================= - -old_domain=$YNH_APP_OLD_DOMAIN -old_path=$YNH_APP_OLD_PATH - -new_domain=$YNH_APP_NEW_DOMAIN -new_path=$YNH_APP_NEW_PATH - -app=$YNH_APP_INSTANCE_NAME - #================================================= # LOAD SETTINGS #================================================= @@ -46,38 +34,6 @@ enable_userdeletion=$(ynh_app_setting_get --app=$app --key=enable_userdeletion) maxavatarsize=$(ynh_app_setting_get --app=$app --key=maxavatarsize) maxitemsperpage=$(ynh_app_setting_get --app=$app --key=maxitemsperpage) -#================================================= -# BACKUP BEFORE UPGRADE THEN ACTIVE TRAP -#================================================= -ynh_script_progression --message="Backing up $app before changing its URL (may take a while)..." --weight=1 - -# Backup the current version of the app -ynh_backup_before_upgrade -ynh_clean_setup () { - # Remove the new domain config file, the remove script won't do it as it doesn't know yet its location. - ynh_secure_remove --file="/etc/nginx/conf.d/$new_domain.d/$app.conf" - - # restore it if the upgrade fails - ynh_restore_upgradebackup -} -# Exit if an error occurs during the execution of the script -ynh_abort_if_errors - -#================================================= -# CHECK WHICH PARTS SHOULD BE CHANGED -#================================================= - -change_domain=0 -if [ "$old_domain" != "$new_domain" ] -then - change_domain=1 -fi - -change_path=0 -if [ "$old_path" != "$new_path" ] -then - change_path=1 -fi #================================================= # STANDARD MODIFICATIONS @@ -139,13 +95,6 @@ ynh_script_progression --message="Starting a systemd service..." --weight=1 # Start a systemd service ynh_systemd_action --service_name=$app --action=start --log_path=systemd -#================================================= -# RELOAD NGINX -#================================================= -ynh_script_progression --message="Reloading NGINX web server..." --weight=1 - -ynh_systemd_action --service_name=nginx --action=reload - #================================================= # END OF SCRIPT #================================================= From 45a588ca13251c41de29dd7daba151d36844cba8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=89ric=20Gaspar?= <46165813+ericgaspar@users.noreply.github.com> Date: Thu, 2 Mar 2023 19:45:54 +0100 Subject: [PATCH 04/12] Update manifest.toml --- manifest.toml | 1 + 1 file changed, 1 insertion(+) diff --git a/manifest.toml b/manifest.toml index 58dd5ce..888338a 100644 --- a/manifest.toml +++ b/manifest.toml @@ -22,6 +22,7 @@ architectures = "all" multi_instance = true ldap = false sso = false +disk = "50M" ram.build = "50M" ram.runtime = "50M" From 61e54d1c17ef9f0248d98edaa0feeb2ff7fbcbaf Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?E=CC=81ric=20Gaspar?= <46165813+ericgaspar@users.noreply.github.com> Date: Thu, 30 Mar 2023 21:45:52 +0200 Subject: [PATCH 05/12] Update manifest.toml --- manifest.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/manifest.toml b/manifest.toml index 888338a..b03e95c 100644 --- a/manifest.toml +++ b/manifest.toml @@ -17,7 +17,7 @@ admindoc = "https://vikunja.io/docs/" code = "https://kolaente.dev/vikunja/" [integration] -yunohost = ">= 11.1.12" +yunohost = ">= 11.1.15" architectures = "all" multi_instance = true ldap = false From 8c96ee816a6168377c5b005b0a2e2dcde5fd474a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?E=CC=81ric=20Gaspar?= <46165813+ericgaspar@users.noreply.github.com> Date: Thu, 30 Mar 2023 21:47:43 +0200 Subject: [PATCH 06/12] cleaning --- manifest.toml | 1 - scripts/_common.sh | 3 --- tests.toml | 8 +++++++- 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/manifest.toml b/manifest.toml index b03e95c..e344a2f 100644 --- a/manifest.toml +++ b/manifest.toml @@ -46,7 +46,6 @@ ram.runtime = "50M" [resources.permissions] main.url = "/" - api.url = "/api" api.show_tile = false api.allowed = "visitors" diff --git a/scripts/_common.sh b/scripts/_common.sh index b4e6641..d847bb9 100644 --- a/scripts/_common.sh +++ b/scripts/_common.sh @@ -4,9 +4,6 @@ # COMMON VARIABLES #================================================= -# dependencies used by the app -#REMOVEME? pkg_dependencies="postgresql" - #================================================= # PERSONAL HELPERS #================================================= diff --git a/tests.toml b/tests.toml index 91daf17..101756f 100644 --- a/tests.toml +++ b/tests.toml @@ -4,4 +4,10 @@ test_format = 1.0 # ------------ # Tests to run - # ------------ \ No newline at end of file + # ------------ + + # ------------------------------- + # Commits to test upgrade from + # ------------------------------- + + test_upgrade_from.b7c5209c.name = "Upgrade from #11" \ No newline at end of file From 045d60ed98271eac29031c10d44b391923fbcb60 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?E=CC=81ric=20Gaspar?= <46165813+ericgaspar@users.noreply.github.com> Date: Thu, 30 Mar 2023 21:51:24 +0200 Subject: [PATCH 07/12] fix --- conf/amd64.src | 7 ------- conf/arm64.src | 7 ------- conf/armhf.src | 7 ------- conf/i386.src | 7 ------- conf/nginx.conf | 3 ++- manifest.toml | 18 ++++++++++++++++++ 6 files changed, 20 insertions(+), 29 deletions(-) delete mode 100644 conf/amd64.src delete mode 100644 conf/arm64.src delete mode 100644 conf/armhf.src delete mode 100644 conf/i386.src diff --git a/conf/amd64.src b/conf/amd64.src deleted file mode 100644 index a7dbe3b..0000000 --- a/conf/amd64.src +++ /dev/null @@ -1,7 +0,0 @@ -SOURCE_URL=https://dl.vikunja.io/api/0.20.2/vikunja-v0.20.2-linux-amd64-full.zip -SOURCE_SUM=ce6f698134ac33ab307472ab6418043a7e92e1dbc917044f616c4bc6112e3ee0 -SOURCE_SUM_PRG=sha256sum -SOURCE_IN_SUBDIR=false -SOURCE_FORMAT=zip -SOURCE_FILENAME=vikunja -SOURCE_EXTRACT=true diff --git a/conf/arm64.src b/conf/arm64.src deleted file mode 100644 index 5f7d912..0000000 --- a/conf/arm64.src +++ /dev/null @@ -1,7 +0,0 @@ -SOURCE_URL=https://dl.vikunja.io/api/0.20.2/vikunja-v0.20.2-linux-arm64-full.zip -SOURCE_SUM=80d217013b11e5e7b2c3be50186abca2d46dac122a45ac69dc5189f7a0163cf2 -SOURCE_SUM_PRG=sha256sum -SOURCE_IN_SUBDIR=false -SOURCE_FORMAT=zip -SOURCE_FILENAME=vikunja -SOURCE_EXTRACT=true diff --git a/conf/armhf.src b/conf/armhf.src deleted file mode 100644 index 84f980b..0000000 --- a/conf/armhf.src +++ /dev/null @@ -1,7 +0,0 @@ -SOURCE_URL=https://dl.vikunja.io/api/0.20.2/vikunja-v0.20.2-linux-arm-7-full.zip -SOURCE_SUM=dceace8dd44baa999ffeb7ff515c5d4108ad064553d58cb0254faed061661ff4 -SOURCE_SUM_PRG=sha256sum -SOURCE_IN_SUBDIR=false -SOURCE_FORMAT=zip -SOURCE_FILENAME=vikunja -SOURCE_EXTRACT=true diff --git a/conf/i386.src b/conf/i386.src deleted file mode 100644 index f699fc4..0000000 --- a/conf/i386.src +++ /dev/null @@ -1,7 +0,0 @@ -SOURCE_URL=https://dl.vikunja.io/api/0.20.2/vikunja-v0.20.2-linux-386-full.zip -SOURCE_SUM=e334c4203de04cc38f3d123445a93cf1b8b945731302d49392e05faabd1844c6 -SOURCE_SUM_PRG=sha256sum -SOURCE_IN_SUBDIR=false -SOURCE_FORMAT=zip -SOURCE_FILENAME=vikunja -SOURCE_EXTRACT=true diff --git a/conf/nginx.conf b/conf/nginx.conf index d49334a..e693a5d 100644 --- a/conf/nginx.conf +++ b/conf/nginx.conf @@ -1,4 +1,5 @@ -location / { +#sub_path_only rewrite ^__PATH__$ __PATH__/ permanent; +location __PATH__/ { # Path to source alias __INSTALL_DIR__/; diff --git a/manifest.toml b/manifest.toml index e344a2f..882bd42 100644 --- a/manifest.toml +++ b/manifest.toml @@ -38,6 +38,24 @@ ram.runtime = "50M" default = "visitors" [resources] + + [resources.sources] + [resources.sources.back] + arm64.url = "https://dl.vikunja.io/api/0.20.2/vikunja-v0.20.2-linux-arm64-full.zip" + arm64.sha256 = "80d217013b11e5e7b2c3be50186abca2d46dac122a45ac69dc5189f7a0163cf2" + amd64.url = "https://dl.vikunja.io/api/0.20.2/vikunja-v0.20.2-linux-amd64-full.zip" + amd64.sha256 = "ce6f698134ac33ab307472ab6418043a7e92e1dbc917044f616c4bc6112e3ee0" + armhf.url = "https://dl.vikunja.io/api/0.20.2/vikunja-v0.20.2-linux-arm-7-full.zip" + armhf.sha256 = "dceace8dd44baa999ffeb7ff515c5d4108ad064553d58cb0254faed061661ff4" + i386.url = "https://dl.vikunja.io/api/0.20.2/vikunja-v0.20.2-linux-386-full.zip" + i386.sha256 = "e334c4203de04cc38f3d123445a93cf1b8b945731302d49392e05faabd1844c6" + in_subdir = false + + [resources.sources.front] + url = "https://dl.vikunja.io/frontend/vikunja-frontend-0.20.3.zip" + sha256 = "f95b5d81b25a5dc3e53bbd06aacbabea8b016fb880bd59cfbf689a1dbb364669" + in_subdir = false + [resources.ports] [resources.system_user] From 1ddbadcb5b2acf49479fc52aaa0738e39528c0c0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?E=CC=81ric=20Gaspar?= <46165813+ericgaspar@users.noreply.github.com> Date: Wed, 5 Apr 2023 22:58:59 +0200 Subject: [PATCH 08/12] Update manifest.toml --- manifest.toml | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/manifest.toml b/manifest.toml index 882bd42..4c97d6a 100644 --- a/manifest.toml +++ b/manifest.toml @@ -5,7 +5,7 @@ name = "Vikunja" description.en = "Self-hosted To-Do list application" description.fr = "Application de liste de tâches auto-hébergée" -version = "0.20.2~ynh1" +version = "0.20.4~ynh1" maintainers = ["eric_G"] @@ -41,19 +41,19 @@ ram.runtime = "50M" [resources.sources] [resources.sources.back] - arm64.url = "https://dl.vikunja.io/api/0.20.2/vikunja-v0.20.2-linux-arm64-full.zip" - arm64.sha256 = "80d217013b11e5e7b2c3be50186abca2d46dac122a45ac69dc5189f7a0163cf2" - amd64.url = "https://dl.vikunja.io/api/0.20.2/vikunja-v0.20.2-linux-amd64-full.zip" - amd64.sha256 = "ce6f698134ac33ab307472ab6418043a7e92e1dbc917044f616c4bc6112e3ee0" - armhf.url = "https://dl.vikunja.io/api/0.20.2/vikunja-v0.20.2-linux-arm-7-full.zip" - armhf.sha256 = "dceace8dd44baa999ffeb7ff515c5d4108ad064553d58cb0254faed061661ff4" - i386.url = "https://dl.vikunja.io/api/0.20.2/vikunja-v0.20.2-linux-386-full.zip" - i386.sha256 = "e334c4203de04cc38f3d123445a93cf1b8b945731302d49392e05faabd1844c6" + arm64.url = "https://dl.vikunja.io/api/0.20.4/vikunja-v0.20.4-linux-arm64-full.zip" + arm64.sha256 = "8d4c53dffc06484bd3d783dfd9c623f109ec116cbd00145b5e6c5756758c281d" + amd64.url = "https://dl.vikunja.io/api/0.20.4/vikunja-v0.20.4-linux-amd64-full.zip" + amd64.sha256 = "f4c9eea0bb0a05417ca4c40b55119c783e64732ce0e372198cb11c51a9914cdb" + armhf.url = "https://dl.vikunja.io/api/0.20.4/vikunja-v0.20.4-linux-arm-7-full.zip" + armhf.sha256 = "0746fdc6daa335629bf0330cf9ecb7255fa6e5b7ceb6c61bed19e456895c7c20" + i386.url = "https://dl.vikunja.io/api/0.20.4/vikunja-v0.20.4-linux-386-full.zip" + i386.sha256 = "7a24ba368c56c851c3a9e666dfc5baeb31bfaa411776caa9095ce2f87e8dcd85" in_subdir = false [resources.sources.front] - url = "https://dl.vikunja.io/frontend/vikunja-frontend-0.20.3.zip" - sha256 = "f95b5d81b25a5dc3e53bbd06aacbabea8b016fb880bd59cfbf689a1dbb364669" + url = "https://dl.vikunja.io/frontend/vikunja-frontend-0.20.5.zip" + sha256 = "7d458c95ac84f29c550469682ebcb05401425c5ff7be5af3fc21e31cd05aed4f" in_subdir = false [resources.ports] From 83b9fd478a332d0c24fb3ba368e9484d3127560c Mon Sep 17 00:00:00 2001 From: yunohost-bot Date: Wed, 5 Apr 2023 20:59:04 +0000 Subject: [PATCH 09/12] Auto-update README --- README.md | 2 +- README_fr.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index b614f9e..ae33916 100644 --- a/README.md +++ b/README.md @@ -27,7 +27,7 @@ Vikunja is a self-hosted open-source to-do list application for all platforms. - CalDAV - Links -**Shipped version:** 0.20.2~ynh1 +**Shipped version:** 0.20.4~ynh1 **Demo:** https://try.vikunja.io/login diff --git a/README_fr.md b/README_fr.md index 859d70c..f50aafd 100644 --- a/README_fr.md +++ b/README_fr.md @@ -27,7 +27,7 @@ Vikunja est une application de liste de tâches Open Source auto-hébergée pour - CalDAV - Links -**Version incluse :** 0.20.2~ynh1 +**Version incluse :** 0.20.4~ynh1 **Démo :** https://try.vikunja.io/login From 33ca6f7ad5b447904c4e3cd32f869b3b09d37a2b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?E=CC=81ric=20Gaspar?= <46165813+ericgaspar@users.noreply.github.com> Date: Wed, 5 Apr 2023 23:07:17 +0200 Subject: [PATCH 10/12] fix --- conf/front.src | 6 ------ manifest.toml | 2 +- scripts/backup | 19 ------------------- scripts/change_url | 45 ++------------------------------------------- scripts/install | 2 +- scripts/restore | 8 -------- scripts/upgrade | 23 +++++++++++------------ 7 files changed, 15 insertions(+), 90 deletions(-) delete mode 100644 conf/front.src diff --git a/conf/front.src b/conf/front.src deleted file mode 100644 index ca5192e..0000000 --- a/conf/front.src +++ /dev/null @@ -1,6 +0,0 @@ -SOURCE_URL=https://dl.vikunja.io/frontend/vikunja-frontend-0.20.3.zip -SOURCE_SUM=f95b5d81b25a5dc3e53bbd06aacbabea8b016fb880bd59cfbf689a1dbb364669 -SOURCE_SUM_PRG=sha256sum -SOURCE_FORMAT=zip -SOURCE_IN_SUBDIR=false -SOURCE_EXTRACT=true \ No newline at end of file diff --git a/manifest.toml b/manifest.toml index 4c97d6a..7dfe2e0 100644 --- a/manifest.toml +++ b/manifest.toml @@ -17,7 +17,7 @@ admindoc = "https://vikunja.io/docs/" code = "https://kolaente.dev/vikunja/" [integration] -yunohost = ">= 11.1.15" +yunohost = ">= 11.1.17" architectures = "all" multi_instance = true ldap = false diff --git a/scripts/backup b/scripts/backup index 8d24919..64e1a14 100644 --- a/scripts/backup +++ b/scripts/backup @@ -9,25 +9,6 @@ source ../settings/scripts/_common.sh source /usr/share/yunohost/helpers -#================================================= -# MANAGE SCRIPT FAILURE -#================================================= - -# Exit if an error occurs during the execution of the script -#REMOVEME? ynh_abort_if_errors - -#================================================= -# LOAD SETTINGS -#================================================= -#REMOVEME? ynh_print_info --message="Loading installation settings..." - -#REMOVEME? app=$YNH_APP_INSTANCE_NAME - -#REMOVEME? #REMOVEME? install_dir=$(ynh_app_setting_get --app=$app --key=install_dir) -#REMOVEME? backend_path=$(ynh_app_setting_get --app=$app --key=backend_path) -#REMOVEME? domain=$(ynh_app_setting_get --app=$app --key=domain) -#REMOVEME? db_name=$(ynh_app_setting_get --app=$app --key=db_name) - #================================================= # DECLARE DATA AND CONF FILES TO BACKUP #================================================= diff --git a/scripts/change_url b/scripts/change_url index c4e3c55..db32764 100644 --- a/scripts/change_url +++ b/scripts/change_url @@ -12,28 +12,10 @@ source /usr/share/yunohost/helpers #================================================= # LOAD SETTINGS #================================================= -ynh_script_progression --message="Loading installation settings..." --weight=1 -# Needed for helper "ynh_add_nginx_config" -final_path=$(ynh_app_setting_get --app=$app --key=final_path) -backend_path=$(ynh_app_setting_get --app=$app --key=backend_path) -port=$(ynh_app_setting_get --app=$app --key=port) -db_name=$(ynh_app_setting_get --app=$app --key=db_name) -db_user=$db_name -db_pwd=$(ynh_app_setting_get --app=$app --key=psqlpwd) secret=$(ynh_string_random --length=32) timezone="$(cat /etc/timezone)" - -set_motd=$(ynh_app_setting_get --app=$app --key=set_motd) -enable_registration=$(ynh_app_setting_get --app=$app --key=enable_registration) -enable_linksharing=$(ynh_app_setting_get --app=$app --key=enable_linksharing) -enable_taskattachments=$(ynh_app_setting_get --app=$app --key=enable_taskattachments) -enable_taskcomments=$(ynh_app_setting_get --app=$app --key=enable_taskcomments) -enable_emailreminders=$(ynh_app_setting_get --app=$app --key=enable_emailreminders) -enable_userdeletion=$(ynh_app_setting_get --app=$app --key=enable_userdeletion) -maxavatarsize=$(ynh_app_setting_get --app=$app --key=maxavatarsize) -maxitemsperpage=$(ynh_app_setting_get --app=$app --key=maxitemsperpage) - +redis_db=$(ynh_redis_get_free_db) #================================================= # STANDARD MODIFICATIONS @@ -49,29 +31,7 @@ ynh_systemd_action --service_name=$app --action=stop --log_path="/var/log/$app/$ #================================================= ynh_script_progression --message="Updating NGINX web server configuration..." --weight=1 -nginx_conf_path=/etc/nginx/conf.d/$old_domain.d/$app.conf - -# Change the path in the NGINX config file -if [ $change_path -eq 1 ] -then - # Make a backup of the original NGINX config file if modified - ynh_backup_if_checksum_is_different --file="$nginx_conf_path" - # Set global variables for NGINX helper - domain="$old_domain" - path_url="$new_path" - # Create a dedicated NGINX config - ynh_add_nginx_config -fi - -# Change the domain for NGINX -if [ $change_domain -eq 1 ] -then - # Delete file checksum for the old conf file location - ynh_delete_file_checksum --file="$nginx_conf_path" - mv $nginx_conf_path /etc/nginx/conf.d/$new_domain.d/$app.conf - # Store file checksum for the new config file location - ynh_store_file_checksum --file="/etc/nginx/conf.d/$new_domain.d/$app.conf" -fi +ynh_change_url_nginx_config #================================================= # ADD A CONFIGURATION @@ -80,7 +40,6 @@ ynh_script_progression --message="Adding a configuration file..." --weight=1 domain="$new_domain" path="$new_path" -redis_db=$(ynh_redis_get_free_db) ynh_add_config --template="../conf/config.yml" --destination="$backend_path/config.yml" chmod 600 "$backend_path/config.yml" diff --git a/scripts/install b/scripts/install index 0c5cff1..c95c5d9 100644 --- a/scripts/install +++ b/scripts/install @@ -69,7 +69,7 @@ ynh_app_setting_set --app=$app --key=backend_path --value=$backend_path mkdir -p "$backend_path" mkdir -p "$backend_path/files" tempdir="$(mktemp -d)" -ynh_setup_source --dest_dir=$tempdir --source_id=$YNH_ARCH +ynh_setup_source --dest_dir=$tempdir --source_id="back" back="$(find $tempdir -name "vikunja-*" \! -name "*.sha256")" cp "$back" "$backend_path/vikunja" diff --git a/scripts/restore b/scripts/restore index 12f90e8..df9e294 100644 --- a/scripts/restore +++ b/scripts/restore @@ -18,14 +18,6 @@ ynh_script_progression --message="Restoring the NGINX configuration..." --weight ynh_restore_file --origin_path="/etc/nginx/conf.d/$domain.d/$app.conf" -#================================================= -# RECREATE THE DEDICATED USER -#================================================= -#REMOVEME? ynh_script_progression --message="Recreating the dedicated system user..." --weight=1 - -# Create the dedicated user (if not existing) -#REMOVEME? ynh_system_user_create --username=$app --home_dir="$install_dir" - #================================================= # RESTORE THE APP MAIN DIR #================================================= diff --git a/scripts/upgrade b/scripts/upgrade index fd7244b..5ce62ed 100644 --- a/scripts/upgrade +++ b/scripts/upgrade @@ -30,50 +30,50 @@ ynh_script_progression --message="Ensuring downward compatibility..." --weight=1 # If backend_path doesn't exist, create it if [ -z "$backend_path" ]; then backend_path=/opt/$app -#REMOVEME? ynh_app_setting_set --app=$app --key=backend_path --value=$backend_path + ynh_app_setting_set --app=$app --key=backend_path --value=$backend_path fi -if [ -z "$set_motd" ]; then +if [ -z "${set_motd:-}" ]; then set_motd="" ynh_app_setting_set --app=$app --key=set_motd --value=$set_motd fi -if [ -z "$enable_registration" ]; then +if [ -z "${enable_registration:-}" ]; then enable_registration="true" ynh_app_setting_set --app=$app --key=enable_registration --value=$enable_registration fi -if [ -z "$enable_linksharing" ]; then +if [ -z "${enable_linksharing:-}" ]; then enable_linksharing="true" ynh_app_setting_set --app=$app --key=enable_linksharing --value=$enable_linksharing fi -if [ -z "$enable_taskattachments" ]; then +if [ -z "${enable_taskattachments:-}" ]; then enable_taskattachments="true" ynh_app_setting_set --app=$app --key=enable_taskattachments --value=$enable_taskattachments fi -if [ -z "$enable_taskcomments" ]; then +if [ -z "${enable_taskcomments:-}" ]; then enable_taskcomments="true" ynh_app_setting_set --app=$app --key=enable_taskcomments --value=$enable_taskcomments fi -if [ -z "$enable_emailreminders" ]; then +if [ -z "${enable_emailreminders:-}" ]; then enable_emailreminders="true" ynh_app_setting_set --app=$app --key=enable_emailreminders --value=$enable_emailreminders fi -if [ -z "$enable_userdeletion" ]; then +if [ -z "${enable_userdeletion:-}" ]; then enable_userdeletion="true" ynh_app_setting_set --app=$app --key=enable_userdeletion --value=$enable_userdeletion fi -if [ -z "$maxavatarsize" ]; then +if [ -z "${maxavatarsize:-}" ]; then maxavatarsize=1024 ynh_app_setting_set --app=$app --key=maxavatarsize --value=$maxavatarsize fi -if [ -z "$maxitemsperpage" ]; then +if [ -z "${maxitemsperpage:-}" ]; then maxitemsperpage=50 ynh_app_setting_set --app=$app --key=maxitemsperpage --value=$maxitemsperpage fi @@ -102,12 +102,11 @@ then # Backend mkdir -p "$backend_path/files" tempdir="$(mktemp -d)" - ynh_setup_source --dest_dir=$tempdir --source_id=$YNH_ARCH + ynh_setup_source --dest_dir=$tempdir --source_id="back" back="$(find $tempdir -name "vikunja-*" \! -name "*.sha256")" cp "$back" "$backend_path/vikunja" fi -chmod 750 "$install_dir" chmod -R o-rwx "$install_dir" chown -R $app:www-data "$install_dir" chmod +x "$backend_path/vikunja" From c9eae5ffed045eae1616a1cf3a5617125ee12076 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?E=CC=81ric=20Gaspar?= <46165813+ericgaspar@users.noreply.github.com> Date: Wed, 5 Apr 2023 23:16:48 +0200 Subject: [PATCH 11/12] fix --- check_process | 26 -------------------------- manifest.toml | 2 +- 2 files changed, 1 insertion(+), 27 deletions(-) delete mode 100644 check_process diff --git a/check_process b/check_process deleted file mode 100644 index 518c46a..0000000 --- a/check_process +++ /dev/null @@ -1,26 +0,0 @@ -;; Test complet - ; Manifest - domain="domain.tld" - path="/path" - is_public=1 - admin="john" - password="password" - ; Checks - pkg_linter=1 - setup_sub_dir=0 - setup_root=1 - setup_nourl=0 - setup_private=1 - setup_public=1 - upgrade=1 - upgrade=1 from_commit=b7c5209ca080054e8777c1882f4bf54851834270 - backup_restore=1 - multi_instance=1 - change_url=1 -;;; Options -Email= -Notification=none -;;; Upgrade options - ; commit=b7c5209ca080054e8777c1882f4bf54851834270 - name=Merge pull request #11 from YunoHost-Apps/testing - manifest_arg=domain=DOMAIN&path=PATH&admin=USER&language=fr&is_public=1&password=pass&port=4533& \ No newline at end of file diff --git a/manifest.toml b/manifest.toml index 7dfe2e0..ca75c39 100644 --- a/manifest.toml +++ b/manifest.toml @@ -23,7 +23,7 @@ multi_instance = true ldap = false sso = false disk = "50M" -ram.build = "50M" +ram.build = "1500M" ram.runtime = "50M" [install] From 758009a4b968ce0333dc7b1fc8241b248c7cf46a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?E=CC=81ric=20Gaspar?= <46165813+ericgaspar@users.noreply.github.com> Date: Wed, 5 Apr 2023 23:50:16 +0200 Subject: [PATCH 12/12] Update tests.toml --- tests.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests.toml b/tests.toml index 101756f..8faedda 100644 --- a/tests.toml +++ b/tests.toml @@ -10,4 +10,4 @@ test_format = 1.0 # Commits to test upgrade from # ------------------------------- - test_upgrade_from.b7c5209c.name = "Upgrade from #11" \ No newline at end of file + test_upgrade_from.4cf807ee10e609d85147ac389ea7f62260c733b2.name = "Upgrade from 0.20.2" \ No newline at end of file