1
0
Fork 0
mirror of https://github.com/YunoHost-Apps/wallabag2_ynh.git synced 2024-10-01 13:35:06 +02:00

Take official review into account (#36)

Small improvements to fit with Yunohost package standards
This commit is contained in:
JimboJoe 2017-06-06 15:13:25 +02:00 committed by lapineige
parent 53deb700de
commit 5c76ddeb6c
4 changed files with 5 additions and 65 deletions

View file

@ -302,7 +302,7 @@ pm.max_requests = 500
; The log file for slow requests
; Default Value: not set
; Note: slowlog is mandatory if request_slowlog_timeout is set
slowlog = /var/log/nginx/{POOLNAME}.slow.log
slowlog = /var/log/nginx/__NAMETOCHANGE__.slow.log
; The timeout for serving a single request after which a PHP backtrace will be
; dumped to the 'slowlog' file. A value of '0s' means 'off'.

View file

@ -28,6 +28,9 @@ domain=$(ynh_app_setting_get "$app" domain)
#=================================================
ynh_remove_app_dependencies
# The following command is kept as a matter of transition with the previous way
# of managing dependencies
ynh_package_autoremove "wallabag-deps" || true
#=================================================
# REMOVE THE MYSQL DB
@ -52,14 +55,6 @@ ynh_remove_nginx_config
sudo systemctl restart php5-fpm
sudo systemctl reload nginx
#=================================================
# REMOVE DEPENDENCIES
#=================================================
ynh_remove_app_dependencies
# The following command is keeped as a matter of transition with the previous way
# of managing dependencies
ynh_package_autoremove "wallabag-deps" || true
#=================================================
# REMOVE DEDICATED USER
#=================================================

View file

@ -98,7 +98,7 @@ ynh_replace_string "{DESKEY}" "${deskey}" "$wb_conf"
# Replace files and set permissions
ynh_secure_remove "${final_path}/var/cache"
sudo mkdir "${final_path}/var/cache"
sudo rsync -a $TMPDIR/* "${final_path}"
sudo cp -a $TMPDIR/. "${final_path}"
sudo chown -R $app: "${final_path}"
sudo chmod 755 $final_path

View file

@ -1,55 +0,0 @@
#!/bin/bash
set -eu
# check usage
if [[ $# -ne 1 ]]; then
cat << EOF
Usage: `basename $0` version
Update the application version shipped by this package.
EOF
exit 1
fi
version=$1
# -- helper:
# check that the version is set in a given file.
check_version() {
grep -q "$version" "$1" \
&& echo "[OK]" \
|| echo "[ERROR]"
}
# set new version
echo ":: set new version: ${version}"
echo -n "- processing 'scripts/_common.sh'... "
sed -ri "s#^(VERSION=).*#\1\"${version}\"#" \
./scripts/_common.sh
check_version "./scripts/_common.sh"
echo -n "- processing 'manifest.json'... "
sed -ri "s#(\"version\":).*#\1 \"${version}\",#" \
manifest.json
check_version "./manifest.json"
echo -n "- processing 'README.md'... "
sed -ri "s#(\*\*Shipped version:\*\*).*#\1 ${version}#" \
README.md
check_version "./README.md"
source ./scripts/_common.sh
# download and calculate the checksum
echo ":: downloading source tarball..."
rm -f "source.tar.gz"
wget -O "source.tar.gz" "$WALLABAG_SOURCE_URL"
calc_sum=$(sha256sum "source.tar.gz" | awk '{print $1}')
# set new checksum
echo ":: set new checksum: ${calc_sum}"
sed -ri "s#^(WALLABAG_SOURCE_SHA256=).*#\1\"${calc_sum}\"#" \
./scripts/_common.sh
echo "DONE!"