mirror of
https://github.com/YunoHost-Apps/wikijs_ynh.git
synced 2024-09-03 20:36:09 +02:00
Update pull_request_template.md
This commit is contained in:
parent
ff00ec5f3b
commit
fd97c22071
1 changed files with 4 additions and 9 deletions
|
@ -11,13 +11,8 @@
|
||||||
- [ ] Upgrade from last version tested.
|
- [ ] Upgrade from last version tested.
|
||||||
- [ ] Can be reviewed and tested.
|
- [ ] Can be reviewed and tested.
|
||||||
|
|
||||||
## Validation
|
## Package_check results
|
||||||
---
|
---
|
||||||
- [ ] **Code review**
|
*If you have access to [App Continuous Integration for packagers](https://yunohost.org/#/packaging_apps_ci) you can provide a link to the package_check results like below, replacing '-NUM-' in this link by the PR number and USERNAME by your username on the ci-apps-dev. Or you provide a screenshot or a pastebin of the results*
|
||||||
- [ ] **Approval (LGTM)**
|
|
||||||
*Code review and approval have to be from a member of @YunoHost/apps group*
|
[![Build Status](https://ci-apps-dev.yunohost.org/jenkins/job/wikijs_ynh%20PR-NUM-%20(USERNAME)/badge/icon)](https://ci-apps-dev.yunohost.org/jenkins/job/wikijs_ynh%20PR-NUM-%20(USERNAME)/)
|
||||||
- **CI succeeded** :
|
|
||||||
[![Build Status](https://ci-apps-dev.yunohost.org/jenkins/job/wikijs_ynh%20-BRANCH-/badge/icon)](https://ci-apps-dev.yunohost.org/jenkins/job/wikijs_ynh%20-BRANCH-/)
|
|
||||||
*Please replace '-BRANCH-' in this link by the name of the branch used.*
|
|
||||||
*If the PR is from a forked repository. Please provide public results from package_check.*
|
|
||||||
When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.
|
|
||||||
|
|
Loading…
Reference in a new issue