From cc33fa3177788dc54ea4276ba20a8cc0e83250f1 Mon Sep 17 00:00:00 2001 From: yalh76 Date: Thu, 13 Jun 2019 23:55:04 +0200 Subject: [PATCH 1/3] Update pull_request_template.md --- pull_request_template.md | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/pull_request_template.md b/pull_request_template.md index 05a2bcf..f941977 100644 --- a/pull_request_template.md +++ b/pull_request_template.md @@ -11,13 +11,8 @@ - [ ] Upgrade from last version tested. - [ ] Can be reviewed and tested. -## Validation +## Package_check results --- -- [ ] **Code review** -- [ ] **Approval (LGTM)** -*Code review and approval have to be from a member of @YunoHost/apps group* -- **CI succeeded** : -[![Build Status](https://ci-apps-dev.yunohost.org/jenkins/job/writefreely_ynh%20-BRANCH-/badge/icon)](https://ci-apps-dev.yunohost.org/jenkins/job/writefreely_ynh%20-BRANCH-/) -*Please replace '-BRANCH-' in this link by the name of the branch used.* -*If the PR is from a forked repository. Please provide public results from package_check.* -When the PR is marked as ready to merge, you have to wait for 3 days before really merging it. +*If you have access to [App Continuous Integration for packagers](https://yunohost.org/#/packaging_apps_ci) you can provide a link to the package_check results like below, replacing '-NUM-' in this link by the PR number and USERNAME by your username on the ci-apps-dev. Or you provide a screenshot or a pastebin of the results* + +[![Build Status](https://ci-apps-dev.yunohost.org/jenkins/job/writefreely_ynh%20PR-NUM-%20(USERNAME)/badge/icon)](https://ci-apps-dev.yunohost.org/jenkins/job/writefreely_ynh%20PR-NUM-%20(USERNAME)/) From 9b20c88aec1797e64307038ca84a7eba353c5c4c Mon Sep 17 00:00:00 2001 From: yalh76 Date: Sun, 16 Jun 2019 16:15:22 +0200 Subject: [PATCH 2/3] Update check_process --- check_process | 16 +++------------- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/check_process b/check_process index 970a404..2707ecf 100644 --- a/check_process +++ b/check_process @@ -16,23 +16,13 @@ upgrade=1 from_commit=093ec18f9f5282e1a137c0ac5444a414ee2b83bc backup_restore=1 multi_instance=1 - incorrect_path=1 + # This test is no longer necessary since the version 2.7 (PR: https://github.com/YunoHost/yunohost/pull/304), you can still do it if your app could be installed with this version. + # incorrect_path=1 port_already_use=0 change_url=0 ;;; Levels - Level 1=auto - Level 2=auto - Level 3=auto -# Level 4: If the app supports LDAP and SSOwat, turn level 4 to '1' and add a link to an issue or a part of your code to show it. -# If the app does not use LDAP nor SSOwat, and can't use them, turn level 4 to 'na' and explain as well. - # https://github.com/YunoHost-Apps/writefreely_ynh/issues/24 - Level 4=na + # If the level 5 (Package linter) is forced to 1. Please add justifications here. Level 5=auto - Level 6=auto - Level 7=auto - Level 8=0 - Level 9=0 - Level 10=0 ;;; Options Email=yalh@yahoo.com Notification=all From 2fca090d8f2ea77714f4e4995bb3a786e9a72ec7 Mon Sep 17 00:00:00 2001 From: yalh76 Date: Tue, 25 Jun 2019 22:09:06 +0200 Subject: [PATCH 3/3] removing dummy help --- manifest.json | 4 ---- 1 file changed, 4 deletions(-) diff --git a/manifest.json b/manifest.json index 52da4d0..e75063b 100644 --- a/manifest.json +++ b/manifest.json @@ -61,10 +61,6 @@ "en": "Set the administrator password", "fr": "Définissez le mot de passe administrateur" }, - "help": { - "en": "Use the help field to add an information for the admin about this question.", - "fr": "Utilisez le champ aide pour ajouter une information à l'intention de l'administrateur à propos de cette question." - }, "example": "Choose a password" }, {