From 089e8117037cb4eec138ba8e2c77d58744997383 Mon Sep 17 00:00:00 2001
From: yalh76 <yalh@yahoo.com>
Date: Sat, 10 Apr 2021 17:46:40 +0200
Subject: [PATCH] Apply example_ynh

---
 scripts/install | 35 +++++++++++++++++------------------
 scripts/remove  |  2 +-
 scripts/restore | 18 +++++++-----------
 scripts/upgrade | 36 ++++++++++++++++++------------------
 4 files changed, 43 insertions(+), 48 deletions(-)

diff --git a/scripts/install b/scripts/install
index 33abf31..b8e13ae 100644
--- a/scripts/install
+++ b/scripts/install
@@ -65,6 +65,14 @@ ynh_script_progression --message="Installing dependencies..."
 
 ynh_install_app_dependencies $pkg_dependencies
 
+#=================================================
+# CREATE DEDICATED USER
+#=================================================
+ynh_script_progression --message="Configuring system user..."
+
+# Create a system user
+ynh_system_user_create --username=$app --home_dir="$final_path"
+
 #=================================================
 # DOWNLOAD, CHECK AND UNPACK SOURCE
 #=================================================
@@ -79,6 +87,10 @@ pushd "$final_path"
 	git reset --quiet --hard FETCH_HEAD
 popd
 
+chmod 750 "$final_path"
+chmod -R o-rwx "$final_path"
+chown -R root:$app "$final_path"
+
 #=================================================
 # NGINX CONFIGURATION
 #=================================================
@@ -87,14 +99,6 @@ ynh_script_progression --message="Configuring NGINX web server..."
 # Create a dedicated NGINX config
 ynh_add_nginx_config
 
-#=================================================
-# CREATE DEDICATED USER
-#=================================================
-ynh_script_progression --message="Configuring system user..."
-
-# Create a system user
-ynh_system_user_create --username=$app
-
 #=================================================
 # SPECIFIC SETUP
 #=================================================
@@ -120,22 +124,17 @@ ynh_script_progression --message="Configuring a systemd service..."
 ynh_add_systemd_config
 
 #=================================================
-# CONFIGURE YUNORUNNER
+# ADD A CONFIGURATION
 #=================================================
-ynh_script_progression --message="Configuring YunoRunner..."
+ynh_script_progression --message="Adding a config file..."
 
 ynh_add_config --template="yunorunner.config.py" --destination="$final_path/config.py"
 
+chmod 400 "$final_path/config.py"
+chown $app:$app "$final_path/config.py"
+
 #=================================================
 # GENERIC FINALIZATION
-#=================================================
-# SECURE FILES AND DIRECTORIES
-#=================================================
-ynh_script_progression --message="Securing files and directories..."
-
-# Set permissions to app files
-chown -R $app:root $final_path
-
 #=================================================
 # INTEGRATE SERVICE IN YUNOHOST
 #=================================================
diff --git a/scripts/remove b/scripts/remove
index 7b05647..524c878 100755
--- a/scripts/remove
+++ b/scripts/remove
@@ -76,7 +76,7 @@ then
 fi
 
 #=================================================
-# GENERIC FINALISATION
+# GENERIC FINALIZATION
 #=================================================
 # REMOVE DEDICATED USER
 #=================================================
diff --git a/scripts/restore b/scripts/restore
index ed1970a..d1ad259 100644
--- a/scripts/restore
+++ b/scripts/restore
@@ -56,13 +56,6 @@ ynh_script_progression --message="Restoring the NGINX web server configuration..
 
 ynh_restore_file --origin_path="/etc/nginx/conf.d/$domain.d/$app.conf"
 
-#=================================================
-# RESTORE THE APP MAIN DIR
-#=================================================
-ynh_script_progression --message="Restoring the app main directory..."
-
-ynh_restore_file --origin_path="$final_path"
-
 #=================================================
 # RECREATE THE DEDICATED USER
 #=================================================
@@ -72,12 +65,15 @@ ynh_script_progression --message="Recreating the dedicated system user..."
 ynh_system_user_create --username=$app
 
 #=================================================
-# RESTORE USER RIGHTS
+# RESTORE THE APP MAIN DIR
 #=================================================
-ynh_script_progression --message="Restoring user rights..."
+ynh_script_progression --message="Restoring the app main directory..."
 
-# Restore permissions on app files
-chown -R $app:root $final_path
+ynh_restore_file --origin_path="$final_path"
+
+chmod 750 "$final_path"
+chmod -R o-rwx "$final_path"
+chown -R root:$app "$final_path"
 
 #=================================================
 # SPECIFIC RESTORATION
diff --git a/scripts/upgrade b/scripts/upgrade
index 20fb21f..3fec468 100644
--- a/scripts/upgrade
+++ b/scripts/upgrade
@@ -96,6 +96,14 @@ ynh_script_progression --message="Stopping a systemd service..."
 
 ynh_systemd_action --service_name=$app --action="stop" --log_path="systemd" --line_match="Stopped YunoRunner CI"
 
+#=================================================
+# CREATE DEDICATED USER
+#=================================================
+ynh_script_progression --message="Making sure dedicated system user exists..."
+
+# Create a dedicated user (if not existing)
+ynh_system_user_create --username=$app --home_dir="$final_path"
+
 #=================================================
 # DOWNLOAD, CHECK AND UNPACK SOURCE
 #=================================================
@@ -111,6 +119,10 @@ then
 	popd
 fi
 
+chmod 750 "$final_path"
+chmod -R o-rwx "$final_path"
+chown -R root:$app "$final_path"
+
 #=================================================
 # NGINX CONFIGURATION
 #=================================================
@@ -126,14 +138,6 @@ ynh_script_progression --message="Upgrading dependencies..."
 
 ynh_install_app_dependencies $pkg_dependencies
 
-#=================================================
-# CREATE DEDICATED USER
-#=================================================
-ynh_script_progression --message="Making sure dedicated system user exists..."
-
-# Create a dedicated user (if not existing)
-ynh_system_user_create --username=$app
-
 #=================================================
 # SPECIFIC UPGRADE
 #=================================================
@@ -155,25 +159,21 @@ popd
 #=================================================
 ynh_script_progression --message="Upgrading systemd configuration..."
 
+# Create a dedicated systemd config
 ynh_add_systemd_config
 
 #=================================================
-# CONFIGURE YUNORUNNER
+# UPDATE A CONFIG FILE
 #=================================================
-ynh_script_progression --message="Configuring YunoRunner..."
+ynh_script_progression --message="Updating a config file..."
 
 ynh_add_config --template="yunorunner.config.py" --destination="$final_path/config.py"
 
+chmod 400 "$final_path/config.py"
+chown $app:$app "$final_path/config.py"
+
 #=================================================
 # GENERIC FINALIZATION
-#=================================================
-# SECURE FILES AND DIRECTORIES
-#=================================================
-ynh_script_progression --message="Securing files and directories..."
-
-# Set permissions on app files
-chown -R $app:root $final_path
-
 #=================================================
 # INTEGRATE SERVICE IN YUNOHOST
 #=================================================