From 1398f5a1148532eec60e3819bff71bf7b04a857c Mon Sep 17 00:00:00 2001 From: Alexandre Aubin Date: Sat, 29 Jun 2024 17:31:56 +0200 Subject: [PATCH] Recommend to always upgrade sources instead of 'if ynh_app_upstream_version_changed' --- tools/helpers2.1/convert_to_helpers_2.1.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/helpers2.1/convert_to_helpers_2.1.py b/tools/helpers2.1/convert_to_helpers_2.1.py index 1acf21eb..4284a026 100644 --- a/tools/helpers2.1/convert_to_helpers_2.1.py +++ b/tools/helpers2.1/convert_to_helpers_2.1.py @@ -97,7 +97,7 @@ def cleanup(): (r"ynh_compare_current_package_version.*lt.*version\s?=?\"?([0-9\.]+~ynh[0-9])\"?", "ynh_app_upgrading_from_version_before \\1"), (r"ynh_compare_current_package_version.*le.*version\s?=?\"?([0-9\.]+~ynh[0-9])\"?", "ynh_app_upgrading_from_version_before_or_equal_to \\1"), (r"upgrade_type=\S*", ""), - (r'\[\s+"?\$upgrade_type"?\s+==\s+"?UPGRADE_APP"? \]', "ynh_app_upstream_version_changed"), + (r'if \[\s+"?\$upgrade_type"?\s+==\s+"?UPGRADE_APP"? \]', "# FIXME: this is still supported but the recommendation is now to *always* re-setup the app sources wether or not the upstream sources changed\nif ynh_app_upstream_version_changed"), # Backup/store (r"ynh_restore\s*$", "ynh_restore_everything"), # -> Specific trick to remove the --not_mandatory here, but replace it with || true for the other occurences