From 8c3408b84063d4f3dcef5682ead2cbe00aee2560 Mon Sep 17 00:00:00 2001
From: Tagada <36127788+Tagadda@users.noreply.github.com>
Date: Fri, 21 Jan 2022 23:17:36 +0100
Subject: [PATCH] Anti-features draft

---
 antifeatures.yml | 79 ++++++++++++++++++++++++++++++++++++++++++++++++
 apps.json        | 28 +++++++++++++++++
 list_builder.py  |  4 ++-
 3 files changed, 110 insertions(+), 1 deletion(-)
 create mode 100644 antifeatures.yml

diff --git a/antifeatures.yml b/antifeatures.yml
new file mode 100644
index 00000000..9df020ea
--- /dev/null
+++ b/antifeatures.yml
@@ -0,0 +1,79 @@
+- id: tracking
+  icon: user-secret
+  title:
+      en: "Tracking"
+      fr: "Pistage"
+  description:
+      en: "Track you and/or report your activity to somewhere, either without your permission or by default."
+
+- id: non-free-network
+  icon: network-wired
+  title:
+      en: "Non-free Network Services"
+      fr : "Services réseau non-libres"
+  description:
+      en: "Promote or depend entirely on a Non-Free network service."
+
+- id: non-free-addons
+  icon: puzzle-piece
+  title:
+      en: "Non-free Addons"
+      fr: "Extensions non libres"
+  description:
+      en: "Promote other Non-Free applications or plugins."
+
+- id: non-free-dependencies
+  icon: book
+  title:
+      en: "Non-free dependencies"
+  description:
+      en: "Require things that are not Free Software in order to run"
+
+- id: non-free-assets
+  icon: file-image
+  title:
+      en: "Non-free assets"
+      fr: "Ressources non libres"
+  description:
+      en: "Contain and make use of non-ree assets. The most common case is apps using artwork - images, sounds, music, etc. - under a non-commercial license."
+
+- id: known-vulnerability
+  icon: face-frown
+  title:
+      en: "Known Vulnerability"
+      fr: "Vulnérabilité connue"
+  description:
+      en: "Known security vulnerability."
+
+- id: deprecated-software
+  icon: face-frown
+  title:
+      en: "Upstream not maintained"
+      fr: "Application non maintenue"
+  description:
+      en: "This software is not maintained anymore."
+
+- id: package-not-maintained
+  icon: face-frown
+  title:
+      en: "Package not maintained"
+      fr: "Paquet non maintenu"
+  description:
+      en: "YunoHost package is not maintained anymore."
+
+- id: paid-content
+  icon: coins
+  title:
+      en: "Paid content"
+      fr: "Contenu payant"
+  description:
+      en: "Promote or depend entierly on a paid service."
+
+- id: arbitrary-limitations
+  icon: face-frown
+  title:
+      en: "Arbitrary limitations"
+      fr: "Limitations arbritraires"
+  description:
+      en: "Please refer to the README."
+      fr: "Se référer au fichier README."
diff --git a/apps.json b/apps.json
index 568c27e0..c000ed76 100644
--- a/apps.json
+++ b/apps.json
@@ -3,6 +3,9 @@
         "category": "games",
         "level": 8,
         "state": "working",
+        "antifeatures": [
+            "non-free-assets"
+        ],
         "url": "https://github.com/YunoHost-Apps/20euros_ynh"
     },
     "243": {
@@ -92,6 +95,9 @@
         "subtags": [
             "download"
         ],
+        "antifeatures": [
+            "non-free-network"
+        ],
         "url": "https://github.com/YunoHost-Apps/alltube_ynh"
     },
     "ampache": {
@@ -199,6 +205,9 @@
         "subtags": [
             "pictures"
         ],
+        "antifeatures": [
+            "non-free-network"
+        ],
         "url": "https://github.com/YunoHost-Apps/bibliogram_ynh"
     },
     "biboumi": {
@@ -527,6 +536,9 @@
         "category": "games",
         "level": 8,
         "state": "working",
+        "antifeatures": [
+            "tracking"
+        ],
         "url": "https://github.com/YunoHost-Apps/Cubiks-2048_ynh"
     },
     "dato": {
@@ -1375,6 +1387,9 @@
         "subtags": [
             "videos"
         ],
+        "antifeatures": [
+            "non-free-network"
+        ],
         "url": "https://github.com/YunoHost-Apps/invidious_ynh"
     },
     "invoiceninja": {
@@ -2168,6 +2183,9 @@
         "subtags": [
             "microblogging"
         ],
+        "antifeatures": [
+            "non-free-network"
+        ],
         "url": "https://github.com/YunoHost-Apps/nitter_ynh"
     },
     "noalyss": {
@@ -3557,6 +3575,10 @@
             "websites",
             "blog"
         ],
+        "antifeatures": [
+            "non-free-addons",
+            "paid-content"
+        ],
         "url": "https://github.com/YunoHost-Apps/wordpress_ynh"
     },
     "writefreely": {
@@ -3612,6 +3634,9 @@
         "subtags": [
             "download"
         ],
+        "antifeatures": [
+            "non-free-network"
+        ],
         "url": "https://github.com/YunoHost-Apps/youtube-dl-webui_ynh"
     },
     "yunofav": {
@@ -3701,6 +3726,9 @@
         "subtags": [
             "network"
         ],
+        "antifeatures": [
+            "non-free-dependencies"
+        ],
         "url": "https://github.com/YunoHost-Apps/ztncui_ynh"
     },
     "zusam": {
diff --git a/list_builder.py b/list_builder.py
index be49b1f1..41c04d80 100755
--- a/list_builder.py
+++ b/list_builder.py
@@ -149,9 +149,10 @@ def build_catalog():
     # Current version 2 #
     #####################
     categories = yaml.load(open("categories.yml").read())
+    antifeatures = yaml.load(open("antifeatures.yml").read())
     os.system("mkdir -p ./builds/default/v2/")
     with open("builds/default/v2/apps.json", 'w') as f:
-        f.write(json.dumps({"apps": result_dict, "categories": categories}, sort_keys=True))
+        f.write(json.dumps({"apps": result_dict, "categories": categories, "antifeatures": antifeatures}, sort_keys=True))
 
     ####################
     # Legacy version 1 #
@@ -199,6 +200,7 @@ def build_catalog():
             "broken": level <= 0,
             "good_quality": level >= 8,
             "bad_quality":  level <= 5,
+            "antifeatures": infos.get("antifeatures"),
         }
     result_dict_doc = {k: infos_for_doc_catalog(v) for k, v in result_dict.items() if v["state"] in ["working", "validated"]}
     with open("builds/default/doc_catalog/apps.json", 'w') as f: