Iterate on new CI job (#1569)

.github/workflows/main.yml

@@ -9,21 +9,25 @@ jobs:
 
     steps:
     - uses: actions/checkout@v2
-    - name: Check apps.json
+
+    - name: Check JSON validity for apps.json
       run: |
-        jq apps.json
+        cat apps.json | jq >/dev/null
+
     - name: Check all working apps have consistent app id / app url
       run: |
+        FAULTY_APPS="false";
         for LINE in $(cat apps.json | jq -r 'to_entries[] | select ( .value.state=="working" ) | "\(.key)|\(.value.url)"')
         do
             APP=$(echo $LINE | awk -F'|' '{print $1}')
             URL_END=$(echo $LINE | awk -F'/' '{print $NF}')
-            [ "$APP" == "$(echo $APP | tr [A-Z] [a-z])" ] || echo "$APP : app id should be lowercase" >&2
-            [ "$URL_END" == "${APP}_ynh" ] || echo "$APP : the url should end with ${APP}_ynh" >&2
+            [ "$APP" == "$(echo $APP | tr [A-Z] [a-z])" ] || { FAULTY_APPS="true"; echo "$APP : app id should be lowercase" >&2; }
+            [ "$URL_END" == "${APP}_ynh" ] || { FAULTY_APPS="true"; echo "$APP : the url should end with ${APP}_ynh" >&2; }
         done
+        [ $FAULTY_APPS = "false" ]
 
     - name: Check all working apps have a category
       run: |
-        jq -e -r '.[] | select ( .state=="working" ) | select ( has("category") | not )'  apps.json
-        [ $? -eq 4 ] || echo "Some working applications don't have their category defined ?" >&2
+        APPS_WITH_NO_CATEGORY=$(jq -e -r '.[] | select ( .state=="working" ) | select ( has("category") | not )'  apps.json || true)
+        [ "$APPS_WITH_NO_CATEGORY" == "" ] || { echo "Some working apps are missing a category: $APPS_WITH_NO_CATEGORY" >&2; false; }
 

apps.json

@@ -861,7 +861,7 @@
         ],
         "url": "https://github.com/Jojo144/django_app_ynh"
     },
-    "django_example_ynh": {
+    "django_example": {
         "category": "dev",
         "level": 7,
         "state": "working",