From d1035b61174a5432c96f7cbde66f2ca19f81a896 Mon Sep 17 00:00:00 2001 From: Maniack Crudelis Date: Fri, 1 Feb 2019 15:11:12 +0100 Subject: [PATCH 01/32] Add support for featured apps --- README.md | 26 ++++++++++++++++++++++++++ list_builder.py | 8 +++++++- 2 files changed, 33 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index 9f0ea447..2bf606bd 100644 --- a/README.md +++ b/README.md @@ -40,6 +40,7 @@ sudo yunohost app fetchlist -n community -u https://yunohost.org/community.json * Fork and edit the [community list](https://github.com/YunoHost/apps/tree/master/community.json) * Add your app's ID and git information at the right alphabetical place * Indicate the app's functioning state: `notworking`, `inprogress`, or `working` +* Do not add the level yourself. The CI will do it. * Send a [Pull Request](https://github.com/YunoHost/apps/pulls/) App example addition: @@ -69,5 +70,30 @@ Usage: ./add_or_update.py [community.json OR official.json] [github/gitlab url OR app name [github/gitlab url OR app name [github/gitlab url OR app name ...]]] ``` +### How to make my app a Featured app + +A featured app will be highlighted in the community list as a high quality app. +To become a Featured app, a package have to follow the following rules: + +* The app should already be in the community list for 2 months. +* The app should be keep up to date, regarding the upstream source. (If it’s possible with our current YunoHost version) +* The package itself should be up to date regarding the packaging recommendations and helpers. +* The package should be level 7, at least. +* The repository should have testing and master branches, at least. The list should point to HEAD, so the list stays up to date. +* Any modification should be done to the testing branch, and wait at least for one approval for one member of the Apps group. So that we can ensure that there’s nothing in opposition to those criteria. Nor any changes that would harm servers. + +If the app is already tag as Featured and one of those criteria isn't respected anymore. After a warning, the tag will be removed until the criteria are again validated. + +To make an app a Featured app, technically, you have to add the tag ```"featured": true```. +```json + "wallabag": { + "branch": "master", + "featured": true, + "revision": "c2fc62438ac5c9503e3f4ebfdc425ec03a0ec0c0", + "url": "https://github.com/abeudin/wallabag_ynh.git", + "state": "working" + } +``` + #### More information See [yunohost.org/packaging_apps](https://yunohost.org/packaging_apps) diff --git a/list_builder.py b/list_builder.py index 2538718c..332ab954 100755 --- a/list_builder.py +++ b/list_builder.py @@ -145,6 +145,7 @@ for app, info in apps_list.items(): app_state = info["state"] app_level = info.get("level") app_maintained = info.get("maintained", True) + app_featured = info.get("featured", False) forge_site = app_url.split('/')[2] owner = app_url.split('/')[3] @@ -167,6 +168,7 @@ for app, info in apps_list.items(): previous_url = already_built_file.get(app, {}).get("git", {}).get("url") previous_level = already_built_file.get(app, {}).get("level") previous_maintained = already_built_file.get(app, {}).get("maintained") + previous_featured = already_built_file.get(app, {}).get("featured") if forge_type == "github" and app_rev == "HEAD": @@ -210,6 +212,9 @@ for app, info in apps_list.items(): if previous_maintained != app_maintained: result_dict[app]["maintained"] = app_maintained print("... but maintained status changed, updating it from '%s' to '%s'" % (previous_maintained, app_maintained)) + if previous_featured != app_featured: + result_dict[app]["featured"] = app_featured + print("... but featured status changed, updating it from '%s' to '%s'" % (previous_featured, app_featured)) print "update translations but don't download anything" result_dict[app]['manifest'] = include_translations_in_manifest(app, result_dict[app]['manifest']) @@ -318,7 +323,8 @@ for app, info in apps_list.items(): 'manifest': include_translations_in_manifest(manifest['id'], manifest), 'state': info['state'], 'level': info.get('level', '?'), - 'maintained': app_maintained + 'maintained': app_maintained, + 'featured': app_featured } except KeyError as e: print("-> Error: invalid app info or manifest, %s" % e) From 23b16733b65b6762bfb4d5fc1bba739d0e4a3daf Mon Sep 17 00:00:00 2001 From: Maniack Crudelis Date: Wed, 20 Feb 2019 17:28:41 +0100 Subject: [PATCH 02/32] Modify level descriptions --- app_levels/en.json | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/app_levels/en.json b/app_levels/en.json index 13df50e9..0869b310 100644 --- a/app_levels/en.json +++ b/app_levels/en.json @@ -3,11 +3,11 @@ "applevel_1": "Installable", "applevel_2": "Installable in all situations", "applevel_3": "Can be updated", - "applevel_4": "Single Sign On support", + "applevel_4": "Backup and restore support", "applevel_5": "Clean", - "applevel_6": "Backup and restore support", + "applevel_6": "Available for the community", "applevel_7": "Successfully pass functional tests", - "applevel_8": "Respect main guidelines", - "applevel_9": "Respect all guidelines", + "applevel_8": "High quality app", + "applevel_9": "Respect highter guidelines", "applevel_10": "Package assessed as perfect" } From 143799e65c4017719a4ab3d12e064c69df8b6333 Mon Sep 17 00:00:00 2001 From: Maniack Crudelis Date: Wed, 20 Feb 2019 17:59:24 +0100 Subject: [PATCH 03/32] Update Featured app and add High Quality ones --- README.md | 36 ++++++++++++++++++++++++++++++------ 1 file changed, 30 insertions(+), 6 deletions(-) diff --git a/README.md b/README.md index 2bf606bd..2dd8f1a0 100644 --- a/README.md +++ b/README.md @@ -70,10 +70,10 @@ Usage: ./add_or_update.py [community.json OR official.json] [github/gitlab url OR app name [github/gitlab url OR app name [github/gitlab url OR app name ...]]] ``` -### How to make my app a Featured app +### How to make my app a High Quality app ? -A featured app will be highlighted in the community list as a high quality app. -To become a Featured app, a package have to follow the following rules: +A High Quality app will be highlighted in the app list and mark as a level 8 app. +To become a High Quality app, a package have to follow the following rules: * The app should already be in the community list for 2 months. * The app should be keep up to date, regarding the upstream source. (If it’s possible with our current YunoHost version) @@ -82,14 +82,38 @@ To become a Featured app, a package have to follow the following rules: * The repository should have testing and master branches, at least. The list should point to HEAD, so the list stays up to date. * Any modification should be done to the testing branch, and wait at least for one approval for one member of the Apps group. So that we can ensure that there’s nothing in opposition to those criteria. Nor any changes that would harm servers. -If the app is already tag as Featured and one of those criteria isn't respected anymore. After a warning, the tag will be removed until the criteria are again validated. +If the app is already tag as High Quality and one of those criteria isn't respected anymore. After a warning, the tag will be removed until the criteria are again validated. -To make an app a Featured app, technically, you have to add the tag ```"featured": true```. +To make an app a High Quality app, technically, you have to add the tag ```"high_quality": true```. ```json "wallabag": { "branch": "master", + "high_quality": true, + "revision": HEAD, + "url": "https://github.com/abeudin/wallabag_ynh.git", + "state": "working" + } +``` + +### How to make my app a Featured app ? + +A Featured app highlighted in the app list and shown before any others. +To become a Featured app, a package have to follow the following rules: + +* The app should already be a High Quality app. +* The upstream app should be accessible and well made. +* The app should be interesting and demanded by the community. +* The app should fit the spirit of YunoHost. + +**Please note that the exact process to decide which app are going to be Featured, and for how many time, isn't yet defined...** + +To make an app a High Quality app, technically, you have to add the tag ```"featured": true```. +```json + "wallabag": { + "branch": "master", + "high_quality": true, "featured": true, - "revision": "c2fc62438ac5c9503e3f4ebfdc425ec03a0ec0c0", + "revision": HEAD, "url": "https://github.com/abeudin/wallabag_ynh.git", "state": "working" } From cb58e8e10c69fca7d6f62ad76ff58825bb09e4a4 Mon Sep 17 00:00:00 2001 From: Maniack Crudelis Date: Wed, 20 Feb 2019 18:05:20 +0100 Subject: [PATCH 04/32] Add High Quality into the list --- list_builder.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/list_builder.py b/list_builder.py index 332ab954..0790bfb4 100755 --- a/list_builder.py +++ b/list_builder.py @@ -146,6 +146,7 @@ for app, info in apps_list.items(): app_level = info.get("level") app_maintained = info.get("maintained", True) app_featured = info.get("featured", False) + app_high_quality = info.get("high_quality", False) forge_site = app_url.split('/')[2] owner = app_url.split('/')[3] @@ -169,6 +170,7 @@ for app, info in apps_list.items(): previous_level = already_built_file.get(app, {}).get("level") previous_maintained = already_built_file.get(app, {}).get("maintained") previous_featured = already_built_file.get(app, {}).get("featured") + previous_high_quality = already_built_file.get(app, {}).get("high_quality") if forge_type == "github" and app_rev == "HEAD": @@ -215,6 +217,9 @@ for app, info in apps_list.items(): if previous_featured != app_featured: result_dict[app]["featured"] = app_featured print("... but featured status changed, updating it from '%s' to '%s'" % (previous_featured, app_featured)) + if previous_high_quality != app_high_quality: + result_dict[app]["high_quality"] = app_high_quality + print("... but high_quality status changed, updating it from '%s' to '%s'" % (previous_high_quality, app_high_quality)) print "update translations but don't download anything" result_dict[app]['manifest'] = include_translations_in_manifest(app, result_dict[app]['manifest']) @@ -324,6 +329,7 @@ for app, info in apps_list.items(): 'state': info['state'], 'level': info.get('level', '?'), 'maintained': app_maintained, + 'high_quality': app_high_quality, 'featured': app_featured } except KeyError as e: From 39fd0c1e38253c5cff7b3b4242a95db95e057d7f Mon Sep 17 00:00:00 2001 From: Maniack Crudelis Date: Wed, 20 Feb 2019 18:12:18 +0100 Subject: [PATCH 05/32] Typo fix --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 2dd8f1a0..c11c0950 100644 --- a/README.md +++ b/README.md @@ -107,7 +107,7 @@ To become a Featured app, a package have to follow the following rules: **Please note that the exact process to decide which app are going to be Featured, and for how many time, isn't yet defined...** -To make an app a High Quality app, technically, you have to add the tag ```"featured": true```. +To make an app a Featured app, technically, you have to add the tag ```"featured": true```. ```json "wallabag": { "branch": "master", From 1122a959a6ce555456af7ddccec6dbfd28913a94 Mon Sep 17 00:00:00 2001 From: Maniack Crudelis Date: Thu, 21 Feb 2019 01:26:04 +0100 Subject: [PATCH 06/32] Add info about maintained status --- README.md | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/README.md b/README.md index c11c0950..e542c866 100644 --- a/README.md +++ b/README.md @@ -119,5 +119,18 @@ To make an app a Featured app, technically, you have to add the tag ```"featured } ``` +### What to do if I can't maintain my app anymore ? + +If you don't have time anymore to maintain an app, you can update its status to inform users and packagers that you will not maintain it anymore. +In order to do so, use the tag `"maintained":`. +This tag can have 5 different values: +- `"maintained": true` That's the default value if the tag isn't present for your app. That simply means that this app is maintained. +- `"maintained": "request_help"` Use that value to inform other packagers that you need help to maintain this app. You'll then be more than one maintainer for this apps. +- `"maintained": "request_adoption"` Use that value to inform other packagers, as well as users, that you're going to give up that app. So that you would like another maintainer to take care of it. +- `"maintained": false` or `"maintained": "orphaned"` This value means that this app is no longer maintained... That means also that a packager can declare himself as its new maintainer. +Please contact Apps group if you want to take back a unmaintained app. + +If you want to modify the status of one of your app, for any reason, please think also to inform the community via the forum. Users would probably be glad to be inform that an app they use will be unmaintained. + #### More information See [yunohost.org/packaging_apps](https://yunohost.org/packaging_apps) From 895e3b804e01e52247cba3e252edc33a967d4ab4 Mon Sep 17 00:00:00 2001 From: Maniack Crudelis Date: Mon, 4 Mar 2019 18:14:45 +0100 Subject: [PATCH 07/32] Add a pull_request_template for High Quality apps --- pull_request_template-HQ-apps.md | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) create mode 100644 pull_request_template-HQ-apps.md diff --git a/pull_request_template-HQ-apps.md b/pull_request_template-HQ-apps.md new file mode 100644 index 00000000..6b290b26 --- /dev/null +++ b/pull_request_template-HQ-apps.md @@ -0,0 +1,23 @@ +## Problem +- *Description of why you made this PR* + +## Solution +- *And how do you fix that problem* + +## PR Status +- [ ] Code finished. +- [ ] Tested with Package_check. +- [ ] Fix or enhancement tested. +- [ ] Upgrade from last version tested. +- [ ] Can be reviewed and tested. + +## Validation +--- +- [ ] **Code review** +- [ ] **Approval (LGTM)** +*Code review and approval have to be from a member of @YunoHost/apps group* +- **CI succeeded** : +[![Build Status](https://ci-apps-dev.yunohost.org/jenkins/job/nextcloud_ynh%20-BRANCH-%20(Official)/badge/icon)](https://ci-apps-dev.yunohost.org/jenkins/job/nextcloud_ynh%20-BRANCH-%20(Official)/) +*Please replace '-BRANCH-' in this link by the name of the branch used.* +*If the PR is from a forked repository. Please provide public results from package_check.* +When the PR is marked as ready to merge, you have to wait for 3 days before really merging it. From a3499f215cf4681350912d52c3a75b77a8fc4dbb Mon Sep 17 00:00:00 2001 From: Maniack Crudelis Date: Mon, 4 Mar 2019 18:16:16 +0100 Subject: [PATCH 08/32] Replace CI link --- pull_request_template-HQ-apps.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pull_request_template-HQ-apps.md b/pull_request_template-HQ-apps.md index 6b290b26..4f6a1d44 100644 --- a/pull_request_template-HQ-apps.md +++ b/pull_request_template-HQ-apps.md @@ -17,7 +17,7 @@ - [ ] **Approval (LGTM)** *Code review and approval have to be from a member of @YunoHost/apps group* - **CI succeeded** : -[![Build Status](https://ci-apps-dev.yunohost.org/jenkins/job/nextcloud_ynh%20-BRANCH-%20(Official)/badge/icon)](https://ci-apps-dev.yunohost.org/jenkins/job/nextcloud_ynh%20-BRANCH-%20(Official)/) +[![Build Status](https://ci-apps-hq.yunohost.org/jenkins/job/APP_ynh%20-BRANCH-/badge/icon)](https://ci-apps-hq.yunohost.org/jenkins/job/APP_ynh%20-BRANCH-/) *Please replace '-BRANCH-' in this link by the name of the branch used.* *If the PR is from a forked repository. Please provide public results from package_check.* When the PR is marked as ready to merge, you have to wait for 3 days before really merging it. From abdcf2b7b91a22c73c3feab7d71178fe4d22eefb Mon Sep 17 00:00:00 2001 From: Maniack Crudelis Date: Mon, 4 Mar 2019 19:29:18 +0100 Subject: [PATCH 09/32] Create validation template for High Quality apps --- hq_validation_template.md | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) create mode 100644 hq_validation_template.md diff --git a/hq_validation_template.md b/hq_validation_template.md new file mode 100644 index 00000000..55e70962 --- /dev/null +++ b/hq_validation_template.md @@ -0,0 +1,24 @@ +# Validation template for High Quality tag request + +This template is designed to be used as it is by Apps group to validate requests from packagers for the tag High Quality. + +Mandatory check boxes: +- [ ] The package is level 7. +- [ ] The package is level 7 since at least 2 months. +- [ ] The package is in the list since at least 2 months. +- [ ] The package is up to date regarding the packaging recommendations and helpers. +- [ ] The repository has a testing branch. +- [ ] All commits are made in testing branch before being merged into master. +- [ ] The list point to HEAD, not a specific commit. +- [ ] The repository has a [`pull_request_template.md`](https://github.com/YunoHost/apps/blob/master/pull_request_template-HQ-apps.md) +- [ ] The package shows the YunoHost tile `yunohost_panel.conf.inc` + +Optional check boxes: +- [ ] The package is level 7 for ARM as well. +*If the app is really important for the community, we can accept it with a broken ARM support. But this should be clearly explained and managed.* +- [ ] The app is up to date with the upstream version. +*If this is possible with the last YunoHost version.* +- [ ] The package supports LDAP +*If the app upstream supports it* +- [ ] The package supports HTTP authentication +*If the app upstream supports it* From 6f4569451fbeca72619dfb3089d36ede23cfb06d Mon Sep 17 00:00:00 2001 From: Maniack Crudelis Date: Mon, 4 Mar 2019 19:43:38 +0100 Subject: [PATCH 10/32] Add info about level 8 and validation template --- README.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/README.md b/README.md index e542c866..19840a07 100644 --- a/README.md +++ b/README.md @@ -81,6 +81,9 @@ To become a High Quality app, a package have to follow the following rules: * The package should be level 7, at least. * The repository should have testing and master branches, at least. The list should point to HEAD, so the list stays up to date. * Any modification should be done to the testing branch, and wait at least for one approval for one member of the Apps group. So that we can ensure that there’s nothing in opposition to those criteria. Nor any changes that would harm servers. +* The package should comply with the [requirement of the level 8](https://github.com/YunoHost/doc/blob/master/packaging_apps_levels.md#level-8). + +You can find the validation form used by Apps group [here](https://github.com/YunoHost/apps/blob/master/hq_validation_template.md). If the app is already tag as High Quality and one of those criteria isn't respected anymore. After a warning, the tag will be removed until the criteria are again validated. From 56736631c96f0665e432199230574db1ff90b103 Mon Sep 17 00:00:00 2001 From: JimboJoe Date: Sat, 9 Mar 2019 17:12:31 +0100 Subject: [PATCH 11/32] Update README.md Co-Authored-By: maniackcrudelis --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 19840a07..f77750ff 100644 --- a/README.md +++ b/README.md @@ -72,7 +72,7 @@ Usage: ### How to make my app a High Quality app ? -A High Quality app will be highlighted in the app list and mark as a level 8 app. +A High Quality app will be highlighted in the app list and marked as a level 8 app. To become a High Quality app, a package have to follow the following rules: * The app should already be in the community list for 2 months. From ac3759c1de79f96c67dbe93b7188095c732eef04 Mon Sep 17 00:00:00 2001 From: JimboJoe Date: Sat, 9 Mar 2019 17:12:41 +0100 Subject: [PATCH 12/32] Update README.md Co-Authored-By: maniackcrudelis --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index f77750ff..a3c6361b 100644 --- a/README.md +++ b/README.md @@ -73,7 +73,7 @@ Usage: ### How to make my app a High Quality app ? A High Quality app will be highlighted in the app list and marked as a level 8 app. -To become a High Quality app, a package have to follow the following rules: +To become a High Quality app, a package has to follow the following rules: * The app should already be in the community list for 2 months. * The app should be keep up to date, regarding the upstream source. (If it’s possible with our current YunoHost version) From 88f0295be325da62604dad3541576ec8147f8e3f Mon Sep 17 00:00:00 2001 From: JimboJoe Date: Sat, 9 Mar 2019 17:12:54 +0100 Subject: [PATCH 13/32] Update README.md Co-Authored-By: maniackcrudelis --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index a3c6361b..743c9df0 100644 --- a/README.md +++ b/README.md @@ -75,7 +75,7 @@ Usage: A High Quality app will be highlighted in the app list and marked as a level 8 app. To become a High Quality app, a package has to follow the following rules: -* The app should already be in the community list for 2 months. +* The app should already have been in the community list for 2 months. * The app should be keep up to date, regarding the upstream source. (If it’s possible with our current YunoHost version) * The package itself should be up to date regarding the packaging recommendations and helpers. * The package should be level 7, at least. From a3d02f30c7fced42a196da4ed2a805d6a40a5294 Mon Sep 17 00:00:00 2001 From: JimboJoe Date: Sat, 9 Mar 2019 17:13:11 +0100 Subject: [PATCH 14/32] Update README.md Co-Authored-By: maniackcrudelis --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 743c9df0..dddd0842 100644 --- a/README.md +++ b/README.md @@ -76,7 +76,7 @@ A High Quality app will be highlighted in the app list and marked as a level 8 a To become a High Quality app, a package has to follow the following rules: * The app should already have been in the community list for 2 months. -* The app should be keep up to date, regarding the upstream source. (If it’s possible with our current YunoHost version) +* The app should be kept up to date, regarding the upstream source (if it’s possible with our current YunoHost version). * The package itself should be up to date regarding the packaging recommendations and helpers. * The package should be level 7, at least. * The repository should have testing and master branches, at least. The list should point to HEAD, so the list stays up to date. From 062bcac245b2513e5f16716618baf7158dce362d Mon Sep 17 00:00:00 2001 From: JimboJoe Date: Sat, 9 Mar 2019 17:13:38 +0100 Subject: [PATCH 15/32] Update README.md Co-Authored-By: maniackcrudelis --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index dddd0842..5563eaf7 100644 --- a/README.md +++ b/README.md @@ -80,7 +80,7 @@ To become a High Quality app, a package has to follow the following rules: * The package itself should be up to date regarding the packaging recommendations and helpers. * The package should be level 7, at least. * The repository should have testing and master branches, at least. The list should point to HEAD, so the list stays up to date. -* Any modification should be done to the testing branch, and wait at least for one approval for one member of the Apps group. So that we can ensure that there’s nothing in opposition to those criteria. Nor any changes that would harm servers. +* Any modification should be done to the testing branch, and wait at least for one approval of one member of the Apps group so that we can ensure that there’s nothing in opposition to those criteria, nor any changes that would harm servers. * The package should comply with the [requirement of the level 8](https://github.com/YunoHost/doc/blob/master/packaging_apps_levels.md#level-8). You can find the validation form used by Apps group [here](https://github.com/YunoHost/apps/blob/master/hq_validation_template.md). From 6a7f37f0bde5b926327efb15d3c0a00cb912608f Mon Sep 17 00:00:00 2001 From: JimboJoe Date: Sat, 9 Mar 2019 17:14:31 +0100 Subject: [PATCH 16/32] Update README.md Co-Authored-By: maniackcrudelis --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 5563eaf7..0357d52f 100644 --- a/README.md +++ b/README.md @@ -133,7 +133,7 @@ This tag can have 5 different values: - `"maintained": false` or `"maintained": "orphaned"` This value means that this app is no longer maintained... That means also that a packager can declare himself as its new maintainer. Please contact Apps group if you want to take back a unmaintained app. -If you want to modify the status of one of your app, for any reason, please think also to inform the community via the forum. Users would probably be glad to be inform that an app they use will be unmaintained. +If you want to modify the status of one of your apps, for any reason, please think also to inform the community via the forum. Users would probably be glad to be informed that an app they use will become unmaintained. #### More information See [yunohost.org/packaging_apps](https://yunohost.org/packaging_apps) From 281fcd7b8c2cde40a696a663c9df70038bf88d36 Mon Sep 17 00:00:00 2001 From: JimboJoe Date: Sat, 9 Mar 2019 17:15:28 +0100 Subject: [PATCH 17/32] Update hq_validation_template.md Co-Authored-By: maniackcrudelis --- hq_validation_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hq_validation_template.md b/hq_validation_template.md index 55e70962..5853ff01 100644 --- a/hq_validation_template.md +++ b/hq_validation_template.md @@ -4,7 +4,7 @@ This template is designed to be used as it is by Apps group to validate requests Mandatory check boxes: - [ ] The package is level 7. -- [ ] The package is level 7 since at least 2 months. +- [ ] The package has been level 7 for at least 2 months. - [ ] The package is in the list since at least 2 months. - [ ] The package is up to date regarding the packaging recommendations and helpers. - [ ] The repository has a testing branch. From 4c72fe9ba53a508c848e11604201211a8fac62a9 Mon Sep 17 00:00:00 2001 From: JimboJoe Date: Sat, 9 Mar 2019 17:15:38 +0100 Subject: [PATCH 18/32] Update hq_validation_template.md Co-Authored-By: maniackcrudelis --- hq_validation_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hq_validation_template.md b/hq_validation_template.md index 5853ff01..473b3309 100644 --- a/hq_validation_template.md +++ b/hq_validation_template.md @@ -5,7 +5,7 @@ This template is designed to be used as it is by Apps group to validate requests Mandatory check boxes: - [ ] The package is level 7. - [ ] The package has been level 7 for at least 2 months. -- [ ] The package is in the list since at least 2 months. +- [ ] The package has been in the list for at least 2 months. - [ ] The package is up to date regarding the packaging recommendations and helpers. - [ ] The repository has a testing branch. - [ ] All commits are made in testing branch before being merged into master. From bde0fcfcf3509eccc10eaf497ad0af2c98ab286c Mon Sep 17 00:00:00 2001 From: JimboJoe Date: Sat, 9 Mar 2019 17:15:49 +0100 Subject: [PATCH 19/32] Update hq_validation_template.md Co-Authored-By: maniackcrudelis --- hq_validation_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hq_validation_template.md b/hq_validation_template.md index 473b3309..f4dc11b7 100644 --- a/hq_validation_template.md +++ b/hq_validation_template.md @@ -9,7 +9,7 @@ Mandatory check boxes: - [ ] The package is up to date regarding the packaging recommendations and helpers. - [ ] The repository has a testing branch. - [ ] All commits are made in testing branch before being merged into master. -- [ ] The list point to HEAD, not a specific commit. +- [ ] The list points to HEAD, not to a specific commit. - [ ] The repository has a [`pull_request_template.md`](https://github.com/YunoHost/apps/blob/master/pull_request_template-HQ-apps.md) - [ ] The package shows the YunoHost tile `yunohost_panel.conf.inc` From 08d733c29620c54b86031cc2d2a43d554b7cfbf4 Mon Sep 17 00:00:00 2001 From: JimboJoe Date: Sat, 9 Mar 2019 17:16:22 +0100 Subject: [PATCH 20/32] Update README.md Co-Authored-By: maniackcrudelis --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 0357d52f..2f91856e 100644 --- a/README.md +++ b/README.md @@ -81,7 +81,7 @@ To become a High Quality app, a package has to follow the following rules: * The package should be level 7, at least. * The repository should have testing and master branches, at least. The list should point to HEAD, so the list stays up to date. * Any modification should be done to the testing branch, and wait at least for one approval of one member of the Apps group so that we can ensure that there’s nothing in opposition to those criteria, nor any changes that would harm servers. -* The package should comply with the [requirement of the level 8](https://github.com/YunoHost/doc/blob/master/packaging_apps_levels.md#level-8). +* The package should comply with the [requirements of the level 8](https://github.com/YunoHost/doc/blob/master/packaging_apps_levels.md#level-8). You can find the validation form used by Apps group [here](https://github.com/YunoHost/apps/blob/master/hq_validation_template.md). From 82aa09aede63f7f062163e7bd175d207c3128d24 Mon Sep 17 00:00:00 2001 From: JimboJoe Date: Sat, 9 Mar 2019 17:17:40 +0100 Subject: [PATCH 21/32] Update README.md Co-Authored-By: maniackcrudelis --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 2f91856e..efa559b1 100644 --- a/README.md +++ b/README.md @@ -100,7 +100,7 @@ To make an app a High Quality app, technically, you have to add the tag ```"high ### How to make my app a Featured app ? -A Featured app highlighted in the app list and shown before any others. +A Featured app is highlighted in the app list and shown before any others. To become a Featured app, a package have to follow the following rules: * The app should already be a High Quality app. From 3289cf544581716a0bde53fa01b5b6ceb590c203 Mon Sep 17 00:00:00 2001 From: JimboJoe Date: Sat, 9 Mar 2019 17:18:01 +0100 Subject: [PATCH 22/32] Update README.md Co-Authored-By: maniackcrudelis --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index efa559b1..7290c01f 100644 --- a/README.md +++ b/README.md @@ -101,7 +101,7 @@ To make an app a High Quality app, technically, you have to add the tag ```"high ### How to make my app a Featured app ? A Featured app is highlighted in the app list and shown before any others. -To become a Featured app, a package have to follow the following rules: +To become a Featured app, a package has to follow the following rules: * The app should already be a High Quality app. * The upstream app should be accessible and well made. From d34632a07948020ebc8c079c052fa85002e10f94 Mon Sep 17 00:00:00 2001 From: JimboJoe Date: Sat, 9 Mar 2019 17:18:27 +0100 Subject: [PATCH 23/32] Update README.md Co-Authored-By: maniackcrudelis --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 7290c01f..7f25bd5f 100644 --- a/README.md +++ b/README.md @@ -108,7 +108,7 @@ To become a Featured app, a package has to follow the following rules: * The app should be interesting and demanded by the community. * The app should fit the spirit of YunoHost. -**Please note that the exact process to decide which app are going to be Featured, and for how many time, isn't yet defined...** +**Please note that the exact process to decide which apps are going to be Featured, and for how many time, isn't yet defined...** To make an app a Featured app, technically, you have to add the tag ```"featured": true```. ```json From 5814eb5dc2512a12d444d8af99b5f15a0702c202 Mon Sep 17 00:00:00 2001 From: JimboJoe Date: Sat, 9 Mar 2019 17:20:44 +0100 Subject: [PATCH 24/32] Update README.md Co-Authored-By: maniackcrudelis --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 7f25bd5f..e12808d9 100644 --- a/README.md +++ b/README.md @@ -130,7 +130,7 @@ This tag can have 5 different values: - `"maintained": true` That's the default value if the tag isn't present for your app. That simply means that this app is maintained. - `"maintained": "request_help"` Use that value to inform other packagers that you need help to maintain this app. You'll then be more than one maintainer for this apps. - `"maintained": "request_adoption"` Use that value to inform other packagers, as well as users, that you're going to give up that app. So that you would like another maintainer to take care of it. -- `"maintained": false` or `"maintained": "orphaned"` This value means that this app is no longer maintained... That means also that a packager can declare himself as its new maintainer. +- `"maintained": false` or `"maintained": "orphaned"` This value means that this app is no longer maintained... That means also that a packager can declare himself/herself as its new maintainer. Please contact Apps group if you want to take back a unmaintained app. If you want to modify the status of one of your apps, for any reason, please think also to inform the community via the forum. Users would probably be glad to be informed that an app they use will become unmaintained. From 66a2239af9f3e3f9300c9245769ca8c376479638 Mon Sep 17 00:00:00 2001 From: JimboJoe Date: Sat, 9 Mar 2019 17:20:55 +0100 Subject: [PATCH 25/32] Update README.md Co-Authored-By: maniackcrudelis --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index e12808d9..82f8fcba 100644 --- a/README.md +++ b/README.md @@ -131,7 +131,7 @@ This tag can have 5 different values: - `"maintained": "request_help"` Use that value to inform other packagers that you need help to maintain this app. You'll then be more than one maintainer for this apps. - `"maintained": "request_adoption"` Use that value to inform other packagers, as well as users, that you're going to give up that app. So that you would like another maintainer to take care of it. - `"maintained": false` or `"maintained": "orphaned"` This value means that this app is no longer maintained... That means also that a packager can declare himself/herself as its new maintainer. -Please contact Apps group if you want to take back a unmaintained app. +Please contact Apps group if you want to take back an unmaintained app. If you want to modify the status of one of your apps, for any reason, please think also to inform the community via the forum. Users would probably be glad to be informed that an app they use will become unmaintained. From fe54b444b4c02f4570adee933186459d74959aea Mon Sep 17 00:00:00 2001 From: JimboJoe Date: Sat, 9 Mar 2019 17:27:15 +0100 Subject: [PATCH 26/32] Update app_levels/en.json Co-Authored-By: maniackcrudelis --- app_levels/en.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app_levels/en.json b/app_levels/en.json index 0869b310..5845ad42 100644 --- a/app_levels/en.json +++ b/app_levels/en.json @@ -8,6 +8,6 @@ "applevel_6": "Available for the community", "applevel_7": "Successfully pass functional tests", "applevel_8": "High quality app", - "applevel_9": "Respect highter guidelines", + "applevel_9": "Respect higher guidelines", "applevel_10": "Package assessed as perfect" } From f78c37067f3199624acb401fdc9e00b9050f2686 Mon Sep 17 00:00:00 2001 From: JimboJoe Date: Sat, 9 Mar 2019 19:33:14 +0100 Subject: [PATCH 27/32] Update README.md Co-Authored-By: maniackcrudelis --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 82f8fcba..38f9f5d5 100644 --- a/README.md +++ b/README.md @@ -85,7 +85,7 @@ To become a High Quality app, a package has to follow the following rules: You can find the validation form used by Apps group [here](https://github.com/YunoHost/apps/blob/master/hq_validation_template.md). -If the app is already tag as High Quality and one of those criteria isn't respected anymore. After a warning, the tag will be removed until the criteria are again validated. +If the app is already tagged as High Quality and one of those criteria isn't respected anymore: after a warning, the tag will be removed until the criterion is again validated. To make an app a High Quality app, technically, you have to add the tag ```"high_quality": true```. ```json From f67df4b62675a38ff8130112387a79fb958e12c6 Mon Sep 17 00:00:00 2001 From: Alexandre Aubin Date: Sat, 9 Mar 2019 20:13:57 +0100 Subject: [PATCH 28/32] Update README.md Co-Authored-By: maniackcrudelis --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 38f9f5d5..b1fa37e2 100644 --- a/README.md +++ b/README.md @@ -131,7 +131,7 @@ This tag can have 5 different values: - `"maintained": "request_help"` Use that value to inform other packagers that you need help to maintain this app. You'll then be more than one maintainer for this apps. - `"maintained": "request_adoption"` Use that value to inform other packagers, as well as users, that you're going to give up that app. So that you would like another maintainer to take care of it. - `"maintained": false` or `"maintained": "orphaned"` This value means that this app is no longer maintained... That means also that a packager can declare himself/herself as its new maintainer. -Please contact Apps group if you want to take back an unmaintained app. +Please contact the Apps group if you want to take care of an unmaintained app. If you want to modify the status of one of your apps, for any reason, please think also to inform the community via the forum. Users would probably be glad to be informed that an app they use will become unmaintained. From 91dcfc5af23134454790d2311130523daf8117ce Mon Sep 17 00:00:00 2001 From: Alexandre Aubin Date: Sat, 9 Mar 2019 20:14:16 +0100 Subject: [PATCH 29/32] Update README.md Co-Authored-By: maniackcrudelis --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index b1fa37e2..e43402e6 100644 --- a/README.md +++ b/README.md @@ -133,7 +133,7 @@ This tag can have 5 different values: - `"maintained": false` or `"maintained": "orphaned"` This value means that this app is no longer maintained... That means also that a packager can declare himself/herself as its new maintainer. Please contact the Apps group if you want to take care of an unmaintained app. -If you want to modify the status of one of your apps, for any reason, please think also to inform the community via the forum. Users would probably be glad to be informed that an app they use will become unmaintained. +If you want to modify the status of one of your apps, for any reason, please consider informing the community via the forum. Users would probably be glad to be informed that an app they use will become unmaintained. #### More information See [yunohost.org/packaging_apps](https://yunohost.org/packaging_apps) From 782e0f5abb7ff1beb80179b69c1aa53321712d9d Mon Sep 17 00:00:00 2001 From: Alexandre Aubin Date: Sat, 9 Mar 2019 20:14:49 +0100 Subject: [PATCH 30/32] Update app_levels/en.json Co-Authored-By: maniackcrudelis --- app_levels/en.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app_levels/en.json b/app_levels/en.json index 5845ad42..1838ee67 100644 --- a/app_levels/en.json +++ b/app_levels/en.json @@ -5,7 +5,7 @@ "applevel_3": "Can be updated", "applevel_4": "Backup and restore support", "applevel_5": "Clean", - "applevel_6": "Available for the community", + "applevel_6": "Open to contributions from the community", "applevel_7": "Successfully pass functional tests", "applevel_8": "High quality app", "applevel_9": "Respect higher guidelines", From 7949ff0dbf8d7b7090493955c5933fe543fe2a29 Mon Sep 17 00:00:00 2001 From: Alexandre Aubin Date: Sat, 9 Mar 2019 20:17:45 +0100 Subject: [PATCH 31/32] Update hq_validation_template.md Co-Authored-By: maniackcrudelis --- hq_validation_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hq_validation_template.md b/hq_validation_template.md index f4dc11b7..addb2ad7 100644 --- a/hq_validation_template.md +++ b/hq_validation_template.md @@ -4,7 +4,7 @@ This template is designed to be used as it is by Apps group to validate requests Mandatory check boxes: - [ ] The package is level 7. -- [ ] The package has been level 7 for at least 2 months. +- [ ] The package has been level 7 for at least 1 month. - [ ] The package has been in the list for at least 2 months. - [ ] The package is up to date regarding the packaging recommendations and helpers. - [ ] The repository has a testing branch. From e5b19c855e5b5c2b7adf5e8d5ac451af9820c3a2 Mon Sep 17 00:00:00 2001 From: Maniack Crudelis Date: Tue, 12 Mar 2019 19:06:56 +0100 Subject: [PATCH 32/32] Update README.md --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index e43402e6..56afc798 100644 --- a/README.md +++ b/README.md @@ -78,7 +78,7 @@ To become a High Quality app, a package has to follow the following rules: * The app should already have been in the community list for 2 months. * The app should be kept up to date, regarding the upstream source (if it’s possible with our current YunoHost version). * The package itself should be up to date regarding the packaging recommendations and helpers. -* The package should be level 7, at least. +* The package should be level 7 for at least 1 month. * The repository should have testing and master branches, at least. The list should point to HEAD, so the list stays up to date. * Any modification should be done to the testing branch, and wait at least for one approval of one member of the Apps group so that we can ensure that there’s nothing in opposition to those criteria, nor any changes that would harm servers. * The package should comply with the [requirements of the level 8](https://github.com/YunoHost/doc/blob/master/packaging_apps_levels.md#level-8).