From edfa399c455991125a7fd2c389cd7a09cf6513e1 Mon Sep 17 00:00:00 2001
From: Alexandre Aubin <alex.aubin@mailoo.org>
Date: Mon, 25 Sep 2023 14:40:49 +0200
Subject: [PATCH] appstore: fix broken popularity sorting on chromium

---
 store/templates/catalog.html  |  6 +++---
 store/templates/wishlist.html | 10 +++-------
 2 files changed, 6 insertions(+), 10 deletions(-)

diff --git a/store/templates/catalog.html b/store/templates/catalog.html
index 3bfbbf4a..67a591ee 100644
--- a/store/templates/catalog.html
+++ b/store/templates/catalog.html
@@ -234,17 +234,17 @@
         toSort = Array.prototype.slice.call(toSort, 0);
         if (sortBy === "newest") {
             toSort.sort(function(a, b) {
-                return a.dataset.addedincatalog - b.dataset.addedincatalog;
+                return a.dataset.addedincatalog - b.dataset.addedincatalog ? 1 : -1;
             });
         }
         else if (sortBy === "popularity") {
             toSort.sort(function(a, b) {
-                return a.dataset.stars < b.dataset.stars;
+                return a.dataset.stars < b.dataset.stars ? 1 : -1;
             });
         }
         else if (sortBy === "") {
             toSort.sort(function(a, b) {
-                return a.dataset.appid > b.dataset.appid;
+                return a.dataset.appid > b.dataset.appid ? 1 : -1;
             });
         }
         var parent = document.getElementById(container_to_sort);
diff --git a/store/templates/wishlist.html b/store/templates/wishlist.html
index 7c803853..3aca66a8 100644
--- a/store/templates/wishlist.html
+++ b/store/templates/wishlist.html
@@ -204,20 +204,19 @@
         let sortBy = selectSort.value.trim();
         var toSort = document.getElementById(container_to_sort).children;
         toSort = Array.prototype.slice.call(toSort, 0);
-        console.log(sortBy);
         if (sortBy === "newest") {
             toSort.sort(function(a, b) {
-                return a.dataset.addedincatalog - b.dataset.addedincatalog;
+                return a.dataset.addedincatalog - b.dataset.addedincatalog ? 1 : -1;
             });
         }
         else if (sortBy === "popularity") {
             toSort.sort(function(a, b) {
-                return a.dataset.stars < b.dataset.stars;
+                return a.dataset.stars < b.dataset.stars ? 1 : -1;
             });
         }
         else if (sortBy === "") {
             toSort.sort(function(a, b) {
-                return a.dataset.appid > b.dataset.appid;
+                return a.dataset.appid > b.dataset.appid ? 1 : -1;
             });
         }
         var parent = document.getElementById(container_to_sort);
@@ -226,7 +225,6 @@
         for(var i = 0, l = toSort.length; i < l; i++) {
             parent.appendChild(toSort[i]);
         }
-        console.log("gni?")
         updateQueryArgsInURL()
     }
 
@@ -243,8 +241,6 @@
             if (sortBy) { queryArgs.set("sort", sortBy) } else { queryArgs.delete("sort"); };
             if (starsOnly) { queryArgs.set("starsonly", true) } else { queryArgs.delete("starsonly"); };
 
-            console.log(queryArgs.toString());
-
             let newUrl;
             if (queryArgs.toString())
             {