From 71891fe721238dc56a2cf7e7db22a143d494ca45 Mon Sep 17 00:00:00 2001 From: Maniack Crudelis Date: Mon, 31 Jul 2017 11:24:14 +0200 Subject: [PATCH] PR model for apps group --- apps_group_PR_model.md | 51 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 51 insertions(+) create mode 100644 apps_group_PR_model.md diff --git a/apps_group_PR_model.md b/apps_group_PR_model.md new file mode 100644 index 00000000..6b10e01b --- /dev/null +++ b/apps_group_PR_model.md @@ -0,0 +1,51 @@ +## Problem +- *Description of why you made this PR* + +## Solution +- *And how you fix that* + +## PR Status +*Obviously, you should really check these affirmations* +Work finished. Package_check, basic tests and upgrade from last version OK. +Could be reviewed and tested. + +## Validation +--- +*Minor decision* +- [ ] **Upgrade previous version** : +- [ ] **Code review** : +- [ ] **Approval (LGTM)** : +- [ ] **Approval (LGTM)** : +- [ ] **CI succeeded** : +When the PR is mark as ready to merge, you have to wait for 3 days before really merge it. + +*Medium decision* +- [ ] **Complete test** : +- [ ] **Upgrade previous version** : +- [ ] **Code review** : +- [ ] **Code review** : +- [ ] **Approval (LGTM)** : +- [ ] **Approval (LGTM)** : +- [ ] **Approval (LGTM)** : +- [ ] **CI succeeded** : +- [ ] **CI succeeded** : +One public package check log is enough instead of two checks. +When the PR is mark as ready to merge, you have to wait for 7 days before really merge it. + +*Major decision* +- [ ] **Complete test** : +- [ ] **Complete test** : +- [ ] **Upgrade previous version** : +- [ ] **Upgrade previous version** : +- [ ] **Code review** : +- [ ] **Code review** : +- [ ] **Code review** : +- [ ] **Approval (LGTM)** : +- [ ] **Approval (LGTM)** : +- [ ] **Approval (LGTM)** : +- [ ] **Approval (LGTM)** : +- [ ] **CI succeeded** : +- [ ] **CI succeeded** : +- [ ] **CI succeeded** : +One public package check log is enough instead of three checks. +When the PR is mark as ready to merge, you have to wait for 7 days before really merge it.