From c35f1619d96433226ba750af04da30c7e493a671 Mon Sep 17 00:00:00 2001 From: "ljf (zamentur)" Date: Wed, 23 Aug 2023 15:56:17 +0200 Subject: [PATCH 1/3] [enh] Add a small short key blacklist --- .../60.advanced/20.config_panels/config_panels.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pages/06.contribute/10.packaging_apps/60.advanced/20.config_panels/config_panels.md b/pages/06.contribute/10.packaging_apps/60.advanced/20.config_panels/config_panels.md index 9d02b98a..abf7c619 100644 --- a/pages/06.contribute/10.packaging_apps/60.advanced/20.config_panels/config_panels.md +++ b/pages/06.contribute/10.packaging_apps/60.advanced/20.config_panels/config_panels.md @@ -67,6 +67,8 @@ For performance reasons, questions short keys have to be unique in all the `conf ``` In which two questions have "real variable name" `is server_ip` and therefore conflict with each other. +! Short keys should avoid conflicts with settings too (e.g. id, install_time, mysql_pwd, path, domain, port, db_name) + ### Supported questions types and properties See [the full list of questions types and properties](/dev/forms) From c84bd922207f6692a7e46307ef490851653eb459 Mon Sep 17 00:00:00 2001 From: "ljf (zamentur)" Date: Wed, 23 Aug 2023 16:03:06 +0200 Subject: [PATCH 2/3] [fix] Add other blacklisted short keys --- .../60.advanced/20.config_panels/config_panels.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pages/06.contribute/10.packaging_apps/60.advanced/20.config_panels/config_panels.md b/pages/06.contribute/10.packaging_apps/60.advanced/20.config_panels/config_panels.md index abf7c619..c186e75a 100644 --- a/pages/06.contribute/10.packaging_apps/60.advanced/20.config_panels/config_panels.md +++ b/pages/06.contribute/10.packaging_apps/60.advanced/20.config_panels/config_panels.md @@ -67,7 +67,7 @@ For performance reasons, questions short keys have to be unique in all the `conf ``` In which two questions have "real variable name" `is server_ip` and therefore conflict with each other. -! Short keys should avoid conflicts with settings too (e.g. id, install_time, mysql_pwd, path, domain, port, db_name) +! Some short key are forbidden cause it can interfer with config scripts (`old`, `file_hash`, `types`, `binds`, `formats`, `changed`) and you probably should avoid to use common settings name to avoid to bind your question to this settings (e.g. `id`, `install_time`, `mysql_pwd`, `path`, `domain`, `port`, `db_name`, `current_revision`, `admin`) ### Supported questions types and properties From 3fc9c33497c5a20d48f3cc43207e7c4fa4518239 Mon Sep 17 00:00:00 2001 From: "ljf (zamentur)" Date: Mon, 4 Sep 2023 20:15:25 +0200 Subject: [PATCH 3/3] [fix] missing s --- .../60.advanced/20.config_panels/config_panels.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pages/06.contribute/10.packaging_apps/60.advanced/20.config_panels/config_panels.md b/pages/06.contribute/10.packaging_apps/60.advanced/20.config_panels/config_panels.md index c186e75a..610895a0 100644 --- a/pages/06.contribute/10.packaging_apps/60.advanced/20.config_panels/config_panels.md +++ b/pages/06.contribute/10.packaging_apps/60.advanced/20.config_panels/config_panels.md @@ -67,7 +67,7 @@ For performance reasons, questions short keys have to be unique in all the `conf ``` In which two questions have "real variable name" `is server_ip` and therefore conflict with each other. -! Some short key are forbidden cause it can interfer with config scripts (`old`, `file_hash`, `types`, `binds`, `formats`, `changed`) and you probably should avoid to use common settings name to avoid to bind your question to this settings (e.g. `id`, `install_time`, `mysql_pwd`, `path`, `domain`, `port`, `db_name`, `current_revision`, `admin`) +! Some short keys are forbidden cause it can interfer with config scripts (`old`, `file_hash`, `types`, `binds`, `formats`, `changed`) and you probably should avoid to use common settings name to avoid to bind your question to this settings (e.g. `id`, `install_time`, `mysql_pwd`, `path`, `domain`, `port`, `db_name`, `current_revision`, `admin`) ### Supported questions types and properties