YunoHost/moulinette
1
0
Fork 0
mirror of https://github.com/YunoHost/moulinette.git synced 2024-09-03 20:06:31 +02:00
Code Issues Projects Releases Packages Wiki Activity

Make the linter gods happy

Browse source
This commit is contained in:
Alexandre Aubin 2019-11-20 00:27:34 +01:00
parent 9b475f092e
commit 952d707362
2 changed files with 4 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
moulinette/authenticators/__init__.py
View file

@ -167,14 +167,14 @@ class BaseAuthenticator(object):
raise MoulinetteError('unable_retrieve_session', exception=e)
else:
#
# session_id (or just id) : This is unique id for the current session from the user. Not too important
# session_id (or just id) : This is unique id for the current session from the user. Not too important
# if this info gets stolen somehow. It is stored in the client's side (browser) using regular cookies.
#
# session_token (or just token) : This is a secret info, like some sort of ephemeral password,
# used to authenticate the session without the user having to retype the password all the time...
# session_token (or just token) : This is a secret info, like some sort of ephemeral password,
# used to authenticate the session without the user having to retype the password all the time...
# - It is generated on our side during the initial auth of the user (which happens with the actual admin password)
# - It is stored on the client's side (browser) using (signed) cookies.
# - We also store it on our side in the form of a hash of {id}:{token} (c.f. _store_session).
# - We also store it on our side in the form of a hash of {id}:{token} (c.f. _store_session).
# We could simply store the raw token, but hashing it is an additonal low-cost security layer
# in case this info gets exposed for some reason (e.g. bad file perms for reasons...)
#

3
test/test_auth.py
View file

@ -57,9 +57,6 @@ def test_login_then_legit_request(moulinette_webapi):
login(moulinette_webapi)
#for cookie in moulinette_webapi.cookiejar:
# cookie.domain = "localhost"
assert moulinette_webapi.get("/test-auth/default", status=200).text == '"some_data_from_default"'